]> git.koha-community.org Git - koha.git/commit
Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 28 Jan 2022 14:04:49 +0000 (15:04 +0100)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 25 Feb 2022 13:29:53 +0000 (08:29 -0500)
commitcec300839b426f50457c42e1590c95a0d815306b
tree0e99b2dd44645acc62d65b4b06fd2f2970b2289b
parentcdab942ee00ab916ed58033a20419414c9dc21b0
Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation

If you cancel holds in bulk, the list is not updated as we enqueued the
task. But the "Update hold(s)" button will explode if clicked.

Test plan:
Place several holds on a bib record
Use the "Cancel selected" link to cancel holds in bulk
The job is enqueued and the hold list still show the holds you cancelled
Click "Update holds"
=> Without this patch you get an ugly 500
Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060
=> With this patch applied the table is refresh, no crash (and there is
a warning in the log, that may not be necessary)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Reserves.pm
reserve/modrequest.pl
t/db_dependent/Holds.t