]> git.koha-community.org Git - koha.git/commit
Bug 10110: Problems with diacritics in saved SQL reports
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 25 Apr 2013 11:54:31 +0000 (13:54 +0200)
committerChris Cormack <chris@bigballofwax.co.nz>
Sat, 27 Apr 2013 21:39:51 +0000 (09:39 +1200)
commitf06fff86051e9ab15048382185e6379cb17d0396
tree8a5754bb7fc6ec757b02bbdb4c501b6acb6d2676
parent31a6b2265315a9ac376887a64c6f532b94a28cce
Bug 10110: Problems with diacritics in saved SQL reports

Adds decoding for cgi params (for completeness).
Apparently, the NAME attribute of DBI statement handle has a UTF8 bug.
Fixing this by decoding the returned column names.
Did this in a shared routine.

http://bugs.koha-community.org/show_bug.cgi?id=10110
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Copying test plan from bug report:

Example SQL:
select
branchname as "Bibliothek (üöä)",
branchname "Bibiothek (üäa)",
branchname
from branches where branchcode = <<Bibliothekskürzel|branches>>

1) Create report with given example SQL or your own including
   some diacritics in the columnnames
2) Save the report and run it
3) Verify column names are broken before patch, but fixed after..

All tests and QA script pass.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
reports/guided_reports.pl