Ian Walls [Wed, 6 Oct 2010 16:46:26 +0000 (12:46 -0400)]
Followup to Bug 4305: multiple ISBNS in biblioitems.isbn breaks patron
This patch adds a scrub for ' | ' when the ISBN comes from the
biblioitems table, in the event that Koha has attempted to store
multiple ISBNs in the field. The ISBN presented to Business::ISBN will
now be something it can handle.
Galen Charlton [Wed, 6 Oct 2010 14:39:57 +0000 (10:39 -0400)]
various improvements to t/db_dependent/VirtualShelves.t
* updated to reflect recent (and old) changes to the API
* corrected test plan
* adopted Test::More
* correctly handle and test functionality to not add duplicate
bibs to a list
Galen Charlton [Wed, 6 Oct 2010 14:38:09 +0000 (10:38 -0400)]
removed AddToShelfFromBiblio from C4::VirtualShelves
Back in the day, lists could contain item records instead or in addition
to bibs, but that hasn't been the case for a while. Therefore, removed
AddToShelfFromBiblio, which does exactly the same thing that AddToShelf does.
The current code in AuthoritiesMarc.pm rewrites all subfields from the report
tag in the authority record to fields in related bibliographic records when
merging authorities. Additional subfields in the biblio records (e.g. relator
code or term) are lost in the process.
This patch retains the original algorithm but restores the additional subfields
from the original biblio record when rewriting the linked marc fields.
The problem also exists in 3.0. Two separate patches have been submitted.
Frédéric Demians [Wed, 25 Aug 2010 07:51:21 +0000 (09:51 +0200)]
Bug 3630 Impossible to perform Scan Indexes search
This is a quick fix. The way scan indexes performs should be improved in
3.4. There are several issues:
- No paging
- The interface is the same as for biblio records search result and so
is unusable: for example you have a button to place a hold or you
can sort by Popularity which is irrelevant for index terms.
Owen Leonard [Wed, 25 Aug 2010 18:36:20 +0000 (14:36 -0400)]
Fix for Bug 4849 - Cannot delete records from Labeled MARC view
The template checks for a "count" variable (item count) to see
whether it should allow deletion of the biblio record. For some
reason labeledMARCdetail.pl hard-coded this as 1, which meant
the template always thought was 1 item.
This patch also adds an item count check on the display of
"Delete all items," disabling it if there are no items.
Robin Sheat [Mon, 30 Aug 2010 23:48:20 +0000 (11:48 +1200)]
Bug 5139 - packages now do email and other cron jobs
By default the packages now set up the cron jobs to handle things like
overdues and email etc. By default, email is off, 'koha-email-enable'
and 'koha-email-disable' can manage this.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
In the Debian installer shell script for Debian Lenny -
"apt-get-debian-lenny.sh" - there were 2 missing lines for packages
that exist for Debian Lenny and that have versions that satisfy the
requirements of the Koha Installer, listed in the "PerlDependencies.pm"
file - located at "C4/Installer/PerlDependencies.pm".
The two missing lines are for "libnet-server-perl" (for the
"Net::Server" module) and "libpdf-table-perl" (for the "PDF::Table"
module).
I also noticed, in that same "apt-get-debian-lenny.sh" script, that
there were some duplicate (repeated) entries / lines for other modules,
namely: libdate-calc-perl, libdbd-mysql-perl, libemail-date-perl,
libgd-barcode-perl, libhtml-scrubber-perl, liblingua-stem-perl,
libmail-sendmail-perl, libmime-lite-perl, libnet-ldap-perl
and libpoe-perl.
So I'm adding, in this patch, the 2 missing lines
and removing the duplicate lines / entries.
Ian Walls [Fri, 20 Aug 2010 17:02:24 +0000 (13:02 -0400)]
Update VOKAL icon set
The Green Mountain Library Consortium has updated the 'vokal' item type
image set to include new and updated icons, including:
Puzzles and Games
BLURAY
Hardware
Educational Media
Fiction, Nonfiction, New and Holiday books
ILL materials
Smaller versions of all the icons (32 px) are included as well.
Sorting of the icons has been included in this patch to group
large and small versions of these icons together, as well as make large
icon sets easier to visually scan (the 'bridge' set benefits from this,
as well) .
Owen Leonard [Tue, 7 Sep 2010 14:59:52 +0000 (16:59 +0200)]
Fix for Bug 4922 - Item display tries to show serial info for titles with series tags
Removing check for "is this a serial record" when displaying enumchron
information. This check evaluates as true for all biblio records which
have a series title, so it's an inaccurate determiner of whether
enumchron information should be displayed. The script already
checks for the presence of enumchron data, so that will display
anyway if it exists.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 23 Sep 2010 16:04:28 +0000 (17:04 +0100)]
bug_5245 Fix SQL syntax in GetItems
Routine never executed query due to syntax error
and returned undef
made the call to fetchrow_array explicit as the old fetchrow alias
is no longer documented in perldoc DBI
The way Koha get book cover from Amazon doesn't work from biblio records
having ISBN13 because Amazon expect an ISBN10. This patch transforms
ISBN13 into ISBN10 before sending it to Amazon.
Warning! On some devel installations, you will have to install by hand a
new CPAN depency:
Business::ISBN
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch eliminates the sysprefs-menu.inc include file and changes the
systempreferences.pl and systempreferences.tmpl files to work with the
prefs-menu.inc instead. This will centralize the syspref tabs and make it
easier to modify tabs in the future if necessary.
This commit also changes the default tab to Acquisitions, since the Local Use
tab does not work with preferences.pl at present.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Bug 4867 - cannot clone subfields in marc editor, other clone/unclone weirdness
When the clone/unclone plus/minus were replaced with images the <span> tags were inadvertantly deleted
causing the js to loose its ability to identify the clone/unclone links and properly udpate the indexes.
The resulting incorrect indexes caused various weirdnesses to result when one attempted to clone/unclone
subfields.
This patch simply adds classes to the two links and updates the js to identify the links based on class.
Thanks to owen for his help in chasing this down.
Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Mon, 13 Sep 2010 23:15:22 +0000 (01:15 +0200)]
Bug 5191 Patron notification was being reset to none
The value of the letter variable was not being correctly passed
to the edit template instead it was reset to none
Also compressed some verbage from letter_loop generation
(if you want a scalar use one)
removed an unused $count variable (?!)
and put a couple of lone )s back on the line they came from
Resend to remove wrong utf-9 header.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The apparent fix is to have the text wrap alogrithm to calculate based
on a label width reduced by approx. 3/16" when there is no left text margin.
This is probably not the proper fix as it appears that this algorithm is being
affected by adjustments in the label width for label creep and perhaps offset
as well. But this does fix the symptom and is all the time available for this
problem at present.
Documentation Changes:
It might be good to add a note to the effect that if the user does not supply
a left text margin in the layout, a 3/16" (13.5 point) left text margin will
apply by default.
Bug 5203 - Creating a label template causes fatal error if description field is empty
This is due to the underlying script not having any defaults hard coded which results
in skewed hash elements when the parameter array is coerced into a hash at a later point.
This also occurs in layouts and profiles. This patch adds defaults to all three.
Bug 5215 - Barcode field not cleared when using "Add and Duplicate" option on additem.pl
The barcode field is not cleared/incremented properly when using the "Add and
Duplicate" option. Rather it is pre-populated with the previously used barcode
which causes additem.pl to return a duplicate barcode error if the cataloger
does not catch the mistake.
The problem is caused by the fact that the current item record is simply
duplicated and re-loaded into the form.
The solution is to add code which either pre-populates with the next barcode
number if the incremental pattern is set or clears the p subfield if one of the
various patterns using the javascript plugin is selected.
In reality C4::Barcodes should be implimented here along with all necessary changes elsewhere.
projects / koha.git / log