From 179f0f32b793f557ba1b7261974115fddfbc5545 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Mon, 17 Jun 2024 16:41:37 +0000
Subject: [PATCH] Bug 29079: Add author and publication details columns to
 holds queue

To test:
1. Apply patch, restart_all
2. Add some holds and run the holds queue builder.
3. Go to the holds queue.
4. You should see less information in the 'Title' field.
5. You should see an 'Author' column, make sure it is sortable and the data is correct.
6. You should see a 'Publication details' column, that should also be sortable. Make sure the data is correct.
7. Each column, and all other in the holds queue table, should be column configurable via Table Settings.
8. Make sure you hide/show columns via Table settings.
9. Make sure the data can be exported correctly via tha Export button.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 admin/columns_settings.yml                     |  4 ++++
 .../prog/en/modules/circ/view_holdsqueue.tt    | 18 ++++++++++++++++--
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index e318746cb7..8ab19fdf96 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -1721,6 +1721,10 @@ modules:
         columns:
             -
               columnname: title
+            -
+              columnname: author
+            -
+              columnname: pubdetails
             -
               columnname: holdingbranch
               is_hidden: 1
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
index cabae9b64f..ae74a101ff 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
@@ -77,6 +77,8 @@
                 <thead>
                 <tr>
                     <th class="hq-title anti-the">Title</th>
+                    <th class="hq-author">Author</th>
+                    <th class="hq-pubdetails">Publication details</th>
                     <th class="hq-holdingbranch">Current library</th>
                     <th class="hq-homebranch">Home library</th>
                     <th class="hq-collection">Collection</th>
@@ -98,6 +100,16 @@
                             <input class="text_filter" type="text" placeholder="Title">
                         </span>
                     </td>
+                    <td class="hq-author">
+                        <span class="filter_column filter_text">
+                            <input class="text_filter" type="text" placeholder="Author">
+                        </span>
+                    </td>
+                    <td class="hq-pubdetails">
+                        <span class="filter_column filter_text">
+                            <input class="text_filter" type="text" placeholder="Author">
+                        </span>
+                    </td>
                     <td class="hq-holdingbranch">
                         <span class="filter_column filter_text">
                             <input class="text_filter" type="text" placeholder="Current library">
@@ -177,9 +189,11 @@
                                 [% INCLUDE 'biblio-title.inc' biblio=itemsloo.biblio link = 1 %]
                             </p>
                             <div class="hq-biblionumber content_hidden">[% itemsloo.biblionumber | html %]</div>
-                            <div class="hq-author">[% itemsloo.biblio.author | html %]</div>
-                            [% IF ( itemsloo.biblio.biblioitem.editionstatement ) %]<div class="hq-editionstatement">[% itemsloo.biblio.biblioitem.editionstatement | html %]</div>[% END %]
+                        </td>
+                        <td class="hq-author">[% itemsloo.biblio.author | html %]</td>
+                        <td class="hq-pubdetails">
                             <div class="hq-pubdata">
+                                [% IF ( itemsloo.biblio.biblioitem.editionstatement ) %]<div class="hq-editionstatement">[% itemsloo.biblio.biblioitem.editionstatement | html %]</div>[% END %]
                                 [% IF ( itemsloo.biblio.biblioitem.publishercode ) %][% itemsloo.biblio.biblioitem.publishercode | html %][% END %]
 
                                 [% IF ( itemsloo.biblio.biblioitem.publicationyear ) %]
-- 
2.39.5