From 86fc6301a7f6b021e24b50e22fb47a27c7bfefe1 Mon Sep 17 00:00:00 2001
From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Date: Tue, 22 Aug 2023 13:45:27 +0300
Subject: [PATCH] Bug 34585: Add data-code attribute to chargeperiod_charge_at
 selector

When one tries to edit circulation rule "When to charge"
columns value is always set as "End of interval". This patch adds
data-code attribute to chargeperiod_charge_at selector
to define existing rules value.

To reproduce:
1. Navigate to Circulation and fine rules page.
2. Find or create a rule with a "When to charge" value set as
"Start of interval".
3. Edit rule.
=> Note that "When to charge" value is now "End of interval",
while as the other values should be copied as they were.
4. Apply this patch.
5. Edit rule again.
=> "When to charge" should now be copied correctly.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 2ca65e0a06bff5b0b1c395874fca431e915c11c1)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt    | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
index 620a94319e..bf7b8936a9 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ -291,7 +291,13 @@
                                                 <td>[% decreaseloanholds | html %]</td>
                                                 <td>[% fine | $Price %]</td>
                                                 <td>[% chargeperiod | html %]</td>
-                                                <td>[% IF chargeperiod_charge_at %]Start of interval[% ELSE %]End of interval[% END %]</td>
+                                                <td data-code="[% chargeperiod_charge_at | html %]">
+                                                  [% IF chargeperiod_charge_at %]
+                                                    Start of interval
+                                                  [% ELSE %]
+                                                    End of interval
+                                                  [% END %]
+                                                </td>
                                                 <td>[% firstremind | html %]</td>
                                                 <td>[% IF overduefinescap %][% overduefinescap | $Price %][% ELSE %][% END %]</td>
                                                 <td>
-- 
2.39.5