3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 55;
24 use Test::Deep qw( cmp_deeply );
30 use POSIX qw( floor );
32 use t::lib::TestBuilder;
41 use C4::Overdues qw(UpdateFine CalcFine);
45 use Koha::Item::Transfers;
49 use Koha::CirculationRules;
50 use Koha::Subscriptions;
51 use Koha::Account::Lines;
52 use Koha::Account::Offsets;
57 t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
61 my ( $error, $question, $alert ) = @_;
63 $s = %$error ? ' (error: ' . join( ' ', keys %$error ) . ')' : '';
64 $s .= %$question ? ' (question: ' . join( ' ', keys %$question ) . ')' : '';
65 $s .= %$alert ? ' (alert: ' . join( ' ', keys %$alert ) . ')' : '';
69 sub test_debarment_on_checkout {
71 my $item = $params->{item};
72 my $library = $params->{library};
73 my $patron = $params->{patron};
74 my $due_date = $params->{due_date} || dt_from_string;
75 my $return_date = $params->{return_date} || dt_from_string;
76 my $expected_expiration_date = $params->{expiration_date};
78 $expected_expiration_date = output_pref(
80 dt => $expected_expiration_date,
86 my $line_number = $caller[2];
87 AddIssue( $patron, $item->barcode, $due_date );
89 my ( undef, $message ) = AddReturn( $item->barcode, $library->{branchcode}, undef, $return_date );
90 is( $message->{WasReturned} && exists $message->{Debarred}, 1, 'AddReturn must have debarred the patron' )
91 or diag('AddReturn returned message ' . Dumper $message );
92 my $debarments = Koha::Patron::Debarments::GetDebarments(
93 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
94 is( scalar(@$debarments), 1, 'Test at line ' . $line_number );
96 is( $debarments->[0]->{expiration},
97 $expected_expiration_date, 'Test at line ' . $line_number );
98 Koha::Patron::Debarments::DelUniqueDebarment(
99 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
102 my $schema = Koha::Database->schema;
103 $schema->storage->txn_begin;
104 my $builder = t::lib::TestBuilder->new;
105 my $dbh = C4::Context->dbh;
107 # Prevent random failures by mocking ->now
108 my $now_value = dt_from_string;
109 my $mocked_datetime = Test::MockModule->new('DateTime');
110 $mocked_datetime->mock( 'now', sub { return $now_value->clone; } );
112 my $cache = Koha::Caches->get_instance();
113 $dbh->do(q|DELETE FROM special_holidays|);
114 $dbh->do(q|DELETE FROM repeatable_holidays|);
115 my $branches = Koha::Libraries->search();
116 for my $branch ( $branches->next ) {
117 my $key = $branch->branchcode . "_holidays";
118 $cache->clear_from_cache($key);
121 # Start with a clean slate
122 $dbh->do('DELETE FROM issues');
123 $dbh->do('DELETE FROM borrowers');
125 # Disable recording of the staff who checked out an item until we're ready for it
126 t::lib::Mocks::mock_preference('RecordStaffUserOnCheckout', 0);
128 my $module = Test::MockModule->new('C4::Context');
130 my $library = $builder->build({
133 my $library2 = $builder->build({
136 my $itemtype = $builder->build(
138 source => 'Itemtype',
142 rentalcharge_daily => 0,
143 defaultreplacecost => undef,
148 my $patron_category = $builder->build(
150 source => 'Category',
152 category_type => 'P',
154 BlockExpiredPatronOpacActions => -1, # Pick the pref value
159 my $CircControl = C4::Context->preference('CircControl');
160 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
163 homebranch => $library2->{branchcode},
164 holdingbranch => $library2->{branchcode}
168 branchcode => $library2->{branchcode}
171 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
173 # No userenv, PickupLibrary
174 t::lib::Mocks::mock_preference('IndependentBranches', '0');
175 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
177 C4::Context->preference('CircControl'),
179 'CircControl changed to PickupLibrary'
182 C4::Circulation::_GetCircControlBranch($item, $borrower),
183 $item->{$HomeOrHoldingBranch},
184 '_GetCircControlBranch returned item branch (no userenv defined)'
187 # No userenv, PatronLibrary
188 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
190 C4::Context->preference('CircControl'),
192 'CircControl changed to PatronLibrary'
195 C4::Circulation::_GetCircControlBranch($item, $borrower),
196 $borrower->{branchcode},
197 '_GetCircControlBranch returned borrower branch'
200 # No userenv, ItemHomeLibrary
201 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
203 C4::Context->preference('CircControl'),
205 'CircControl changed to ItemHomeLibrary'
208 $item->{$HomeOrHoldingBranch},
209 C4::Circulation::_GetCircControlBranch($item, $borrower),
210 '_GetCircControlBranch returned item branch'
214 t::lib::Mocks::mock_userenv({ branchcode => $library2->{branchcode} });
215 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
217 # Userenv set, PickupLibrary
218 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
220 C4::Context->preference('CircControl'),
222 'CircControl changed to PickupLibrary'
225 C4::Circulation::_GetCircControlBranch($item, $borrower),
226 $library2->{branchcode},
227 '_GetCircControlBranch returned current branch'
230 # Userenv set, PatronLibrary
231 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
233 C4::Context->preference('CircControl'),
235 'CircControl changed to PatronLibrary'
238 C4::Circulation::_GetCircControlBranch($item, $borrower),
239 $borrower->{branchcode},
240 '_GetCircControlBranch returned borrower branch'
243 # Userenv set, ItemHomeLibrary
244 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
246 C4::Context->preference('CircControl'),
248 'CircControl changed to ItemHomeLibrary'
251 C4::Circulation::_GetCircControlBranch($item, $borrower),
252 $item->{$HomeOrHoldingBranch},
253 '_GetCircControlBranch returned item branch'
256 # Reset initial configuration
257 t::lib::Mocks::mock_preference('CircControl', $CircControl);
259 C4::Context->preference('CircControl'),
261 'CircControl reset to its initial value'
264 # Set a simple circ policy
265 $dbh->do('DELETE FROM circulation_rules');
266 Koha::CirculationRules->set_rules(
268 categorycode => undef,
272 reservesallowed => 25,
274 lengthunit => 'days',
275 renewalsallowed => 1,
277 norenewalbefore => undef,
285 subtest "CanBookBeRenewed AllowRenewalIfOtherItemsAvailable multiple borrowers and items tests" => sub {
288 #Can only reserve from home branch
289 Koha::CirculationRules->set_rule(
293 rule_name => 'holdallowed',
297 Koha::CirculationRules->set_rule(
300 categorycode => undef,
302 rule_name => 'onshelfholds',
307 # Patrons from three different branches
308 my $patron_borrower = $builder->build_object({ class => 'Koha::Patrons' });
309 my $patron_hold_1 = $builder->build_object({ class => 'Koha::Patrons' });
310 my $patron_hold_2 = $builder->build_object({ class => 'Koha::Patrons' });
311 my $biblio = $builder->build_sample_biblio();
313 # Item at each patron branch
314 my $item_1 = $builder->build_sample_item({
315 biblionumber => $biblio->biblionumber,
316 homebranch => $patron_borrower->branchcode
318 my $item_2 = $builder->build_sample_item({
319 biblionumber => $biblio->biblionumber,
320 homebranch => $patron_hold_2->branchcode
322 my $item_3 = $builder->build_sample_item({
323 biblionumber => $biblio->biblionumber,
324 homebranch => $patron_hold_1->branchcode
327 my $issue = AddIssue( $patron_borrower->unblessed, $item_1->barcode);
328 my $datedue = dt_from_string( $issue->date_due() );
329 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
334 branchcode => $patron_hold_1->branchcode,
335 borrowernumber => $patron_hold_1->borrowernumber,
336 biblionumber => $biblio->biblionumber,
338 reservation_date => dt_from_string(),
339 expiration_date => undef,
346 branchcode => $patron_hold_2->branchcode,
347 borrowernumber => $patron_hold_2->borrowernumber,
348 biblionumber => $biblio->biblionumber,
350 reservation_date => dt_from_string(),
351 expiration_date => undef,
356 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
358 my ( $renewokay, $error ) = CanBookBeRenewed($patron_borrower->borrowernumber, $item_1->itemnumber);
359 is( $renewokay, 0, 'Cannot renew, reserved');
360 is( $error, 'on_reserve', 'Cannot renew, reserved (returned error is on_reserve)');
362 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
364 ( $renewokay, $error ) = CanBookBeRenewed($patron_borrower->borrowernumber, $item_1->itemnumber);
365 is( $renewokay, 1, 'Can renew, two items available for two holds');
366 is( $error, undef, 'Can renew, each reserve has an item');
371 subtest "GetIssuingCharges tests" => sub {
373 my $branch_discount = $builder->build_object({ class => 'Koha::Libraries' });
374 my $branch_no_discount = $builder->build_object({ class => 'Koha::Libraries' });
375 Koha::CirculationRules->set_rule(
377 categorycode => undef,
378 branchcode => $branch_discount->branchcode,
380 rule_name => 'rentaldiscount',
384 my $itype_charge = $builder->build_object({
385 class => 'Koha::ItemTypes',
390 my $itype_no_charge = $builder->build_object({
391 class => 'Koha::ItemTypes',
396 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
397 my $item_1 = $builder->build_sample_item({ itype => $itype_charge->itemtype });
398 my $item_2 = $builder->build_sample_item({ itype => $itype_no_charge->itemtype });
400 t::lib::Mocks::mock_userenv({ branchcode => $branch_no_discount->branchcode });
401 # For now the sub always uses the env branch, this should follow CircControl instead
402 my ($charge, $itemtype) = GetIssuingCharges( $item_1->itemnumber, $patron->borrowernumber);
403 is( $charge + 0, 10.00, "Charge fetched correctly when no discount exists");
404 ($charge, $itemtype) = GetIssuingCharges( $item_2->itemnumber, $patron->borrowernumber);
405 is( $charge + 0, 0.00, "Charge fetched correctly when no discount exists and no charge");
407 t::lib::Mocks::mock_userenv({ branchcode => $branch_discount->branchcode });
408 # For now the sub always uses the env branch, this should follow CircControl instead
409 ($charge, $itemtype) = GetIssuingCharges( $item_1->itemnumber, $patron->borrowernumber);
410 is( $charge + 0, 8.50, "Charge fetched correctly when discount exists");
411 ($charge, $itemtype) = GetIssuingCharges( $item_2->itemnumber, $patron->borrowernumber);
412 is( $charge + 0, 0.00, "Charge fetched correctly when discount exists and no charge");
416 my ( $reused_itemnumber_1, $reused_itemnumber_2 );
417 subtest "CanBookBeRenewed tests" => sub {
420 C4::Context->set_preference('ItemsDeniedRenewal','');
421 # Generate test biblio
422 my $biblio = $builder->build_sample_biblio();
424 my $branch = $library2->{branchcode};
426 my $item_1 = $builder->build_sample_item(
428 biblionumber => $biblio->biblionumber,
430 replacementprice => 12.00,
434 $reused_itemnumber_1 = $item_1->itemnumber;
436 my $item_2 = $builder->build_sample_item(
438 biblionumber => $biblio->biblionumber,
440 replacementprice => 23.00,
444 $reused_itemnumber_2 = $item_2->itemnumber;
446 my $item_3 = $builder->build_sample_item(
448 biblionumber => $biblio->biblionumber,
450 replacementprice => 23.00,
456 my %renewing_borrower_data = (
458 surname => 'Renewal',
459 categorycode => $patron_category->{categorycode},
460 branchcode => $branch,
463 my %reserving_borrower_data = (
464 firstname => 'Katrin',
465 surname => 'Reservation',
466 categorycode => $patron_category->{categorycode},
467 branchcode => $branch,
470 my %hold_waiting_borrower_data = (
472 surname => 'Reservation',
473 categorycode => $patron_category->{categorycode},
474 branchcode => $branch,
477 my %restricted_borrower_data = (
478 firstname => 'Alice',
479 surname => 'Reservation',
480 categorycode => $patron_category->{categorycode},
481 debarred => '3228-01-01',
482 branchcode => $branch,
485 my %expired_borrower_data = (
488 categorycode => $patron_category->{categorycode},
489 branchcode => $branch,
490 dateexpiry => dt_from_string->subtract( months => 1 ),
493 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
494 my $reserving_borrowernumber = Koha::Patron->new(\%reserving_borrower_data)->store->borrowernumber;
495 my $hold_waiting_borrowernumber = Koha::Patron->new(\%hold_waiting_borrower_data)->store->borrowernumber;
496 my $restricted_borrowernumber = Koha::Patron->new(\%restricted_borrower_data)->store->borrowernumber;
497 my $expired_borrowernumber = Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
499 my $renewing_borrower_obj = Koha::Patrons->find( $renewing_borrowernumber );
500 my $renewing_borrower = $renewing_borrower_obj->unblessed;
501 my $restricted_borrower = Koha::Patrons->find( $restricted_borrowernumber )->unblessed;
502 my $expired_borrower = Koha::Patrons->find( $expired_borrowernumber )->unblessed;
509 my $checkitem = undef;
512 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
513 my $datedue = dt_from_string( $issue->date_due() );
514 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
516 my $issue2 = AddIssue( $renewing_borrower, $item_2->barcode);
517 $datedue = dt_from_string( $issue->date_due() );
518 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
521 my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $item_1->itemnumber } )->borrowernumber;
522 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
524 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
525 is( $renewokay, 1, 'Can renew, no holds for this title or item');
528 # Biblio-level hold, renewal test
531 branchcode => $branch,
532 borrowernumber => $reserving_borrowernumber,
533 biblionumber => $biblio->biblionumber,
534 priority => $priority,
535 reservation_date => $resdate,
536 expiration_date => $expdate,
538 itemnumber => $checkitem,
543 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
544 Koha::CirculationRules->set_rule(
546 categorycode => undef,
549 rule_name => 'onshelfholds',
553 Koha::CirculationRules->set_rule(
555 categorycode => undef,
558 rule_name => 'renewalsallowed',
562 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
563 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
564 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
565 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
566 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
568 # Now let's add an item level hold, we should no longer be able to renew the item
569 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
571 borrowernumber => $hold_waiting_borrowernumber,
572 biblionumber => $biblio->biblionumber,
573 itemnumber => $item_1->itemnumber,
574 branchcode => $branch,
578 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
579 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
582 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
583 # be able to renew these items
584 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
586 borrowernumber => $hold_waiting_borrowernumber,
587 biblionumber => $biblio->biblionumber,
588 itemnumber => $item_3->itemnumber,
589 branchcode => $branch,
594 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
595 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
596 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
597 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
598 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
600 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
601 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
602 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
604 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
605 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
606 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
608 my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
609 my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;
610 AddIssue($reserving_borrower, $item_3->barcode);
611 my $reserve = $dbh->selectrow_hashref(
612 'SELECT * FROM old_reserves WHERE reserve_id = ?',
616 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
618 # Item-level hold, renewal test
621 branchcode => $branch,
622 borrowernumber => $reserving_borrowernumber,
623 biblionumber => $biblio->biblionumber,
624 priority => $priority,
625 reservation_date => $resdate,
626 expiration_date => $expdate,
628 itemnumber => $item_1->itemnumber,
633 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
634 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
635 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
637 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber, 1);
638 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
640 # Items can't fill hold for reasons
641 $item_1->notforloan(1)->store;
642 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
643 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
644 $item_1->set({notforloan => 0, itype => $itemtype })->store;
646 # FIXME: Add more for itemtype not for loan etc.
648 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
649 my $item_5 = $builder->build_sample_item(
651 biblionumber => $biblio->biblionumber,
653 replacementprice => 23.00,
657 my $datedue5 = AddIssue($restricted_borrower, $item_5->barcode);
658 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
660 t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
661 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
662 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
663 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $item_5->itemnumber);
664 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
665 is( $error, 'restriction', "Correct error returned");
667 # Users cannot renew an overdue item
668 my $item_6 = $builder->build_sample_item(
670 biblionumber => $biblio->biblionumber,
672 replacementprice => 23.00,
677 my $item_7 = $builder->build_sample_item(
679 biblionumber => $biblio->biblionumber,
681 replacementprice => 23.00,
686 my $datedue6 = AddIssue( $renewing_borrower, $item_6->barcode);
687 is (defined $datedue6, 1, "Item 2 checked out, due date: ".$datedue6->date_due);
689 my $now = dt_from_string();
690 my $five_weeks = DateTime::Duration->new(weeks => 5);
691 my $five_weeks_ago = $now - $five_weeks;
692 t::lib::Mocks::mock_preference('finesMode', 'production');
694 my $passeddatedue1 = AddIssue($renewing_borrower, $item_7->barcode, $five_weeks_ago);
695 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
697 my ( $fine ) = CalcFine( $item_7->unblessed, $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
698 C4::Overdues::UpdateFine(
700 issue_id => $passeddatedue1->id(),
701 itemnumber => $item_7->itemnumber,
702 borrowernumber => $renewing_borrower->{borrowernumber},
704 due => Koha::DateUtils::output_pref($five_weeks_ago)
708 # Make sure fine calculation isn't skipped when adding renewal
709 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
711 t::lib::Mocks::mock_preference('RenewalLog', 0);
712 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
713 my %params_renewal = (
714 timestamp => { -like => $date . "%" },
715 module => "CIRCULATION",
719 timestamp => { -like => $date . "%" },
720 module => "CIRCULATION",
723 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );
724 my $dt = dt_from_string();
725 Time::Fake->offset( $dt->epoch );
726 my $datedue1 = AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
727 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
728 is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
729 isnt (DateTime->compare($datedue1, $dt), 0, "AddRenewal returned a good duedate");
732 t::lib::Mocks::mock_preference('RenewalLog', 1);
733 $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
734 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
735 AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
736 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
737 is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
739 my $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
740 is( $fines->count, 2, 'AddRenewal left both fines' );
741 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
742 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
745 t::lib::Mocks::mock_preference('OverduesBlockRenewing','allow');
746 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
747 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
748 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
749 is( $renewokay, 1, '(Bug 8236), Can renew, this item is overdue but not pref does not block');
751 t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
752 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
753 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is not overdue but patron has overdues');
754 is( $error, 'overdue', "Correct error returned");
755 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
756 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue so patron has overdues');
757 is( $error, 'overdue', "Correct error returned");
759 t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
760 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
761 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
762 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
763 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
764 is( $error, 'overdue', "Correct error returned");
767 my $old_issue_log_size = Koha::ActionLogs->count( \%params_issue );
768 my $old_renew_log_size = Koha::ActionLogs->count( \%params_renewal );
769 AddIssue( $renewing_borrower,$item_7->barcode,Koha::DateUtils::output_pref({str=>$datedue6->date_due, dateformat =>'iso'}),0,$date, 0, undef );
770 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
771 is ($new_log_size, $old_renew_log_size + 1, 'renew log successfully added when renewed via issuing');
772 $new_log_size = Koha::ActionLogs->count( \%params_issue );
773 is ($new_log_size, $old_issue_log_size, 'renew not logged as issue when renewed via issuing');
775 $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
778 $hold = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next;
782 # Test automatic renewal before value for "norenewalbefore" in policy is set
783 # In this case automatic renewal is not permitted prior to due date
784 my $item_4 = $builder->build_sample_item(
786 biblionumber => $biblio->biblionumber,
788 replacementprice => 16.00,
793 $issue = AddIssue( $renewing_borrower, $item_4->barcode, undef, undef, undef, undef, { auto_renew => 1 } );
794 ( $renewokay, $error ) =
795 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
796 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
797 is( $error, 'auto_too_soon',
798 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
801 branchcode => $branch,
802 borrowernumber => $reserving_borrowernumber,
803 biblionumber => $biblio->biblionumber,
804 itemnumber => $bibitems,
805 priority => $priority,
806 reservation_date => $resdate,
807 expiration_date => $expdate,
810 itemnumber => $item_4->itemnumber,
814 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
815 is( $renewokay, 0, 'Still should not be able to renew' );
816 is( $error, 'on_reserve', 'returned code is on_reserve, reserve checked when not checking for cron' );
817 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, undef, 1 );
818 is( $renewokay, 0, 'Still should not be able to renew' );
819 is( $error, 'auto_too_soon', 'returned code is auto_too_soon, reserve not checked when checking for cron' );
820 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
821 is( $renewokay, 0, 'Still should not be able to renew' );
822 is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
823 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1, 1 );
824 is( $renewokay, 0, 'Still should not be able to renew' );
825 is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
826 $dbh->do('UPDATE circulation_rules SET rule_value = 0 where rule_name = "norenewalbefore"');
827 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
828 is( $renewokay, 0, 'Still should not be able to renew' );
829 is( $error, 'on_reserve', 'returned code is on_reserve, auto_renew only happens if not on reserve' );
830 ModReserveCancelAll($item_4->itemnumber, $reserving_borrowernumber);
834 $renewing_borrower_obj->autorenew_checkouts(0)->store;
835 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
836 is( $renewokay, 1, 'No renewal before is undef, but patron opted out of auto_renewal' );
837 $renewing_borrower_obj->autorenew_checkouts(1)->store;
841 # Test premature manual renewal
842 Koha::CirculationRules->set_rule(
844 categorycode => undef,
847 rule_name => 'norenewalbefore',
852 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
853 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
854 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
857 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
858 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
860 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
861 $datedue->clone->add( days => -7 ),
862 'Bug 14395: Renewals permitted 7 days before due date, as expected'
866 # Test 'date' setting for syspref NoRenewalBeforePrecision
867 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
869 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
870 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
871 'Bug 14395: Renewals permitted 7 days before due date, as expected'
875 # Test premature automatic renewal
876 ( $renewokay, $error ) =
877 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
878 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
879 is( $error, 'auto_too_soon',
880 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
883 $renewing_borrower_obj->autorenew_checkouts(0)->store;
884 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
885 is( $renewokay, 0, 'No renewal before is 7, patron opted out of auto_renewal still cannot renew early' );
886 is( $error, 'too_soon', 'Error is too_soon, no auto' );
887 $renewing_borrower_obj->autorenew_checkouts(1)->store;
889 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
890 # and test automatic renewal again
891 $dbh->do(q{UPDATE circulation_rules SET rule_value = '0' WHERE rule_name = 'norenewalbefore'});
892 ( $renewokay, $error ) =
893 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
894 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
895 is( $error, 'auto_too_soon',
896 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
899 $renewing_borrower_obj->autorenew_checkouts(0)->store;
900 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
901 is( $renewokay, 0, 'No renewal before is 0, patron opted out of auto_renewal still cannot renew early' );
902 is( $error, 'too_soon', 'Error is too_soon, no auto' );
903 $renewing_borrower_obj->autorenew_checkouts(1)->store;
905 # Change policy so that loans can be renewed 99 days prior to the due date
906 # and test automatic renewal again
907 $dbh->do(q{UPDATE circulation_rules SET rule_value = '99' WHERE rule_name = 'norenewalbefore'});
908 ( $renewokay, $error ) =
909 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
910 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
911 is( $error, 'auto_renew',
912 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
915 $renewing_borrower_obj->autorenew_checkouts(0)->store;
916 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
917 is( $renewokay, 1, 'No renewal before is 99, patron opted out of auto_renewal so can renew' );
918 $renewing_borrower_obj->autorenew_checkouts(1)->store;
920 subtest "too_late_renewal / no_auto_renewal_after" => sub {
922 my $item_to_auto_renew = $builder->build_sample_item(
924 biblionumber => $biblio->biblionumber,
929 my $ten_days_before = dt_from_string->add( days => -10 );
930 my $ten_days_ahead = dt_from_string->add( days => 10 );
931 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
933 Koha::CirculationRules->set_rules(
935 categorycode => undef,
939 norenewalbefore => '7',
940 no_auto_renewal_after => '9',
944 ( $renewokay, $error ) =
945 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
946 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
947 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
949 Koha::CirculationRules->set_rules(
951 categorycode => undef,
955 norenewalbefore => '7',
956 no_auto_renewal_after => '10',
960 ( $renewokay, $error ) =
961 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
962 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
963 is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
965 Koha::CirculationRules->set_rules(
967 categorycode => undef,
971 norenewalbefore => '7',
972 no_auto_renewal_after => '11',
976 ( $renewokay, $error ) =
977 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
978 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
979 is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
981 Koha::CirculationRules->set_rules(
983 categorycode => undef,
987 norenewalbefore => '10',
988 no_auto_renewal_after => '11',
992 ( $renewokay, $error ) =
993 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
994 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
995 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
997 Koha::CirculationRules->set_rules(
999 categorycode => undef,
1000 branchcode => undef,
1003 norenewalbefore => '10',
1004 no_auto_renewal_after => undef,
1005 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
1009 ( $renewokay, $error ) =
1010 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1011 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1012 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
1014 Koha::CirculationRules->set_rules(
1016 categorycode => undef,
1017 branchcode => undef,
1020 norenewalbefore => '7',
1021 no_auto_renewal_after => '15',
1022 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
1026 ( $renewokay, $error ) =
1027 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1028 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1029 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
1031 Koha::CirculationRules->set_rules(
1033 categorycode => undef,
1034 branchcode => undef,
1037 norenewalbefore => '10',
1038 no_auto_renewal_after => undef,
1039 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 1 ),
1043 ( $renewokay, $error ) =
1044 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1045 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1046 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
1049 subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredit" => sub {
1051 my $item_to_auto_renew = $builder->build_sample_item(
1053 biblionumber => $biblio->biblionumber,
1058 my $ten_days_before = dt_from_string->add( days => -10 );
1059 my $ten_days_ahead = dt_from_string->add( days => 10 );
1060 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1062 Koha::CirculationRules->set_rules(
1064 categorycode => undef,
1065 branchcode => undef,
1068 norenewalbefore => '10',
1069 no_auto_renewal_after => '11',
1073 C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
1074 C4::Context->set_preference('OPACFineNoRenewals','10');
1075 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
1076 my $fines_amount = 5;
1077 my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
1078 $account->add_debit(
1080 amount => $fines_amount,
1081 interface => 'test',
1083 item_id => $item_to_auto_renew->itemnumber,
1084 description => "Some fines"
1086 )->status('RETURNED')->store;
1087 ( $renewokay, $error ) =
1088 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1089 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1090 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
1092 $account->add_debit(
1094 amount => $fines_amount,
1095 interface => 'test',
1097 item_id => $item_to_auto_renew->itemnumber,
1098 description => "Some fines"
1100 )->status('RETURNED')->store;
1101 ( $renewokay, $error ) =
1102 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1103 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1104 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
1106 $account->add_debit(
1108 amount => $fines_amount,
1109 interface => 'test',
1111 item_id => $item_to_auto_renew->itemnumber,
1112 description => "Some fines"
1114 )->status('RETURNED')->store;
1115 ( $renewokay, $error ) =
1116 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1117 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1118 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );
1120 $account->add_credit(
1122 amount => $fines_amount,
1123 interface => 'test',
1125 description => "Some payment"
1128 ( $renewokay, $error ) =
1129 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1130 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1131 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
1133 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','0');
1134 ( $renewokay, $error ) =
1135 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1136 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1137 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
1139 $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
1140 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
1143 subtest "auto_account_expired | BlockExpiredPatronOpacActions" => sub {
1145 my $item_to_auto_renew = $builder->build_sample_item(
1147 biblionumber => $biblio->biblionumber,
1152 Koha::CirculationRules->set_rules(
1154 categorycode => undef,
1155 branchcode => undef,
1158 norenewalbefore => 10,
1159 no_auto_renewal_after => 11,
1164 my $ten_days_before = dt_from_string->add( days => -10 );
1165 my $ten_days_ahead = dt_from_string->add( days => 10 );
1167 # Patron is expired and BlockExpiredPatronOpacActions=0
1168 # => auto renew is allowed
1169 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 0);
1170 my $patron = $expired_borrower;
1171 my $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1172 ( $renewokay, $error ) =
1173 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1174 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1175 is( $error, 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
1176 Koha::Checkouts->find( $checkout->issue_id )->delete;
1179 # Patron is expired and BlockExpiredPatronOpacActions=1
1180 # => auto renew is not allowed
1181 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1182 $patron = $expired_borrower;
1183 $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1184 ( $renewokay, $error ) =
1185 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1186 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1187 is( $error, 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
1188 Koha::Checkouts->find( $checkout->issue_id )->delete;
1191 # Patron is not expired and BlockExpiredPatronOpacActions=1
1192 # => auto renew is allowed
1193 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1194 $patron = $renewing_borrower;
1195 $checkout = AddIssue( $patron, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1196 ( $renewokay, $error ) =
1197 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->itemnumber );
1198 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1199 is( $error, 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
1200 Koha::Checkouts->find( $checkout->issue_id )->delete;
1203 subtest "GetLatestAutoRenewDate" => sub {
1205 my $item_to_auto_renew = $builder->build_sample_item(
1207 biblionumber => $biblio->biblionumber,
1212 my $ten_days_before = dt_from_string->add( days => -10 );
1213 my $ten_days_ahead = dt_from_string->add( days => 10 );
1214 AddIssue( $renewing_borrower, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1215 Koha::CirculationRules->set_rules(
1217 categorycode => undef,
1218 branchcode => undef,
1221 norenewalbefore => '7',
1222 no_auto_renewal_after => '',
1223 no_auto_renewal_after_hard_limit => undef,
1227 my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1228 is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after or no_auto_renewal_after_hard_limit are not defined' );
1229 my $five_days_before = dt_from_string->add( days => -5 );
1230 Koha::CirculationRules->set_rules(
1232 categorycode => undef,
1233 branchcode => undef,
1236 norenewalbefore => '10',
1237 no_auto_renewal_after => '5',
1238 no_auto_renewal_after_hard_limit => undef,
1242 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1243 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1244 $five_days_before->truncate( to => 'minute' ),
1245 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
1247 my $five_days_ahead = dt_from_string->add( days => 5 );
1248 $dbh->do(q{UPDATE circulation_rules SET rule_value = '10' WHERE rule_name = 'norenewalbefore'});
1249 $dbh->do(q{UPDATE circulation_rules SET rule_value = '15' WHERE rule_name = 'no_auto_renewal_after'});
1250 $dbh->do(q{UPDATE circulation_rules SET rule_value = NULL WHERE rule_name = 'no_auto_renewal_after_hard_limit'});
1251 Koha::CirculationRules->set_rules(
1253 categorycode => undef,
1254 branchcode => undef,
1257 norenewalbefore => '10',
1258 no_auto_renewal_after => '15',
1259 no_auto_renewal_after_hard_limit => undef,
1263 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1264 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1265 $five_days_ahead->truncate( to => 'minute' ),
1266 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
1268 my $two_days_ahead = dt_from_string->add( days => 2 );
1269 Koha::CirculationRules->set_rules(
1271 categorycode => undef,
1272 branchcode => undef,
1275 norenewalbefore => '10',
1276 no_auto_renewal_after => '',
1277 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1281 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1282 is( $latest_auto_renew_date->truncate( to => 'day' ),
1283 $two_days_ahead->truncate( to => 'day' ),
1284 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
1286 Koha::CirculationRules->set_rules(
1288 categorycode => undef,
1289 branchcode => undef,
1292 norenewalbefore => '10',
1293 no_auto_renewal_after => '15',
1294 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1298 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->itemnumber );
1299 is( $latest_auto_renew_date->truncate( to => 'day' ),
1300 $two_days_ahead->truncate( to => 'day' ),
1301 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
1307 # set policy to forbid renewals
1308 Koha::CirculationRules->set_rules(
1310 categorycode => undef,
1311 branchcode => undef,
1314 norenewalbefore => undef,
1315 renewalsallowed => 0,
1320 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1321 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
1322 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
1324 # Too many unseen renewals
1325 Koha::CirculationRules->set_rules(
1327 categorycode => undef,
1328 branchcode => undef,
1331 unseen_renewals_allowed => 2,
1332 renewalsallowed => 10,
1336 t::lib::Mocks::mock_preference('UnseenRenewals', 1);
1337 $dbh->do('UPDATE issues SET unseen_renewals = 2 where borrowernumber = ? AND itemnumber = ?', undef, ($renewing_borrowernumber, $item_1->itemnumber));
1338 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1339 is( $renewokay, 0, 'Cannot renew, 0 unseen renewals allowed');
1340 is( $error, 'too_unseen', 'Cannot renew, returned code is too_unseen');
1341 Koha::CirculationRules->set_rules(
1343 categorycode => undef,
1344 branchcode => undef,
1347 norenewalbefore => undef,
1348 renewalsallowed => 0,
1352 t::lib::Mocks::mock_preference('UnseenRenewals', 0);
1354 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
1355 t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
1356 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1358 C4::Overdues::UpdateFine(
1360 issue_id => $issue->id(),
1361 itemnumber => $item_1->itemnumber,
1362 borrowernumber => $renewing_borrower->{borrowernumber},
1365 due => Koha::DateUtils::output_pref($datedue)
1369 my $line = Koha::Account::Lines->search({ borrowernumber => $renewing_borrower->{borrowernumber} })->next();
1370 is( $line->debit_type_code, 'OVERDUE', 'Account line type is OVERDUE' );
1371 is( $line->status, 'UNRETURNED', 'Account line status is UNRETURNED' );
1372 is( $line->amountoutstanding+0, 15, 'Account line amount outstanding is 15.00' );
1373 is( $line->amount+0, 15, 'Account line amount is 15.00' );
1374 is( $line->issue_id, $issue->id, 'Account line issue id matches' );
1376 my $offset = Koha::Account::Offsets->search({ debit_id => $line->id })->next();
1377 is( $offset->type, 'OVERDUE', 'Account offset type is Fine' );
1378 is( $offset->amount+0, 15, 'Account offset amount is 15.00' );
1380 t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
1381 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
1383 LostItem( $item_1->itemnumber, 'test', 1 );
1385 $line = Koha::Account::Lines->find($line->id);
1386 is( $line->debit_type_code, 'OVERDUE', 'Account type remains as OVERDUE' );
1387 isnt( $line->status, 'UNRETURNED', 'Account status correctly changed from UNRETURNED to RETURNED' );
1389 my $item = Koha::Items->find($item_1->itemnumber);
1390 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
1391 my $checkout = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber });
1392 is( $checkout, undef, 'LostItem called with forced return has checked in the item' );
1394 my $total_due = $dbh->selectrow_array(
1395 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1396 undef, $renewing_borrower->{borrowernumber}
1399 is( $total_due+0, 15, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
1401 C4::Context->dbh->do("DELETE FROM accountlines");
1403 C4::Overdues::UpdateFine(
1405 issue_id => $issue2->id(),
1406 itemnumber => $item_2->itemnumber,
1407 borrowernumber => $renewing_borrower->{borrowernumber},
1410 due => Koha::DateUtils::output_pref($datedue)
1414 LostItem( $item_2->itemnumber, 'test', 0 );
1416 my $item2 = Koha::Items->find($item_2->itemnumber);
1417 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
1418 ok( Koha::Checkouts->find({ itemnumber => $item_2->itemnumber }), 'LostItem called without forced return has checked in the item' );
1420 $total_due = $dbh->selectrow_array(
1421 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1422 undef, $renewing_borrower->{borrowernumber}
1425 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
1427 my $future = dt_from_string();
1428 $future->add( days => 7 );
1429 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
1430 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
1432 my $manager = $builder->build_object({ class => "Koha::Patrons" });
1433 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
1434 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1435 $checkout = Koha::Checkouts->find( { itemnumber => $item_3->itemnumber } );
1436 LostItem( $item_3->itemnumber, 'test', 0 );
1437 my $accountline = Koha::Account::Lines->find( { itemnumber => $item_3->itemnumber } );
1438 is( $accountline->issue_id, $checkout->id, "Issue id added for lost replacement fee charge" );
1440 $accountline->description,
1441 sprintf( "%s %s %s",
1442 $item_3->biblio->title || '',
1443 $item_3->barcode || '',
1444 $item_3->itemcallnumber || '' ),
1445 "Account line description must not contain 'Lost Items ', but be title, barcode, itemcallnumber"
1449 subtest "GetUpcomingDueIssues" => sub {
1452 my $branch = $library2->{branchcode};
1454 #Create another record
1455 my $biblio2 = $builder->build_sample_biblio();
1458 my $item_1 = Koha::Items->find($reused_itemnumber_1);
1459 my $item_2 = Koha::Items->find($reused_itemnumber_2);
1460 my $item_3 = $builder->build_sample_item(
1462 biblionumber => $biblio2->biblionumber,
1470 my %a_borrower_data = (
1471 firstname => 'Fridolyn',
1472 surname => 'SOMERS',
1473 categorycode => $patron_category->{categorycode},
1474 branchcode => $branch,
1477 my $a_borrower_borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1478 my $a_borrower = Koha::Patrons->find( $a_borrower_borrowernumber )->unblessed;
1480 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
1481 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
1482 my $today = DateTime->today(time_zone => C4::Context->tz());
1484 my $issue = AddIssue( $a_borrower, $item_1->barcode, $yesterday );
1485 my $datedue = dt_from_string( $issue->date_due() );
1486 my $issue2 = AddIssue( $a_borrower, $item_2->barcode, $two_days_ahead );
1487 my $datedue2 = dt_from_string( $issue->date_due() );
1491 # GetUpcomingDueIssues tests
1493 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1494 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
1497 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
1498 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1499 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
1502 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1503 is ( scalar( @$upcoming_dues ), 1,
1504 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
1507 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
1509 my $issue3 = AddIssue( $a_borrower, $item_3->barcode, $today );
1511 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
1512 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
1514 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
1515 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
1517 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
1518 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
1520 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1521 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1523 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
1524 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1526 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
1527 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
1531 subtest "Bug 13841 - Do not create new 0 amount fines" => sub {
1532 my $branch = $library2->{branchcode};
1534 my $biblio = $builder->build_sample_biblio();
1537 my $item = $builder->build_sample_item(
1539 biblionumber => $biblio->biblionumber,
1546 my %a_borrower_data = (
1547 firstname => 'Kyle',
1549 categorycode => $patron_category->{categorycode},
1550 branchcode => $branch,
1553 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1555 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1556 my $issue = AddIssue( $borrower, $item->barcode );
1559 issue_id => $issue->id(),
1560 itemnumber => $item->itemnumber,
1561 borrowernumber => $borrowernumber,
1567 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $item->itemnumber );
1568 my $count = $hr->{count};
1570 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
1573 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
1574 $dbh->do('DELETE FROM issues');
1575 $dbh->do('DELETE FROM items');
1576 $dbh->do('DELETE FROM circulation_rules');
1577 Koha::CirculationRules->set_rules(
1579 categorycode => undef,
1581 branchcode => undef,
1583 reservesallowed => 25,
1585 lengthunit => 'days',
1586 renewalsallowed => 1,
1588 norenewalbefore => undef,
1596 my $biblio = $builder->build_sample_biblio();
1598 my $item_1 = $builder->build_sample_item(
1600 biblionumber => $biblio->biblionumber,
1601 library => $library2->{branchcode},
1606 my $item_2= $builder->build_sample_item(
1608 biblionumber => $biblio->biblionumber,
1609 library => $library2->{branchcode},
1614 my $borrowernumber1 = Koha::Patron->new({
1615 firstname => 'Kyle',
1617 categorycode => $patron_category->{categorycode},
1618 branchcode => $library2->{branchcode},
1619 })->store->borrowernumber;
1620 my $borrowernumber2 = Koha::Patron->new({
1621 firstname => 'Chelsea',
1623 categorycode => $patron_category->{categorycode},
1624 branchcode => $library2->{branchcode},
1625 })->store->borrowernumber;
1627 my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
1628 my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
1630 my $issue = AddIssue( $borrower1, $item_1->barcode );
1632 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1633 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
1637 branchcode => $library2->{branchcode},
1638 borrowernumber => $borrowernumber2,
1639 biblionumber => $biblio->biblionumber,
1644 Koha::CirculationRules->set_rules(
1646 categorycode => undef,
1648 branchcode => undef,
1654 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1655 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1656 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
1658 Koha::CirculationRules->set_rules(
1660 categorycode => undef,
1662 branchcode => undef,
1668 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1669 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1670 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
1672 Koha::CirculationRules->set_rules(
1674 categorycode => undef,
1676 branchcode => undef,
1682 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1683 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1684 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
1686 Koha::CirculationRules->set_rules(
1688 categorycode => undef,
1690 branchcode => undef,
1696 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1697 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1698 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
1700 # Setting item not checked out to be not for loan but holdable
1701 $item_2->notforloan(-1)->store;
1703 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1704 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
1708 # Don't allow renewing onsite checkout
1709 my $branch = $library->{branchcode};
1711 #Create another record
1712 my $biblio = $builder->build_sample_biblio();
1714 my $item = $builder->build_sample_item(
1716 biblionumber => $biblio->biblionumber,
1722 my $borrowernumber = Koha::Patron->new({
1725 categorycode => $patron_category->{categorycode},
1726 branchcode => $branch,
1727 })->store->borrowernumber;
1729 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1731 my $issue = AddIssue( $borrower, $item->barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
1732 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $item->itemnumber );
1733 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
1734 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1738 my $library = $builder->build({ source => 'Branch' });
1740 my $biblio = $builder->build_sample_biblio();
1742 my $item = $builder->build_sample_item(
1744 biblionumber => $biblio->biblionumber,
1745 library => $library->{branchcode},
1750 my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode} } } );
1752 my $issue = AddIssue( $patron, $item->barcode );
1755 issue_id => $issue->id(),
1756 itemnumber => $item->itemnumber,
1757 borrowernumber => $patron->{borrowernumber},
1764 issue_id => $issue->id(),
1765 itemnumber => $item->itemnumber,
1766 borrowernumber => $patron->{borrowernumber},
1771 is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1774 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1777 my $homebranch = $builder->build( { source => 'Branch' } );
1778 my $holdingbranch = $builder->build( { source => 'Branch' } );
1779 my $otherbranch = $builder->build( { source => 'Branch' } );
1780 my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1781 my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1783 my $item = $builder->build_sample_item(
1785 homebranch => $homebranch->{branchcode},
1786 holdingbranch => $holdingbranch->{branchcode},
1790 set_userenv($holdingbranch);
1792 my $issue = AddIssue( $patron_1->unblessed, $item->barcode );
1793 is( ref($issue), 'Koha::Checkout', 'AddIssue should return a Koha::Checkout object' );
1795 my ( $error, $question, $alerts );
1797 # AllowReturnToBranch == anywhere
1798 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1799 ## Test that unknown barcodes don't generate internal server errors
1800 set_userenv($homebranch);
1801 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
1802 ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
1803 ## Can be issued from homebranch
1804 set_userenv($homebranch);
1805 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1806 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1807 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1808 ## Can be issued from holdingbranch
1809 set_userenv($holdingbranch);
1810 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1811 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1812 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1813 ## Can be issued from another branch
1814 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1815 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1816 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1818 # AllowReturnToBranch == holdingbranch
1819 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1820 ## Cannot be issued from homebranch
1821 set_userenv($homebranch);
1822 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1823 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1824 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1825 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matched holdingbranch' );
1826 ## Can be issued from holdinbranch
1827 set_userenv($holdingbranch);
1828 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1829 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1830 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1831 ## Cannot be issued from another branch
1832 set_userenv($otherbranch);
1833 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1834 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1835 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1836 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matches holdingbranch' );
1838 # AllowReturnToBranch == homebranch
1839 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1840 ## Can be issued from holdinbranch
1841 set_userenv($homebranch);
1842 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1843 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1844 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1845 ## Cannot be issued from holdinbranch
1846 set_userenv($holdingbranch);
1847 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1848 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1849 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1850 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1851 ## Cannot be issued from holdinbranch
1852 set_userenv($otherbranch);
1853 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode );
1854 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1855 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1856 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1858 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1861 subtest 'AddIssue & AllowReturnToBranch' => sub {
1864 my $homebranch = $builder->build( { source => 'Branch' } );
1865 my $holdingbranch = $builder->build( { source => 'Branch' } );
1866 my $otherbranch = $builder->build( { source => 'Branch' } );
1867 my $patron_1 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1868 my $patron_2 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1870 my $item = $builder->build_sample_item(
1872 homebranch => $homebranch->{branchcode},
1873 holdingbranch => $holdingbranch->{branchcode},
1877 set_userenv($holdingbranch);
1879 my $ref_issue = 'Koha::Checkout';
1880 my $issue = AddIssue( $patron_1, $item->barcode );
1882 my ( $error, $question, $alerts );
1884 # AllowReturnToBranch == homebranch
1885 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1886 ## Can be issued from homebranch
1887 set_userenv($homebranch);
1888 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from homebranch');
1889 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1890 ## Can be issued from holdinbranch
1891 set_userenv($holdingbranch);
1892 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from holdingbranch');
1893 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1894 ## Can be issued from another branch
1895 set_userenv($otherbranch);
1896 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from otherbranch');
1897 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1899 # AllowReturnToBranch == holdinbranch
1900 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1901 ## Cannot be issued from homebranch
1902 set_userenv($homebranch);
1903 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from homebranch');
1904 ## Can be issued from holdingbranch
1905 set_userenv($holdingbranch);
1906 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - holdingbranch | Can be issued from holdingbranch');
1907 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1908 ## Cannot be issued from another branch
1909 set_userenv($otherbranch);
1910 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from otherbranch');
1912 # AllowReturnToBranch == homebranch
1913 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1914 ## Can be issued from homebranch
1915 set_userenv($homebranch);
1916 is ( ref( AddIssue( $patron_2, $item->barcode ) ), $ref_issue, 'AllowReturnToBranch - homebranch | Can be issued from homebranch' );
1917 set_userenv($holdingbranch); AddIssue( $patron_1, $item->barcode ); # Reinsert the original issue
1918 ## Cannot be issued from holdinbranch
1919 set_userenv($holdingbranch);
1920 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from holdingbranch' );
1921 ## Cannot be issued from another branch
1922 set_userenv($otherbranch);
1923 is ( ref( AddIssue( $patron_2, $item->barcode ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from otherbranch' );
1924 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1927 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1930 my $library = $builder->build( { source => 'Branch' } );
1931 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1932 my $item_1 = $builder->build_sample_item(
1934 library => $library->{branchcode},
1937 my $item_2 = $builder->build_sample_item(
1939 library => $library->{branchcode},
1943 my ( $error, $question, $alerts );
1945 # Patron cannot issue item_1, they have overdues
1946 my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1947 my $issue = AddIssue( $patron->unblessed, $item_1->barcode, $yesterday ); # Add an overdue
1949 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1950 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1951 is( keys(%$error) + keys(%$alerts), 0, 'No key for error and alert' . str($error, $question, $alerts) );
1952 is( $question->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=confirmation, USERBLOCKEDOVERDUE should be set for question' );
1954 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1955 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1956 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1957 is( $error->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=block, USERBLOCKEDOVERDUE should be set for error' );
1959 # Patron cannot issue item_1, they are debarred
1960 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1961 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber, expiration => $tomorrow } );
1962 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1963 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1964 is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ), 'USERBLOCKEDWITHENDDATE should be tomorrow' );
1966 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber } );
1967 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
1968 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1969 is( $error->{USERBLOCKEDNOENDDATE}, '9999-12-31', 'USERBLOCKEDNOENDDATE should be 9999-12-31 for unlimited debarments' );
1972 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
1975 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1976 my $patron_category_x = $builder->build_object(
1978 class => 'Koha::Patron::Categories',
1979 value => { category_type => 'X' }
1982 my $patron = $builder->build_object(
1984 class => 'Koha::Patrons',
1986 categorycode => $patron_category_x->categorycode,
1987 gonenoaddress => undef,
1994 my $item_1 = $builder->build_sample_item(
1996 library => $library->{branchcode},
2000 my ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_1->barcode );
2001 is( $error->{STATS}, 1, '"Error" flag "STATS" must be set if CanBookBeIssued is called with a statistic patron (category_type=X)' );
2003 # TODO There are other tests to provide here
2006 subtest 'MultipleReserves' => sub {
2009 my $biblio = $builder->build_sample_biblio();
2011 my $branch = $library2->{branchcode};
2013 my $item_1 = $builder->build_sample_item(
2015 biblionumber => $biblio->biblionumber,
2017 replacementprice => 12.00,
2022 my $item_2 = $builder->build_sample_item(
2024 biblionumber => $biblio->biblionumber,
2026 replacementprice => 12.00,
2033 my $resdate = undef;
2034 my $expdate = undef;
2036 my $checkitem = undef;
2039 my %renewing_borrower_data = (
2040 firstname => 'John',
2041 surname => 'Renewal',
2042 categorycode => $patron_category->{categorycode},
2043 branchcode => $branch,
2045 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
2046 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
2047 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
2048 my $datedue = dt_from_string( $issue->date_due() );
2049 is (defined $issue->date_due(), 1, "item 1 checked out");
2050 my $borrowing_borrowernumber = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber })->borrowernumber;
2052 my %reserving_borrower_data1 = (
2053 firstname => 'Katrin',
2054 surname => 'Reservation',
2055 categorycode => $patron_category->{categorycode},
2056 branchcode => $branch,
2058 my $reserving_borrowernumber1 = Koha::Patron->new(\%reserving_borrower_data1)->store->borrowernumber;
2061 branchcode => $branch,
2062 borrowernumber => $reserving_borrowernumber1,
2063 biblionumber => $biblio->biblionumber,
2064 priority => $priority,
2065 reservation_date => $resdate,
2066 expiration_date => $expdate,
2068 itemnumber => $checkitem,
2073 my %reserving_borrower_data2 = (
2074 firstname => 'Kirk',
2075 surname => 'Reservation',
2076 categorycode => $patron_category->{categorycode},
2077 branchcode => $branch,
2079 my $reserving_borrowernumber2 = Koha::Patron->new(\%reserving_borrower_data2)->store->borrowernumber;
2082 branchcode => $branch,
2083 borrowernumber => $reserving_borrowernumber2,
2084 biblionumber => $biblio->biblionumber,
2085 priority => $priority,
2086 reservation_date => $resdate,
2087 expiration_date => $expdate,
2089 itemnumber => $checkitem,
2095 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
2096 is($renewokay, 0, 'Bug 17941 - should cover the case where 2 books are both reserved, so failing');
2099 my $item_3 = $builder->build_sample_item(
2101 biblionumber => $biblio->biblionumber,
2103 replacementprice => 12.00,
2109 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
2110 is($renewokay, 1, 'Bug 17941 - should cover the case where 2 books are reserved, but a third one is available');
2114 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
2117 my $library = $builder->build( { source => 'Branch' } );
2118 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
2120 my $biblionumber = $builder->build_sample_biblio(
2122 branchcode => $library->{branchcode},
2125 my $item_1 = $builder->build_sample_item(
2127 biblionumber => $biblionumber,
2128 library => $library->{branchcode},
2132 my $item_2 = $builder->build_sample_item(
2134 biblionumber => $biblionumber,
2135 library => $library->{branchcode},
2139 my ( $error, $question, $alerts );
2140 my $issue = AddIssue( $patron->unblessed, $item_1->barcode, dt_from_string->add( days => 1 ) );
2142 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
2143 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2145 { error => $error, alerts => $alerts },
2146 { error => {}, alerts => {} },
2147 'No error or alert should be raised'
2149 is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' );
2151 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
2152 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2154 { error => $error, question => $question, alerts => $alerts },
2155 { error => {}, question => {}, alerts => {} },
2156 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1'
2159 # Add a subscription
2160 Koha::Subscription->new({ biblionumber => $biblionumber })->store;
2162 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
2163 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2165 { error => $error, question => $question, alerts => $alerts },
2166 { error => {}, question => {}, alerts => {} },
2167 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
2170 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
2171 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode );
2173 { error => $error, question => $question, alerts => $alerts },
2174 { error => {}, question => {}, alerts => {} },
2175 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
2179 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
2182 my $library = $builder->build( { source => 'Branch' } );
2183 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2186 my $biblionumber = $builder->build_sample_biblio(
2188 branchcode => $library->{branchcode},
2191 my $item_1 = $builder->build_sample_item(
2193 biblionumber => $biblionumber,
2194 library => $library->{branchcode},
2197 my $item_2 = $builder->build_sample_item(
2199 biblionumber => $biblionumber,
2200 library => $library->{branchcode},
2204 # And the circulation rule
2205 Koha::CirculationRules->search->delete;
2206 Koha::CirculationRules->set_rules(
2208 categorycode => undef,
2210 branchcode => undef,
2213 firstremind => 1, # 1 day of grace
2214 finedays => 2, # 2 days of fine per day of overdue
2215 lengthunit => 'days',
2220 # Patron cannot issue item_1, they have overdues
2221 my $now = dt_from_string;
2222 my $five_days_ago = $now->clone->subtract( days => 5 );
2223 my $ten_days_ago = $now->clone->subtract( days => 10 );
2224 AddIssue( $patron, $item_1->barcode, $five_days_ago ); # Add an overdue
2225 AddIssue( $patron, $item_2->barcode, $ten_days_ago )
2226 ; # Add another overdue
2228 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
2229 AddReturn( $item_1->barcode, $library->{branchcode}, undef, $now );
2230 my $debarments = Koha::Patron::Debarments::GetDebarments(
2231 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2232 is( scalar(@$debarments), 1 );
2234 # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
2235 # Same for the others
2236 my $expected_expiration = output_pref(
2238 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2239 dateformat => 'sql',
2243 is( $debarments->[0]->{expiration}, $expected_expiration );
2245 AddReturn( $item_2->barcode, $library->{branchcode}, undef, $now );
2246 $debarments = Koha::Patron::Debarments::GetDebarments(
2247 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2248 is( scalar(@$debarments), 1 );
2249 $expected_expiration = output_pref(
2251 dt => $now->clone->add( days => ( 10 - 1 ) * 2 ),
2252 dateformat => 'sql',
2256 is( $debarments->[0]->{expiration}, $expected_expiration );
2258 Koha::Patron::Debarments::DelUniqueDebarment(
2259 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2261 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
2262 AddIssue( $patron, $item_1->barcode, $five_days_ago ); # Add an overdue
2263 AddIssue( $patron, $item_2->barcode, $ten_days_ago )
2264 ; # Add another overdue
2265 AddReturn( $item_1->barcode, $library->{branchcode}, undef, $now );
2266 $debarments = Koha::Patron::Debarments::GetDebarments(
2267 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2268 is( scalar(@$debarments), 1 );
2269 $expected_expiration = output_pref(
2271 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2272 dateformat => 'sql',
2276 is( $debarments->[0]->{expiration}, $expected_expiration );
2278 AddReturn( $item_2->barcode, $library->{branchcode}, undef, $now );
2279 $debarments = Koha::Patron::Debarments::GetDebarments(
2280 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2281 is( scalar(@$debarments), 1 );
2282 $expected_expiration = output_pref(
2284 dt => $now->clone->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
2285 dateformat => 'sql',
2289 is( $debarments->[0]->{expiration}, $expected_expiration );
2292 subtest 'AddReturn + suspension_chargeperiod' => sub {
2295 my $library = $builder->build( { source => 'Branch' } );
2296 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2298 my $biblionumber = $builder->build_sample_biblio(
2300 branchcode => $library->{branchcode},
2303 my $item_1 = $builder->build_sample_item(
2305 biblionumber => $biblionumber,
2306 library => $library->{branchcode},
2310 # And the issuing rule
2311 Koha::CirculationRules->search->delete;
2312 Koha::CirculationRules->set_rules(
2314 categorycode => '*',
2319 firstremind => 0, # 0 day of grace
2320 finedays => 2, # 2 days of fine per day of overdue
2321 suspension_chargeperiod => 1,
2322 lengthunit => 'days',
2327 my $now = dt_from_string;
2328 my $five_days_ago = $now->clone->subtract( days => 5 );
2329 # We want to charge 2 days every day, without grace
2330 # With 5 days of overdue: 5 * Z
2331 my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
2332 test_debarment_on_checkout(
2335 library => $library,
2337 due_date => $five_days_ago,
2338 expiration_date => $expected_expiration,
2342 # Same with undef firstremind
2343 Koha::CirculationRules->search->delete;
2344 Koha::CirculationRules->set_rules(
2346 categorycode => '*',
2351 firstremind => undef, # 0 day of grace
2352 finedays => 2, # 2 days of fine per day of overdue
2353 suspension_chargeperiod => 1,
2354 lengthunit => 'days',
2359 my $now = dt_from_string;
2360 my $five_days_ago = $now->clone->subtract( days => 5 );
2361 # We want to charge 2 days every day, without grace
2362 # With 5 days of overdue: 5 * Z
2363 my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
2364 test_debarment_on_checkout(
2367 library => $library,
2369 due_date => $five_days_ago,
2370 expiration_date => $expected_expiration,
2374 # We want to charge 2 days every 2 days, without grace
2375 # With 5 days of overdue: (5 * 2) / 2
2376 Koha::CirculationRules->set_rule(
2378 categorycode => undef,
2379 branchcode => undef,
2381 rule_name => 'suspension_chargeperiod',
2386 $expected_expiration = $now->clone->add( days => floor( 5 * 2 ) / 2 );
2387 test_debarment_on_checkout(
2390 library => $library,
2392 due_date => $five_days_ago,
2393 expiration_date => $expected_expiration,
2397 # We want to charge 2 days every 3 days, with 1 day of grace
2398 # With 5 days of overdue: ((5-1) / 3 ) * 2
2399 Koha::CirculationRules->set_rules(
2401 categorycode => undef,
2402 branchcode => undef,
2405 suspension_chargeperiod => 3,
2410 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 1 ) / 3 ) * 2 ) );
2411 test_debarment_on_checkout(
2414 library => $library,
2416 due_date => $five_days_ago,
2417 expiration_date => $expected_expiration,
2421 # Use finesCalendar to know if holiday must be skipped to calculate the due date
2422 # We want to charge 2 days every days, with 0 day of grace (to not burn brains)
2423 Koha::CirculationRules->set_rules(
2425 categorycode => undef,
2426 branchcode => undef,
2430 suspension_chargeperiod => 1,
2435 t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
2436 t::lib::Mocks::mock_preference('SuspensionsCalendar', 'noSuspensionsWhenClosed');
2438 # Adding a holiday 2 days ago
2439 my $calendar = C4::Calendar->new(branchcode => $library->{branchcode});
2440 my $two_days_ago = $now->clone->subtract( days => 2 );
2441 $calendar->insert_single_holiday(
2442 day => $two_days_ago->day,
2443 month => $two_days_ago->month,
2444 year => $two_days_ago->year,
2445 title => 'holidayTest-2d',
2446 description => 'holidayDesc 2 days ago'
2448 # With 5 days of overdue, only 4 (x finedays=2) days must charged (one was an holiday)
2449 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) );
2450 test_debarment_on_checkout(
2453 library => $library,
2455 due_date => $five_days_ago,
2456 expiration_date => $expected_expiration,
2460 # Adding a holiday 2 days ahead, with finesCalendar=noFinesWhenClosed it should be skipped
2461 my $two_days_ahead = $now->clone->add( days => 2 );
2462 $calendar->insert_single_holiday(
2463 day => $two_days_ahead->day,
2464 month => $two_days_ahead->month,
2465 year => $two_days_ahead->year,
2466 title => 'holidayTest+2d',
2467 description => 'holidayDesc 2 days ahead'
2470 # Same as above, but we should skip D+2
2471 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) + 1 );
2472 test_debarment_on_checkout(
2475 library => $library,
2477 due_date => $five_days_ago,
2478 expiration_date => $expected_expiration,
2482 # Adding another holiday, day of expiration date
2483 my $expected_expiration_dt = dt_from_string($expected_expiration);
2484 $calendar->insert_single_holiday(
2485 day => $expected_expiration_dt->day,
2486 month => $expected_expiration_dt->month,
2487 year => $expected_expiration_dt->year,
2488 title => 'holidayTest_exp',
2489 description => 'holidayDesc on expiration date'
2491 # Expiration date will be the day after
2492 test_debarment_on_checkout(
2495 library => $library,
2497 due_date => $five_days_ago,
2498 expiration_date => $expected_expiration_dt->clone->add( days => 1 ),
2502 test_debarment_on_checkout(
2505 library => $library,
2507 return_date => $now->clone->add(days => 5),
2508 expiration_date => $now->clone->add(days => 5 + (5 * 2 - 1) ),
2512 test_debarment_on_checkout(
2515 library => $library,
2517 due_date => $now->clone->add(days => 1),
2518 return_date => $now->clone->add(days => 5),
2519 expiration_date => $now->clone->add(days => 5 + (4 * 2 - 1) ),
2525 subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub {
2528 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2529 my $patron1 = $builder->build_object(
2531 class => 'Koha::Patrons',
2533 library => $library->branchcode,
2534 categorycode => $patron_category->{categorycode}
2538 my $patron2 = $builder->build_object(
2540 class => 'Koha::Patrons',
2542 library => $library->branchcode,
2543 categorycode => $patron_category->{categorycode}
2548 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
2550 my $item = $builder->build_sample_item(
2552 library => $library->branchcode,
2556 my ( $error, $question, $alerts );
2557 my $issue = AddIssue( $patron1->unblessed, $item->barcode );
2559 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2560 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->barcode );
2561 is( $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' );
2563 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 1);
2564 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->barcode );
2565 is( $alerts->{RETURNED_FROM_ANOTHER}->{patron}->borrowernumber, $patron1->borrowernumber, 'RETURNED_FROM_ANOTHER alert flag should be set if AutoReturnCheckedOutItems is enabled and item is checked out to another' );
2567 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2571 subtest 'AddReturn | is_overdue' => sub {
2574 t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'batchmod|moredetail|cronjob|additem|pendingreserves|onpayment');
2575 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
2576 t::lib::Mocks::mock_preference('finesMode', 'production');
2577 t::lib::Mocks::mock_preference('MaxFine', '100');
2579 my $library = $builder->build( { source => 'Branch' } );
2580 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2581 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2582 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2584 my $item = $builder->build_sample_item(
2586 library => $library->{branchcode},
2587 replacementprice => 7
2591 Koha::CirculationRules->search->delete;
2592 Koha::CirculationRules->set_rules(
2594 categorycode => undef,
2596 branchcode => undef,
2599 lengthunit => 'days',
2600 fine => 1, # Charge 1 every day of overdue
2606 my $now = dt_from_string;
2607 my $one_day_ago = $now->clone->subtract( days => 1 );
2608 my $two_days_ago = $now->clone->subtract( days => 2 );
2609 my $five_days_ago = $now->clone->subtract( days => 5 );
2610 my $ten_days_ago = $now->clone->subtract( days => 10 );
2611 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
2613 # No return date specified, today will be used => 10 days overdue charged
2614 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2615 AddReturn( $item->barcode, $library->{branchcode} );
2616 is( int($patron->account->balance()), 10, 'Patron should have a charge of 10 (10 days x 1)' );
2617 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2619 # specify return date 5 days before => no overdue charged
2620 AddIssue( $patron->unblessed, $item->barcode, $five_days_ago ); # date due was 5d ago
2621 AddReturn( $item->barcode, $library->{branchcode}, undef, $ten_days_ago );
2622 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2623 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2625 # specify return date 5 days later => 5 days overdue charged
2626 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2627 AddReturn( $item->barcode, $library->{branchcode}, undef, $five_days_ago );
2628 is( int($patron->account->balance()), 5, 'AddReturn: pass return_date => overdue' );
2629 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2631 # specify return date 5 days later, specify exemptfine => no overdue charge
2632 AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2633 AddReturn( $item->barcode, $library->{branchcode}, 1, $five_days_ago );
2634 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2635 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2637 subtest 'bug 22877 | Lost item return' => sub {
2641 my $issue = AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago ); # date due was 10d ago
2643 # Fake fines cronjob on this checkout
2645 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2646 $ten_days_ago, $now );
2649 issue_id => $issue->issue_id,
2650 itemnumber => $item->itemnumber,
2651 borrowernumber => $patron->borrowernumber,
2653 due => output_pref($ten_days_ago)
2656 is( int( $patron->account->balance() ),
2657 10, "Overdue fine of 10 days overdue" );
2659 # Fake longoverdue with charge and not marking returned
2660 LostItem( $item->itemnumber, 'cronjob', 0 );
2661 is( int( $patron->account->balance() ),
2662 17, "Lost fine of 7 plus 10 days overdue" );
2664 # Now we return it today
2665 AddReturn( $item->barcode, $library->{branchcode} );
2666 is( int( $patron->account->balance() ),
2667 17, "Should have a single 10 days overdue fine and lost charge" );
2670 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2673 subtest 'bug 8338 | backdated return resulting in zero amount fine' => sub {
2677 t::lib::Mocks::mock_preference('CalculateFinesOnBackdate', 1);
2679 my $issue = AddIssue( $patron->unblessed, $item->barcode, $one_day_ago ); # date due was 1d ago
2681 # Fake fines cronjob on this checkout
2683 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2684 $one_day_ago, $now );
2687 issue_id => $issue->issue_id,
2688 itemnumber => $item->itemnumber,
2689 borrowernumber => $patron->borrowernumber,
2691 due => output_pref($one_day_ago)
2694 is( int( $patron->account->balance() ),
2695 1, "Overdue fine of 1 day overdue" );
2697 # Backdated return (dropbox mode example - charge should be removed)
2698 AddReturn( $item->barcode, $library->{branchcode}, 1, $one_day_ago );
2699 is( int( $patron->account->balance() ),
2700 0, "Overdue fine should be annulled" );
2701 my $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2702 is( $lines->count, 0, "Overdue fine accountline has been removed");
2704 $issue = AddIssue( $patron->unblessed, $item->barcode, $two_days_ago ); # date due was 2d ago
2706 # Fake fines cronjob on this checkout
2708 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2709 $two_days_ago, $now );
2712 issue_id => $issue->issue_id,
2713 itemnumber => $item->itemnumber,
2714 borrowernumber => $patron->borrowernumber,
2716 due => output_pref($one_day_ago)
2719 is( int( $patron->account->balance() ),
2720 2, "Overdue fine of 2 days overdue" );
2722 # Payment made against fine
2723 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2724 my $debit = $lines->next;
2725 my $credit = $patron->account->add_credit(
2729 interface => 'test',
2733 { debits => [ $debit ], offset_type => 'Payment' } );
2735 is( int( $patron->account->balance() ),
2736 0, "Overdue fine should be paid off" );
2737 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
2738 is ( $lines->count, 2, "Overdue (debit) and Payment (credit) present");
2739 my $line = $lines->next;
2740 is( $line->amount+0, 2, "Overdue fine amount remains as 2 days");
2741 is( $line->amountoutstanding+0, 0, "Overdue fine amountoutstanding reduced to 0");
2743 # Backdated return (dropbox mode example - charge should be removed)
2744 AddReturn( $item->barcode, $library->{branchcode}, undef, $one_day_ago );
2745 is( int( $patron->account->balance() ),
2746 -1, "Refund credit has been applied" );
2747 $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber }, { order_by => { '-asc' => 'accountlines_id' }});
2748 is( $lines->count, 3, "Overdue (debit), Payment (credit) and Refund (credit) are all present");
2750 $line = $lines->next;
2751 is($line->amount+0,1, "Overdue fine amount has been reduced to 1");
2752 is($line->amountoutstanding+0,0, "Overdue fine amount outstanding remains at 0");
2753 is($line->status,'RETURNED', "Overdue fine is fixed");
2754 $line = $lines->next;
2755 is($line->amount+0,-2, "Original payment amount remains as 2");
2756 is($line->amountoutstanding+0,0, "Original payment remains applied");
2757 $line = $lines->next;
2758 is($line->amount+0,-1, "Refund amount correctly set to 1");
2759 is($line->amountoutstanding+0,-1, "Refund amount outstanding unspent");
2762 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2765 subtest 'bug 25417 | backdated return + exemptfine' => sub {
2769 t::lib::Mocks::mock_preference('CalculateFinesOnBackdate', 1);
2771 my $issue = AddIssue( $patron->unblessed, $item->barcode, $one_day_ago ); # date due was 1d ago
2773 # Fake fines cronjob on this checkout
2775 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2776 $one_day_ago, $now );
2779 issue_id => $issue->issue_id,
2780 itemnumber => $item->itemnumber,
2781 borrowernumber => $patron->borrowernumber,
2783 due => output_pref($one_day_ago)
2786 is( int( $patron->account->balance() ),
2787 1, "Overdue fine of 1 day overdue" );
2789 # Backdated return (dropbox mode example - charge should no longer exist)
2790 AddReturn( $item->barcode, $library->{branchcode}, 1, $one_day_ago );
2791 is( int( $patron->account->balance() ),
2792 0, "Overdue fine should be annulled" );
2795 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2798 subtest 'bug 24075 | backdated return with return datetime matching due datetime' => sub {
2801 t::lib::Mocks::mock_preference( 'CalculateFinesOnBackdate', 1 );
2803 my $due_date = dt_from_string;
2804 my $issue = AddIssue( $patron->unblessed, $item->barcode, $due_date );
2809 issue_id => $issue->issue_id,
2810 itemnumber => $item->itemnumber,
2811 borrowernumber => $patron->borrowernumber,
2813 due => output_pref($due_date)
2816 is( $patron->account->balance(),
2817 0.25, 'Overdue fine of $0.25 recorded' );
2819 # Backdate return to exact due date and time
2820 my ( undef, $message ) =
2821 AddReturn( $item->barcode, $library->{branchcode},
2825 Koha::Account::Lines->find( { issue_id => $issue->id } );
2826 ok( !$accountline, 'accountline removed as expected' );
2829 $issue = AddIssue( $patron->unblessed, $item->barcode, $due_date );
2834 issue_id => $issue->issue_id,
2835 itemnumber => $item->itemnumber,
2836 borrowernumber => $patron->borrowernumber,
2838 due => output_pref($due_date)
2841 is( $patron->account->balance(),
2842 0.25, 'Overdue fine of $0.25 recorded' );
2844 # Partial pay accruing fine
2845 my $lines = Koha::Account::Lines->search(
2847 borrowernumber => $patron->borrowernumber,
2848 issue_id => $issue->id
2851 my $debit = $lines->next;
2852 my $credit = $patron->account->add_credit(
2856 interface => 'test',
2859 $credit->apply( { debits => [$debit], offset_type => 'Payment' } );
2861 is( $patron->account->balance(), .05, 'Overdue fine reduced to $0.05' );
2863 # Backdate return to exact due date and time
2864 ( undef, $message ) =
2865 AddReturn( $item->barcode, $library->{branchcode},
2868 $lines = Koha::Account::Lines->search(
2870 borrowernumber => $patron->borrowernumber,
2871 issue_id => $issue->id
2874 $accountline = $lines->next;
2875 is( $accountline->amountoutstanding + 0,
2876 0, 'Partially paid fee amount outstanding was reduced to 0' );
2877 is( $accountline->amount + 0,
2878 0, 'Partially paid fee amount was reduced to 0' );
2879 is( $patron->account->balance(), -0.20, 'Patron refund recorded' );
2882 Koha::Account::Lines->search(
2883 { borrowernumber => $patron->borrowernumber } )->delete;
2886 subtest 'enh 23091 | Lost item return policies' => sub {
2889 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2891 my $branchcode_false =
2892 $builder->build( { source => 'Branch' } )->{branchcode};
2893 my $specific_rule_false = $builder->build(
2895 source => 'CirculationRule',
2897 branchcode => $branchcode_false,
2898 categorycode => undef,
2900 rule_name => 'lostreturn',
2905 my $branchcode_refund =
2906 $builder->build( { source => 'Branch' } )->{branchcode};
2907 my $specific_rule_refund = $builder->build(
2909 source => 'CirculationRule',
2911 branchcode => $branchcode_refund,
2912 categorycode => undef,
2914 rule_name => 'lostreturn',
2915 rule_value => 'refund'
2919 my $branchcode_restore =
2920 $builder->build( { source => 'Branch' } )->{branchcode};
2921 my $specific_rule_restore = $builder->build(
2923 source => 'CirculationRule',
2925 branchcode => $branchcode_restore,
2926 categorycode => undef,
2928 rule_name => 'lostreturn',
2929 rule_value => 'restore'
2933 my $branchcode_charge =
2934 $builder->build( { source => 'Branch' } )->{branchcode};
2935 my $specific_rule_charge = $builder->build(
2937 source => 'CirculationRule',
2939 branchcode => $branchcode_charge,
2940 categorycode => undef,
2942 rule_name => 'lostreturn',
2943 rule_value => 'charge'
2948 my $replacement_amount = 99.00;
2949 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
2950 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
2951 t::lib::Mocks::mock_preference( 'WhenLostForgiveFine', 0 );
2952 t::lib::Mocks::mock_preference( 'BlockReturnOfLostItems', 0 );
2953 t::lib::Mocks::mock_preference( 'RefundLostOnReturnControl',
2955 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge',
2958 subtest 'lostreturn | false' => sub {
2961 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_false });
2963 my $item = $builder->build_sample_item(
2965 replacementprice => $replacement_amount
2970 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
2972 # Fake fines cronjob on this checkout
2974 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2975 $ten_days_ago, $now );
2978 issue_id => $issue->issue_id,
2979 itemnumber => $item->itemnumber,
2980 borrowernumber => $patron->borrowernumber,
2982 due => output_pref($ten_days_ago)
2985 my $overdue_fees = Koha::Account::Lines->search(
2987 borrowernumber => $patron->id,
2988 itemnumber => $item->itemnumber,
2989 debit_type_code => 'OVERDUE'
2992 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
2993 my $overdue_fee = $overdue_fees->next;
2994 is( $overdue_fee->amount + 0,
2995 10, 'The right OVERDUE amount is generated' );
2996 is( $overdue_fee->amountoutstanding + 0,
2998 'The right OVERDUE amountoutstanding is generated' );
3000 # Simulate item marked as lost
3001 $item->itemlost(3)->store;
3002 C4::Circulation::LostItem( $item->itemnumber, 1 );
3004 my $lost_fee_lines = Koha::Account::Lines->search(
3006 borrowernumber => $patron->id,
3007 itemnumber => $item->itemnumber,
3008 debit_type_code => 'LOST'
3011 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3012 my $lost_fee_line = $lost_fee_lines->next;
3013 is( $lost_fee_line->amount + 0,
3014 $replacement_amount, 'The right LOST amount is generated' );
3015 is( $lost_fee_line->amountoutstanding + 0,
3016 $replacement_amount,
3017 'The right LOST amountoutstanding is generated' );
3018 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3021 my ( $returned, $message ) =
3022 AddReturn( $item->barcode, $branchcode_false, undef, $five_days_ago );
3024 $overdue_fee->discard_changes;
3025 is( $overdue_fee->amount + 0,
3026 10, 'The OVERDUE amount is left intact' );
3027 is( $overdue_fee->amountoutstanding + 0,
3029 'The OVERDUE amountoutstanding is left intact' );
3031 $lost_fee_line->discard_changes;
3032 is( $lost_fee_line->amount + 0,
3033 $replacement_amount, 'The LOST amount is left intact' );
3034 is( $lost_fee_line->amountoutstanding + 0,
3035 $replacement_amount,
3036 'The LOST amountoutstanding is left intact' );
3037 # FIXME: Should we set the LOST fee status to 'FOUND' regardless of whether we're refunding or not?
3038 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3041 subtest 'lostreturn | refund' => sub {
3044 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_refund });
3046 my $item = $builder->build_sample_item(
3048 replacementprice => $replacement_amount
3053 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
3055 # Fake fines cronjob on this checkout
3057 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3058 $ten_days_ago, $now );
3061 issue_id => $issue->issue_id,
3062 itemnumber => $item->itemnumber,
3063 borrowernumber => $patron->borrowernumber,
3065 due => output_pref($ten_days_ago)
3068 my $overdue_fees = Koha::Account::Lines->search(
3070 borrowernumber => $patron->id,
3071 itemnumber => $item->itemnumber,
3072 debit_type_code => 'OVERDUE'
3075 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3076 my $overdue_fee = $overdue_fees->next;
3077 is( $overdue_fee->amount + 0,
3078 10, 'The right OVERDUE amount is generated' );
3079 is( $overdue_fee->amountoutstanding + 0,
3081 'The right OVERDUE amountoutstanding is generated' );
3083 # Simulate item marked as lost
3084 $item->itemlost(3)->store;
3085 C4::Circulation::LostItem( $item->itemnumber, 1 );
3087 my $lost_fee_lines = Koha::Account::Lines->search(
3089 borrowernumber => $patron->id,
3090 itemnumber => $item->itemnumber,
3091 debit_type_code => 'LOST'
3094 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3095 my $lost_fee_line = $lost_fee_lines->next;
3096 is( $lost_fee_line->amount + 0,
3097 $replacement_amount, 'The right LOST amount is generated' );
3098 is( $lost_fee_line->amountoutstanding + 0,
3099 $replacement_amount,
3100 'The right LOST amountoutstanding is generated' );
3101 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3103 # Return the lost item
3104 my ( undef, $message ) =
3105 AddReturn( $item->barcode, $branchcode_refund, undef, $five_days_ago );
3107 $overdue_fee->discard_changes;
3108 is( $overdue_fee->amount + 0,
3109 10, 'The OVERDUE amount is left intact' );
3110 is( $overdue_fee->amountoutstanding + 0,
3112 'The OVERDUE amountoutstanding is left intact' );
3114 $lost_fee_line->discard_changes;
3115 is( $lost_fee_line->amount + 0,
3116 $replacement_amount, 'The LOST amount is left intact' );
3117 is( $lost_fee_line->amountoutstanding + 0,
3119 'The LOST amountoutstanding is refunded' );
3120 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3123 subtest 'lostreturn | restore' => sub {
3126 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_restore });
3128 my $item = $builder->build_sample_item(
3130 replacementprice => $replacement_amount
3135 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode , $ten_days_ago);
3137 # Fake fines cronjob on this checkout
3139 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3140 $ten_days_ago, $now );
3143 issue_id => $issue->issue_id,
3144 itemnumber => $item->itemnumber,
3145 borrowernumber => $patron->borrowernumber,
3147 due => output_pref($ten_days_ago)
3150 my $overdue_fees = Koha::Account::Lines->search(
3152 borrowernumber => $patron->id,
3153 itemnumber => $item->itemnumber,
3154 debit_type_code => 'OVERDUE'
3157 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3158 my $overdue_fee = $overdue_fees->next;
3159 is( $overdue_fee->amount + 0,
3160 10, 'The right OVERDUE amount is generated' );
3161 is( $overdue_fee->amountoutstanding + 0,
3163 'The right OVERDUE amountoutstanding is generated' );
3165 # Simulate item marked as lost
3166 $item->itemlost(3)->store;
3167 C4::Circulation::LostItem( $item->itemnumber, 1 );
3169 my $lost_fee_lines = Koha::Account::Lines->search(
3171 borrowernumber => $patron->id,
3172 itemnumber => $item->itemnumber,
3173 debit_type_code => 'LOST'
3176 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3177 my $lost_fee_line = $lost_fee_lines->next;
3178 is( $lost_fee_line->amount + 0,
3179 $replacement_amount, 'The right LOST amount is generated' );
3180 is( $lost_fee_line->amountoutstanding + 0,
3181 $replacement_amount,
3182 'The right LOST amountoutstanding is generated' );
3183 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3185 # Simulate refunding overdue fees upon marking item as lost
3186 my $overdue_forgive = $patron->account->add_credit(
3189 user_id => $manager->borrowernumber,
3190 library_id => $branchcode_restore,
3191 interface => 'test',
3193 item_id => $item->itemnumber
3196 $overdue_forgive->apply(
3197 { debits => [$overdue_fee], offset_type => 'Forgiven' } );
3198 $overdue_fee->discard_changes;
3199 is($overdue_fee->amountoutstanding + 0, 0, 'Overdue fee forgiven');
3202 my ( undef, $message ) =
3203 AddReturn( $item->barcode, $branchcode_restore, undef, $five_days_ago );
3205 $overdue_fee->discard_changes;
3206 is( $overdue_fee->amount + 0,
3207 10, 'The OVERDUE amount is left intact' );
3208 is( $overdue_fee->amountoutstanding + 0,
3210 'The OVERDUE amountoutstanding is restored' );
3212 $lost_fee_line->discard_changes;
3213 is( $lost_fee_line->amount + 0,
3214 $replacement_amount, 'The LOST amount is left intact' );
3215 is( $lost_fee_line->amountoutstanding + 0,
3217 'The LOST amountoutstanding is refunded' );
3218 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3221 subtest 'lostreturn | charge' => sub {
3224 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $branchcode_charge });
3226 my $item = $builder->build_sample_item(
3228 replacementprice => $replacement_amount
3233 my $issue = C4::Circulation::AddIssue( $patron->unblessed, $item->barcode, $ten_days_ago );
3235 # Fake fines cronjob on this checkout
3237 CalcFine( $item, $patron->categorycode, $library->{branchcode},
3238 $ten_days_ago, $now );
3241 issue_id => $issue->issue_id,
3242 itemnumber => $item->itemnumber,
3243 borrowernumber => $patron->borrowernumber,
3245 due => output_pref($ten_days_ago)
3248 my $overdue_fees = Koha::Account::Lines->search(
3250 borrowernumber => $patron->id,
3251 itemnumber => $item->itemnumber,
3252 debit_type_code => 'OVERDUE'
3255 is( $overdue_fees->count, 1, 'Overdue item fee produced' );
3256 my $overdue_fee = $overdue_fees->next;
3257 is( $overdue_fee->amount + 0,
3258 10, 'The right OVERDUE amount is generated' );
3259 is( $overdue_fee->amountoutstanding + 0,
3261 'The right OVERDUE amountoutstanding is generated' );
3263 # Simulate item marked as lost
3264 $item->itemlost(3)->store;
3265 C4::Circulation::LostItem( $item->itemnumber, 1 );
3267 my $lost_fee_lines = Koha::Account::Lines->search(
3269 borrowernumber => $patron->id,
3270 itemnumber => $item->itemnumber,
3271 debit_type_code => 'LOST'
3274 is( $lost_fee_lines->count, 1, 'Lost item fee produced' );
3275 my $lost_fee_line = $lost_fee_lines->next;
3276 is( $lost_fee_line->amount + 0,
3277 $replacement_amount, 'The right LOST amount is generated' );
3278 is( $lost_fee_line->amountoutstanding + 0,
3279 $replacement_amount,
3280 'The right LOST amountoutstanding is generated' );
3281 is( $lost_fee_line->status, undef, 'The LOST status was not set' );
3283 # Simulate refunding overdue fees upon marking item as lost
3284 my $overdue_forgive = $patron->account->add_credit(
3287 user_id => $manager->borrowernumber,
3288 library_id => $branchcode_charge,
3289 interface => 'test',
3291 item_id => $item->itemnumber
3294 $overdue_forgive->apply(
3295 { debits => [$overdue_fee], offset_type => 'Forgiven' } );
3296 $overdue_fee->discard_changes;
3297 is($overdue_fee->amountoutstanding + 0, 0, 'Overdue fee forgiven');
3300 my ( undef, $message ) =
3301 AddReturn( $item->barcode, $branchcode_charge, undef, $five_days_ago );
3303 $lost_fee_line->discard_changes;
3304 is( $lost_fee_line->amount + 0,
3305 $replacement_amount, 'The LOST amount is left intact' );
3306 is( $lost_fee_line->amountoutstanding + 0,
3308 'The LOST amountoutstanding is refunded' );
3309 is( $lost_fee_line->status, 'FOUND', 'The LOST status was set to FOUND' );
3311 $overdue_fees = Koha::Account::Lines->search(
3313 borrowernumber => $patron->id,
3314 itemnumber => $item->itemnumber,
3315 debit_type_code => 'OVERDUE'
3318 order_by => { '-asc' => 'accountlines_id'}
3321 is( $overdue_fees->count, 2, 'A second OVERDUE fee has been added' );
3322 $overdue_fee = $overdue_fees->next;
3323 is( $overdue_fee->amount + 0,
3324 10, 'The original OVERDUE amount is left intact' );
3325 is( $overdue_fee->amountoutstanding + 0,
3327 'The original OVERDUE amountoutstanding is left as forgiven' );
3328 $overdue_fee = $overdue_fees->next;
3329 is( $overdue_fee->amount + 0,
3330 5, 'The new OVERDUE amount is correct for the backdated return' );
3331 is( $overdue_fee->amountoutstanding + 0,
3333 'The new OVERDUE amountoutstanding is correct for the backdated return' );
3338 subtest '_FixOverduesOnReturn' => sub {
3341 my $manager = $builder->build_object({ class => "Koha::Patrons" });
3342 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
3344 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
3346 my $branchcode = $library2->{branchcode};
3348 my $item = $builder->build_sample_item(
3350 biblionumber => $biblio->biblionumber,
3351 library => $branchcode,
3352 replacementprice => 99.00,
3357 my $patron = $builder->build( { source => 'Borrower' } );
3359 ## Start with basic call, should just close out the open fine
3360 my $accountline = Koha::Account::Line->new(
3362 borrowernumber => $patron->{borrowernumber},
3363 debit_type_code => 'OVERDUE',
3364 status => 'UNRETURNED',
3365 itemnumber => $item->itemnumber,
3367 amountoutstanding => 99.00,
3368 interface => 'test',
3372 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, undef, 'RETURNED' );
3374 $accountline->_result()->discard_changes();
3376 is( $accountline->amountoutstanding+0, 99, 'Fine has the same amount outstanding as previously' );
3377 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3378 is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
3380 ## Run again, with exemptfine enabled
3383 debit_type_code => 'OVERDUE',
3384 status => 'UNRETURNED',
3385 amountoutstanding => 99.00,
3389 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
3391 $accountline->_result()->discard_changes();
3392 my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next();
3394 is( $accountline->amountoutstanding + 0, 0, 'Fine amountoutstanding has been reduced to 0' );
3395 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3396 is( $accountline->status, 'RETURNED', 'Open fine ( account type OVERDUE ) has been set to returned ( status RETURNED )');
3397 is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" );
3398 is( $offset->amount + 0, -99, "Amount of offset is correct" );
3399 my $credit = $offset->credit;
3400 is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" );
3401 is( $credit->amount + 0, -99, "Credit amount is set correctly" );
3402 is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" );
3404 # Bug 25417 - Only forgive fines where there is an amount outstanding to forgive
3407 debit_type_code => 'OVERDUE',
3408 status => 'UNRETURNED',
3409 amountoutstanding => 0.00,
3414 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
3416 $accountline->_result()->discard_changes();
3417 $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next();
3418 is( $offset, undef, "No offset created when trying to forgive fine with no outstanding balance" );
3419 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
3420 is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
3423 subtest 'Set waiting flag' => sub {
3426 my $library_1 = $builder->build( { source => 'Branch' } );
3427 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
3428 my $library_2 = $builder->build( { source => 'Branch' } );
3429 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
3431 my $item = $builder->build_sample_item(
3433 library => $library_1->{branchcode},
3437 set_userenv( $library_2 );
3438 my $reserve_id = AddReserve(
3440 branchcode => $library_2->{branchcode},
3441 borrowernumber => $patron_2->{borrowernumber},
3442 biblionumber => $item->biblionumber,
3444 itemnumber => $item->itemnumber,
3448 set_userenv( $library_1 );
3449 my $do_transfer = 1;
3450 my ( $res, $rr ) = AddReturn( $item->barcode, $library_1->{branchcode} );
3451 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
3452 my $hold = Koha::Holds->find( $reserve_id );
3453 is( $hold->found, 'T', 'Hold is in transit' );
3455 my ( $status ) = CheckReserves($item->itemnumber);
3456 is( $status, 'Transferred', 'Hold is not waiting yet');
3458 set_userenv( $library_2 );
3460 AddReturn( $item->barcode, $library_2->{branchcode} );
3461 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
3462 $hold = Koha::Holds->find( $reserve_id );
3463 is( $hold->found, 'W', 'Hold is waiting' );
3464 ( $status ) = CheckReserves($item->itemnumber);
3465 is( $status, 'Waiting', 'Now the hold is waiting');
3467 #Bug 21944 - Waiting transfer checked in at branch other than pickup location
3468 set_userenv( $library_1 );
3469 (undef, my $messages, undef, undef ) = AddReturn ( $item->barcode, $library_1->{branchcode} );
3470 $hold = Koha::Holds->find( $reserve_id );
3471 is( $hold->found, undef, 'Hold is no longer marked waiting' );
3472 is( $hold->priority, 1, "Hold is now priority one again");
3473 is( $hold->waitingdate, undef, "Hold no longer has a waiting date");
3474 is( $hold->itemnumber, $item->itemnumber, "Hold has retained its' itemnumber");
3475 is( $messages->{ResFound}->{ResFound}, "Reserved", "Hold is still returned");
3476 is( $messages->{ResFound}->{found}, undef, "Hold is no longer marked found in return message");
3477 is( $messages->{ResFound}->{priority}, 1, "Hold is priority 1 in return message");
3480 subtest 'Cancel transfers on lost items' => sub {
3483 my $library_to = $builder->build_object( { class => 'Koha::Libraries' } );
3484 my $item = $builder->build_sample_item();
3485 my $holdingbranch = $item->holdingbranch;
3486 # Historic transfer (datearrived is defined)
3487 my $old_transfer = $builder->build_object(
3489 class => 'Koha::Item::Transfers',
3491 itemnumber => $item->itemnumber,
3492 frombranch => $holdingbranch,
3493 tobranch => $library_to->branchcode,
3495 datesent => \'NOW()',
3496 datearrived => \'NOW()',
3497 datecancelled => undef,
3498 daterequested => \'NOW()'
3502 # Queued transfer (datesent is undefined)
3503 my $transfer_1 = $builder->build_object(
3505 class => 'Koha::Item::Transfers',
3507 itemnumber => $item->itemnumber,
3508 frombranch => $holdingbranch,
3509 tobranch => $library_to->branchcode,
3512 datearrived => undef,
3513 datecancelled => undef,
3514 daterequested => \'NOW()'
3518 # In transit transfer (datesent is defined, datearrived and datecancelled are both undefined)
3519 my $transfer_2 = $builder->build_object(
3521 class => 'Koha::Item::Transfers',
3523 itemnumber => $item->itemnumber,
3524 frombranch => $holdingbranch,
3525 tobranch => $library_to->branchcode,
3527 datesent => \'NOW()',
3528 datearrived => undef,
3529 datecancelled => undef,
3530 daterequested => \'NOW()'
3535 # Simulate item being marked as lost
3536 $item->itemlost(1)->store;
3537 LostItem( $item->itemnumber, 'test', 1 );
3539 $transfer_1->discard_changes;
3540 isnt($transfer_1->datecancelled, undef, "Queud transfer was cancelled upon item lost");
3541 is($transfer_1->cancellation_reason, 'ItemLost', "Cancellation reason was set to 'ItemLost'");
3542 $transfer_2->discard_changes;
3543 isnt($transfer_2->datecancelled, undef, "Active transfer was cancelled upon item lost");
3544 is($transfer_2->cancellation_reason, 'ItemLost', "Cancellation reason was set to 'ItemLost'");
3545 $old_transfer->discard_changes;
3546 is($old_transfer->datecancelled, undef, "Old transfers are unaffected");
3547 $item->discard_changes;
3548 is($item->holdingbranch, $holdingbranch, "Items holding branch remains unchanged");
3551 subtest 'CanBookBeIssued | is_overdue' => sub {
3554 # Set a simple circ policy
3555 Koha::CirculationRules->set_rules(
3557 categorycode => undef,
3558 branchcode => undef,
3562 reservesallowed => 25,
3564 lengthunit => 'days',
3565 renewalsallowed => 1,
3567 norenewalbefore => undef,
3575 my $now = dt_from_string;
3576 my $five_days_go = output_pref({ dt => $now->clone->add( days => 5 ), dateonly => 1});
3577 my $ten_days_go = output_pref({ dt => $now->clone->add( days => 10), dateonly => 1 });
3578 my $library = $builder->build( { source => 'Branch' } );
3579 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
3581 my $item = $builder->build_sample_item(
3583 library => $library->{branchcode},
3587 my $issue = AddIssue( $patron->unblessed, $item->barcode, $five_days_go ); # date due was 10d ago
3588 my $actualissue = Koha::Checkouts->find( { itemnumber => $item->itemnumber } );
3589 is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
3590 my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->barcode,$ten_days_go, undef, undef, undef);
3591 is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
3592 is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
3595 subtest 'ItemsDeniedRenewal preference' => sub {
3598 C4::Context->set_preference('ItemsDeniedRenewal','');
3600 my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
3601 Koha::CirculationRules->set_rules(
3603 categorycode => '*',
3605 branchcode => $idr_lib->branchcode,
3607 reservesallowed => 25,
3609 lengthunit => 'days',
3610 renewalsallowed => 10,
3612 norenewalbefore => undef,
3620 my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
3621 homebranch => $idr_lib->branchcode,
3625 itemcallnumber => undef,
3629 my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
3630 homebranch => $idr_lib->branchcode,
3633 location => 'NOPROC'
3637 my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
3638 branchcode => $idr_lib->branchcode,
3641 my $future = dt_from_string->add( days => 1 );
3642 my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3643 returndate => undef,
3646 borrowernumber => $idr_borrower->borrowernumber,
3647 itemnumber => $deny_book->itemnumber,
3648 onsite_checkout => 0,
3649 date_due => $future,
3652 my $allow_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3653 returndate => undef,
3656 borrowernumber => $idr_borrower->borrowernumber,
3657 itemnumber => $allow_book->itemnumber,
3658 onsite_checkout => 0,
3659 date_due => $future,
3665 my ( $idr_mayrenew, $idr_error ) =
3666 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3667 is( $idr_mayrenew, 1, 'Renewal allowed when no rules' );
3668 is( $idr_error, undef, 'Renewal allowed when no rules' );
3670 $idr_rules="withdrawn: [1]";
3672 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3673 ( $idr_mayrenew, $idr_error ) =
3674 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3675 is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
3676 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
3677 ( $idr_mayrenew, $idr_error ) =
3678 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3679 is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3680 is( $idr_error, undef, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3682 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
3684 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3685 ( $idr_mayrenew, $idr_error ) =
3686 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3687 is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
3688 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
3689 ( $idr_mayrenew, $idr_error ) =
3690 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3691 is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3692 is( $idr_error, undef, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3694 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
3696 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3697 ( $idr_mayrenew, $idr_error ) =
3698 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3699 is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
3700 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
3701 ( $idr_mayrenew, $idr_error ) =
3702 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3703 is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3704 is( $idr_error, undef, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3706 $idr_rules="itemcallnumber: [NULL]";
3707 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3708 ( $idr_mayrenew, $idr_error ) =
3709 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3710 is( $idr_mayrenew, 0, 'Renewal blocked for undef when NULL in pref' );
3711 $idr_rules="itemcallnumber: ['']";
3712 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3713 ( $idr_mayrenew, $idr_error ) =
3714 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3715 is( $idr_mayrenew, 1, 'Renewal not blocked for undef when "" in pref' );
3717 $idr_rules="itemnotes: [NULL]";
3718 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3719 ( $idr_mayrenew, $idr_error ) =
3720 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3721 is( $idr_mayrenew, 1, 'Renewal not blocked for "" when NULL in pref' );
3722 $idr_rules="itemnotes: ['']";
3723 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3724 ( $idr_mayrenew, $idr_error ) =
3725 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3726 is( $idr_mayrenew, 0, 'Renewal blocked for empty string when "" in pref' );
3729 subtest 'CanBookBeIssued | item-level_itypes=biblio' => sub {
3732 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3733 my $library = $builder->build( { source => 'Branch' } );
3734 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3736 my $item = $builder->build_sample_item(
3738 library => $library->{branchcode},
3742 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3743 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3744 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3747 subtest 'CanBookBeIssued | notforloan' => sub {
3750 t::lib::Mocks::mock_preference('AllowNotForLoanOverride', 0);
3752 my $library = $builder->build( { source => 'Branch' } );
3753 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3755 my $itemtype = $builder->build(
3757 source => 'Itemtype',
3758 value => { notforloan => undef, }
3761 my $item = $builder->build_sample_item(
3763 library => $library->{branchcode},
3764 itype => $itemtype->{itemtype},
3767 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3769 my ( $issuingimpossible, $needsconfirmation );
3772 subtest 'item-level_itypes = 1' => sub {
3775 t::lib::Mocks::mock_preference('item-level_itypes', 1); # item
3776 # Is for loan at item type and item level
3777 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3778 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3779 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3781 # not for loan at item type level
3782 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3783 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3784 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3787 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3788 'Item can not be issued, not for loan at item type level'
3791 # not for loan at item level
3792 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3793 $item->notforloan( 1 )->store;
3794 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3795 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3798 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3799 'Item can not be issued, not for loan at item type level'
3803 subtest 'item-level_itypes = 0' => sub {
3806 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3808 # We set another itemtype for biblioitem
3809 my $itemtype = $builder->build(
3811 source => 'Itemtype',
3812 value => { notforloan => undef, }
3816 # for loan at item type and item level
3817 $item->notforloan(0)->store;
3818 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3819 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3820 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3821 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3823 # not for loan at item type level
3824 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3825 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3826 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3829 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3830 'Item can not be issued, not for loan at item type level'
3833 # not for loan at item level
3834 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3835 $item->notforloan( 1 )->store;
3836 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3837 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3840 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3841 'Item can not be issued, not for loan at item type level'
3845 # TODO test with AllowNotForLoanOverride = 1
3848 subtest 'AddReturn should clear items.onloan for unissued items' => sub {
3851 t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' );
3852 my $item = $builder->build_sample_item(
3854 onloan => '2018-01-01',
3858 AddReturn( $item->barcode, $item->homebranch );
3859 $item->discard_changes; # refresh
3860 is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
3864 subtest 'AddRenewal and AddIssuingCharge tests' => sub {
3869 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3871 my $issuing_charges = 15;
3872 my $title = 'A title';
3873 my $author = 'Author, An';
3874 my $barcode = 'WHATARETHEODDS';
3876 my $circ = Test::MockModule->new('C4::Circulation');
3878 'GetIssuingCharges',
3880 return $issuing_charges;
3884 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3885 my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes', value => { rentalcharge_daily => 0.00 }});
3886 my $patron = $builder->build_object({
3887 class => 'Koha::Patrons',
3888 value => { branchcode => $library->id }
3891 my $biblio = $builder->build_sample_biblio({ title=> $title, author => $author });
3892 my $item_id = Koha::Item->new(
3894 biblionumber => $biblio->biblionumber,
3895 homebranch => $library->id,
3896 holdingbranch => $library->id,
3897 barcode => $barcode,
3898 replacementprice => 23.00,
3899 itype => $itemtype->id
3901 )->store->itemnumber;
3902 my $item = Koha::Items->find( $item_id );
3904 my $context = Test::MockModule->new('C4::Context');
3905 $context->mock( userenv => { branch => $library->id } );
3907 # Check the item out
3908 AddIssue( $patron->unblessed, $item->barcode );
3911 AddRenewal( $patron->borrowernumber, $item->itemnumber, $library->id, undef, {break=>"the_renewal"} );
3912 } 'Koha::Exceptions::Checkout::FailedRenewal', 'Exception is thrown when renewal update to issues fails';
3914 t::lib::Mocks::mock_preference( 'RenewalLog', 0 );
3915 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
3916 my %params_renewal = (
3917 timestamp => { -like => $date . "%" },
3918 module => "CIRCULATION",
3919 action => "RENEWAL",
3921 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );;
3922 AddRenewal( $patron->id, $item->id, $library->id );
3923 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3924 is( $new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog' );
3926 my $checkouts = $patron->checkouts;
3927 # The following will fail if run on 00:00:00
3928 unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part');
3930 my $lines = Koha::Account::Lines->search({
3931 borrowernumber => $patron->id,
3932 itemnumber => $item->id
3935 is( $lines->count, 2 );
3937 my $line = $lines->next;
3938 is( $line->debit_type_code, 'RENT', 'The issue of item with issuing charge generates an accountline of the correct type' );
3939 is( $line->branchcode, $library->id, 'AddIssuingCharge correctly sets branchcode' );
3940 is( $line->description, '', 'AddIssue does not set a hardcoded description for the accountline' );
3942 $line = $lines->next;
3943 is( $line->debit_type_code, 'RENT_RENEW', 'The renewal of item with issuing charge generates an accountline of the correct type' );
3944 is( $line->branchcode, $library->id, 'AddRenewal correctly sets branchcode' );
3945 is( $line->description, '', 'AddRenewal does not set a hardcoded description for the accountline' );
3947 t::lib::Mocks::mock_preference( 'RenewalLog', 1 );
3949 $context = Test::MockModule->new('C4::Context');
3950 $context->mock( userenv => { branch => undef, interface => 'CRON'} ); #Test statistical logging of renewal via cron (atuo_renew)
3952 my $now = dt_from_string;
3953 $date = output_pref( { dt => $now, dateonly => 1, dateformat => 'iso' } );
3954 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
3955 my $sth = $dbh->prepare("SELECT COUNT(*) FROM statistics WHERE itemnumber = ? AND branch = ?");
3956 $sth->execute($item->id, $library->id);
3957 my ($old_stats_size) = $sth->fetchrow_array;
3958 AddRenewal( $patron->id, $item->id, $library->id );
3959 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3960 $sth->execute($item->id, $library->id);
3961 my ($new_stats_size) = $sth->fetchrow_array;
3962 is( $new_log_size, $old_log_size + 1, 'renew log successfully added' );
3963 is( $new_stats_size, $old_stats_size + 1, 'renew statistic successfully added with passed branch' );
3965 AddReturn( $item->id, $library->id, undef, $date );
3966 AddIssue( $patron->unblessed, $item->barcode, $now );
3967 AddRenewal( $patron->id, $item->id, $library->id, undef, undef, 1 );
3968 my $lines_skipped = Koha::Account::Lines->search({
3969 borrowernumber => $patron->id,
3970 itemnumber => $item->id
3972 is( $lines_skipped->count, 5, 'Passing skipfinecalc causes fine calculation on renewal to be skipped' );
3976 subtest 'ProcessOfflinePayment() tests' => sub {
3983 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
3984 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3985 my $result = C4::Circulation::ProcessOfflinePayment({ cardnumber => $patron->cardnumber, amount => $amount, branchcode => $library->id });
3987 is( $result, 'Success.', 'The right string is returned' );
3989 my $lines = $patron->account->lines;
3990 is( $lines->count, 1, 'line created correctly');
3992 my $line = $lines->next;
3993 is( $line->amount+0, $amount * -1, 'amount picked from params' );
3994 is( $line->branchcode, $library->id, 'branchcode set correctly' );
3998 subtest 'Incremented fee tests' => sub {
4001 my $dt = dt_from_string();
4002 Time::Fake->offset( $dt->epoch );
4004 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
4007 $builder->build_object( { class => 'Koha::Libraries' } )->store;
4009 $module->mock( 'userenv', sub { { branch => $library->id } } );
4011 my $patron = $builder->build_object(
4013 class => 'Koha::Patrons',
4014 value => { categorycode => $patron_category->{categorycode} }
4018 my $itemtype = $builder->build_object(
4020 class => 'Koha::ItemTypes',
4022 notforloan => undef,
4024 rentalcharge_daily => 1,
4025 rentalcharge_daily_calendar => 0
4030 my $item = $builder->build_sample_item(
4032 library => $library->{branchcode},
4033 itype => $itemtype->id,
4037 is( $itemtype->rentalcharge_daily+0,
4038 1, 'Daily rental charge stored and retreived correctly' );
4039 is( $item->effective_itemtype, $itemtype->id,
4040 "Itemtype set correctly for item" );
4042 my $now = dt_from_string;
4043 my $dt_from = $now->clone;
4044 my $dt_to = $now->clone->add( days => 7 );
4045 my $dt_to_renew = $now->clone->add( days => 13 );
4049 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4050 my $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4051 is( $accountline->amount+0, 7,
4052 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0"
4054 $accountline->delete();
4055 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4056 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4057 is( $accountline->amount+0, 6,
4058 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0, for renewal"
4060 $accountline->delete();
4063 t::lib::Mocks::mock_preference( 'finesCalendar', 'noFinesWhenClosed' );
4064 $itemtype->rentalcharge_daily_calendar(1)->store();
4066 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4067 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4068 is( $accountline->amount+0, 7,
4069 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1"
4071 $accountline->delete();
4072 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4073 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4074 is( $accountline->amount+0, 6,
4075 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1, for renewal"
4077 $accountline->delete();
4080 my $calendar = C4::Calendar->new( branchcode => $library->id );
4081 # DateTime 1..7 (Mon..Sun), C4::Calender 0..6 (Sun..Sat)
4083 ( $dt_from->day_of_week == 6 ) ? 0
4084 : ( $dt_from->day_of_week == 7 ) ? 1
4085 : $dt_from->day_of_week + 1;
4086 my $closed_day_name = $dt_from->clone->add(days => 1)->day_name;
4087 $calendar->insert_week_day_holiday(
4088 weekday => $closed_day,
4089 title => 'Test holiday',
4090 description => 'Test holiday'
4093 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4094 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4095 is( $accountline->amount+0, 6,
4096 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name"
4098 $accountline->delete();
4099 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4100 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4101 is( $accountline->amount+0, 5,
4102 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name, for renewal"
4104 $accountline->delete();
4107 $itemtype->rentalcharge(2)->store;
4108 is( $itemtype->rentalcharge+0, 2,
4109 'Rental charge updated and retreived correctly' );
4111 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4113 Koha::Account::Lines->search( { itemnumber => $item->id } );
4114 is( $accountlines->count, '2',
4115 "Fixed charge and accrued charge recorded distinctly" );
4116 $accountlines->delete();
4117 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4118 $accountlines = Koha::Account::Lines->search( { itemnumber => $item->id } );
4119 is( $accountlines->count, '2',
4120 "Fixed charge and accrued charge recorded distinctly, for renewal" );
4121 $accountlines->delete();
4123 $itemtype->rentalcharge(0)->store;
4124 is( $itemtype->rentalcharge+0, 0,
4125 'Rental charge reset and retreived correctly' );
4128 Koha::CirculationRules->set_rule(
4130 categorycode => $patron->categorycode,
4131 itemtype => $itemtype->id,
4132 branchcode => $library->id,
4133 rule_name => 'lengthunit',
4134 rule_value => 'hours',
4138 $itemtype->rentalcharge_hourly('0.25')->store();
4139 is( $itemtype->rentalcharge_hourly,
4140 '0.25', 'Hourly rental charge stored and retreived correctly' );
4142 $dt_to = $now->clone->add( hours => 168 );
4143 $dt_to_renew = $now->clone->add( hours => 312 );
4145 $itemtype->rentalcharge_hourly_calendar(0)->store();
4147 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4148 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4149 is( $accountline->amount + 0, 42,
4150 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0 (168h * 0.25u)" );
4151 $accountline->delete();
4152 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4153 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4154 is( $accountline->amount + 0, 36,
4155 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0, for renewal (312h - 168h * 0.25u)" );
4156 $accountline->delete();
4159 $itemtype->rentalcharge_hourly_calendar(1)->store();
4161 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4162 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4163 is( $accountline->amount + 0, 36,
4164 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name (168h - 24h * 0.25u)" );
4165 $accountline->delete();
4166 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4167 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4168 is( $accountline->amount + 0, 30,
4169 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name, for renewal (312h - 168h - 24h * 0.25u" );
4170 $accountline->delete();
4173 $calendar->delete_holiday( weekday => $closed_day );
4175 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4176 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4177 is( $accountline->amount + 0, 42,
4178 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u" );
4179 $accountline->delete();
4180 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
4181 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
4182 is( $accountline->amount + 0, 36,
4183 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1, for renewal (312h - 168h - 0h * 0.25u)" );
4184 $accountline->delete();
4189 subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
4192 t::lib::Mocks::mock_preference('RentalFeesCheckoutConfirmation', 1);
4193 t::lib::Mocks::mock_preference('item-level_itypes', 1);
4196 $builder->build_object( { class => 'Koha::Libraries' } )->store;
4197 my $patron = $builder->build_object(
4199 class => 'Koha::Patrons',
4200 value => { categorycode => $patron_category->{categorycode} }
4204 my $itemtype = $builder->build_object(
4206 class => 'Koha::ItemTypes',
4210 rentalcharge_daily => 0
4215 my $item = $builder->build_sample_item(
4217 library => $library->id,
4221 itype => $itemtype->id,
4225 my ( $issuingimpossible, $needsconfirmation );
4226 my $dt_from = dt_from_string();
4227 my $dt_due = $dt_from->clone->add( days => 3 );
4229 $itemtype->rentalcharge(1)->store;
4230 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4231 is_deeply( $needsconfirmation, { RENTALCHARGE => '1.00' }, 'Item needs rentalcharge confirmation to be issued' );
4232 $itemtype->rentalcharge('0')->store;
4233 $itemtype->rentalcharge_daily(1)->store;
4234 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4235 is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
4236 $itemtype->rentalcharge_daily('0')->store;
4239 subtest 'CanBookBeIssued & CircConfirmItemParts' => sub {
4242 t::lib::Mocks::mock_preference('CircConfirmItemParts', 1);
4244 my $patron = $builder->build_object(
4246 class => 'Koha::Patrons',
4247 value => { categorycode => $patron_category->{categorycode} }
4251 my $item = $builder->build_sample_item(
4253 materials => 'includes DVD',
4257 my $dt_due = dt_from_string->add( days => 3 );
4259 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
4260 is_deeply( $needsconfirmation, { ADDITIONAL_MATERIALS => 'includes DVD' }, 'Item needs confirmation of additional parts' );
4263 subtest 'Do not return on renewal (LOST charge)' => sub {
4266 t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'onpayment');
4267 my $library = $builder->build_object( { class => "Koha::Libraries" } );
4268 my $manager = $builder->build_object( { class => "Koha::Patrons" } );
4269 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
4271 my $biblio = $builder->build_sample_biblio;
4273 my $item = $builder->build_sample_item(
4275 biblionumber => $biblio->biblionumber,
4276 library => $library->branchcode,
4277 replacementprice => 99.00,
4282 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
4283 AddIssue( $patron->unblessed, $item->barcode );
4285 my $accountline = Koha::Account::Line->new(
4287 borrowernumber => $patron->borrowernumber,
4288 debit_type_code => 'LOST',
4290 itemnumber => $item->itemnumber,
4292 amountoutstanding => 12,
4293 interface => 'something',
4297 # AddRenewal doesn't call _FixAccountForLostAndFound
4298 AddIssue( $patron->unblessed, $item->barcode );
4300 is( $patron->checkouts->count, 1,
4301 'Renewal should not return the item even if a LOST payment has been made earlier'
4305 subtest 'Filling a hold should cancel existing transfer' => sub {
4308 t::lib::Mocks::mock_preference('AutomaticItemReturn', 1);
4310 my $libraryA = $builder->build_object( { class => 'Koha::Libraries' } );
4311 my $libraryB = $builder->build_object( { class => 'Koha::Libraries' } );
4312 my $patron = $builder->build_object(
4314 class => 'Koha::Patrons',
4316 categorycode => $patron_category->{categorycode},
4317 branchcode => $libraryA->branchcode,
4322 my $item = $builder->build_sample_item({
4323 homebranch => $libraryB->branchcode,
4326 my ( undef, $message ) = AddReturn( $item->barcode, $libraryA->branchcode, undef, undef );
4327 is( Koha::Item::Transfers->search({ itemnumber => $item->itemnumber, datearrived => undef })->count, 1, "We generate a transfer on checkin");
4329 branchcode => $libraryA->branchcode,
4330 borrowernumber => $patron->borrowernumber,
4331 biblionumber => $item->biblionumber,
4332 itemnumber => $item->itemnumber
4334 my $reserves = Koha::Holds->search({ itemnumber => $item->itemnumber });
4335 is( $reserves->count, 1, "Reserve is placed");
4336 ( undef, $message ) = AddReturn( $item->barcode, $libraryA->branchcode, undef, undef );
4337 my $reserve = $reserves->next;
4338 ModReserveAffect( $item->itemnumber, $patron->borrowernumber, 0, $reserve->reserve_id );
4339 $reserve->discard_changes;
4340 ok( $reserve->found eq 'W', "Reserve is marked waiting" );
4341 is( Koha::Item::Transfers->search({ itemnumber => $item->itemnumber, datearrived => undef })->count, 0, "No outstanding transfers when hold is waiting");
4344 subtest 'Tests for NoRefundOnLostReturnedItemsAge with AddReturn' => sub {
4348 t::lib::Mocks::mock_preference('BlockReturnOfLostItems', 0);
4349 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4350 my $patron = $builder->build_object(
4352 class => 'Koha::Patrons',
4353 value => { categorycode => $patron_category->{categorycode} }
4357 my $biblionumber = $builder->build_sample_biblio(
4359 branchcode => $library->branchcode,
4363 # And the circulation rule
4364 Koha::CirculationRules->search->delete;
4365 Koha::CirculationRules->set_rules(
4367 categorycode => undef,
4369 branchcode => undef,
4372 lengthunit => 'days',
4378 source => 'CirculationRule',
4380 branchcode => undef,
4381 categorycode => undef,
4383 rule_name => 'lostreturn',
4384 rule_value => 'refund'
4389 subtest 'NoRefundOnLostReturnedItemsAge = undef' => sub {
4392 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4393 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', undef );
4395 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4397 my $item = $builder->build_sample_item(
4399 biblionumber => $biblionumber,
4400 library => $library->branchcode,
4401 replacementprice => '42',
4404 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4405 LostItem( $item->itemnumber, 'cli', 0 );
4406 $item->_result->itemlost(1);
4407 $item->_result->itemlost_on( $lost_on );
4408 $item->_result->update();
4410 my $a = Koha::Account::Lines->search(
4412 itemnumber => $item->id,
4413 borrowernumber => $patron->borrowernumber
4416 ok( $a, "Found accountline for lost fee" );
4417 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4418 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4419 $a = $a->get_from_storage;
4420 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4424 subtest 'NoRefundOnLostReturnedItemsAge > length of days item has been lost' => sub {
4427 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4428 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4430 my $lost_on = dt_from_string->subtract( days => 6 )->date;
4432 my $item = $builder->build_sample_item(
4434 biblionumber => $biblionumber,
4435 library => $library->branchcode,
4436 replacementprice => '42',
4439 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4440 LostItem( $item->itemnumber, 'cli', 0 );
4441 $item->_result->itemlost(1);
4442 $item->_result->itemlost_on( $lost_on );
4443 $item->_result->update();
4445 my $a = Koha::Account::Lines->search(
4447 itemnumber => $item->id,
4448 borrowernumber => $patron->borrowernumber
4451 ok( $a, "Found accountline for lost fee" );
4452 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4453 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4454 $a = $a->get_from_storage;
4455 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4459 subtest 'NoRefundOnLostReturnedItemsAge = length of days item has been lost' => sub {
4462 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4463 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4465 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4467 my $item = $builder->build_sample_item(
4469 biblionumber => $biblionumber,
4470 library => $library->branchcode,
4471 replacementprice => '42',
4474 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4475 LostItem( $item->itemnumber, 'cli', 0 );
4476 $item->_result->itemlost(1);
4477 $item->_result->itemlost_on( $lost_on );
4478 $item->_result->update();
4480 my $a = Koha::Account::Lines->search(
4482 itemnumber => $item->id,
4483 borrowernumber => $patron->borrowernumber
4486 ok( $a, "Found accountline for lost fee" );
4487 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4488 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4489 $a = $a->get_from_storage;
4490 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4494 subtest 'NoRefundOnLostReturnedItemsAge < length of days item has been lost' => sub {
4497 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4498 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4500 my $lost_on = dt_from_string->subtract( days => 8 )->date;
4502 my $item = $builder->build_sample_item(
4504 biblionumber => $biblionumber,
4505 library => $library->branchcode,
4506 replacementprice => '42',
4509 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4510 LostItem( $item->itemnumber, 'cli', 0 );
4511 $item->_result->itemlost(1);
4512 $item->_result->itemlost_on( $lost_on );
4513 $item->_result->update();
4515 my $a = Koha::Account::Lines->search(
4517 itemnumber => $item->id,
4518 borrowernumber => $patron->borrowernumber
4522 ok( $a, "Found accountline for lost fee" );
4523 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4524 my ( $doreturn, $messages ) = AddReturn( $item->barcode, $library->branchcode, undef, dt_from_string );
4525 $a = $a->get_from_storage;
4526 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4531 subtest 'Tests for NoRefundOnLostReturnedItemsAge with AddIssue' => sub {
4535 t::lib::Mocks::mock_preference('BlockReturnOfLostItems', 0);
4536 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4537 my $patron = $builder->build_object(
4539 class => 'Koha::Patrons',
4540 value => { categorycode => $patron_category->{categorycode} }
4543 my $patron2 = $builder->build_object(
4545 class => 'Koha::Patrons',
4546 value => { categorycode => $patron_category->{categorycode} }
4550 my $biblionumber = $builder->build_sample_biblio(
4552 branchcode => $library->branchcode,
4556 # And the circulation rule
4557 Koha::CirculationRules->search->delete;
4558 Koha::CirculationRules->set_rules(
4560 categorycode => undef,
4562 branchcode => undef,
4565 lengthunit => 'days',
4571 source => 'CirculationRule',
4573 branchcode => undef,
4574 categorycode => undef,
4576 rule_name => 'lostreturn',
4577 rule_value => 'refund'
4582 subtest 'NoRefundOnLostReturnedItemsAge = undef' => sub {
4585 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4586 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', undef );
4588 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4590 my $item = $builder->build_sample_item(
4592 biblionumber => $biblionumber,
4593 library => $library->branchcode,
4594 replacementprice => '42',
4597 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4598 LostItem( $item->itemnumber, 'cli', 0 );
4599 $item->_result->itemlost(1);
4600 $item->_result->itemlost_on( $lost_on );
4601 $item->_result->update();
4603 my $a = Koha::Account::Lines->search(
4605 itemnumber => $item->id,
4606 borrowernumber => $patron->borrowernumber
4609 ok( $a, "Found accountline for lost fee" );
4610 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4611 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4612 $a = $a->get_from_storage;
4613 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4618 subtest 'NoRefundOnLostReturnedItemsAge > length of days item has been lost' => sub {
4621 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4622 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4624 my $lost_on = dt_from_string->subtract( days => 6 )->date;
4626 my $item = $builder->build_sample_item(
4628 biblionumber => $biblionumber,
4629 library => $library->branchcode,
4630 replacementprice => '42',
4633 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4634 LostItem( $item->itemnumber, 'cli', 0 );
4635 $item->_result->itemlost(1);
4636 $item->_result->itemlost_on( $lost_on );
4637 $item->_result->update();
4639 my $a = Koha::Account::Lines->search(
4641 itemnumber => $item->id,
4642 borrowernumber => $patron->borrowernumber
4645 ok( $a, "Found accountline for lost fee" );
4646 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4647 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4648 $a = $a->get_from_storage;
4649 is( $a->amountoutstanding + 0, 0, "Lost fee was refunded" );
4653 subtest 'NoRefundOnLostReturnedItemsAge = length of days item has been lost' => sub {
4656 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4657 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4659 my $lost_on = dt_from_string->subtract( days => 7 )->date;
4661 my $item = $builder->build_sample_item(
4663 biblionumber => $biblionumber,
4664 library => $library->branchcode,
4665 replacementprice => '42',
4668 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4669 LostItem( $item->itemnumber, 'cli', 0 );
4670 $item->_result->itemlost(1);
4671 $item->_result->itemlost_on( $lost_on );
4672 $item->_result->update();
4674 my $a = Koha::Account::Lines->search(
4676 itemnumber => $item->id,
4677 borrowernumber => $patron->borrowernumber
4680 ok( $a, "Found accountline for lost fee" );
4681 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4682 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4683 $a = $a->get_from_storage;
4684 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4688 subtest 'NoRefundOnLostReturnedItemsAge < length of days item has been lost' => sub {
4691 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
4692 t::lib::Mocks::mock_preference( 'NoRefundOnLostReturnedItemsAge', 7 );
4694 my $lost_on = dt_from_string->subtract( days => 8 )->date;
4696 my $item = $builder->build_sample_item(
4698 biblionumber => $biblionumber,
4699 library => $library->branchcode,
4700 replacementprice => '42',
4703 my $issue = AddIssue( $patron->unblessed, $item->barcode );
4704 LostItem( $item->itemnumber, 'cli', 0 );
4705 $item->_result->itemlost(1);
4706 $item->_result->itemlost_on( $lost_on );
4707 $item->_result->update();
4709 my $a = Koha::Account::Lines->search(
4711 itemnumber => $item->id,
4712 borrowernumber => $patron->borrowernumber
4716 ok( $a, "Found accountline for lost fee" );
4717 is( $a->amountoutstanding + 0, 42, "Lost fee charged correctly" );
4718 $issue = AddIssue( $patron2->unblessed, $item->barcode );
4719 $a = $a->get_from_storage;
4720 is( $a->amountoutstanding + 0, 42, "Lost fee was not refunded" );
4725 subtest 'transferbook tests' => sub {
4729 { C4::Circulation::transferbook({}); }
4730 'Koha::Exceptions::MissingParameter',
4731 'Koha::Patron->store raises an exception on missing params';
4734 { C4::Circulation::transferbook({to_branch=>'anything'}); }
4735 'Koha::Exceptions::MissingParameter',
4736 'Koha::Patron->store raises an exception on missing params';
4739 { C4::Circulation::transferbook({from_branch=>'anything'}); }
4740 'Koha::Exceptions::MissingParameter',
4741 'Koha::Patron->store raises an exception on missing params';
4743 my ($doreturn,$messages) = C4::Circulation::transferbook({to_branch=>'there',from_branch=>'here'});
4744 is( $doreturn, 0, "No return without barcode");
4745 ok( exists $messages->{BadBarcode}, "We get a BadBarcode message if no barcode passed");
4746 is( $messages->{BadBarcode}, undef, "No barcode passed means undef BadBarcode" );
4748 ($doreturn,$messages) = C4::Circulation::transferbook({to_branch=>'there',from_branch=>'here',barcode=>'BadBarcode'});
4749 is( $doreturn, 0, "No return without barcode");
4750 ok( exists $messages->{BadBarcode}, "We get a BadBarcode message if no barcode passed");
4751 is( $messages->{BadBarcode}, 'BadBarcode', "No barcode passed means undef BadBarcode" );
4755 subtest 'Checkout should correctly terminate a transfer' => sub {
4758 my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } );
4759 my $patron_1 = $builder->build_object(
4761 class => 'Koha::Patrons',
4762 value => { branchcode => $library_1->branchcode }
4765 my $library_2 = $builder->build_object( { class => 'Koha::Libraries' } );
4766 my $patron_2 = $builder->build_object(
4768 class => 'Koha::Patrons',
4769 value => { branchcode => $library_2->branchcode }
4773 my $item = $builder->build_sample_item(
4775 library => $library_1->branchcode,
4779 t::lib::Mocks::mock_userenv( { branchcode => $library_1->branchcode } );
4780 my $reserve_id = AddReserve(
4782 branchcode => $library_2->branchcode,
4783 borrowernumber => $patron_2->borrowernumber,
4784 biblionumber => $item->biblionumber,
4785 itemnumber => $item->itemnumber,
4790 my $do_transfer = 1;
4791 ModItemTransfer( $item->itemnumber, $library_1->branchcode,
4792 $library_2->branchcode, 'Manual' );
4793 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
4794 GetOtherReserves( $item->itemnumber )
4795 ; # To put the Reason, it's what does returns.pl...
4796 my $hold = Koha::Holds->find($reserve_id);
4797 is( $hold->found, 'T', 'Hold is in transit' );
4798 my $transfer = $item->get_transfer;
4799 is( $transfer->frombranch, $library_1->branchcode );
4800 is( $transfer->tobranch, $library_2->branchcode );
4801 is( $transfer->reason, 'Reserve' );
4803 t::lib::Mocks::mock_userenv( { branchcode => $library_2->branchcode } );
4804 AddIssue( $patron_1->unblessed, $item->barcode );
4805 $transfer = $transfer->get_from_storage;
4806 isnt( $transfer->datearrived, undef );
4807 $hold = $hold->get_from_storage;
4808 is( $hold->found, undef, 'Hold is waiting' );
4809 is( $hold->priority, 1, );
4812 subtest 'AddIssue records staff who checked out item if appropriate' => sub {
4815 $module->mock( 'userenv', sub { { branch => $library->{id} } } );
4817 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
4818 my $patron = $builder->build_object(
4820 class => 'Koha::Patrons',
4821 value => { categorycode => $patron_category->{categorycode} }
4824 my $issuer = $builder->build_object(
4826 class => 'Koha::Patrons',
4827 value => { categorycode => $patron_category->{categorycode} }
4830 my $item = $builder->build_sample_item(
4832 library => $library->{branchcode}
4836 $module->mock( 'userenv', sub { { branch => $library->id, number => $issuer->{borrowernumber} } } );
4838 my $dt_from = dt_from_string();
4839 my $dt_to = dt_from_string()->add( days => 7 );
4841 my $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4843 is( $issue->issuer, undef, "Staff who checked out the item not recorded when RecordStaffUserOnCheckout turned off" );
4845 t::lib::Mocks::mock_preference('RecordStaffUserOnCheckout', 1);
4848 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
4850 is( $issue->issuer, $issuer->{borrowernumber}, "Staff who checked out the item recorded when RecordStaffUserOnCheckout turned on" );
4853 subtest "Item's onloan value should be set if checked out item is checked out to a different patron" => sub {
4856 my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } );
4857 my $patron_1 = $builder->build_object(
4859 class => 'Koha::Patrons',
4860 value => { branchcode => $library_1->branchcode }
4863 my $patron_2 = $builder->build_object(
4865 class => 'Koha::Patrons',
4866 value => { branchcode => $library_1->branchcode }
4870 my $item = $builder->build_sample_item(
4872 library => $library_1->branchcode,
4876 AddIssue( $patron_1->unblessed, $item->barcode );
4877 ok( $item->get_from_storage->onloan, "Item's onloan column is set after initial checkout" );
4878 AddIssue( $patron_2->unblessed, $item->barcode );
4879 ok( $item->get_from_storage->onloan, "Item's onloan column is set after second checkout" );
4882 subtest "updateWrongTransfer tests" => sub {
4885 my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
4886 my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
4887 my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
4888 my $item = $builder->build_sample_item(
4890 homebranch => $library1->branchcode,
4891 holdingbranch => $library2->branchcode,
4892 datelastseen => undef
4896 my $transfer = $builder->build_object(
4898 class => 'Koha::Item::Transfers',
4900 itemnumber => $item->itemnumber,
4901 frombranch => $library2->branchcode,
4902 tobranch => $library1->branchcode,
4903 daterequested => dt_from_string,
4904 datesent => dt_from_string,
4905 datecancelled => undef,
4906 datearrived => undef,
4911 is( ref($transfer), 'Koha::Item::Transfer', 'Mock transfer added' );
4913 my $new_transfer = C4::Circulation::updateWrongTransfer($item->itemnumber, $library1->branchcode);
4914 is(ref($new_transfer), 'Koha::Item::Transfer', "updateWrongTransfer returns a 'Koha::Item::Transfer' object");
4915 ok( !$new_transfer->in_transit, "New transfer is NOT created as in transit (or cancelled)");
4917 my $original_transfer = $transfer->get_from_storage;
4918 ok( defined($original_transfer->datecancelled), "Original transfer was cancelled");
4919 is( $original_transfer->cancellation_reason, 'WrongTransfer', "Original transfer cancellation reason is 'WrongTransfer'");
4922 $schema->storage->txn_rollback;
4923 C4::Context->clear_syspref_cache();
4924 $branches = Koha::Libraries->search();
4925 for my $branch ( $branches->next ) {
4926 my $key = $branch->branchcode . "_holidays";
4927 $cache->clear_from_cache($key);