3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 4;
27 use_ok('C4::Heading', qw( field valid_heading_subfield ));
30 subtest "MARC21 tests" => sub {
33 t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
35 ok(C4::Heading::valid_heading_subfield('100', 'a'), '100a valid for bib');
36 ok(!C4::Heading::valid_heading_subfield('100', 'e'), '100e not valid for bib');
38 ok(C4::Heading::valid_heading_subfield('100', 'a', 1), '100a valid for authority');
40 ok(C4::Heading::valid_heading_subfield('110', 'a'), '110a valid for bib');
41 ok(!C4::Heading::valid_heading_subfield('110', 'e'), '110e not valid for bib');
43 ok(C4::Heading::valid_heading_subfield('600', 'a'), '600a valid for bib');
44 ok(!C4::Heading::valid_heading_subfield('600', 'e'), '600e not valid for bib');
46 ok(!C4::Heading::valid_heading_subfield('012', 'a'), '012a invalid field for bib');
49 subtest "UNIMARC tests" => sub {
52 t::lib::Mocks::mock_preference('marcflavour', 'UNIMARC');
54 ok(C4::Heading::valid_heading_subfield('100', 'a'), '100a valid for bib');
55 ok(!C4::Heading::valid_heading_subfield('100', 'i'), '100i not valid fir bib');
57 ok(C4::Heading::valid_heading_subfield('110', 'a'), '110a valid for bib');
58 ok(!C4::Heading::valid_heading_subfield('110', 'i'), '110i not valid for bib');
60 ok(C4::Heading::valid_heading_subfield('600', 'a'), '600a valid for bib');
61 ok(!C4::Heading::valid_heading_subfield('600', 'i'), '600i not valid for bib');
63 ok(!C4::Heading::valid_heading_subfield('012', 'a'), '012a invalid field for bib');
66 subtest "_search tests" => sub {
70 t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
71 t::lib::Mocks::mock_preference('SearchEngine', 'Elasticsearch');
72 # NOTE: We are testing solely against ES here to make the assumptions simpler while testing
73 # C4/Headings code specifically. The actual query building and searching code should
74 # be covered in other test files
75 my $search = Test::MockModule->new('Koha::SearchEngine::Elasticsearch::Search');
77 $search->mock('search_auth_compat', sub {
79 my $search_query = shift;
80 return ($search_query, 1 );
83 t::lib::Mocks::mock_preference('LinkerConsiderThesaurus', '0');
85 my $field = MARC::Field->new( '650', ' ', '0', a => 'Uncles', x => 'Fiction' );
86 my $heading = C4::Heading->new_from_field($field);
87 my ($search_query) = $heading->_search( 'match-heading' );
88 my $terms = $search_query->{query}->{bool}->{must};
89 my $expected_terms = [
90 { term => { 'match-heading.ci_raw' => 'Uncles generalsubdiv Fiction' } },
92 is_deeply( $terms, $expected_terms, "Search formed only using heading content, not thesaurus, when LinkerConsiderThesaurus disabled");
95 t::lib::Mocks::mock_preference('LinkerConsiderThesaurus', '1');
97 $field = MARC::Field->new( '650', ' ', '0', a => 'Uncles', x => 'Fiction' );
98 $heading = C4::Heading->new_from_field($field);
99 ($search_query) = $heading->_search( 'match-heading' );
100 $terms = $search_query->{query}->{bool}->{must};
102 { term => { 'match-heading.ci_raw' => 'Uncles generalsubdiv Fiction' } },
103 { term => { 'subject-heading-thesaurus.ci_raw' => 'a' } },
105 is_deeply( $terms, $expected_terms, "Search formed as expected for a subject with second indicator 0");
107 $field = MARC::Field->new( '650', ' ', '3', a => 'Uncles', x => 'Fiction' );
108 $heading = C4::Heading->new_from_field($field);
109 ($search_query) = $heading->_search( 'match-heading' );
110 $terms = $search_query->{query}->{bool}->{must};
112 { term => { 'match-heading.ci_raw' => 'Uncles generalsubdiv Fiction' } },
113 { term => { 'subject-heading-thesaurus.ci_raw' => 'd' } },
115 is_deeply( $terms, $expected_terms, "Search formed as expected with second indicator 3");
117 $field = MARC::Field->new( '650', ' ', '7', a => 'Uncles', x => 'Fiction', 2 => 'special_sauce' );
118 $heading = C4::Heading->new_from_field($field);
119 ($search_query) = $heading->_search( 'match-heading' );
120 $terms = $search_query->{query}->{bool}->{must};
122 { term => { 'match-heading.ci_raw' => 'Uncles generalsubdiv Fiction' } },
123 { term => { 'subject-heading-thesaurus.ci_raw' => 'special_sauce' } },
125 is_deeply( $terms, $expected_terms, "Search formed as expected with second indicator 7 and subfield 2");
127 $field = MARC::Field->new( '650', ' ', '4', a => 'Uncles', x => 'Fiction' );
128 $heading = C4::Heading->new_from_field($field);
129 ($search_query) = $heading->_search( 'match-heading' );
130 $terms = $search_query->{query}->{bool}->{must};
132 { term => { 'match-heading.ci_raw' => 'Uncles generalsubdiv Fiction' } },
133 { term => { 'subject-heading-thesaurus.ci_raw' => '|' } },
135 is_deeply( $terms, $expected_terms, "Search looks for thesaurus '|' when second indicator 4");
137 $field = MARC::Field->new( '100', ' ', '', a => 'Yankovic, Al', d => '1959-,' );
138 $heading = C4::Heading->new_from_field($field);
139 ($search_query) = $heading->_search( 'match-heading' );
140 $terms = $search_query->{query}->{bool}->{must};
142 { term => { 'match-heading.ci_raw' => 'Yankovic, Al 1959' } },
144 is_deeply( $terms, $expected_terms, "Search formed as expected for a non-subject field with single punctuation mark");
146 $field = MARC::Field->new( '100', ' ', '', a => 'Yankovic, Al', d => '1959-,', e => '[author]' );
147 $heading = C4::Heading->new_from_field($field);
148 ($search_query) = $heading->_search( 'match-heading' );
149 $terms = $search_query->{query}->{bool}->{must};
151 { term => { 'match-heading.ci_raw' => 'Yankovic, Al 1959' } },
153 is_deeply( $terms, $expected_terms, "Search formed as expected for a non-subject field with double punctuation, hyphen+comma");
155 $field = MARC::Field->new( '100', ' ', '', a => 'Tolkien, J.R.R.,', e => '[author]' );
156 $heading = C4::Heading->new_from_field($field);
157 ($search_query) = $heading->_search( 'match-heading' );
158 $terms = $search_query->{query}->{bool}->{must};
160 { term => { 'match-heading.ci_raw' => 'Tolkien, J.R.R' } },
162 is_deeply( $terms, $expected_terms, "Search formed as expected for a non-subject field with double punctuation, period+comma ");
164 $search->mock('search_auth_compat', sub {
166 my $search_query = shift;
168 scalar @{$search_query->{query}->{bool}->{must}} == 2 &&
169 $search_query->{query}->{bool}->{must}[1]->{term}->{'subject-heading-thesaurus.ci_raw'} eq 'special_sauce'
173 return ($search_query, 1);
176 # Special case where thesaurus defined in subfield 2 should also match record with no thesaurus
177 $field = MARC::Field->new( '650', ' ', '7', a => 'Uncles', x => 'Fiction', 2 => 'special_sauce' );
178 $heading = C4::Heading->new_from_field($field);
179 ($search_query) = $heading->_search( 'match-heading' );
180 $terms = $search_query->{query}->{bool}->{must};
182 { term => { 'match-heading.ci_raw' => 'Uncles generalsubdiv Fiction' } },
183 { term => { 'subject-heading-thesaurus.ci_raw' => 'z' } },
185 is_deeply( $terms, $expected_terms, "When thesaurus in subfield 2, and nothing is found, we should search again for notdefined (008_11 = z) ");
187 t::lib::Mocks::mock_preference('LinkerConsiderThesaurus', '0');
189 $search_query = undef;
190 ($search_query) = $heading->_search( 'match-heading' );
191 $terms = $search_query->{query}->{bool}->{must};
193 { term => { 'match-heading.ci_raw' => 'Uncles generalsubdiv Fiction' } },
195 is_deeply( $terms, $expected_terms, "When thesaurus in subfield 2, and nothing is found, we don't search again if LinkerConsiderThesaurusDisabled");