9 use Test::More tests => 32;
17 use lib $FindBin::Bin;
18 use_ok('C4::Reserves');
21 my $dbh = C4::Context->dbh;
24 $dbh->{AutoCommit} = 0;
25 $dbh->{RaiseError} = 1;
27 my $borrowers_count = 5;
29 $dbh->do('DELETE FROM itemtypes');
30 my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)');
31 $insert_sth->execute('CAN');
32 $insert_sth->execute('CANNOT');
34 # Setup Test------------------------
36 diag("Creating biblio instance for testing.");
37 my ($bibnum, $title, $bibitemnum) = create_helper_biblio();
39 # Helper item for that biblio.
40 diag("Creating item instance for testing.");
41 my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
43 # Create some borrowers
45 foreach (1..$borrowers_count) {
46 my $borrowernumber = AddMember(
47 firstname => 'my firstname',
48 surname => 'my surname ' . $_,
52 push @borrowernumbers, $borrowernumber;
55 my $biblionumber = $bibnum;
57 my @branches = GetBranchesLoop();
58 my $branch = $branches[0][0]{value};
60 # Create five item level holds
61 foreach my $borrowernumber ( @borrowernumbers ) {
73 my $checkitem = $itemnumber,
79 my $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
80 is( scalar(@$reserves), $borrowers_count, "Test GetReserves()" );
83 my ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
84 ok($reserve_id, "Test GetReservesFromItemnumber()");
87 my ( $reserve ) = GetReservesFromBorrowernumber($borrowernumbers[0]);
88 ok( $reserve->{'borrowernumber'} eq $borrowernumbers[0], "Test GetReservesFromBorrowernumber()");
91 ok( GetReserveCount( $borrowernumbers[0] ), "Test GetReserveCount()" );
94 CancelReserve({ 'reserve_id' => $reserve_id });
95 $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
96 is( scalar(@$reserves), $borrowers_count - 1, "Test CancelReserve()" );
99 ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
101 reserve_id => $reserve_id,
103 branchcode => $branch,
104 itemnumber => $itemnumber,
105 suspend_until => C4::Dates->new("2013-01-01","iso")->output(),
107 $reserve = GetReserve( $reserve_id );
108 ok( $reserve->{'priority'} eq '4', "Test GetReserve(), priority changed correctly" );
109 ok( $reserve->{'suspend'}, "Test GetReserve(), suspend hold" );
110 ok( $reserve->{'suspend_until'} eq '2013-01-01 00:00:00', "Test GetReserve(), suspend until date" );
112 ToggleSuspend( $reserve_id );
113 $reserve = GetReserve( $reserve_id );
114 ok( !$reserve->{'suspend'}, "Test ToggleSuspend(), no date" );
116 ToggleSuspend( $reserve_id, '2012-01-01' );
117 $reserve = GetReserve( $reserve_id );
118 ok( $reserve->{'suspend_until'} eq '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
120 AutoUnsuspendReserves();
121 $reserve = GetReserve( $reserve_id );
122 ok( !$reserve->{'suspend'}, "Test AutoUnsuspendReserves()" );
124 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
129 my $constraint = 'a',
139 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
140 my $reserveid = C4::Reserves::GetReserveId(
142 biblionumber => $biblionumber,
143 borrowernumber => $borrowernumber
146 is( $reserveid, $reserve->{reserve_id}, "Test GetReserveId" );
147 ModReserveMinusPriority( $itemnumber, $reserve->{'reserve_id'} );
148 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
149 ok( $reserve->{'itemnumber'} eq $itemnumber, "Test ModReserveMinusPriority()" );
152 my $reserve2 = GetReserveInfo( $reserve->{'reserve_id'} );
153 ok( $reserve->{'reserve_id'} eq $reserve2->{'reserve_id'}, "Test GetReserveInfo()" );
156 $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber, all_dates => 1 });
157 $reserve = $reserves->[1];
158 AlterPriority( 'top', $reserve->{'reserve_id'} );
159 $reserve = GetReserve( $reserve->{'reserve_id'} );
160 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move to top" );
162 AlterPriority( 'down', $reserve->{'reserve_id'} );
163 $reserve = GetReserve( $reserve->{'reserve_id'} );
164 ok( $reserve->{'priority'} eq '2', "Test AlterPriority(), move down" );
166 AlterPriority( 'up', $reserve->{'reserve_id'} );
167 $reserve = GetReserve( $reserve->{'reserve_id'} );
168 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move up" );
170 AlterPriority( 'bottom', $reserve->{'reserve_id'} );
171 $reserve = GetReserve( $reserve->{'reserve_id'} );
172 ok( $reserve->{'priority'} eq '5', "Test AlterPriority(), move to bottom" );
174 # Regression test for bug 2394
176 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
177 # a patron is not permittedo to request an item whose homebranch (i.e.,
178 # owner of the item) is different from the patron's own library.
179 # However, if canreservefromotherbranches is turned ON, the patron can
180 # create such hold requests.
182 # Note that canreservefromotherbranches has no effect if
183 # IndependentBranches is OFF.
185 my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio();
186 my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
187 = AddItem({ homebranch => 'MPL', holdingbranch => 'MPL' } , $foreign_bibnum);
188 $dbh->do('DELETE FROM issuingrules');
190 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
191 VALUES (?, ?, ?, ?)},
196 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
197 VALUES (?, ?, ?, ?)},
199 '*', '*', 'CANNOT', 0
202 # make sure some basic sysprefs are set
203 t::lib::Mocks::mock_preference('ReservesControlBranch', 'homebranch');
204 t::lib::Mocks::mock_preference('item-level_itypes', 1);
206 # if IndependentBranches is OFF, a CPL patron can reserve an MPL item
207 t::lib::Mocks::mock_preference('IndependentBranches', 0);
209 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
210 'CPL patron allowed to reserve MPL item with IndependentBranches OFF (bug 2394)'
213 # if IndependentBranches is OFF, a CPL patron cannot reserve an MPL item
214 t::lib::Mocks::mock_preference('IndependentBranches', 1);
215 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
217 ! CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
218 'CPL patron NOT allowed to reserve MPL item with IndependentBranches ON ... (bug 2394)'
221 # ... unless canreservefromotherbranches is ON
222 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
224 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
225 '... unless canreservefromotherbranches is ON (bug 2394)'
228 # Regression test for bug 11336
229 ($bibnum, $title, $bibitemnum) = create_helper_biblio();
230 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
240 my $reserveid1 = C4::Reserves::GetReserveId(
242 biblionumber => $bibnum,
243 borrowernumber => $borrowernumbers[0]
247 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
256 my $reserveid2 = C4::Reserves::GetReserveId(
258 biblionumber => $bibnum,
259 borrowernumber => $borrowernumbers[1]
263 CancelReserve({ reserve_id => $reserveid1 });
265 $reserve2 = GetReserve( $reserveid2 );
266 is( $reserve2->{priority}, 1, "After cancelreserve, the 2nd reserve becomes the first on the waiting list" );
268 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
277 my $reserveid3 = C4::Reserves::GetReserveId(
279 biblionumber => $bibnum,
280 borrowernumber => $borrowernumbers[0]
284 my $reserve3 = GetReserve( $reserveid3 );
285 is( $reserve3->{priority}, 2, "New reserve for patron 0, the reserve has a priority = 2" );
287 ModReserve({ reserve_id => $reserveid2, rank => 'del' });
288 $reserve3 = GetReserve( $reserveid3 );
289 is( $reserve3->{priority}, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
291 ModItem({ damaged => 1 }, $item_bibnum, $itemnumber);
292 C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 1 );
293 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber), "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
294 ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
295 C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 0 );
296 ok( !CanItemBeReserved( $borrowernumbers[0], $itemnumber), "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
297 ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
299 # Regression test for bug 9532
300 ($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
301 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL', itype => 'CANNOT' } , $bibnum);
311 !CanItemBeReserved( $borrowernumbers[0], $itemnumber),
312 "cannot request item if policy that matches on item-level item type forbids it"
314 ModItem({ itype => 'CAN' }, $item_bibnum, $itemnumber);
316 CanItemBeReserved( $borrowernumbers[0], $itemnumber),
317 "can request item if policy that matches on item type allows it"
320 t::lib::Mocks::mock_preference('item-level_itypes', 0);
321 ModItem({ itype => undef }, $item_bibnum, $itemnumber);
323 !CanItemBeReserved( $borrowernumbers[0], $itemnumber),
324 "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
327 # Helper method to set up a Biblio.
328 sub create_helper_biblio {
329 my $itemtype = shift;
330 my $bib = MARC::Record->new();
331 my $title = 'Silence in the library';
333 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
334 MARC::Field->new('245', ' ', ' ', a => $title),
335 MARC::Field->new('942', ' ', ' ', c => $itemtype),
337 return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');