6 use t::lib::TestBuilder;
10 use Test::More tests => 61;
19 use Koha::CirculationRules;
21 use Koha::DateUtils qw( dt_from_string output_pref );
23 use Koha::Item::Transfer::Limits;
26 use Koha::Library::Groups;
31 use lib $FindBin::Bin;
34 my $schema = Koha::Database->new->schema;
35 $schema->storage->txn_begin;
37 my $builder = t::lib::TestBuilder->new();
38 my $dbh = C4::Context->dbh;
40 # Create two random branches
41 my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
42 my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
44 my $category = $builder->build({ source => 'Category' });
46 my $borrowers_count = 5;
48 $dbh->do('DELETE FROM itemtypes');
49 $dbh->do('DELETE FROM reserves');
50 $dbh->do('DELETE FROM circulation_rules');
51 my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)');
52 $insert_sth->execute('CAN');
53 $insert_sth->execute('CANNOT');
54 $insert_sth->execute('DUMMY');
55 $insert_sth->execute('ONLY1');
57 # Setup Test------------------------
58 my $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
60 # Create item instance for testing.
61 my $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
63 # Create some borrowers
65 foreach (1..$borrowers_count) {
66 my $borrowernumber = Koha::Patron->new({
67 firstname => 'my firstname',
68 surname => 'my surname ' . $_,
69 categorycode => $category->{categorycode},
70 branchcode => $branch_1,
71 })->store->borrowernumber;
72 push @borrowernumbers, $borrowernumber;
75 # Create five item level holds
76 foreach my $borrowernumber ( @borrowernumbers ) {
79 branchcode => $branch_1,
80 borrowernumber => $borrowernumber,
81 biblionumber => $biblio->biblionumber,
82 priority => C4::Reserves::CalculatePriority( $biblio->biblionumber ),
83 itemnumber => $itemnumber,
88 my $holds = $biblio->holds;
89 is( $holds->count, $borrowers_count, 'Test GetReserves()' );
90 is( $holds->next->priority, 1, "Reserve 1 has a priority of 1" );
91 is( $holds->next->priority, 2, "Reserve 2 has a priority of 2" );
92 is( $holds->next->priority, 3, "Reserve 3 has a priority of 3" );
93 is( $holds->next->priority, 4, "Reserve 4 has a priority of 4" );
94 is( $holds->next->priority, 5, "Reserve 5 has a priority of 5" );
96 my $item = Koha::Items->find( $itemnumber );
97 $holds = $item->current_holds;
98 my $first_hold = $holds->next;
99 my $reservedate = $first_hold->reservedate;
100 my $borrowernumber = $first_hold->borrowernumber;
101 my $branch_1code = $first_hold->branchcode;
102 my $reserve_id = $first_hold->reserve_id;
103 is( $reservedate, output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), "holds_placed_today should return a valid reserve date");
104 is( $borrowernumber, $borrowernumbers[0], "holds_placed_today should return a valid borrowernumber");
105 is( $branch_1code, $branch_1, "holds_placed_today should return a valid branchcode");
106 ok($reserve_id, "Test holds_placed_today()");
108 my $hold = Koha::Holds->find( $reserve_id );
109 ok( $hold, "Koha::Holds found the hold" );
110 my $hold_biblio = $hold->biblio();
111 ok( $hold_biblio, "Got biblio using biblio() method" );
112 ok( $hold_biblio == $hold->biblio(), "biblio method returns stashed biblio" );
113 my $hold_item = $hold->item();
114 ok( $hold_item, "Got item using item() method" );
115 ok( $hold_item == $hold->item(), "item method returns stashed item" );
116 my $hold_branch = $hold->branch();
117 ok( $hold_branch, "Got branch using branch() method" );
118 ok( $hold_branch == $hold->branch(), "branch method returns stashed branch" );
119 my $hold_found = $hold->found();
120 $hold->set({ found => 'W'})->store();
121 is( Koha::Holds->waiting()->count(), 1, "Koha::Holds->waiting returns waiting holds" );
122 is( Koha::Holds->unfilled()->count(), 4, "Koha::Holds->unfilled returns unfilled holds" );
124 my $patron = Koha::Patrons->find( $borrowernumbers[0] );
125 $holds = $patron->holds;
126 is( $holds->next->borrowernumber, $borrowernumbers[0], "Test Koha::Patron->holds");
129 $holds = $item->current_holds;
130 $first_hold = $holds->next;
131 $borrowernumber = $first_hold->borrowernumber;
132 $branch_1code = $first_hold->branchcode;
133 $reserve_id = $first_hold->reserve_id;
136 reserve_id => $reserve_id,
138 branchcode => $branch_1,
139 itemnumber => $itemnumber,
140 suspend_until => output_pref( { dt => dt_from_string( "2013-01-01", "iso" ), dateonly => 1 } ),
143 $hold = Koha::Holds->find( $reserve_id );
144 ok( $hold->priority eq '4', "Test ModReserve, priority changed correctly" );
145 ok( $hold->suspend, "Test ModReserve, suspend hold" );
146 is( $hold->suspend_until, '2013-01-01 00:00:00', "Test ModReserve, suspend until date" );
148 ModReserve({ # call without reserve_id
150 biblionumber => $biblio->biblionumber,
151 itemnumber => $itemnumber,
152 borrowernumber => $borrowernumber,
154 $hold = Koha::Holds->find( $reserve_id );
155 ok( $hold->priority eq '3', "Test ModReserve, priority changed correctly" );
157 ToggleSuspend( $reserve_id );
158 $hold = Koha::Holds->find( $reserve_id );
159 ok( ! $hold->suspend, "Test ToggleSuspend(), no date" );
161 ToggleSuspend( $reserve_id, '2012-01-01' );
162 $hold = Koha::Holds->find( $reserve_id );
163 is( $hold->suspend_until, '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
165 AutoUnsuspendReserves();
166 $hold = Koha::Holds->find( $reserve_id );
167 ok( ! $hold->suspend, "Test AutoUnsuspendReserves()" );
170 borrowernumber => $borrowernumber,
171 biblionumber => $biblio->biblionumber,
173 suspend_until => '2012-01-01',
175 $hold = Koha::Holds->find( $reserve_id );
176 is( $hold->suspend, 1, "Test SuspendAll()" );
177 is( $hold->suspend_until, '2012-01-01 00:00:00', "Test SuspendAll(), with date" );
180 borrowernumber => $borrowernumber,
181 biblionumber => $biblio->biblionumber,
184 $hold = Koha::Holds->find( $reserve_id );
185 is( $hold->suspend, 0, "Test resuming with SuspendAll()" );
186 is( $hold->suspend_until, undef, "Test resuming with SuspendAll(), should have no suspend until date" );
188 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
191 branchcode => $branch_1,
192 borrowernumber => $borrowernumbers[0],
193 biblionumber => $biblio->biblionumber,
197 $patron = Koha::Patrons->find( $borrowernumber );
198 $holds = $patron->holds;
199 my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $borrowernumbers[0] })->next->reserve_id;
200 ModReserveMinusPriority( $itemnumber, $reserveid );
201 $holds = $patron->holds;
202 is( $holds->next->itemnumber, $itemnumber, "Test ModReserveMinusPriority()" );
204 $holds = $biblio->holds;
205 $hold = $holds->next;
206 AlterPriority( 'top', $hold->reserve_id, undef, 2, 1, 6 );
207 $hold = Koha::Holds->find( $reserveid );
208 is( $hold->priority, '1', "Test AlterPriority(), move to top" );
210 AlterPriority( 'down', $hold->reserve_id, undef, 2, 1, 6 );
211 $hold = Koha::Holds->find( $reserveid );
212 is( $hold->priority, '2', "Test AlterPriority(), move down" );
214 AlterPriority( 'up', $hold->reserve_id, 1, 3, 1, 6 );
215 $hold = Koha::Holds->find( $reserveid );
216 is( $hold->priority, '1', "Test AlterPriority(), move up" );
218 AlterPriority( 'bottom', $hold->reserve_id, undef, 2, 1, 6 );
219 $hold = Koha::Holds->find( $reserveid );
220 is( $hold->priority, '6', "Test AlterPriority(), move to bottom" );
222 # Regression test for bug 2394
224 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
225 # a patron is not permittedo to request an item whose homebranch (i.e.,
226 # owner of the item) is different from the patron's own library.
227 # However, if canreservefromotherbranches is turned ON, the patron can
228 # create such hold requests.
230 # Note that canreservefromotherbranches has no effect if
231 # IndependentBranches is OFF.
233 my $foreign_biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
234 my $foreign_itemnumber = $builder->build_sample_item({ library => $branch_2, biblionumber => $foreign_biblio->biblionumber })->itemnumber;
235 Koha::CirculationRules->set_rules(
237 categorycode => undef,
241 reservesallowed => 25,
242 holds_per_record => 99,
246 Koha::CirculationRules->set_rules(
248 categorycode => undef,
250 itemtype => 'CANNOT',
252 reservesallowed => 0,
253 holds_per_record => 99,
258 # make sure some basic sysprefs are set
259 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
260 t::lib::Mocks::mock_preference('item-level_itypes', 1);
262 # if IndependentBranches is OFF, a $branch_1 patron can reserve an $branch_2 item
263 t::lib::Mocks::mock_preference('IndependentBranches', 0);
266 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status}, 'OK',
267 '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)'
270 # if IndependentBranches is OFF, a $branch_1 patron cannot reserve an $branch_2 item
271 t::lib::Mocks::mock_preference('IndependentBranches', 1);
272 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
274 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'cannotReserveFromOtherBranches',
275 '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)'
278 # ... unless canreservefromotherbranches is ON
279 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
281 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'OK',
282 '... unless canreservefromotherbranches is ON (bug 2394)'
286 # Regression test for bug 11336 # Test if ModReserve correctly recalculate the priorities
287 $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
288 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
289 my $reserveid1 = AddReserve(
291 branchcode => $branch_1,
292 borrowernumber => $borrowernumbers[0],
293 biblionumber => $biblio->biblionumber,
298 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
299 my $reserveid2 = AddReserve(
301 branchcode => $branch_1,
302 borrowernumber => $borrowernumbers[1],
303 biblionumber => $biblio->biblionumber,
308 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
309 my $reserveid3 = AddReserve(
311 branchcode => $branch_1,
312 borrowernumber => $borrowernumbers[2],
313 biblionumber => $biblio->biblionumber,
318 my $hhh = Koha::Holds->search({ biblionumber => $biblio->biblionumber });
319 my $hold3 = Koha::Holds->find( $reserveid3 );
320 is( $hold3->priority, 3, "The 3rd hold should have a priority set to 3" );
321 ModReserve({ reserve_id => $reserveid1, rank => 'del' });
322 ModReserve({ reserve_id => $reserveid2, rank => 'del' });
323 is( $hold3->discard_changes->priority, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
326 ModItem({ damaged => 1 }, $biblio->biblionumber, $itemnumber);
327 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 1 );
328 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
329 ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
331 $hold = Koha::Hold->new(
333 borrowernumber => $borrowernumbers[0],
334 itemnumber => $itemnumber,
335 biblionumber => $biblio->biblionumber,
338 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
340 "Patron cannot place a second item level hold for a given item" );
343 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 0 );
344 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
345 ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
347 # Regression test for bug 9532
348 $biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
349 $itemnumber = $builder->build_sample_item({ library => $branch_1, itype => 'CANNOT', biblionumber => $biblio->biblionumber})->itemnumber;
352 branchcode => $branch_1,
353 borrowernumber => $borrowernumbers[0],
354 biblionumber => $biblio->biblionumber,
359 CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'tooManyReserves',
360 "cannot request item if policy that matches on item-level item type forbids it"
362 ModItem({ itype => 'CAN' }, $biblio->biblionumber, $itemnumber);
364 CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'OK',
365 "can request item if policy that matches on item type allows it"
368 t::lib::Mocks::mock_preference('item-level_itypes', 0);
369 ModItem({ itype => undef }, $biblio->biblionumber, $itemnumber);
371 CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'tooManyReserves',
372 "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
376 # Test branch item rules
378 $dbh->do('DELETE FROM circulation_rules');
379 Koha::CirculationRules->set_rules(
381 categorycode => undef,
385 reservesallowed => 25,
386 holds_per_record => 99,
390 Koha::CirculationRules->set_rules(
392 branchcode => $branch_1,
393 itemtype => 'CANNOT',
396 returnbranch => 'homebranch',
400 Koha::CirculationRules->set_rules(
402 branchcode => $branch_1,
406 returnbranch => 'homebranch',
410 $biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
411 $itemnumber = $builder->build_sample_item({ library => $branch_1, itype => 'CANNOT', biblionumber => $biblio->biblionumber})->itemnumber;
412 is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'notReservable',
413 "CanItemBeReserved should return 'notReservable'");
415 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
416 $itemnumber = $builder->build_sample_item({ library => $branch_2, itype => 'CAN', biblionumber => $biblio->biblionumber})->itemnumber;
417 is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status},
418 'cannotReserveFromOtherBranches',
419 "CanItemBeReserved should use PatronLibrary rule when ReservesControlBranch set to 'PatronLibrary'");
420 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
421 is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status},
423 "CanItemBeReserved should use item home library rule when ReservesControlBranch set to 'ItemsHomeLibrary'");
425 $itemnumber = $builder->build_sample_item({ library => $branch_1, itype => 'CAN', biblionumber => $biblio->biblionumber})->itemnumber;
426 is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'OK',
427 "CanItemBeReserved should return 'OK'");
430 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
431 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
433 $dbh->do('DELETE FROM reserves');
434 $dbh->do('DELETE FROM issues');
435 $dbh->do('DELETE FROM items');
436 $dbh->do('DELETE FROM biblio');
438 $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
439 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
441 Koha::CirculationRules->set_rules(
443 categorycode => undef,
447 reservesallowed => 1,
448 holds_per_record => 99,
452 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
453 'OK', 'Patron can reserve item with hold limit of 1, no holds placed' );
455 my $res_id = AddReserve(
457 branchcode => $branch_1,
458 borrowernumber => $borrowernumbers[0],
459 biblionumber => $biblio->biblionumber,
464 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
465 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
467 #results should be the same for both ReservesControlBranch settings
468 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
469 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
470 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
471 #reset for further tests
472 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
474 subtest 'Test max_holds per library/patron category' => sub {
477 $dbh->do('DELETE FROM reserves');
479 $biblio = $builder->build_sample_biblio;
480 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
481 Koha::CirculationRules->set_rules(
483 categorycode => undef,
485 itemtype => $biblio->itemtype,
487 reservesallowed => 99,
488 holds_per_record => 99,
496 branchcode => $branch_1,
497 borrowernumber => $borrowernumbers[0],
498 biblionumber => $biblio->biblionumber,
505 Koha::Holds->search( { borrowernumber => $borrowernumbers[0] } )->count();
506 is( $count, 3, 'Patron now has 3 holds' );
508 my $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
509 is( $ret->{status}, 'OK', 'Patron can place hold with no borrower circ rules' );
511 my $rule_all = Koha::CirculationRules->set_rule(
513 categorycode => $category->{categorycode},
515 rule_name => 'max_holds',
520 my $rule_branch = Koha::CirculationRules->set_rule(
522 branchcode => $branch_1,
523 categorycode => $category->{categorycode},
524 rule_name => 'max_holds',
529 $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
530 is( $ret->{status}, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 3' );
532 $rule_branch->delete();
534 $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
535 is( $ret->{status}, 'tooManyReserves', 'Patron cannot place hold with only a category rule of 3' );
538 $rule_branch->rule_value(3);
539 $rule_branch->store();
541 $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
542 is( $ret->{status}, 'tooManyReserves', 'Patron cannot place hold with only a branch/category rule of 3' );
544 $rule_branch->rule_value(5);
545 $rule_branch->update();
546 $rule_branch->rule_value(5);
547 $rule_branch->store();
549 $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
550 is( $ret->{status}, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 5' );
553 subtest 'Pickup location availability tests' => sub {
556 $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
557 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
558 #Add a default rule to allow some holds
560 Koha::CirculationRules->set_rules(
563 categorycode => undef,
566 reservesallowed => 25,
567 holds_per_record => 99,
571 my $item = Koha::Items->find($itemnumber);
572 my $branch_to = $builder->build({ source => 'Branch' })->{ branchcode };
573 my $library = Koha::Libraries->find($branch_to);
574 $library->pickup_location('1')->store;
575 my $patron = $builder->build({ source => 'Borrower' })->{ borrowernumber };
577 t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);
578 t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype');
580 $library->pickup_location('1')->store;
581 is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
582 'OK', 'Library is a pickup location');
584 my $limit = Koha::Item::Transfer::Limit->new({
585 fromBranch => $item->holdingbranch,
586 toBranch => $branch_to,
587 itemtype => $item->effective_itemtype,
589 is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
590 'cannotBeTransferred', 'Item cannot be transferred');
593 $library->pickup_location('0')->store;
594 is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
595 'libraryNotPickupLocation', 'Library is not a pickup location');
596 is(CanItemBeReserved($patron, $item->itemnumber, 'nonexistent')->{status},
597 'libraryNotFound', 'Cannot set unknown library as pickup location');
600 $schema->storage->txn_rollback;
602 subtest 'CanItemBeReserved / holds_per_day tests' => sub {
606 $schema->storage->txn_begin;
608 Koha::Holds->search->delete;
609 $dbh->do('DELETE FROM issues');
610 Koha::Items->search->delete;
611 Koha::Biblios->search->delete;
613 my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes' } );
614 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
615 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
617 # Create 3 biblios with items
618 my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
619 my $itemnumber_1 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_1->biblionumber})->itemnumber;
620 my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
621 my $itemnumber_2 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_2->biblionumber})->itemnumber;
622 my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
623 my $itemnumber_3 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_3->biblionumber})->itemnumber;
625 Koha::CirculationRules->search->delete;
626 Koha::CirculationRules->set_rules(
630 itemtype => $itemtype->itemtype,
632 reservesallowed => 1,
633 holds_per_record => 99,
640 CanItemBeReserved( $patron->borrowernumber, $itemnumber_1 ),
642 'Patron can reserve item with hold limit of 1, no holds placed'
647 branchcode => $library->branchcode,
648 borrowernumber => $patron->borrowernumber,
649 biblionumber => $biblio_1->biblionumber,
655 CanItemBeReserved( $patron->borrowernumber, $itemnumber_1 ),
656 { status => 'tooManyReserves', limit => 1 },
657 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed'
660 # Raise reservesallowed to avoid tooManyReserves from it
661 Koha::CirculationRules->set_rule(
666 itemtype => $itemtype->itemtype,
667 rule_name => 'reservesallowed',
673 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
675 'Patron can reserve item with 2 reserves daily cap'
678 # Add a second reserve
679 my $res_id = AddReserve(
681 branchcode => $library->branchcode,
682 borrowernumber => $patron->borrowernumber,
683 biblionumber => $biblio_2->biblionumber,
688 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
689 { status => 'tooManyReservesToday', limit => 2 },
690 'Patron cannot a third item with 2 reserves daily cap'
693 # Update last hold so reservedate is in the past, so 2 holds, but different day
694 $hold = Koha::Holds->find($res_id);
695 my $yesterday = dt_from_string() - DateTime::Duration->new( days => 1 );
696 $hold->reservedate($yesterday)->store;
699 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
701 'Patron can reserve item with 2 bib level hold placed on different days, 2 reserves daily cap'
704 # Set holds_per_day to 0
705 Koha::CirculationRules->set_rule(
710 itemtype => $itemtype->itemtype,
711 rule_name => 'holds_per_day',
717 # Delete existing holds
718 Koha::Holds->search->delete;
720 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
721 { status => 'tooManyReservesToday', limit => 0 },
722 'Patron cannot reserve if holds_per_day is 0 (i.e. 0 is 0)'
725 Koha::CirculationRules->set_rule(
730 itemtype => $itemtype->itemtype,
731 rule_name => 'holds_per_day',
736 Koha::Holds->search->delete;
738 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
740 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)'
744 branchcode => $library->branchcode,
745 borrowernumber => $patron->borrowernumber,
746 biblionumber => $biblio_1->biblionumber,
752 branchcode => $library->branchcode,
753 borrowernumber => $patron->borrowernumber,
754 biblionumber => $biblio_2->biblionumber,
760 CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
762 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)'
766 branchcode => $library->branchcode,
767 borrowernumber => $patron->borrowernumber,
768 biblionumber => $biblio_3->biblionumber,
773 CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
774 { status => 'tooManyReserves', limit => 3 },
775 'Unlimited daily holds, but reached reservesallowed'
777 #results should be the same for both ReservesControlBranch settings
778 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
780 CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
781 { status => 'tooManyReserves', limit => 3 },
782 'Unlimited daily holds, but reached reservesallowed'
785 $schema->storage->txn_rollback;
788 subtest 'CanItemBeReserved / branch_not_in_hold_group' => sub {
791 $schema->storage->txn_begin;
794 Koha::Holds->search->delete;
795 $dbh->do('DELETE FROM issues');
796 Koha::CirculationRules->set_rule(
799 categorycode => undef,
801 rule_name => 'reservesallowed',
806 Koha::Items->search->delete;
807 Koha::Biblios->search->delete;
810 my $itemtype1 = $builder->build_object( { class => 'Koha::ItemTypes' } );
811 my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } );
814 my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
815 my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
816 my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
818 # Create library groups hierarchy
819 my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } );
820 my $group1 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library1->branchcode}} );
821 my $group2 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library2->branchcode} } );
824 my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library1->branchcode} } );
825 my $patron3 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library3->branchcode} } );
827 # Create 3 biblios with items
828 my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
829 my ( undef, undef, $itemnumber_1 ) = AddItem(
830 { homebranch => $library1->branchcode,
831 holdingbranch => $library1->branchcode
833 $biblio_1->biblionumber
835 my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
836 my ( undef, undef, $itemnumber_2 ) = AddItem(
837 { homebranch => $library2->branchcode,
838 holdingbranch => $library2->branchcode
840 $biblio_2->biblionumber
842 my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
843 my ( undef, undef, $itemnumber_3 ) = AddItem(
844 { homebranch => $library1->branchcode,
845 holdingbranch => $library1->branchcode
847 $biblio_3->biblionumber
850 # Test 1: Patron 3 can place hold
852 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
854 'Patron can place hold if no circ_rules where defined'
857 # Insert default circ rule of holds allowed only from local hold group for all libraries
858 Koha::CirculationRules->set_rules(
864 hold_fulfillment_policy => 'any',
865 returnbranch => 'any'
870 # Test 2: Patron 1 can place hold
872 CanItemBeReserved( $patron1->borrowernumber, $itemnumber_2 ),
874 'Patron can place hold because patron\'s home library is part of hold group'
877 # Test 3: Patron 3 cannot place hold
879 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
880 { status => 'branchNotInHoldGroup' },
881 'Patron cannot place hold because patron\'s home library is not part of hold group'
884 # Insert default circ rule to "any" for library 2
885 Koha::CirculationRules->set_rules(
887 branchcode => $library2->branchcode,
891 hold_fulfillment_policy => 'any',
892 returnbranch => 'any'
897 # Test 4: Patron 3 can place hold
899 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
901 'Patron can place hold if holdallowed is set to "any" for library 2'
904 # Update default circ rule to "hold group" for library 2
905 Koha::CirculationRules->set_rules(
907 branchcode => $library2->branchcode,
911 hold_fulfillment_policy => 'any',
912 returnbranch => 'any'
917 # Test 5: Patron 3 cannot place hold
919 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
920 { status => 'branchNotInHoldGroup' },
921 'Patron cannot place hold if holdallowed is set to "hold group" for library 2'
924 # Insert default item rule to "any" for itemtype 2
925 Koha::CirculationRules->set_rules(
927 branchcode => $library2->branchcode,
928 itemtype => $itemtype2->itemtype,
931 hold_fulfillment_policy => 'any',
932 returnbranch => 'any'
937 # Test 6: Patron 3 can place hold
939 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
941 'Patron can place hold if holdallowed is set to "any" for itemtype 2'
944 # Update default item rule to "hold group" for itemtype 2
945 Koha::CirculationRules->set_rules(
947 branchcode => $library2->branchcode,
948 itemtype => $itemtype2->itemtype,
951 hold_fulfillment_policy => 'any',
952 returnbranch => 'any'
957 # Test 7: Patron 3 cannot place hold
959 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
960 { status => 'branchNotInHoldGroup' },
961 'Patron cannot place hold if holdallowed is set to "hold group" for itemtype 2'
964 # Insert branch item rule to "any" for itemtype 2 and library 2
965 Koha::CirculationRules->set_rules(
967 branchcode => $library2->branchcode,
968 itemtype => $itemtype2->itemtype,
971 hold_fulfillment_policy => 'any',
972 returnbranch => 'any'
977 # Test 8: Patron 3 can place hold
979 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
981 'Patron can place hold if holdallowed is set to "any" for itemtype 2 and library 2'
984 # Update branch item rule to "hold group" for itemtype 2 and library 2
985 Koha::CirculationRules->set_rules(
987 branchcode => $library2->branchcode,
988 itemtype => $itemtype2->itemtype,
991 hold_fulfillment_policy => 'any',
992 returnbranch => 'any'
997 # Test 9: Patron 3 cannot place hold
999 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
1000 { status => 'branchNotInHoldGroup' },
1001 'Patron cannot place hold if holdallowed is set to "hold group" for itemtype 2 and library 2'
1004 $schema->storage->txn_rollback;
1008 subtest 'CanItemBeReserved / pickup_not_in_hold_group' => sub {
1011 $schema->storage->txn_begin;
1014 Koha::Holds->search->delete;
1015 $dbh->do('DELETE FROM issues');
1016 Koha::CirculationRules->set_rule(
1018 branchcode => undef,
1019 categorycode => undef,
1021 rule_name => 'reservesallowed',
1026 Koha::Items->search->delete;
1027 Koha::Biblios->search->delete;
1030 my $itemtype1 = $builder->build_object( { class => 'Koha::ItemTypes' } );
1031 my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } );
1034 my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
1035 my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
1036 my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
1038 # Create library groups hierarchy
1039 my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } );
1040 my $group1 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library1->branchcode}} );
1041 my $group2 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library2->branchcode} } );
1044 my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library1->branchcode} } );
1045 my $patron3 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library3->branchcode} } );
1047 # Create 3 biblios with items
1048 my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
1049 my ( undef, undef, $itemnumber_1 ) = AddItem(
1050 { homebranch => $library1->branchcode,
1051 holdingbranch => $library1->branchcode
1053 $biblio_1->biblionumber
1055 my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
1056 my ( undef, undef, $itemnumber_2 ) = AddItem(
1057 { homebranch => $library2->branchcode,
1058 holdingbranch => $library2->branchcode
1060 $biblio_2->biblionumber
1062 my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
1063 my ( undef, undef, $itemnumber_3 ) = AddItem(
1064 { homebranch => $library1->branchcode,
1065 holdingbranch => $library1->branchcode
1067 $biblio_3->biblionumber
1070 # Test 1: Patron 3 can place hold
1072 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1074 'Patron can place hold if no circ_rules where defined'
1077 # Insert default circ rule of holds allowed only from local hold group for all libraries
1078 Koha::CirculationRules->set_rules(
1080 branchcode => undef,
1084 hold_fulfillment_policy => 'holdgroup',
1085 returnbranch => 'any'
1090 # Test 2: Patron 1 can place hold
1092 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library1->branchcode ),
1094 'Patron can place hold because pickup location is part of hold group'
1097 # Test 3: Patron 3 cannot place hold
1099 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1100 { status => 'pickupNotInHoldGroup' },
1101 'Patron cannot place hold because pickup location is not part of hold group'
1104 # Insert default circ rule to "any" for library 2
1105 Koha::CirculationRules->set_rules(
1107 branchcode => $library2->branchcode,
1111 hold_fulfillment_policy => 'any',
1112 returnbranch => 'any'
1117 # Test 4: Patron 3 can place hold
1119 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1121 'Patron can place hold if default_branch_circ_rules is set to "any" for library 2'
1124 # Update default circ rule to "hold group" for library 2
1125 Koha::CirculationRules->set_rules(
1127 branchcode => $library2->branchcode,
1131 hold_fulfillment_policy => 'holdgroup',
1132 returnbranch => 'any'
1137 # Test 5: Patron 3 cannot place hold
1139 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1140 { status => 'pickupNotInHoldGroup' },
1141 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for library 2'
1144 # Insert default item rule to "any" for itemtype 2
1145 Koha::CirculationRules->set_rules(
1147 branchcode => $library2->branchcode,
1148 itemtype => $itemtype2->itemtype,
1151 hold_fulfillment_policy => 'any',
1152 returnbranch => 'any'
1157 # Test 6: Patron 3 can place hold
1159 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1161 'Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2'
1164 # Update default item rule to "hold group" for itemtype 2
1165 Koha::CirculationRules->set_rules(
1167 branchcode => $library2->branchcode,
1168 itemtype => $itemtype2->itemtype,
1171 hold_fulfillment_policy => 'holdgroup',
1172 returnbranch => 'any'
1177 # Test 7: Patron 3 cannot place hold
1179 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1180 { status => 'pickupNotInHoldGroup' },
1181 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2'
1184 # Insert branch item rule to "any" for itemtype 2 and library 2
1185 Koha::CirculationRules->set_rules(
1187 branchcode => $library2->branchcode,
1188 itemtype => $itemtype2->itemtype,
1191 hold_fulfillment_policy => 'any',
1192 returnbranch => 'any'
1197 # Test 8: Patron 3 can place hold
1199 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1201 'Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
1204 # Update branch item rule to "hold group" for itemtype 2 and library 2
1205 Koha::CirculationRules->set_rules(
1207 branchcode => $library2->branchcode,
1208 itemtype => $itemtype2->itemtype,
1211 hold_fulfillment_policy => 'holdgroup',
1212 returnbranch => 'any'
1217 # Test 9: Patron 3 cannot place hold
1219 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1220 { status => 'pickupNotInHoldGroup' },
1221 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
1224 $schema->storage->txn_rollback;