3 # Copyright 2019 Koha Development team
5 # This file is part of Koha
7 # Koha is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 3 of the License, or
10 # (at your option) any later version.
12 # Koha is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
23 use Test::More tests => 27;
27 use C4::Biblio qw( GetMarcSubfieldStructure );
28 use C4::Circulation qw( AddIssue AddReturn );
33 use Koha::DateUtils qw( dt_from_string );
37 use List::MoreUtils qw(all);
39 use t::lib::TestBuilder;
43 my $schema = Koha::Database->new->schema;
44 my $builder = t::lib::TestBuilder->new;
46 subtest 'return_claims relationship' => sub {
49 $schema->storage->txn_begin;
51 my $biblio = $builder->build_sample_biblio();
52 my $item = $builder->build_sample_item({
53 biblionumber => $biblio->biblionumber,
55 my $return_claims = $item->return_claims;
56 is( ref($return_claims), 'Koha::Checkouts::ReturnClaims', 'return_claims returns a Koha::Checkouts::ReturnClaims object set' );
57 is($item->return_claims->count, 0, "Empty Koha::Checkouts::ReturnClaims set returned if no return_claims");
58 my $claim1 = $builder->build({ source => 'ReturnClaim', value => { itemnumber => $item->itemnumber }});
59 my $claim2 = $builder->build({ source => 'ReturnClaim', value => { itemnumber => $item->itemnumber }});
61 is($item->return_claims()->count,2,"Two ReturnClaims found for item");
63 $schema->storage->txn_rollback;
66 subtest 'return_claim accessor' => sub {
69 $schema->storage->txn_begin;
71 my $biblio = $builder->build_sample_biblio();
72 my $item = $builder->build_sample_item({
73 biblionumber => $biblio->biblionumber,
75 my $return_claim = $item->return_claim;
76 is( $return_claim, undef, 'return_claim returned undefined if there are no claims for this item' );
78 my $claim1 = $builder->build_object(
80 class => 'Koha::Checkouts::ReturnClaims',
81 value => { itemnumber => $item->itemnumber, resolution => undef, created_on => dt_from_string()->subtract( minutes => 10 ) }
84 my $claim2 = $builder->build_object(
86 class => 'Koha::Checkouts::ReturnClaims',
87 value => { itemnumber => $item->itemnumber, resolution => undef, created_on => dt_from_string()->subtract( minutes => 5 ) }
91 $return_claim = $item->return_claim;
92 is( ref($return_claim), 'Koha::Checkouts::ReturnClaim', 'return_claim returned a Koha::Checkouts::ReturnClaim object' );
93 is( $return_claim->id, $claim2->id, 'return_claim returns the most recent unresolved claim');
95 $claim2->resolution('test')->store();
96 $return_claim = $item->return_claim;
97 is( $return_claim->id, $claim1->id, 'return_claim returns the only unresolved claim');
99 $claim1->resolution('test')->store();
100 $return_claim = $item->return_claim;
101 is( $return_claim, undef, 'return_claim returned undefined if there are no active claims for this item' );
103 $schema->storage->txn_rollback;
106 subtest 'tracked_links relationship' => sub {
109 my $biblio = $builder->build_sample_biblio();
110 my $item = $builder->build_sample_item({
111 biblionumber => $biblio->biblionumber,
113 my $tracked_links = $item->tracked_links;
114 is( ref($tracked_links), 'Koha::TrackedLinks', 'tracked_links returns a Koha::TrackedLinks object set' );
115 is($item->tracked_links->count, 0, "Empty Koha::TrackedLinks set returned if no tracked_links");
116 my $link1 = $builder->build({ source => 'Linktracker', value => { itemnumber => $item->itemnumber }});
117 my $link2 = $builder->build({ source => 'Linktracker', value => { itemnumber => $item->itemnumber }});
119 is($item->tracked_links()->count,2,"Two tracked links found");
122 subtest 'is_bundle tests' => sub {
125 $schema->storage->txn_begin;
127 my $item = $builder->build_sample_item();
129 my $is_bundle = $item->is_bundle;
130 is($is_bundle, 0, 'is_bundle returns 0 when there are no items attached');
132 my $item2 = $builder->build_sample_item();
133 $schema->resultset('ItemBundle')
134 ->create( { host => $item->itemnumber, item => $item2->itemnumber } );
136 $is_bundle = $item->is_bundle;
137 is($is_bundle, 1, 'is_bundle returns 1 when there is at least one item attached');
139 $schema->storage->txn_rollback;
142 subtest 'in_bundle tests' => sub {
145 $schema->storage->txn_begin;
147 my $item = $builder->build_sample_item();
149 my $in_bundle = $item->in_bundle;
150 is($in_bundle, 0, 'in_bundle returns 0 when the item is not in a bundle');
152 my $host_item = $builder->build_sample_item();
153 $schema->resultset('ItemBundle')
154 ->create( { host => $host_item->itemnumber, item => $item->itemnumber } );
156 $in_bundle = $item->in_bundle;
157 is($in_bundle, 1, 'in_bundle returns 1 when the item is in a bundle');
159 $schema->storage->txn_rollback;
162 subtest 'bundle_items tests' => sub {
165 $schema->storage->txn_begin;
167 my $host_item = $builder->build_sample_item();
168 my $bundle_items = $host_item->bundle_items;
169 is( ref($bundle_items), 'Koha::Items',
170 'bundle_items returns a Koha::Items object set' );
171 is( $bundle_items->count, 0,
172 'bundle_items set is empty when no items are bundled' );
174 my $bundle_item1 = $builder->build_sample_item();
175 my $bundle_item2 = $builder->build_sample_item();
176 my $bundle_item3 = $builder->build_sample_item();
177 $schema->resultset('ItemBundle')
179 { host => $host_item->itemnumber, item => $bundle_item1->itemnumber } );
180 $schema->resultset('ItemBundle')
182 { host => $host_item->itemnumber, item => $bundle_item2->itemnumber } );
183 $schema->resultset('ItemBundle')
185 { host => $host_item->itemnumber, item => $bundle_item3->itemnumber } );
187 $bundle_items = $host_item->bundle_items;
188 is( $bundle_items->count, 3,
189 'bundle_items returns all the bundled items in the set' );
191 $schema->storage->txn_rollback;
194 subtest 'bundle_host tests' => sub {
197 $schema->storage->txn_begin;
199 my $host_item = $builder->build_sample_item();
200 my $bundle_item1 = $builder->build_sample_item();
201 my $bundle_item2 = $builder->build_sample_item();
202 $schema->resultset('ItemBundle')
204 { host => $host_item->itemnumber, item => $bundle_item2->itemnumber } );
206 my $bundle_host = $bundle_item1->bundle_host;
207 is( $bundle_host, undef, 'bundle_host returns undefined when the item it not part of a bundle');
208 $bundle_host = $bundle_item2->bundle_host;
209 is( ref($bundle_host), 'Koha::Item', 'bundle_host returns a Koha::Item object when the item is in a bundle');
210 is( $bundle_host->id, $host_item->id, 'bundle_host returns the host item when called against an item in a bundle');
212 $schema->storage->txn_rollback;
215 subtest 'add_to_bundle tests' => sub {
218 $schema->storage->txn_begin;
220 t::lib::Mocks::mock_preference( 'BundleNotLoanValue', 1 );
222 my $host_item = $builder->build_sample_item();
223 my $bundle_item1 = $builder->build_sample_item();
224 my $bundle_item2 = $builder->build_sample_item();
226 ok($host_item->add_to_bundle($bundle_item1), 'bundle_item1 added to bundle');
227 is($bundle_item1->notforloan, 1, 'add_to_bundle sets notforloan to BundleNotLoanValue');
229 throws_ok { $host_item->add_to_bundle($bundle_item1) }
230 'Koha::Exceptions::Object::DuplicateID',
231 'Exception thrown if you try to add the same item twice';
233 $schema->storage->txn_rollback;
236 subtest 'remove_from_bundle tests' => sub {
239 $schema->storage->txn_begin;
241 my $host_item = $builder->build_sample_item();
242 my $bundle_item1 = $builder->build_sample_item({ notforloan => 1 });
243 $schema->resultset('ItemBundle')
245 { host => $host_item->itemnumber, item => $bundle_item1->itemnumber } );
247 is($bundle_item1->remove_from_bundle(), 1, 'remove_from_bundle returns 1 when item is removed from a bundle');
248 is($bundle_item1->notforloan, 0, 'remove_from_bundle resets notforloan to 0');
249 $bundle_item1 = $bundle_item1->get_from_storage;
250 is($bundle_item1->remove_from_bundle(), 0, 'remove_from_bundle returns 0 when item is not in a bundle');
252 $schema->storage->txn_rollback;
255 subtest 'hidden_in_opac() tests' => sub {
259 $schema->storage->txn_begin;
261 my $item = $builder->build_sample_item({ itemlost => 2 });
264 # disable hidelostitems as it interteres with OpachiddenItems for the calculation
265 t::lib::Mocks::mock_preference( 'hidelostitems', 0 );
267 ok( !$item->hidden_in_opac, 'No rules passed, shouldn\'t hide' );
268 ok( !$item->hidden_in_opac({ rules => $rules }), 'Empty rules passed, shouldn\'t hide' );
270 # enable hidelostitems to verify correct behaviour
271 t::lib::Mocks::mock_preference( 'hidelostitems', 1 );
272 ok( $item->hidden_in_opac, 'Even with no rules, item should hide because of hidelostitems syspref' );
274 # disable hidelostitems
275 t::lib::Mocks::mock_preference( 'hidelostitems', 0 );
276 my $withdrawn = $item->withdrawn + 1; # make sure this attribute doesn't match
278 $rules = { withdrawn => [$withdrawn], itype => [ $item->itype ] };
280 ok( $item->hidden_in_opac({ rules => $rules }), 'Rule matching itype passed, should hide' );
284 $schema->storage->txn_rollback;
287 subtest 'has_pending_hold() tests' => sub {
291 $schema->storage->txn_begin;
293 my $dbh = C4::Context->dbh;
294 my $item = $builder->build_sample_item({ itemlost => 0 });
295 my $itemnumber = $item->itemnumber;
297 $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber) VALUES ('Clamp',42,$itemnumber)");
298 ok( $item->has_pending_hold, "Yes, we have a pending hold");
299 $dbh->do("DELETE FROM tmp_holdsqueue WHERE itemnumber=$itemnumber");
300 ok( !$item->has_pending_hold, "We don't have a pending hold if nothing in the tmp_holdsqueue");
302 $schema->storage->txn_rollback;
305 subtest "as_marc_field() tests" => sub {
307 my $mss = C4::Biblio::GetMarcSubfieldStructure( '' );
308 my ( $itemtag, $itemtagsubfield) = C4::Biblio::GetMarcFromKohaField( "items.itemnumber" );
310 my @schema_columns = $schema->resultset('Item')->result_source->columns;
311 my @mapped_columns = grep { exists $mss->{'items.'.$_} } @schema_columns;
313 plan tests => 2 * (scalar @mapped_columns + 1) + 4;
315 $schema->storage->txn_begin;
317 my $item = $builder->build_sample_item;
318 # Make sure it has at least one undefined attribute
319 $item->set({ replacementprice => undef })->store->discard_changes;
321 # Tests with the mss parameter
322 my $marc_field = $item->as_marc_field({ mss => $mss });
327 'Generated field set the right tag number'
330 foreach my $column ( @mapped_columns ) {
331 my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
332 is( $marc_field->subfield($tagsubfield),
333 $item->$column, "Value is mapped correctly for column $column" );
336 # Tests without the mss parameter
337 $marc_field = $item->as_marc_field();
342 'Generated field set the right tag number'
345 foreach my $column (@mapped_columns) {
346 my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
347 is( $marc_field->subfield($tagsubfield),
348 $item->$column, "Value is mapped correctly for column $column" );
351 my $unmapped_subfield = Koha::MarcSubfieldStructure->new(
354 tagfield => $itemtag,
358 Koha::MarcSubfieldStructure->new(
361 tagfield => $itemtag,
367 my @unlinked_subfields;
368 push @unlinked_subfields, X => 'Something weird', Y => 'Something else';
369 $item->more_subfields_xml( C4::Items::_get_unlinked_subfields_xml( \@unlinked_subfields ) )->store;
371 Koha::Caches->get_instance->clear_from_cache( "MarcStructure-1-" );
372 Koha::MarcSubfieldStructures->search(
373 { frameworkcode => '', tagfield => $itemtag } )
374 ->update( { display_order => \['FLOOR( 1 + RAND( ) * 10 )'] } );
376 $marc_field = $item->as_marc_field;
378 my $tagslib = C4::Biblio::GetMarcStructure(1, '');
379 my @subfields = $marc_field->subfields;
380 my $result = all { defined $_->[1] } @subfields;
381 ok( $result, 'There are no undef subfields' );
382 my @ordered_subfields = sort {
383 $tagslib->{$itemtag}->{ $a->[0] }->{display_order}
384 <=> $tagslib->{$itemtag}->{ $b->[0] }->{display_order}
386 is_deeply(\@subfields, \@ordered_subfields);
388 is( scalar $marc_field->subfield('X'), 'Something weird', 'more_subfield_xml is considered when kohafield is NULL' );
389 is( scalar $marc_field->subfield('Y'), 'Something else', 'more_subfield_xml is considered when kohafield = ""' );
391 $schema->storage->txn_rollback;
392 Koha::Caches->get_instance->clear_from_cache( "MarcStructure-1-" );
395 subtest 'pickup_locations' => sub {
398 $schema->storage->txn_begin;
400 my $dbh = C4::Context->dbh;
402 my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
403 my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
404 my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
405 my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
406 my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, } } );
407 my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
408 my $group1_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );
409 my $group1_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );
411 my $group2_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library3->branchcode } } );
412 my $group2_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library4->branchcode } } );
415 $library1->branchcode, $library2->branchcode,
416 $library3->branchcode, $library4->branchcode
419 my $item1 = $builder->build_sample_item(
421 homebranch => $library1->branchcode,
422 holdingbranch => $library2->branchcode,
428 my $item3 = $builder->build_sample_item(
430 homebranch => $library3->branchcode,
431 holdingbranch => $library4->branchcode,
433 itype => $item1->itype,
437 Koha::CirculationRules->set_rules(
439 categorycode => undef,
440 itemtype => $item1->itype,
443 reservesallowed => 25,
449 my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library1->branchcode, firstname => '1' } } );
450 my $patron4 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library4->branchcode, firstname => '4' } } );
453 "1-1-from_home_library-any" => 3,
454 "1-1-from_home_library-holdgroup" => 2,
455 "1-1-from_home_library-patrongroup" => 2,
456 "1-1-from_home_library-homebranch" => 1,
457 "1-1-from_home_library-holdingbranch" => 1,
458 "1-1-from_any_library-any" => 3,
459 "1-1-from_any_library-holdgroup" => 2,
460 "1-1-from_any_library-patrongroup" => 2,
461 "1-1-from_any_library-homebranch" => 1,
462 "1-1-from_any_library-holdingbranch" => 1,
463 "1-1-from_local_hold_group-any" => 3,
464 "1-1-from_local_hold_group-holdgroup" => 2,
465 "1-1-from_local_hold_group-patrongroup" => 2,
466 "1-1-from_local_hold_group-homebranch" => 1,
467 "1-1-from_local_hold_group-holdingbranch" => 1,
468 "1-4-from_home_library-any" => 0,
469 "1-4-from_home_library-holdgroup" => 0,
470 "1-4-from_home_library-patrongroup" => 0,
471 "1-4-from_home_library-homebranch" => 0,
472 "1-4-from_home_library-holdingbranch" => 0,
473 "1-4-from_any_library-any" => 3,
474 "1-4-from_any_library-holdgroup" => 2,
475 "1-4-from_any_library-patrongroup" => 1,
476 "1-4-from_any_library-homebranch" => 1,
477 "1-4-from_any_library-holdingbranch" => 1,
478 "1-4-from_local_hold_group-any" => 0,
479 "1-4-from_local_hold_group-holdgroup" => 0,
480 "1-4-from_local_hold_group-patrongroup" => 0,
481 "1-4-from_local_hold_group-homebranch" => 0,
482 "1-4-from_local_hold_group-holdingbranch" => 0,
483 "3-1-from_home_library-any" => 0,
484 "3-1-from_home_library-holdgroup" => 0,
485 "3-1-from_home_library-patrongroup" => 0,
486 "3-1-from_home_library-homebranch" => 0,
487 "3-1-from_home_library-holdingbranch" => 0,
488 "3-1-from_any_library-any" => 3,
489 "3-1-from_any_library-holdgroup" => 1,
490 "3-1-from_any_library-patrongroup" => 2,
491 "3-1-from_any_library-homebranch" => 0,
492 "3-1-from_any_library-holdingbranch" => 1,
493 "3-1-from_local_hold_group-any" => 0,
494 "3-1-from_local_hold_group-holdgroup" => 0,
495 "3-1-from_local_hold_group-patrongroup" => 0,
496 "3-1-from_local_hold_group-homebranch" => 0,
497 "3-1-from_local_hold_group-holdingbranch" => 0,
498 "3-4-from_home_library-any" => 0,
499 "3-4-from_home_library-holdgroup" => 0,
500 "3-4-from_home_library-patrongroup" => 0,
501 "3-4-from_home_library-homebranch" => 0,
502 "3-4-from_home_library-holdingbranch" => 0,
503 "3-4-from_any_library-any" => 3,
504 "3-4-from_any_library-holdgroup" => 1,
505 "3-4-from_any_library-patrongroup" => 1,
506 "3-4-from_any_library-homebranch" => 0,
507 "3-4-from_any_library-holdingbranch" => 1,
508 "3-4-from_local_hold_group-any" => 3,
509 "3-4-from_local_hold_group-holdgroup" => 1,
510 "3-4-from_local_hold_group-patrongroup" => 1,
511 "3-4-from_local_hold_group-homebranch" => 0,
512 "3-4-from_local_hold_group-holdingbranch" => 1
516 my ( $item, $patron, $ha, $hfp, $results ) = @_;
518 Koha::CirculationRules->set_rules(
524 hold_fulfillment_policy => $hfp,
525 returnbranch => 'any'
530 $ha eq 'from_local_hold_group' ? 'holdgroup'
532 $ha eq 'from_any_library' ? 'any'
537 my $pickup_location = $_;
538 grep { $pickup_location->branchcode eq $_ } @branchcodes
539 } $item->pickup_locations( { patron => $patron } )->as_list;
542 scalar(@pl) eq $results->{
543 $item->copynumber . '-'
544 . $patron->firstname . '-'
554 . ', hold_fulfillment_policy: '
558 $item->copynumber . '-'
559 . $patron->firstname . '-'
570 foreach my $item ($item1, $item3) {
571 foreach my $patron ($patron1, $patron4) {
572 #holdallowed 1: homebranch, 2: any, 3: holdgroup
573 foreach my $ha ('from_home_library', 'from_any_library', 'from_local_hold_group') {
574 foreach my $hfp ('any', 'holdgroup', 'patrongroup', 'homebranch', 'holdingbranch') {
575 _doTest($item, $patron, $ha, $hfp, $results);
581 # Now test that branchtransferlimits will further filter the pickup locations
583 my $item_no_ccode = $builder->build_sample_item(
585 homebranch => $library1->branchcode,
586 holdingbranch => $library2->branchcode,
587 itype => $item1->itype,
591 t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);
592 t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype');
593 Koha::CirculationRules->set_rules(
596 itemtype => $item1->itype,
598 holdallowed => 'from_home_library',
599 hold_fulfillment_policy => 1,
600 returnbranch => 'any'
604 $builder->build_object(
606 class => 'Koha::Item::Transfer::Limits',
608 toBranch => $library1->branchcode,
609 fromBranch => $library2->branchcode,
610 itemtype => $item1->itype,
616 my @pickup_locations = map {
617 my $pickup_location = $_;
618 grep { $pickup_location->branchcode eq $_ } @branchcodes
619 } $item1->pickup_locations( { patron => $patron1 } )->as_list;
621 is( scalar @pickup_locations, 3 - 1, "With a transfer limits we get back the libraries that are pickup locations minus 1 limited library");
623 $builder->build_object(
625 class => 'Koha::Item::Transfer::Limits',
627 toBranch => $library4->branchcode,
628 fromBranch => $library2->branchcode,
629 itemtype => $item1->itype,
635 @pickup_locations = map {
636 my $pickup_location = $_;
637 grep { $pickup_location->branchcode eq $_ } @branchcodes
638 } $item1->pickup_locations( { patron => $patron1 } )->as_list;
640 is( scalar @pickup_locations, 3 - 2, "With 2 transfer limits we get back the libraries that are pickup locations minus 2 limited libraries");
642 t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'ccode');
643 @pickup_locations = map {
644 my $pickup_location = $_;
645 grep { $pickup_location->branchcode eq $_ } @branchcodes
646 } $item1->pickup_locations( { patron => $patron1 } )->as_list;
647 is( scalar @pickup_locations, 3, "With no transfer limits of type ccode we get back the libraries that are pickup locations");
649 @pickup_locations = map {
650 my $pickup_location = $_;
651 grep { $pickup_location->branchcode eq $_ } @branchcodes
652 } $item_no_ccode->pickup_locations( { patron => $patron1 } )->as_list;
653 is( scalar @pickup_locations, 3, "With no transfer limits of type ccode and an item with no ccode we get back the libraries that are pickup locations");
655 $builder->build_object(
657 class => 'Koha::Item::Transfer::Limits',
659 toBranch => $library2->branchcode,
660 fromBranch => $library2->branchcode,
662 ccode => $item1->ccode,
667 @pickup_locations = map {
668 my $pickup_location = $_;
669 grep { $pickup_location->branchcode eq $_ } @branchcodes
670 } $item1->pickup_locations( { patron => $patron1 } )->as_list;
671 is( scalar @pickup_locations, 3 - 1, "With a transfer limits we get back the libraries that are pickup locations minus 1 limited library");
673 $builder->build_object(
675 class => 'Koha::Item::Transfer::Limits',
677 toBranch => $library4->branchcode,
678 fromBranch => $library2->branchcode,
680 ccode => $item1->ccode,
685 @pickup_locations = map {
686 my $pickup_location = $_;
687 grep { $pickup_location->branchcode eq $_ } @branchcodes
688 } $item1->pickup_locations( { patron => $patron1 } )->as_list;
689 is( scalar @pickup_locations, 3 - 2, "With 2 transfer limits we get back the libraries that are pickup locations minus 2 limited libraries");
691 t::lib::Mocks::mock_preference('UseBranchTransferLimits', 0);
693 $schema->storage->txn_rollback;
696 subtest 'request_transfer' => sub {
698 $schema->storage->txn_begin;
700 my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
701 my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
702 my $item = $builder->build_sample_item(
704 homebranch => $library1->branchcode,
705 holdingbranch => $library2->branchcode,
709 # Mandatory fields tests
710 throws_ok { $item->request_transfer( { to => $library1 } ) }
711 'Koha::Exceptions::MissingParameter',
712 'Exception thrown if `reason` parameter is missing';
714 throws_ok { $item->request_transfer( { reason => 'Manual' } ) }
715 'Koha::Exceptions::MissingParameter',
716 'Exception thrown if `to` parameter is missing';
719 my $transfer = $item->request_transfer({ to => $library1, reason => 'Manual' });
720 is( ref($transfer), 'Koha::Item::Transfer',
721 'Koha::Item->request_transfer should return a Koha::Item::Transfer object'
723 my $original_transfer = $transfer->get_from_storage;
725 # Transfer already in progress
726 throws_ok { $item->request_transfer( { to => $library2, reason => 'Manual' } ) }
727 'Koha::Exceptions::Item::Transfer::InQueue',
728 'Exception thrown if transfer is already in progress';
731 is( ref( $exception->transfer ),
732 'Koha::Item::Transfer',
733 'The exception contains the found Koha::Item::Transfer' );
736 my $queued_transfer = $item->request_transfer(
737 { to => $library2, reason => 'Manual', enqueue => 1 } );
738 is( ref($queued_transfer), 'Koha::Item::Transfer',
739 'Koha::Item->request_transfer allowed when enqueue is set' );
740 my $transfers = $item->get_transfers;
741 is($transfers->count, 2, "There are now 2 live transfers in the queue");
742 $transfer = $transfer->get_from_storage;
743 is_deeply($transfer->unblessed, $original_transfer->unblessed, "Original transfer unchanged");
744 $queued_transfer->datearrived(dt_from_string)->store();
747 my $replaced_transfer = $item->request_transfer(
748 { to => $library2, reason => 'Manual', replace => 1 } );
749 is( ref($replaced_transfer), 'Koha::Item::Transfer',
750 'Koha::Item->request_transfer allowed when replace is set' );
751 $original_transfer->discard_changes;
752 ok($original_transfer->datecancelled, "Original transfer cancelled");
753 $transfers = $item->get_transfers;
754 is($transfers->count, 1, "There is only 1 live transfer in the queue");
755 $replaced_transfer->datearrived(dt_from_string)->store();
757 # BranchTransferLimits
758 t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);
759 t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype');
760 my $limit = Koha::Item::Transfer::Limit->new({
761 fromBranch => $library2->branchcode,
762 toBranch => $library1->branchcode,
763 itemtype => $item->effective_itemtype,
766 throws_ok { $item->request_transfer( { to => $library1, reason => 'Manual' } ) }
767 'Koha::Exceptions::Item::Transfer::Limit',
768 'Exception thrown if transfer is prevented by limits';
770 my $forced_transfer = $item->request_transfer( { to => $library1, reason => 'Manual', ignore_limits => 1 } );
771 is( ref($forced_transfer), 'Koha::Item::Transfer',
772 'Koha::Item->request_transfer allowed when ignore_limits is set'
775 $schema->storage->txn_rollback;
778 subtest 'deletion' => sub {
781 $schema->storage->txn_begin;
783 my $biblio = $builder->build_sample_biblio();
785 my $item = $builder->build_sample_item(
787 biblionumber => $biblio->biblionumber,
790 is( $item->deleted_on, undef, 'deleted_on not set for new item' );
792 my $deleted_item = $item->move_to_deleted;
793 is( ref( $deleted_item ), 'Koha::Schema::Result::Deleteditem', 'Koha::Item->move_to_deleted should return the Deleted item' )
794 ; # FIXME This should be Koha::Deleted::Item
795 is( t::lib::Dates::compare( $deleted_item->deleted_on, dt_from_string() ), 0 );
797 is( Koha::Old::Items->search({itemnumber => $item->itemnumber})->count, 1, '->move_to_deleted must have moved the item to deleteditem' );
798 $item = $builder->build_sample_item(
800 biblionumber => $biblio->biblionumber,
804 is( Koha::Old::Items->search({itemnumber => $item->itemnumber})->count, 0, '->move_to_deleted must not have moved the item to deleteditem' );
807 my $library = $builder->build_object({ class => 'Koha::Libraries' });
808 my $library_2 = $builder->build_object({ class => 'Koha::Libraries' });
809 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
811 my $patron = $builder->build_object({class => 'Koha::Patrons'});
812 $item = $builder->build_sample_item({ library => $library->branchcode });
815 C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
818 @{$item->safe_to_delete->messages}[0]->message,
820 'Koha::Item->safe_to_delete reports item on loan',
824 @{$item->safe_to_delete->messages}[0]->message,
826 'item that is on loan cannot be deleted',
830 ! $item->safe_to_delete,
831 'Koha::Item->safe_to_delete shows item NOT safe to delete'
834 AddReturn( $item->barcode, $library->branchcode );
836 # book_reserved is tested in t/db_dependent/Reserves.t
839 t::lib::Mocks::mock_preference('IndependentBranches', 1);
840 my $item_2 = $builder->build_sample_item({ library => $library_2->branchcode });
843 @{$item_2->safe_to_delete->messages}[0]->message,
845 'Koha::Item->safe_to_delete reports IndependentBranches restriction',
849 @{$item_2->safe_to_delete->messages}[0]->message,
851 'IndependentBranches prevents deletion at another branch',
856 { # codeblock to limit scope of $module->mock
858 my $module = Test::MockModule->new('C4::Items');
859 $module->mock( GetAnalyticsCount => sub { return 1 } );
861 $item->discard_changes;
863 @{$item->safe_to_delete->messages}[0]->message,
865 'Koha::Item->safe_to_delete reports linked analytics',
869 @{$item->safe_to_delete->messages}[0]->message,
871 'Linked analytics prevents deletion of item',
876 { # last_item_for_hold
877 C4::Reserves::AddReserve({ branchcode => $patron->branchcode, borrowernumber => $patron->borrowernumber, biblionumber => $item->biblionumber });
879 @{$item->safe_to_delete->messages}[0]->message,
880 'last_item_for_hold',
881 'Item cannot be deleted if a biblio-level is placed on the biblio and there is only 1 item attached to the biblio'
883 # With another item attached to the biblio, the item can be deleted
884 $builder->build_sample_item({ biblionumber => $item->biblionumber });
888 $item->safe_to_delete,
889 'Koha::Item->safe_to_delete shows item safe to delete'
894 my $test_item = Koha::Items->find( $item->itemnumber );
896 is( $test_item, undef,
897 "Koha::Item->safe_delete should delete item if safe_to_delete returns true"
900 $schema->storage->txn_rollback;
903 subtest 'renewal_branchcode' => sub {
906 $schema->storage->txn_begin;
908 my $item = $builder->build_sample_item();
909 my $branch = $builder->build_object({ class => 'Koha::Libraries' });
910 my $checkout = $builder->build_object({
911 class => 'Koha::Checkouts',
913 itemnumber => $item->itemnumber,
918 C4::Context->interface( 'intranet' );
919 t::lib::Mocks::mock_userenv({ branchcode => $branch->branchcode });
921 is( $item->renewal_branchcode, $branch->branchcode, "If interface not opac, we get the branch from context");
922 is( $item->renewal_branchcode({ branch => "PANDA"}), $branch->branchcode, "If interface not opac, we get the branch from context even if we pass one in");
923 C4::Context->set_userenv(51, 'userid4tests', undef, 'firstname', 'surname', undef, undef, 0, undef, undef, undef ); #mock userenv doesn't let us set null branch
924 is( $item->renewal_branchcode({ branch => "PANDA"}), "PANDA", "If interface not opac, we get the branch we pass one in if context not set");
926 C4::Context->interface( 'opac' );
928 t::lib::Mocks::mock_preference('OpacRenewalBranch', undef);
929 is( $item->renewal_branchcode, 'OPACRenew', "If interface opac and OpacRenewalBranch undef, we get OPACRenew");
930 is( $item->renewal_branchcode({branch=>'COW'}), 'OPACRenew', "If interface opac and OpacRenewalBranch undef, we get OPACRenew even if branch passed");
932 t::lib::Mocks::mock_preference('OpacRenewalBranch', 'none');
933 is( $item->renewal_branchcode, '', "If interface opac and OpacRenewalBranch is none, we get blank string");
934 is( $item->renewal_branchcode({branch=>'COW'}), '', "If interface opac and OpacRenewalBranch is none, we get blank string even if branch passed");
936 t::lib::Mocks::mock_preference('OpacRenewalBranch', 'checkoutbranch');
937 is( $item->renewal_branchcode, $checkout->branchcode, "If interface opac and OpacRenewalBranch set to checkoutbranch, we get branch of checkout");
938 is( $item->renewal_branchcode({branch=>'MONKEY'}), $checkout->branchcode, "If interface opac and OpacRenewalBranch set to checkoutbranch, we get branch of checkout even if branch passed");
940 t::lib::Mocks::mock_preference('OpacRenewalBranch','patronhomebranch');
941 is( $item->renewal_branchcode, $checkout->patron->branchcode, "If interface opac and OpacRenewalBranch set to patronbranch, we get branch of patron");
942 is( $item->renewal_branchcode({branch=>'TURKEY'}), $checkout->patron->branchcode, "If interface opac and OpacRenewalBranch set to patronbranch, we get branch of patron even if branch passed");
944 t::lib::Mocks::mock_preference('OpacRenewalBranch','itemhomebranch');
945 is( $item->renewal_branchcode, $item->homebranch, "If interface opac and OpacRenewalBranch set to itemhomebranch, we get homebranch of item");
946 is( $item->renewal_branchcode({branch=>'MANATEE'}), $item->homebranch, "If interface opac and OpacRenewalBranch set to itemhomebranch, we get homebranch of item even if branch passed");
948 $schema->storage->txn_rollback;
951 subtest 'Tests for itemtype' => sub {
953 $schema->storage->txn_begin;
955 my $biblio = $builder->build_sample_biblio;
956 my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes' });
957 my $item = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, itype => $itemtype->itemtype });
959 t::lib::Mocks::mock_preference('item-level_itypes', 1);
960 is( $item->itemtype->itemtype, $item->itype, 'Pref enabled' );
961 t::lib::Mocks::mock_preference('item-level_itypes', 0);
962 is( $item->itemtype->itemtype, $biblio->biblioitem->itemtype, 'Pref disabled' );
964 $schema->storage->txn_rollback;
967 subtest 'get_transfers' => sub {
969 $schema->storage->txn_begin;
971 my $item = $builder->build_sample_item();
973 my $transfers = $item->get_transfers();
974 is(ref($transfers), 'Koha::Item::Transfers', 'Koha::Item->get_transfer should return a Koha::Item::Transfers object' );
975 is($transfers->count, 0, 'When no transfers exist, the Koha::Item:Transfers object should be empty');
977 my $library_to = $builder->build_object( { class => 'Koha::Libraries' } );
979 my $transfer_1 = $builder->build_object(
981 class => 'Koha::Item::Transfers',
983 itemnumber => $item->itemnumber,
984 frombranch => $item->holdingbranch,
985 tobranch => $library_to->branchcode,
988 datearrived => undef,
989 datecancelled => undef,
990 daterequested => \'NOW()'
995 $transfers = $item->get_transfers();
996 is($transfers->count, 1, 'When one transfer has been requested, the Koha::Item:Transfers object should contain one result');
998 my $transfer_2 = $builder->build_object(
1000 class => 'Koha::Item::Transfers',
1002 itemnumber => $item->itemnumber,
1003 frombranch => $item->holdingbranch,
1004 tobranch => $library_to->branchcode,
1007 datearrived => undef,
1008 datecancelled => undef,
1009 daterequested => \'NOW()'
1014 my $transfer_3 = $builder->build_object(
1016 class => 'Koha::Item::Transfers',
1018 itemnumber => $item->itemnumber,
1019 frombranch => $item->holdingbranch,
1020 tobranch => $library_to->branchcode,
1023 datearrived => undef,
1024 datecancelled => undef,
1025 daterequested => \'NOW()'
1030 $transfers = $item->get_transfers();
1031 is($transfers->count, 3, 'When there are multiple open transfer requests, the Koha::Item::Transfers object contains them all');
1032 my $result_1 = $transfers->next;
1033 my $result_2 = $transfers->next;
1034 my $result_3 = $transfers->next;
1035 is( $result_1->branchtransfer_id, $transfer_1->branchtransfer_id, 'Koha::Item->get_transfers returns the oldest transfer request first');
1036 is( $result_2->branchtransfer_id, $transfer_2->branchtransfer_id, 'Koha::Item->get_transfers returns the newer transfer request second');
1037 is( $result_3->branchtransfer_id, $transfer_3->branchtransfer_id, 'Koha::Item->get_transfers returns the newest transfer request last');
1039 $transfer_2->datesent(\'NOW()')->store;
1040 $transfers = $item->get_transfers();
1041 is($transfers->count, 3, 'When one transfer is set to in_transit, the Koha::Item::Transfers object still contains them all');
1042 $result_1 = $transfers->next;
1043 $result_2 = $transfers->next;
1044 $result_3 = $transfers->next;
1045 is( $result_1->branchtransfer_id, $transfer_2->branchtransfer_id, 'Koha::Item->get_transfers returns the active transfer request first');
1046 is( $result_2->branchtransfer_id, $transfer_1->branchtransfer_id, 'Koha::Item->get_transfers returns the other transfers oldest to newest');
1047 is( $result_3->branchtransfer_id, $transfer_3->branchtransfer_id, 'Koha::Item->get_transfers returns the other transfers oldest to newest');
1049 $transfer_2->datearrived(\'NOW()')->store;
1050 $transfers = $item->get_transfers();
1051 is($transfers->count, 2, 'Once a transfer is received, it no longer appears in the list from ->get_transfers()');
1052 $result_1 = $transfers->next;
1053 $result_2 = $transfers->next;
1054 is( $result_1->branchtransfer_id, $transfer_1->branchtransfer_id, 'Koha::Item->get_transfers returns the other transfers oldest to newest');
1055 is( $result_2->branchtransfer_id, $transfer_3->branchtransfer_id, 'Koha::Item->get_transfers returns the other transfers oldest to newest');
1057 $transfer_1->datecancelled(\'NOW()')->store;
1058 $transfers = $item->get_transfers();
1059 is($transfers->count, 1, 'Once a transfer is cancelled, it no longer appears in the list from ->get_transfers()');
1060 $result_1 = $transfers->next;
1061 is( $result_1->branchtransfer_id, $transfer_3->branchtransfer_id, 'Koha::Item->get_transfers returns the only transfer that remains');
1063 $schema->storage->txn_rollback;
1066 subtest 'Tests for relationship between item and item_orders via aqorders_item' => sub {
1069 $schema->storage->txn_begin;
1071 my $biblio = $builder->build_sample_biblio();
1072 my $item = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
1074 my $orders = $item->orders;
1075 is ($orders->count, 0, 'No order on this item yet');
1077 my $order_note = 'Order for ' . $item->itemnumber;
1079 my $aq_order1 = $builder->build_object({
1080 class => 'Koha::Acquisition::Orders',
1082 biblionumber => $biblio->biblionumber,
1083 order_internalnote => $order_note,
1086 my $aq_order2 = $builder->build_object({
1087 class => 'Koha::Acquisition::Orders',
1089 biblionumber => $biblio->biblionumber,
1092 my $aq_order_item1 = $builder->build({
1093 source => 'AqordersItem',
1095 ordernumber => $aq_order1->ordernumber,
1096 itemnumber => $item->itemnumber,
1100 $orders = $item->orders;
1101 is ($orders->count, 1, 'One order found by item with the relationship');
1102 is ($orders->next->order_internalnote, $order_note, 'Correct order found by item with the relationship');
1105 subtest 'move_to_biblio() tests' => sub {
1108 $schema->storage->txn_begin;
1110 my $dbh = C4::Context->dbh;
1112 my $source_biblio = $builder->build_sample_biblio();
1113 my $target_biblio = $builder->build_sample_biblio();
1115 my $source_biblionumber = $source_biblio->biblionumber;
1116 my $target_biblionumber = $target_biblio->biblionumber;
1118 my $item1 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
1119 my $item2 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
1120 my $item3 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
1122 my $itemnumber1 = $item1->itemnumber;
1123 my $itemnumber2 = $item2->itemnumber;
1125 my $library = $builder->build_object({ class => 'Koha::Libraries' });
1127 my $patron = $builder->build_object({
1128 class => 'Koha::Patrons',
1129 value => { branchcode => $library->branchcode }
1131 my $borrowernumber = $patron->borrowernumber;
1133 my $aq_budget = $builder->build({
1134 source => 'Aqbudget',
1136 budget_notes => 'test',
1140 my $aq_order1 = $builder->build_object({
1141 class => 'Koha::Acquisition::Orders',
1143 biblionumber => $source_biblionumber,
1144 budget_id => $aq_budget->{budget_id},
1147 my $aq_order_item1 = $builder->build({
1148 source => 'AqordersItem',
1150 ordernumber => $aq_order1->ordernumber,
1151 itemnumber => $itemnumber1,
1154 my $aq_order2 = $builder->build_object({
1155 class => 'Koha::Acquisition::Orders',
1157 biblionumber => $source_biblionumber,
1158 budget_id => $aq_budget->{budget_id},
1161 my $aq_order_item2 = $builder->build({
1162 source => 'AqordersItem',
1164 ordernumber => $aq_order2->ordernumber,
1165 itemnumber => $itemnumber2,
1169 my $bib_level_hold = $builder->build_object({
1170 class => 'Koha::Holds',
1172 biblionumber => $source_biblionumber,
1173 itemnumber => undef,
1176 my $item_level_hold1 = $builder->build_object({
1177 class => 'Koha::Holds',
1179 biblionumber => $source_biblionumber,
1180 itemnumber => $itemnumber1,
1183 my $item_level_hold2 = $builder->build_object({
1184 class => 'Koha::Holds',
1186 biblionumber => $source_biblionumber,
1187 itemnumber => $itemnumber2,
1191 my $tmp_holdsqueue1 = $builder->build({
1192 source => 'TmpHoldsqueue',
1194 borrowernumber => $borrowernumber,
1195 biblionumber => $source_biblionumber,
1196 itemnumber => $itemnumber1,
1199 my $tmp_holdsqueue2 = $builder->build({
1200 source => 'TmpHoldsqueue',
1202 borrowernumber => $borrowernumber,
1203 biblionumber => $source_biblionumber,
1204 itemnumber => $itemnumber2,
1207 my $hold_fill_target1 = $builder->build({
1208 source => 'HoldFillTarget',
1210 borrowernumber => $borrowernumber,
1211 biblionumber => $source_biblionumber,
1212 itemnumber => $itemnumber1,
1215 my $hold_fill_target2 = $builder->build({
1216 source => 'HoldFillTarget',
1218 borrowernumber => $borrowernumber,
1219 biblionumber => $source_biblionumber,
1220 itemnumber => $itemnumber2,
1223 my $linktracker1 = $builder->build({
1224 source => 'Linktracker',
1226 borrowernumber => $borrowernumber,
1227 biblionumber => $source_biblionumber,
1228 itemnumber => $itemnumber1,
1231 my $linktracker2 = $builder->build({
1232 source => 'Linktracker',
1234 borrowernumber => $borrowernumber,
1235 biblionumber => $source_biblionumber,
1236 itemnumber => $itemnumber2,
1240 my $to_biblionumber_after_move = $item1->move_to_biblio($target_biblio);
1241 is($to_biblionumber_after_move, $target_biblionumber, 'move_to_biblio returns the target biblionumber if success');
1243 $to_biblionumber_after_move = $item1->move_to_biblio($target_biblio);
1244 is($to_biblionumber_after_move, undef, 'move_to_biblio returns undef if the move has failed. If called twice, the item is not attached to the first biblio anymore');
1246 my $get_item1 = Koha::Items->find( $item1->itemnumber );
1247 is($get_item1->biblionumber, $target_biblionumber, 'item1 is moved');
1248 my $get_item2 = Koha::Items->find( $item2->itemnumber );
1249 is($get_item2->biblionumber, $source_biblionumber, 'item2 is not moved');
1250 my $get_item3 = Koha::Items->find( $item3->itemnumber );
1251 is($get_item3->biblionumber, $source_biblionumber, 'item3 is not moved');
1253 $aq_order1->discard_changes;
1254 $aq_order2->discard_changes;
1255 is($aq_order1->biblionumber, $target_biblionumber, 'move_to_biblio moves aq_orders for item 1');
1256 is($aq_order2->biblionumber, $source_biblionumber, 'move_to_biblio does not move aq_orders for item 2');
1258 $bib_level_hold->discard_changes;
1259 $item_level_hold1->discard_changes;
1260 $item_level_hold2->discard_changes;
1261 is($bib_level_hold->biblionumber, $source_biblionumber, 'move_to_biblio does not move the biblio-level hold');
1262 is($item_level_hold1->biblionumber, $target_biblionumber, 'move_to_biblio moves the item-level hold placed on item 1');
1263 is($item_level_hold2->biblionumber, $source_biblionumber, 'move_to_biblio does not move the item-level hold placed on item 2');
1265 my $get_tmp_holdsqueue1 = $schema->resultset('TmpHoldsqueue')->search({ itemnumber => $tmp_holdsqueue1->{itemnumber} })->single;
1266 my $get_tmp_holdsqueue2 = $schema->resultset('TmpHoldsqueue')->search({ itemnumber => $tmp_holdsqueue2->{itemnumber} })->single;
1267 is($get_tmp_holdsqueue1->biblionumber->biblionumber, $target_biblionumber, 'move_to_biblio moves tmp_holdsqueue for item 1');
1268 is($get_tmp_holdsqueue2->biblionumber->biblionumber, $source_biblionumber, 'move_to_biblio does not move tmp_holdsqueue for item 2');
1270 my $get_hold_fill_target1 = $schema->resultset('HoldFillTarget')->search({ itemnumber => $hold_fill_target1->{itemnumber} })->single;
1271 my $get_hold_fill_target2 = $schema->resultset('HoldFillTarget')->search({ itemnumber => $hold_fill_target2->{itemnumber} })->single;
1272 # Why does ->biblionumber return a Biblio object???
1273 is($get_hold_fill_target1->biblionumber->biblionumber, $target_biblionumber, 'move_to_biblio moves hold_fill_targets for item 1');
1274 is($get_hold_fill_target2->biblionumber->biblionumber, $source_biblionumber, 'move_to_biblio does not move hold_fill_targets for item 2');
1276 my $get_linktracker1 = $schema->resultset('Linktracker')->search({ itemnumber => $linktracker1->{itemnumber} })->single;
1277 my $get_linktracker2 = $schema->resultset('Linktracker')->search({ itemnumber => $linktracker2->{itemnumber} })->single;
1278 is($get_linktracker1->biblionumber->biblionumber, $target_biblionumber, 'move_to_biblio moves linktracker for item 1');
1279 is($get_linktracker2->biblionumber->biblionumber, $source_biblionumber, 'move_to_biblio does not move linktracker for item 2');
1281 $schema->storage->txn_rollback;
1284 subtest 'columns_to_str' => sub {
1287 $schema->storage->txn_begin;
1289 my ( $itemtag, $itemsubfield ) = C4::Biblio::GetMarcFromKohaField( "items.itemnumber" );
1291 my $cache = Koha::Caches->get_instance();
1292 $cache->clear_from_cache("MarcStructure-0-");
1293 $cache->clear_from_cache("MarcStructure-1-");
1294 $cache->clear_from_cache("MarcSubfieldStructure-");
1296 # Creating subfields 'é', 'è' that are not linked with a kohafield
1297 Koha::MarcSubfieldStructures->search(
1299 frameworkcode => '',
1300 tagfield => $itemtag,
1301 tagsubfield => ['é', 'è'],
1303 )->delete; # In case it exist already
1305 # é is not linked with a AV
1306 # è is linked with AV branches
1307 Koha::MarcSubfieldStructure->new(
1309 frameworkcode => '',
1310 tagfield => $itemtag,
1311 tagsubfield => 'é',
1314 defaultvalue => 'ééé',
1318 Koha::MarcSubfieldStructure->new(
1320 frameworkcode => '',
1321 tagfield => $itemtag,
1322 tagsubfield => 'è',
1325 defaultvalue => 'èèè',
1327 authorised_value => 'branches',
1331 my $biblio = $builder->build_sample_biblio({ frameworkcode => '' });
1332 my $item = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
1333 my $lost_av = $builder->build_object({ class => 'Koha::AuthorisedValues', value => { category => 'LOST', authorised_value => '42' }});
1334 my $dateaccessioned = '2020-12-15';
1335 my $library = Koha::Libraries->search->next;
1336 my $branchcode = $library->branchcode;
1338 my $some_marc_xml = qq{<?xml version="1.0" encoding="UTF-8"?>
1340 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1341 xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd"
1342 xmlns="http://www.loc.gov/MARC21/slim">
1345 <leader> a </leader>
1346 <datafield tag="999" ind1=" " ind2=" ">
1347 <subfield code="é">value é</subfield>
1348 <subfield code="è">$branchcode</subfield>
1356 itemlost => $lost_av->authorised_value,
1357 dateaccessioned => $dateaccessioned,
1358 more_subfields_xml => $some_marc_xml,
1362 $item = $item->get_from_storage;
1364 my $s = $item->columns_to_str;
1365 is( $s->{itemlost}, $lost_av->lib, 'Attributes linked with AV replaced with description' );
1366 is( $s->{dateaccessioned}, '2020-12-15', 'Date attributes iso formatted');
1367 is( $s->{'é'}, 'value é', 'subfield ok with more than a-Z');
1368 is( $s->{'è'}, $library->branchname );
1370 $cache->clear_from_cache("MarcStructure-0-");
1371 $cache->clear_from_cache("MarcStructure-1-");
1372 $cache->clear_from_cache("MarcSubfieldStructure-");
1374 $schema->storage->txn_rollback;
1378 subtest 'store() tests' => sub {
1382 subtest 'dateaccessioned handling' => sub {
1386 $schema->storage->txn_begin;
1388 my $item = $builder->build_sample_item;
1390 ok( defined $item->dateaccessioned, 'dateaccessioned is set' );
1392 # reset dateaccessioned on the DB
1393 $schema->resultset('Item')->find({ itemnumber => $item->id })->update({ dateaccessioned => undef });
1394 $item->discard_changes;
1396 ok( !defined $item->dateaccessioned );
1399 $item->replacementprice(100)->store->discard_changes;
1401 ok( !defined $item->dateaccessioned, 'dateaccessioned not set on update if undefined' );
1403 $schema->storage->txn_rollback;
1406 subtest '_set_found_trigger() tests' => sub {
1410 $schema->storage->txn_begin;
1412 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
1413 my $item = $builder->build_sample_item({ itemlost => 1, itemlost_on => dt_from_string() });
1415 # Add a lost item debit
1416 my $debit = $patron->account->add_debit(
1420 item_id => $item->id,
1421 interface => 'intranet',
1425 # Add a lost item processing fee
1426 my $processing_debit = $patron->account->add_debit(
1429 type => 'PROCESSING',
1430 item_id => $item->id,
1431 interface => 'intranet',
1435 my $lostreturn_policy = {
1436 lostreturn => 'charge',
1437 processingreturn => 'refund'
1440 my $mocked_circ_rules = Test::MockModule->new('Koha::CirculationRules');
1441 $mocked_circ_rules->mock( 'get_lostreturn_policy', sub { return $lostreturn_policy; } );
1443 # simulate it was found
1444 $item->set( { itemlost => 0 } )->store;
1446 my $messages = $item->object_messages;
1448 my $message_1 = $messages->[0];
1450 is( $message_1->type, 'info', 'type is correct' );
1451 is( $message_1->message, 'lost_refunded', 'message is correct' );
1453 # Find the refund credit
1454 my $credit = $debit->credits->next;
1457 $message_1->payload,
1458 { credit_id => $credit->id },
1462 my $message_2 = $messages->[1];
1464 is( $message_2->type, 'info', 'type is correct' );
1465 is( $message_2->message, 'lost_charge', 'message is correct' );
1466 is( $message_2->payload, undef, 'no payload' );
1468 my $message_3 = $messages->[2];
1469 is( $message_3->message, 'processing_refunded', 'message is correct' );
1471 my $processing_credit = $processing_debit->credits->next;
1473 $message_3->payload,
1474 { credit_id => $processing_credit->id },
1478 $schema->storage->txn_rollback;
1481 subtest 'holds_queue update tests' => sub {
1485 $schema->storage->txn_begin;
1487 my $biblio = $builder->build_sample_biblio;
1489 my $mock = Test::MockModule->new('Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue');
1490 $mock->mock( 'enqueue', sub {
1491 my ( $self, $args ) = @_;
1493 $args->{biblio_ids},
1495 '->store triggers a holds queue update for the related biblio'
1499 t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 1 );
1502 my $item = $builder->build_sample_item({ biblionumber => $biblio->id });
1505 $item->set({ reserves => 1 })->store;
1507 t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
1509 $item->set({ reserves => 0 })->store;
1511 $schema->storage->txn_rollback;
1515 subtest 'Recalls tests' => sub {
1519 $schema->storage->txn_begin;
1521 my $item1 = $builder->build_sample_item;
1522 my $biblio = $item1->biblio;
1523 my $branchcode = $item1->holdingbranch;
1524 my $patron1 = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $branchcode } });
1525 my $patron2 = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $branchcode } });
1526 my $patron3 = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $branchcode } });
1527 my $item2 = $builder->build_object(
1528 { class => 'Koha::Items',
1529 value => { holdingbranch => $branchcode, homebranch => $branchcode, biblionumber => $biblio->biblionumber, itype => $item1->effective_itemtype }
1533 t::lib::Mocks::mock_userenv( { patron => $patron1 } );
1534 t::lib::Mocks::mock_preference('UseRecalls', 1);
1536 my $recall1 = Koha::Recall->new(
1537 { patron_id => $patron1->borrowernumber,
1538 created_date => \'NOW()',
1539 biblio_id => $biblio->biblionumber,
1540 pickup_library_id => $branchcode,
1541 item_id => $item1->itemnumber,
1542 expiration_date => undef,
1546 my $recall2 = Koha::Recall->new(
1547 { patron_id => $patron2->borrowernumber,
1548 created_date => \'NOW()',
1549 biblio_id => $biblio->biblionumber,
1550 pickup_library_id => $branchcode,
1551 item_id => $item1->itemnumber,
1552 expiration_date => undef,
1557 is( $item1->recall->patron_id, $patron1->borrowernumber, 'Correctly returns most relevant recall' );
1559 $recall2->set_cancelled;
1561 t::lib::Mocks::mock_preference('UseRecalls', 0);
1562 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall with UseRecalls disabled" );
1564 t::lib::Mocks::mock_preference("UseRecalls", 1);
1566 $item1->update({ notforloan => 1 });
1567 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall that is not for loan" );
1568 $item1->update({ notforloan => 0, itemlost => 1 });
1569 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall that is marked lost" );
1570 $item1->update({ itemlost => 0, withdrawn => 1 });
1571 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall that is withdrawn" );
1572 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall item if not checked out" );
1574 $item1->update({ withdrawn => 0 });
1575 C4::Circulation::AddIssue( $patron2->unblessed, $item1->barcode );
1577 Koha::CirculationRules->set_rules({
1578 branchcode => $branchcode,
1579 categorycode => $patron1->categorycode,
1580 itemtype => $item1->effective_itemtype,
1582 recalls_allowed => 0,
1583 recalls_per_record => 1,
1584 on_shelf_recalls => 'all',
1587 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall if recalls_allowed = 0" );
1589 Koha::CirculationRules->set_rules({
1590 branchcode => $branchcode,
1591 categorycode => $patron1->categorycode,
1592 itemtype => $item1->effective_itemtype,
1594 recalls_allowed => 1,
1595 recalls_per_record => 1,
1596 on_shelf_recalls => 'all',
1599 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall if patron has more existing recall(s) than recalls_allowed" );
1600 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall if patron has more existing recall(s) than recalls_per_record" );
1601 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall if patron has already recalled this item" );
1603 my $reserve_id = C4::Reserves::AddReserve({ branchcode => $branchcode, borrowernumber => $patron1->borrowernumber, biblionumber => $item1->biblionumber, itemnumber => $item1->itemnumber });
1604 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall item if patron has already reserved it" );
1605 C4::Reserves::ModReserve({ rank => 'del', reserve_id => $reserve_id, branchcode => $branchcode, itemnumber => $item1->itemnumber, borrowernumber => $patron1->borrowernumber, biblionumber => $item1->biblionumber });
1607 $recall1->set_cancelled;
1608 is( $item1->can_be_recalled({ patron => $patron2 }), 0, "Can't recall if patron has already checked out an item attached to this biblio" );
1610 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall if on_shelf_recalls = all and items are still available" );
1612 Koha::CirculationRules->set_rules({
1613 branchcode => $branchcode,
1614 categorycode => $patron1->categorycode,
1615 itemtype => $item1->effective_itemtype,
1617 recalls_allowed => 1,
1618 recalls_per_record => 1,
1619 on_shelf_recalls => 'any',
1622 C4::Circulation::AddReturn( $item1->barcode, $branchcode );
1623 is( $item1->can_be_recalled({ patron => $patron1 }), 0, "Can't recall if no items are checked out" );
1625 C4::Circulation::AddIssue( $patron2->unblessed, $item1->barcode );
1626 is( $item1->can_be_recalled({ patron => $patron1 }), 1, "Can recall item" );
1628 $recall1 = Koha::Recall->new(
1629 { patron_id => $patron1->borrowernumber,
1630 created_date => \'NOW()',
1631 biblio_id => $biblio->biblionumber,
1632 pickup_library_id => $branchcode,
1634 expiration_date => undef,
1639 # Patron2 has Item1 checked out. Patron1 has placed a biblio-level recall on Biblio1, so check if Item1 can fulfill Patron1's recall.
1641 Koha::CirculationRules->set_rules({
1642 branchcode => undef,
1643 categorycode => undef,
1644 itemtype => $item1->effective_itemtype,
1646 recalls_allowed => 0,
1647 recalls_per_record => 1,
1648 on_shelf_recalls => 'any',
1651 is( $item1->can_be_waiting_recall, 0, "Recalls not allowed for this itemtype" );
1653 Koha::CirculationRules->set_rules({
1654 branchcode => undef,
1655 categorycode => undef,
1656 itemtype => $item1->effective_itemtype,
1658 recalls_allowed => 1,
1659 recalls_per_record => 1,
1660 on_shelf_recalls => 'any',
1663 is( $item1->can_be_waiting_recall, 1, "Recalls are allowed for this itemtype" );
1665 # check_recalls tests
1667 $recall1 = Koha::Recall->new(
1668 { patron_id => $patron2->borrowernumber,
1669 created_date => \'NOW()',
1670 biblio_id => $biblio->biblionumber,
1671 pickup_library_id => $branchcode,
1672 item_id => $item1->itemnumber,
1673 expiration_date => undef,
1677 $recall2 = Koha::Recall->new(
1678 { patron_id => $patron1->borrowernumber,
1679 created_date => \'NOW()',
1680 biblio_id => $biblio->biblionumber,
1681 pickup_library_id => $branchcode,
1683 expiration_date => undef,
1687 $recall2->set_waiting( { item => $item1 } );
1688 is( $item1->has_pending_recall, 1, 'Item has pending recall' );
1690 # return a waiting recall
1691 my $check_recall = $item1->check_recalls;
1692 is( $check_recall->patron_id, $patron1->borrowernumber, "Waiting recall is highest priority and returned" );
1694 $recall2->revert_waiting;
1696 is( $item1->has_pending_recall, 0, 'Item does not have pending recall' );
1698 # return recall based on recalldate
1699 $check_recall = $item1->check_recalls;
1700 is( $check_recall->patron_id, $patron1->borrowernumber, "No waiting recall, so oldest recall is returned" );
1702 $recall1->set_cancelled;
1704 # return a biblio-level recall
1705 $check_recall = $item1->check_recalls;
1706 is( $check_recall->patron_id, $patron1->borrowernumber, "Only remaining recall is returned" );
1708 $recall2->set_cancelled;
1710 $schema->storage->txn_rollback;
1713 subtest 'Notforloan tests' => sub {
1717 $schema->storage->txn_begin;
1719 my $item1 = $builder->build_sample_item;
1720 $item1->update({ notforloan => 0 });
1721 $item1->itemtype->notforloan(0);
1722 is ( $item1->is_notforloan, 0, 'Notforloan is correctly false by item status and item type');
1723 $item1->update({ notforloan => 1 });
1724 is ( $item1->is_notforloan, 1, 'Notforloan is correctly true by item status');
1725 $item1->update({ notforloan => 0 });
1726 $item1->itemtype->update({ notforloan => 1 });
1727 is ( $item1->is_notforloan, 1, 'Notforloan is correctly true by item type');
1729 $schema->storage->txn_rollback;
1732 subtest 'item_group() tests' => sub {
1736 $schema->storage->txn_begin;
1738 my $biblio = $builder->build_sample_biblio();
1739 my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
1740 my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
1742 is( $item_1->item_group, undef, 'Item 1 has no item group');
1743 is( $item_2->item_group, undef, 'Item 2 has no item group');
1745 my $item_group_1 = Koha::Biblio::ItemGroup->new( { biblio_id => $biblio->id } )->store();
1746 my $item_group_2 = Koha::Biblio::ItemGroup->new( { biblio_id => $biblio->id } )->store();
1748 $item_group_1->add_item({ item_id => $item_1->id });
1749 $item_group_2->add_item({ item_id => $item_2->id });
1751 is( $item_1->item_group->id, $item_group_1->id, 'Got item group 1 correctly' );
1752 is( $item_2->item_group->id, $item_group_2->id, 'Got item group 2 correctly' );
1754 $schema->storage->txn_rollback;
1757 subtest 'has_pending_recall() tests' => sub {
1761 $schema->storage->txn_begin;
1763 my $library = $builder->build_object({ class => 'Koha::Libraries' });
1764 my $item = $builder->build_sample_item;
1765 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
1767 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
1768 t::lib::Mocks::mock_preference( 'UseRecalls', 1 );
1770 C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
1772 my ($recall) = Koha::Recalls->add_recall({ biblio => $item->biblio, item => $item, patron => $patron });
1774 ok( !$item->has_pending_recall, 'The item has no pending recalls' );
1776 $recall->status('waiting')->store;
1778 ok( $item->has_pending_recall, 'The item has a pending recall' );
1780 $schema->storage->txn_rollback;
1783 subtest 'is_denied_renewal' => sub {
1786 $schema->storage->txn_begin;
1788 my $library = $builder->build_object({ class => 'Koha::Libraries'});
1790 my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
1791 homebranch => $library->branchcode,
1795 itemcallnumber => undef,
1800 my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
1801 homebranch => $library->branchcode,
1804 location => 'NOPROC'
1809 C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
1810 is( $deny_book->is_denied_renewal, 0, 'Renewal allowed when no rules' );
1812 $idr_rules="withdrawn: [1]";
1813 C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
1814 is( $deny_book->is_denied_renewal, 1, 'Renewal blocked when 1 rules (withdrawn)' );
1815 is( $allow_book->is_denied_renewal, 0, 'Renewal allowed when 1 rules not matched (withdrawn)' );
1817 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
1818 is( $deny_book->is_denied_renewal, 1, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
1819 is( $allow_book->is_denied_renewal, 0, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
1821 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
1822 C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
1823 is( $deny_book->is_denied_renewal, 1, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
1824 is( $allow_book->is_denied_renewal, 0, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
1826 $idr_rules="itemcallnumber: [NULL]";
1827 C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
1828 is( $deny_book->is_denied_renewal, 1, 'Renewal blocked for undef when NULL in pref' );
1830 $idr_rules="itemcallnumber: ['']";
1831 C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
1832 is( $deny_book->is_denied_renewal, 0, 'Renewal not blocked for undef when "" in pref' );
1834 $idr_rules="itemnotes: [NULL]";
1835 C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
1836 is( $deny_book->is_denied_renewal, 0, 'Renewal not blocked for "" when NULL in pref' );
1838 $idr_rules="itemnotes: ['']";
1839 C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
1840 is( $deny_book->is_denied_renewal, 1, 'Renewal blocked for empty string when "" in pref' );
1842 $schema->storage->txn_rollback;