3 # Copyright 2019 Koha Development team
5 # This file is part of Koha
7 # Koha is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 3 of the License, or
10 # (at your option) any later version.
12 # Koha is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
22 use Test::More tests => 6;
31 use t::lib::TestBuilder;
34 my $schema = Koha::Database->new->schema;
35 my $builder = t::lib::TestBuilder->new;
37 subtest 'hidden_in_opac() tests' => sub {
41 $schema->storage->txn_begin;
43 my $item = $builder->build_sample_item({ itemlost => 2 });
46 # disable hidelostitems as it interteres with OpachiddenItems for the calculation
47 t::lib::Mocks::mock_preference( 'hidelostitems', 0 );
49 ok( !$item->hidden_in_opac, 'No rules passed, shouldn\'t hide' );
50 ok( !$item->hidden_in_opac({ rules => $rules }), 'Empty rules passed, shouldn\'t hide' );
52 # enable hidelostitems to verify correct behaviour
53 t::lib::Mocks::mock_preference( 'hidelostitems', 1 );
54 ok( $item->hidden_in_opac, 'Even with no rules, item should hide because of hidelostitems syspref' );
56 # disable hidelostitems
57 t::lib::Mocks::mock_preference( 'hidelostitems', 0 );
58 my $withdrawn = $item->withdrawn + 1; # make sure this attribute doesn't match
60 $rules = { withdrawn => [$withdrawn], itype => [ $item->itype ] };
62 ok( $item->hidden_in_opac({ rules => $rules }), 'Rule matching itype passed, should hide' );
66 $schema->storage->txn_rollback;
69 subtest 'has_pending_hold() tests' => sub {
73 $schema->storage->txn_begin;
75 my $dbh = C4::Context->dbh;
76 my $item = $builder->build_sample_item({ itemlost => 0 });
77 my $itemnumber = $item->itemnumber;
79 $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber) VALUES ('Clamp',42,$itemnumber)");
80 ok( $item->has_pending_hold, "Yes, we have a pending hold");
81 $dbh->do("DELETE FROM tmp_holdsqueue WHERE itemnumber=$itemnumber");
82 ok( !$item->has_pending_hold, "We don't have a pending hold if nothing in the tmp_holdsqueue");
84 $schema->storage->txn_rollback;
87 subtest "as_marc_field() tests" => sub {
89 my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
91 my @schema_columns = $schema->resultset('Item')->result_source->columns;
92 my @mapped_columns = grep { exists $mss->{'items.'.$_} } @schema_columns;
94 plan tests => 2 * (scalar @mapped_columns + 1) + 1;
96 $schema->storage->txn_begin;
98 my $item = $builder->build_sample_item;
100 # Tests with the mss parameter
101 my $marc_field = $item->as_marc_field({ mss => $mss });
105 $mss->{'items.itemnumber'}[0]->{tagfield},
106 'Generated field set the right tag number'
109 foreach my $column ( @mapped_columns ) {
110 my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
111 is( $marc_field->subfield($tagsubfield),
112 $item->$column, "Value is mapped correctly for column $column" );
115 # Tests without the mss parameter
116 $marc_field = $item->as_marc_field();
120 $mss->{'items.itemnumber'}[0]->{tagfield},
121 'Generated field set the right tag number'
124 foreach my $column (@mapped_columns) {
125 my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
126 is( $marc_field->subfield($tagsubfield),
127 $item->$column, "Value is mapped correctly for column $column" );
130 my $unmapped_subfield = Koha::MarcSubfieldStructure->new(
133 tagfield => $mss->{'items.itemnumber'}[0]->{tagfield},
138 $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 0 } );
139 my @unlinked_subfields;
140 push @unlinked_subfields, X => 'Something weird';
141 $item->more_subfields_xml( C4::Items::_get_unlinked_subfields_xml( \@unlinked_subfields ) )->store;
143 $marc_field = $item->as_marc_field;
144 is( scalar $marc_field->subfield('X'), 'Something weird', 'more_subfield_xml is considered' );
146 $schema->storage->txn_rollback;
149 subtest 'pickup_locations' => sub {
152 $schema->storage->txn_begin;
154 my $dbh = C4::Context->dbh;
157 Koha::Holds->search->delete;
158 $dbh->do('DELETE FROM issues');
159 Koha::Patrons->search->delete;
160 Koha::Items->search->delete;
161 Koha::Libraries->search->delete;
162 Koha::CirculationRules->search->delete;
163 Koha::CirculationRules->set_rules(
165 categorycode => undef,
169 reservesallowed => 25,
174 my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
175 my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
176 my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
177 my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
178 my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, } } );
179 my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
180 my $group1_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );
181 my $group1_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );
183 my $group2_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library3->branchcode } } );
184 my $group2_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library4->branchcode } } );
186 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
188 my $item1 = Koha::Item->new({
189 biblionumber => $biblioitem->{biblionumber},
190 biblioitemnumber => $biblioitem->{biblioitemnumber},
191 homebranch => $library1->branchcode,
192 holdingbranch => $library2->branchcode,
197 my $item3 = Koha::Item->new({
198 biblionumber => $biblioitem->{biblionumber},
199 biblioitemnumber => $biblioitem->{biblioitemnumber},
200 homebranch => $library3->branchcode,
201 holdingbranch => $library4->branchcode,
206 my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library1->branchcode, firstname => '1' } } );
207 my $patron4 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library4->branchcode, firstname => '4' } } );
211 "1-1-1-holdgroup" => 2,
212 "1-1-1-patrongroup" => 2,
213 "1-1-1-homebranch" => 1,
214 "1-1-1-holdingbranch" => 1,
216 "1-1-2-holdgroup" => 2,
217 "1-1-2-patrongroup" => 2,
218 "1-1-2-homebranch" => 1,
219 "1-1-2-holdingbranch" => 1,
221 "1-1-3-holdgroup" => 2,
222 "1-1-3-patrongroup" => 2,
223 "1-1-3-homebranch" => 1,
224 "1-1-3-holdingbranch" => 1,
226 "1-4-1-holdgroup" => 0,
227 "1-4-1-patrongroup" => 0,
228 "1-4-1-homebranch" => 0,
229 "1-4-1-holdingbranch" => 0,
231 "1-4-2-holdgroup" => 2,
232 "1-4-2-patrongroup" => 1,
233 "1-4-2-homebranch" => 1,
234 "1-4-2-holdingbranch" => 1,
236 "1-4-3-holdgroup" => 0,
237 "1-4-3-patrongroup" => 0,
238 "1-4-3-homebranch" => 0,
239 "1-4-3-holdingbranch" => 0,
241 "3-1-1-holdgroup" => 0,
242 "3-1-1-patrongroup" => 0,
243 "3-1-1-homebranch" => 0,
244 "3-1-1-holdingbranch" => 0,
246 "3-1-2-holdgroup" => 1,
247 "3-1-2-patrongroup" => 2,
248 "3-1-2-homebranch" => 0,
249 "3-1-2-holdingbranch" => 1,
251 "3-1-3-holdgroup" => 0,
252 "3-1-3-patrongroup" => 0,
253 "3-1-3-homebranch" => 0,
254 "3-1-3-holdingbranch" => 0,
256 "3-4-1-holdgroup" => 0,
257 "3-4-1-patrongroup" => 0,
258 "3-4-1-homebranch" => 0,
259 "3-4-1-holdingbranch" => 0,
261 "3-4-2-holdgroup" => 1,
262 "3-4-2-patrongroup" => 1,
263 "3-4-2-homebranch" => 0,
264 "3-4-2-holdingbranch" => 1,
266 "3-4-3-holdgroup" => 1,
267 "3-4-3-patrongroup" => 1,
268 "3-4-3-homebranch" => 0,
269 "3-4-3-holdingbranch" => 1
273 my ( $item, $patron, $ha, $hfp, $results ) = @_;
275 Koha::CirculationRules->set_rules(
281 hold_fulfillment_policy => $hfp,
282 returnbranch => 'any'
286 my @pl = $item->pickup_locations( { patron => $patron} );
287 my $ha_value=$ha==3?'holdgroup':($ha==2?'any':'homebranch');
289 foreach my $pickup_location (@pl) {
290 is( ref($pickup_location), 'Koha::Library', 'Object type is correct' );
293 scalar(@pl) == $results->{
295 . $patron->firstname . '-'
305 . ', hold_fulfillment_policy: '
310 . $patron->firstname . '-'
321 foreach my $item ($item1, $item3) {
322 foreach my $patron ($patron1, $patron4) {
323 #holdallowed 1: homebranch, 2: any, 3: holdgroup
324 foreach my $ha (1, 2, 3) {
325 foreach my $hfp ('any', 'holdgroup', 'patrongroup', 'homebranch', 'holdingbranch') {
326 _doTest($item, $patron, $ha, $hfp, $results);
332 $schema->storage->txn_rollback;
335 subtest 'deletion' => sub {
338 $schema->storage->txn_begin;
340 my $biblio = $builder->build_sample_biblio();
342 my $item = $builder->build_sample_item(
344 biblionumber => $biblio->biblionumber,
348 is( ref( $item->move_to_deleted ), 'Koha::Schema::Result::Deleteditem', 'Koha::Item->move_to_deleted should return the Deleted item' )
349 ; # FIXME This should be Koha::Deleted::Item
350 is( Koha::Old::Items->search({itemnumber => $item->itemnumber})->count, 1, '->move_to_deleted must have moved the item to deleteditem' );
351 $item = $builder->build_sample_item(
353 biblionumber => $biblio->biblionumber,
357 is( Koha::Old::Items->search({itemnumber => $item->itemnumber})->count, 0, '->move_to_deleted must not have moved the item to deleteditem' );
360 my $library = $builder->build_object({ class => 'Koha::Libraries' });
361 my $library_2 = $builder->build_object({ class => 'Koha::Libraries' });
362 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
364 my $patron = $builder->build_object({class => 'Koha::Patrons'});
365 $item = $builder->build_sample_item({ library => $library->branchcode });
368 C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
371 $item->safe_to_delete,
373 'Koha::Item->safe_to_delete reports item on loan',
379 'item that is on loan cannot be deleted',
382 AddReturn( $item->barcode, $library->branchcode );
384 # book_reserved is tested in t/db_dependent/Reserves.t
387 t::lib::Mocks::mock_preference('IndependentBranches', 1);
388 my $item_2 = $builder->build_sample_item({ library => $library_2->branchcode });
391 $item_2->safe_to_delete,
393 'Koha::Item->safe_to_delete reports IndependentBranches restriction',
397 $item_2->safe_delete,
399 'IndependentBranches prevents deletion at another branch',
404 { # codeblock to limit scope of $module->mock
406 my $module = Test::MockModule->new('C4::Items');
407 $module->mock( GetAnalyticsCount => sub { return 1 } );
409 $item->discard_changes;
411 $item->safe_to_delete,
413 'Koha::Item->safe_to_delete reports linked analytics',
419 'Linked analytics prevents deletion of item',
425 $item->safe_to_delete,
427 'Koha::Item->safe_to_delete shows item safe to delete'
432 my $test_item = Koha::Items->find( $item->itemnumber );
434 is( $test_item, undef,
435 "Koha::Item->safe_delete should delete item if safe_to_delete returns true"
438 $schema->storage->txn_rollback;
441 subtest 'renewal_branchcode' => sub {
444 $schema->storage->txn_begin;
446 my $item = $builder->build_sample_item();
447 my $branch = $builder->build_object({ class => 'Koha::Libraries' });
448 my $checkout = $builder->build_object({
449 class => 'Koha::Checkouts',
451 itemnumber => $item->itemnumber,
456 C4::Context->interface( 'intranet' );
457 t::lib::Mocks::mock_userenv({ branchcode => $branch->branchcode });
459 is( $item->renewal_branchcode, $branch->branchcode, "If interface not opac, we get the branch from context");
460 is( $item->renewal_branchcode({ branch => "PANDA"}), $branch->branchcode, "If interface not opac, we get the branch from context even if we pass one in");
461 C4::Context->set_userenv(51, 'userid4tests', undef, 'firstname', 'surname', undef, undef, 0, undef, undef, undef ); #mock userenv doesn't let us set null branch
462 is( $item->renewal_branchcode({ branch => "PANDA"}), "PANDA", "If interface not opac, we get the branch we pass one in if context not set");
464 C4::Context->interface( 'opac' );
466 t::lib::Mocks::mock_preference('OpacRenewalBranch', undef);
467 is( $item->renewal_branchcode, 'OPACRenew', "If interface opac and OpacRenewalBranch undef, we get OPACRenew");
468 is( $item->renewal_branchcode({branch=>'COW'}), 'OPACRenew', "If interface opac and OpacRenewalBranch undef, we get OPACRenew even if branch passed");
470 t::lib::Mocks::mock_preference('OpacRenewalBranch', 'none');
471 is( $item->renewal_branchcode, '', "If interface opac and OpacRenewalBranch is none, we get blank string");
472 is( $item->renewal_branchcode({branch=>'COW'}), '', "If interface opac and OpacRenewalBranch is none, we get blank string even if branch passed");
474 t::lib::Mocks::mock_preference('OpacRenewalBranch', 'checkoutbranch');
475 is( $item->renewal_branchcode, $checkout->branchcode, "If interface opac and OpacRenewalBranch set to checkoutbranch, we get branch of checkout");
476 is( $item->renewal_branchcode({branch=>'MONKEY'}), $checkout->branchcode, "If interface opac and OpacRenewalBranch set to checkoutbranch, we get branch of checkout even if branch passed");
478 t::lib::Mocks::mock_preference('OpacRenewalBranch','patronhomebranch');
479 is( $item->renewal_branchcode, $checkout->patron->branchcode, "If interface opac and OpacRenewalBranch set to patronbranch, we get branch of patron");
480 is( $item->renewal_branchcode({branch=>'TURKEY'}), $checkout->patron->branchcode, "If interface opac and OpacRenewalBranch set to patronbranch, we get branch of patron even if branch passed");
482 t::lib::Mocks::mock_preference('OpacRenewalBranch','itemhomebranch');
483 is( $item->renewal_branchcode, $item->homebranch, "If interface opac and OpacRenewalBranch set to itemhomebranch, we get homebranch of item");
484 is( $item->renewal_branchcode({branch=>'MANATEE'}), $item->homebranch, "If interface opac and OpacRenewalBranch set to itemhomebranch, we get homebranch of item even if branch passed");