3 # Copyright 2019 Koha Development team
5 # This file is part of Koha
7 # Koha is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 3 of the License, or
10 # (at your option) any later version.
12 # Koha is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
22 use Test::More tests => 7;
31 use List::MoreUtils qw(all);
33 use t::lib::TestBuilder;
36 my $schema = Koha::Database->new->schema;
37 my $builder = t::lib::TestBuilder->new;
39 subtest 'hidden_in_opac() tests' => sub {
43 $schema->storage->txn_begin;
45 my $item = $builder->build_sample_item({ itemlost => 2 });
48 # disable hidelostitems as it interteres with OpachiddenItems for the calculation
49 t::lib::Mocks::mock_preference( 'hidelostitems', 0 );
51 ok( !$item->hidden_in_opac, 'No rules passed, shouldn\'t hide' );
52 ok( !$item->hidden_in_opac({ rules => $rules }), 'Empty rules passed, shouldn\'t hide' );
54 # enable hidelostitems to verify correct behaviour
55 t::lib::Mocks::mock_preference( 'hidelostitems', 1 );
56 ok( $item->hidden_in_opac, 'Even with no rules, item should hide because of hidelostitems syspref' );
58 # disable hidelostitems
59 t::lib::Mocks::mock_preference( 'hidelostitems', 0 );
60 my $withdrawn = $item->withdrawn + 1; # make sure this attribute doesn't match
62 $rules = { withdrawn => [$withdrawn], itype => [ $item->itype ] };
64 ok( $item->hidden_in_opac({ rules => $rules }), 'Rule matching itype passed, should hide' );
68 $schema->storage->txn_rollback;
71 subtest 'has_pending_hold() tests' => sub {
75 $schema->storage->txn_begin;
77 my $dbh = C4::Context->dbh;
78 my $item = $builder->build_sample_item({ itemlost => 0 });
79 my $itemnumber = $item->itemnumber;
81 $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber) VALUES ('Clamp',42,$itemnumber)");
82 ok( $item->has_pending_hold, "Yes, we have a pending hold");
83 $dbh->do("DELETE FROM tmp_holdsqueue WHERE itemnumber=$itemnumber");
84 ok( !$item->has_pending_hold, "We don't have a pending hold if nothing in the tmp_holdsqueue");
86 $schema->storage->txn_rollback;
89 subtest "as_marc_field() tests" => sub {
91 my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
93 my @schema_columns = $schema->resultset('Item')->result_source->columns;
94 my @mapped_columns = grep { exists $mss->{'items.'.$_} } @schema_columns;
96 plan tests => 2 * (scalar @mapped_columns + 1) + 2;
98 $schema->storage->txn_begin;
100 my $item = $builder->build_sample_item;
101 # Make sure it has at least one undefined attribute
102 $item->set({ replacementprice => undef })->store->discard_changes;
104 # Tests with the mss parameter
105 my $marc_field = $item->as_marc_field({ mss => $mss });
109 $mss->{'items.itemnumber'}[0]->{tagfield},
110 'Generated field set the right tag number'
113 foreach my $column ( @mapped_columns ) {
114 my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
115 is( $marc_field->subfield($tagsubfield),
116 $item->$column, "Value is mapped correctly for column $column" );
119 # Tests without the mss parameter
120 $marc_field = $item->as_marc_field();
124 $mss->{'items.itemnumber'}[0]->{tagfield},
125 'Generated field set the right tag number'
128 foreach my $column (@mapped_columns) {
129 my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
130 is( $marc_field->subfield($tagsubfield),
131 $item->$column, "Value is mapped correctly for column $column" );
134 my $unmapped_subfield = Koha::MarcSubfieldStructure->new(
137 tagfield => $mss->{'items.itemnumber'}[0]->{tagfield},
142 $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 0 } );
143 my @unlinked_subfields;
144 push @unlinked_subfields, X => 'Something weird';
145 $item->more_subfields_xml( C4::Items::_get_unlinked_subfields_xml( \@unlinked_subfields ) )->store;
147 $marc_field = $item->as_marc_field;
149 my @subfields = $marc_field->subfields;
150 my $result = all { defined $_->[1] } @subfields;
151 ok( $result, 'There are no undef subfields' );
153 is( scalar $marc_field->subfield('X'), 'Something weird', 'more_subfield_xml is considered' );
155 $schema->storage->txn_rollback;
158 subtest 'pickup_locations' => sub {
161 $schema->storage->txn_begin;
163 my $dbh = C4::Context->dbh;
166 Koha::Holds->search->delete;
167 $dbh->do('DELETE FROM issues');
168 Koha::Patrons->search->delete;
169 Koha::Items->search->delete;
170 Koha::Libraries->search->delete;
171 Koha::CirculationRules->search->delete;
172 Koha::CirculationRules->set_rules(
174 categorycode => undef,
178 reservesallowed => 25,
183 my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
184 my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
185 my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
186 my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
187 my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, } } );
188 my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } );
189 my $group1_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );
190 my $group1_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );
192 my $group2_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library3->branchcode } } );
193 my $group2_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library4->branchcode } } );
195 my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes', value => { itemtype => 'test' } } );
196 my $item1 = $builder->build_sample_item(
198 homebranch => $library1->branchcode,
199 holdingbranch => $library2->branchcode,
206 my $item3 = $builder->build_sample_item(
208 homebranch => $library3->branchcode,
209 holdingbranch => $library4->branchcode,
215 my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library1->branchcode, firstname => '1' } } );
216 my $patron4 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library4->branchcode, firstname => '4' } } );
220 "1-1-1-holdgroup" => 2,
221 "1-1-1-patrongroup" => 2,
222 "1-1-1-homebranch" => 1,
223 "1-1-1-holdingbranch" => 1,
225 "1-1-2-holdgroup" => 2,
226 "1-1-2-patrongroup" => 2,
227 "1-1-2-homebranch" => 1,
228 "1-1-2-holdingbranch" => 1,
230 "1-1-3-holdgroup" => 2,
231 "1-1-3-patrongroup" => 2,
232 "1-1-3-homebranch" => 1,
233 "1-1-3-holdingbranch" => 1,
235 "1-4-1-holdgroup" => 0,
236 "1-4-1-patrongroup" => 0,
237 "1-4-1-homebranch" => 0,
238 "1-4-1-holdingbranch" => 0,
240 "1-4-2-holdgroup" => 2,
241 "1-4-2-patrongroup" => 1,
242 "1-4-2-homebranch" => 1,
243 "1-4-2-holdingbranch" => 1,
245 "1-4-3-holdgroup" => 0,
246 "1-4-3-patrongroup" => 0,
247 "1-4-3-homebranch" => 0,
248 "1-4-3-holdingbranch" => 0,
250 "3-1-1-holdgroup" => 0,
251 "3-1-1-patrongroup" => 0,
252 "3-1-1-homebranch" => 0,
253 "3-1-1-holdingbranch" => 0,
255 "3-1-2-holdgroup" => 1,
256 "3-1-2-patrongroup" => 2,
257 "3-1-2-homebranch" => 0,
258 "3-1-2-holdingbranch" => 1,
260 "3-1-3-holdgroup" => 0,
261 "3-1-3-patrongroup" => 0,
262 "3-1-3-homebranch" => 0,
263 "3-1-3-holdingbranch" => 0,
265 "3-4-1-holdgroup" => 0,
266 "3-4-1-patrongroup" => 0,
267 "3-4-1-homebranch" => 0,
268 "3-4-1-holdingbranch" => 0,
270 "3-4-2-holdgroup" => 1,
271 "3-4-2-patrongroup" => 1,
272 "3-4-2-homebranch" => 0,
273 "3-4-2-holdingbranch" => 1,
275 "3-4-3-holdgroup" => 1,
276 "3-4-3-patrongroup" => 1,
277 "3-4-3-homebranch" => 0,
278 "3-4-3-holdingbranch" => 1
282 my ( $item, $patron, $ha, $hfp, $results ) = @_;
284 Koha::CirculationRules->set_rules(
290 hold_fulfillment_policy => $hfp,
291 returnbranch => 'any'
295 my @pl = $item->pickup_locations( { patron => $patron} )->as_list;
296 my $ha_value=$ha==3?'holdgroup':($ha==2?'any':'homebranch');
298 foreach my $pickup_location (@pl) {
299 is( ref($pickup_location), 'Koha::Library', 'Object type is correct' );
302 scalar(@pl) == $results->{
304 . $patron->firstname . '-'
314 . ', hold_fulfillment_policy: '
319 . $patron->firstname . '-'
330 foreach my $item ($item1, $item3) {
331 foreach my $patron ($patron1, $patron4) {
332 #holdallowed 1: homebranch, 2: any, 3: holdgroup
333 foreach my $ha (1, 2, 3) {
334 foreach my $hfp ('any', 'holdgroup', 'patrongroup', 'homebranch', 'holdingbranch') {
335 _doTest($item, $patron, $ha, $hfp, $results);
341 # Now test that branchtransferlimits will further filter the pickup locations
342 t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);
343 t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype');
344 Koha::CirculationRules->set_rules(
347 itemtype => $item1->itype,
350 hold_fulfillment_policy => 1,
351 returnbranch => 'any'
355 $builder->build_object(
357 class => 'Koha::Item::Transfer::Limits',
359 toBranch => $library1->branchcode,
360 fromBranch => $library2->branchcode,
361 itemtype => $item1->itype,
367 my $pickup_locations = $item1->pickup_locations( { patron => $patron1 } )->as_list;
368 is( scalar @$pickup_locations, 2, "With a transfer limits we get back the libraries that are pickup locations minus 1 limited library");
370 $builder->build_object(
372 class => 'Koha::Item::Transfer::Limits',
374 toBranch => $library4->branchcode,
375 fromBranch => $library2->branchcode,
376 itemtype => $item1->itype,
382 $pickup_locations = $item1->pickup_locations( { patron => $patron1 } )->as_list;
383 is( scalar @$pickup_locations, 1, "With 2 transfer limits we get back the libraries that are pickup locations minus 2 limited libraries");
385 t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'ccode');
386 $pickup_locations = $item1->pickup_locations( { patron => $patron1 } )->as_list;
387 is( scalar @$pickup_locations, 3, "With no transfer limits of type ccode we get back the libraries that are pickup locations");
389 $builder->build_object(
391 class => 'Koha::Item::Transfer::Limits',
393 toBranch => $library2->branchcode,
394 fromBranch => $library2->branchcode,
396 ccode => $item1->ccode,
401 $pickup_locations = $item1->pickup_locations( { patron => $patron1 } )->as_list;
402 is( scalar @$pickup_locations, 2, "With a transfer limits we get back the libraries that are pickup locations minus 1 limited library");
404 $builder->build_object(
406 class => 'Koha::Item::Transfer::Limits',
408 toBranch => $library4->branchcode,
409 fromBranch => $library2->branchcode,
411 ccode => $item1->ccode,
416 $pickup_locations = $item1->pickup_locations( { patron => $patron1 } )->as_list;
417 is( scalar @$pickup_locations, 1, "With 2 transfer limits we get back the libraries that are pickup locations minus 2 limited libraries");
419 t::lib::Mocks::mock_preference('UseBranchTransferLimits', 0);
421 $schema->storage->txn_rollback;
424 subtest 'deletion' => sub {
427 $schema->storage->txn_begin;
429 my $biblio = $builder->build_sample_biblio();
431 my $item = $builder->build_sample_item(
433 biblionumber => $biblio->biblionumber,
437 is( ref( $item->move_to_deleted ), 'Koha::Schema::Result::Deleteditem', 'Koha::Item->move_to_deleted should return the Deleted item' )
438 ; # FIXME This should be Koha::Deleted::Item
439 is( Koha::Old::Items->search({itemnumber => $item->itemnumber})->count, 1, '->move_to_deleted must have moved the item to deleteditem' );
440 $item = $builder->build_sample_item(
442 biblionumber => $biblio->biblionumber,
446 is( Koha::Old::Items->search({itemnumber => $item->itemnumber})->count, 0, '->move_to_deleted must not have moved the item to deleteditem' );
449 my $library = $builder->build_object({ class => 'Koha::Libraries' });
450 my $library_2 = $builder->build_object({ class => 'Koha::Libraries' });
451 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
453 my $patron = $builder->build_object({class => 'Koha::Patrons'});
454 $item = $builder->build_sample_item({ library => $library->branchcode });
457 C4::Circulation::AddIssue( $patron->unblessed, $item->barcode );
460 $item->safe_to_delete,
462 'Koha::Item->safe_to_delete reports item on loan',
468 'item that is on loan cannot be deleted',
471 AddReturn( $item->barcode, $library->branchcode );
473 # book_reserved is tested in t/db_dependent/Reserves.t
476 t::lib::Mocks::mock_preference('IndependentBranches', 1);
477 my $item_2 = $builder->build_sample_item({ library => $library_2->branchcode });
480 $item_2->safe_to_delete,
482 'Koha::Item->safe_to_delete reports IndependentBranches restriction',
486 $item_2->safe_delete,
488 'IndependentBranches prevents deletion at another branch',
493 { # codeblock to limit scope of $module->mock
495 my $module = Test::MockModule->new('C4::Items');
496 $module->mock( GetAnalyticsCount => sub { return 1 } );
498 $item->discard_changes;
500 $item->safe_to_delete,
502 'Koha::Item->safe_to_delete reports linked analytics',
508 'Linked analytics prevents deletion of item',
513 { # last_item_for_hold
514 C4::Reserves::AddReserve({ branchcode => $patron->branchcode, borrowernumber => $patron->borrowernumber, biblionumber => $item->biblionumber });
515 is( $item->safe_to_delete, 'last_item_for_hold', 'Item cannot be deleted if a biblio-level is placed on the biblio and there is only 1 item attached to the biblio' );
517 # With another item attached to the biblio, the item can be deleted
518 $builder->build_sample_item({ biblionumber => $item->biblionumber });
522 $item->safe_to_delete,
524 'Koha::Item->safe_to_delete shows item safe to delete'
529 my $test_item = Koha::Items->find( $item->itemnumber );
531 is( $test_item, undef,
532 "Koha::Item->safe_delete should delete item if safe_to_delete returns true"
535 $schema->storage->txn_rollback;
538 subtest 'renewal_branchcode' => sub {
541 $schema->storage->txn_begin;
543 my $item = $builder->build_sample_item();
544 my $branch = $builder->build_object({ class => 'Koha::Libraries' });
545 my $checkout = $builder->build_object({
546 class => 'Koha::Checkouts',
548 itemnumber => $item->itemnumber,
553 C4::Context->interface( 'intranet' );
554 t::lib::Mocks::mock_userenv({ branchcode => $branch->branchcode });
556 is( $item->renewal_branchcode, $branch->branchcode, "If interface not opac, we get the branch from context");
557 is( $item->renewal_branchcode({ branch => "PANDA"}), $branch->branchcode, "If interface not opac, we get the branch from context even if we pass one in");
558 C4::Context->set_userenv(51, 'userid4tests', undef, 'firstname', 'surname', undef, undef, 0, undef, undef, undef ); #mock userenv doesn't let us set null branch
559 is( $item->renewal_branchcode({ branch => "PANDA"}), "PANDA", "If interface not opac, we get the branch we pass one in if context not set");
561 C4::Context->interface( 'opac' );
563 t::lib::Mocks::mock_preference('OpacRenewalBranch', undef);
564 is( $item->renewal_branchcode, 'OPACRenew', "If interface opac and OpacRenewalBranch undef, we get OPACRenew");
565 is( $item->renewal_branchcode({branch=>'COW'}), 'OPACRenew', "If interface opac and OpacRenewalBranch undef, we get OPACRenew even if branch passed");
567 t::lib::Mocks::mock_preference('OpacRenewalBranch', 'none');
568 is( $item->renewal_branchcode, '', "If interface opac and OpacRenewalBranch is none, we get blank string");
569 is( $item->renewal_branchcode({branch=>'COW'}), '', "If interface opac and OpacRenewalBranch is none, we get blank string even if branch passed");
571 t::lib::Mocks::mock_preference('OpacRenewalBranch', 'checkoutbranch');
572 is( $item->renewal_branchcode, $checkout->branchcode, "If interface opac and OpacRenewalBranch set to checkoutbranch, we get branch of checkout");
573 is( $item->renewal_branchcode({branch=>'MONKEY'}), $checkout->branchcode, "If interface opac and OpacRenewalBranch set to checkoutbranch, we get branch of checkout even if branch passed");
575 t::lib::Mocks::mock_preference('OpacRenewalBranch','patronhomebranch');
576 is( $item->renewal_branchcode, $checkout->patron->branchcode, "If interface opac and OpacRenewalBranch set to patronbranch, we get branch of patron");
577 is( $item->renewal_branchcode({branch=>'TURKEY'}), $checkout->patron->branchcode, "If interface opac and OpacRenewalBranch set to patronbranch, we get branch of patron even if branch passed");
579 t::lib::Mocks::mock_preference('OpacRenewalBranch','itemhomebranch');
580 is( $item->renewal_branchcode, $item->homebranch, "If interface opac and OpacRenewalBranch set to itemhomebranch, we get homebranch of item");
581 is( $item->renewal_branchcode({branch=>'MANATEE'}), $item->homebranch, "If interface opac and OpacRenewalBranch set to itemhomebranch, we get homebranch of item even if branch passed");
583 $schema->storage->txn_rollback;
586 subtest 'Tests for itemtype' => sub {
588 $schema->storage->txn_begin;
590 my $biblio = $builder->build_sample_biblio;
591 my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes' });
592 my $item = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, itype => $itemtype->itemtype });
594 t::lib::Mocks::mock_preference('item-level_itypes', 1);
595 is( $item->itemtype->itemtype, $item->itype, 'Pref enabled' );
596 t::lib::Mocks::mock_preference('item-level_itypes', 0);
597 is( $item->itemtype->itemtype, $biblio->biblioitem->itemtype, 'Pref disabled' );
599 $schema->storage->txn_rollback;