3 # Copyright 2015 Koha Development team
5 # This file is part of Koha
7 # Koha is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 3 of the License, or
10 # (at your option) any later version.
12 # Koha is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
22 use Test::More tests => 43;
31 use C4::Circulation qw( AddIssue AddReturn );
33 use C4::Auth qw( checkpw checkpw_hash );
39 use Koha::Old::Patrons;
40 use Koha::Patron::Attribute::Types;
41 use Koha::Patron::Categories;
42 use Koha::Patron::Relationship;
44 use Koha::DateUtils qw( dt_from_string output_pref );
45 use Koha::Virtualshelf;
46 use Koha::Virtualshelves;
47 use Koha::Notice::Messages;
49 use t::lib::TestBuilder;
52 my $schema = Koha::Database->new->schema;
53 $schema->storage->txn_begin;
55 my $builder = t::lib::TestBuilder->new;
56 my $library = $builder->build({source => 'Branch' });
57 my $category = $builder->build({source => 'Category' });
58 my $nb_of_patrons = Koha::Patrons->search->count;
59 my $new_patron_1 = Koha::Patron->new(
60 { cardnumber => 'test_cn_1',
61 branchcode => $library->{branchcode},
62 categorycode => $category->{categorycode},
63 surname => 'surname for patron1',
64 firstname => 'firstname for patron1',
65 userid => 'a_nonexistent_userid_1',
66 flags => 1, # Is superlibrarian
69 my $new_patron_2 = Koha::Patron->new(
70 { cardnumber => 'test_cn_2',
71 branchcode => $library->{branchcode},
72 categorycode => $category->{categorycode},
73 surname => 'surname for patron2',
74 firstname => 'firstname for patron2',
75 userid => 'a_nonexistent_userid_2',
79 t::lib::Mocks::mock_userenv({ patron => $new_patron_1 });
81 is( Koha::Patrons->search->count, $nb_of_patrons + 2, 'The 2 patrons should have been added' );
83 my $retrieved_patron_1 = Koha::Patrons->find( $new_patron_1->borrowernumber );
84 is( $retrieved_patron_1->cardnumber, $new_patron_1->cardnumber, 'Find a patron by borrowernumber should return the correct patron' );
86 subtest 'library' => sub {
88 is( $retrieved_patron_1->library->branchcode, $library->{branchcode}, 'Koha::Patron->library should return the correct library' );
89 is( ref($retrieved_patron_1->library), 'Koha::Library', 'Koha::Patron->library should return a Koha::Library object' );
92 subtest 'sms_provider' => sub {
94 my $sms_provider = $builder->build({source => 'SmsProvider' });
95 is( $retrieved_patron_1->sms_provider, undef, '->sms_provider should return undef if none defined' );
96 $retrieved_patron_1->sms_provider_id( $sms_provider->{id} )->store;
97 is_deeply( $retrieved_patron_1->sms_provider->unblessed, $sms_provider, 'Koha::Patron->sms_provider returns the correct SMS provider' );
98 is( ref($retrieved_patron_1->sms_provider), 'Koha::SMS::Provider', 'Koha::Patron->sms_provider should return a Koha::SMS::Provider object' );
101 subtest 'guarantees' => sub {
105 t::lib::Mocks::mock_preference( 'borrowerRelationship', 'test|test2' );
107 my $guarantees = $new_patron_1->guarantee_relationships;
108 is( ref($guarantees), 'Koha::Patron::Relationships', 'Koha::Patron->guarantees should return a Koha::Patrons result set in a scalar context' );
109 is( $guarantees->count, 0, 'new_patron_1 should have 0 guarantee relationships' );
111 my $guarantee_1 = $builder->build({ source => 'Borrower' });
112 my $relationship_1 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->id, guarantee_id => $guarantee_1->{borrowernumber}, relationship => 'test' } )->store();
113 my $guarantee_2 = $builder->build({ source => 'Borrower' });
114 my $relationship_2 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->id, guarantee_id => $guarantee_2->{borrowernumber}, relationship => 'test' } )->store();
116 $guarantees = $new_patron_1->guarantee_relationships;
117 is( ref($guarantees), 'Koha::Patron::Relationships', 'Koha::Patron->guarantee_relationships should return a Koha::Patrons result set in a scalar context' );
118 is( $guarantees->count, 2, 'new_patron_1 should have 2 guarantees' );
122 #Test return order of guarantees BZ 18635
123 my $categorycode = $builder->build({ source => 'Category' })->{categorycode};
124 my $branchcode = $builder->build({ source => 'Branch' })->{branchcode};
126 my $guarantor = $builder->build_object( { class => 'Koha::Patrons' } );
128 my $order_guarantee1 = $builder->build_object(
130 class => 'Koha::Patrons',
136 $builder->build_object(
138 class => 'Koha::Patron::Relationships',
140 guarantor_id => $guarantor->id,
141 guarantee_id => $order_guarantee1,
142 relationship => 'test',
147 my $order_guarantee2 = $builder->build_object(
149 class => 'Koha::Patrons',
155 $builder->build_object(
157 class => 'Koha::Patron::Relationships',
159 guarantor_id => $guarantor->id,
160 guarantee_id => $order_guarantee2,
161 relationship => 'test',
166 my $order_guarantee3 = $builder->build_object(
168 class => 'Koha::Patrons',
171 firstname => 'Walrus',
175 $builder->build_object(
177 class => 'Koha::Patron::Relationships',
179 guarantor_id => $guarantor->id,
180 guarantee_id => $order_guarantee3,
181 relationship => 'test',
186 my $order_guarantee4 = $builder->build_object(
188 class => 'Koha::Patrons',
191 firstname => 'Vulture',
195 $builder->build_object(
197 class => 'Koha::Patron::Relationships',
199 guarantor_id => $guarantor->id,
200 guarantee_id => $order_guarantee4,
201 relationship => 'test',
206 my $order_guarantee5 = $builder->build_object(
208 class => 'Koha::Patrons',
211 firstname => 'Unicorn',
215 my $r = $builder->build_object(
217 class => 'Koha::Patron::Relationships',
219 guarantor_id => $guarantor->id,
220 guarantee_id => $order_guarantee5,
221 relationship => 'test',
226 $guarantees = $guarantor->guarantee_relationships->guarantees;
228 is( $guarantees->next()->borrowernumber, $order_guarantee5, "Return first guarantor alphabetically" );
229 is( $guarantees->next()->borrowernumber, $order_guarantee4, "Return second guarantor alphabetically" );
230 is( $guarantees->next()->borrowernumber, $order_guarantee3, "Return third guarantor alphabetically" );
231 is( $guarantees->next()->borrowernumber, $order_guarantee2, "Return fourth guarantor alphabetically" );
232 is( $guarantees->next()->borrowernumber, $order_guarantee1, "Return fifth guarantor alphabetically" );
235 subtest 'category' => sub {
237 my $patron_category = $new_patron_1->category;
238 is( ref( $patron_category), 'Koha::Patron::Category', );
239 is( $patron_category->categorycode, $category->{categorycode}, );
242 subtest 'siblings' => sub {
246 my $siblings = $new_patron_1->siblings;
247 is( $siblings, undef, 'Koha::Patron->siblings should not crashed if the patron has no guarantor' );
248 my $guarantee_1 = $builder->build( { source => 'Borrower' } );
249 my $relationship_1 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->borrowernumber, guarantee_id => $guarantee_1->{borrowernumber}, relationship => 'test' } )->store();
250 my $retrieved_guarantee_1 = Koha::Patrons->find($guarantee_1);
251 $siblings = $retrieved_guarantee_1->siblings;
252 is( ref($siblings), 'Koha::Patrons', 'Koha::Patron->siblings should return a Koha::Patrons result set in a scalar context' );
253 is( $siblings->count, 0, 'guarantee_1 should not have siblings yet' );
254 my $guarantee_2 = $builder->build( { source => 'Borrower' } );
255 my $relationship_2 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->borrowernumber, guarantee_id => $guarantee_2->{borrowernumber}, relationship => 'test' } )->store();
256 my $guarantee_3 = $builder->build( { source => 'Borrower' } );
257 my $relationship_3 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->borrowernumber, guarantee_id => $guarantee_3->{borrowernumber}, relationship => 'test' } )->store();
258 $siblings = $retrieved_guarantee_1->siblings;
259 is( $siblings->count, 2, 'guarantee_1 should have 2 siblings' );
260 is( $guarantee_2->{borrowernumber}, $siblings->next->borrowernumber, 'guarantee_2 should exist in the guarantees' );
261 is( $guarantee_3->{borrowernumber}, $siblings->next->borrowernumber, 'guarantee_3 should exist in the guarantees' );
262 $_->delete for $retrieved_guarantee_1->siblings;
263 $retrieved_guarantee_1->delete;
266 subtest 'has_overdues' => sub {
269 my $item_1 = $builder->build_sample_item;
270 my $retrieved_patron = Koha::Patrons->find( $new_patron_1->borrowernumber );
271 is( $retrieved_patron->has_overdues, 0, );
273 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
274 my $issue = Koha::Checkout->new({ borrowernumber => $new_patron_1->id, itemnumber => $item_1->itemnumber, date_due => $tomorrow, branchcode => $library->{branchcode} })->store();
275 is( $retrieved_patron->has_overdues, 0, );
277 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
278 $issue = Koha::Checkout->new({ borrowernumber => $new_patron_1->id, itemnumber => $item_1->itemnumber, date_due => $yesterday, branchcode => $library->{branchcode} })->store();
279 $retrieved_patron = Koha::Patrons->find( $new_patron_1->borrowernumber );
280 is( $retrieved_patron->has_overdues, 1, );
284 subtest 'is_expired' => sub {
286 my $patron = $builder->build({ source => 'Borrower' });
287 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
288 $patron->dateexpiry( undef )->store->discard_changes;
289 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is not set');
290 $patron->dateexpiry( dt_from_string )->store->discard_changes;
291 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is today');
292 $patron->dateexpiry( dt_from_string->add( days => 1 ) )->store->discard_changes;
293 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is tomorrow');
294 $patron->dateexpiry( dt_from_string->add( days => -1 ) )->store->discard_changes;
295 is( $patron->is_expired, 1, 'Patron should be considered expired if dateexpiry is yesterday');
300 subtest 'is_going_to_expire' => sub {
303 my $today = dt_from_string(undef, undef, 'floating');
304 my $patron = $builder->build({ source => 'Borrower' });
305 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
306 $patron->dateexpiry( undef )->store->discard_changes;
307 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is not set');
309 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 0);
310 $patron->dateexpiry( $today )->store->discard_changes;
311 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is today');
313 $patron->dateexpiry( $today )->store->discard_changes;
314 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is today and pref is 0');
316 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
317 $patron->dateexpiry( $today->clone->add( days => 11 ) )->store->discard_changes;
318 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 11 days ahead and pref is 10');
320 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 0);
321 $patron->dateexpiry( $today->clone->add( days => 10 ) )->store->discard_changes;
322 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 10 days ahead and pref is 0');
324 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
325 $patron->dateexpiry( $today->clone->add( days => 10 ) )->store->discard_changes;
326 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 10 days ahead and pref is 10');
329 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
330 $patron->dateexpiry( $today->clone->add( days => 20 ) )->store->discard_changes;
331 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 20 days ahead and pref is 10');
333 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 20);
334 $patron->dateexpiry( $today->clone->add( days => 10 ) )->store->discard_changes;
335 is( $patron->is_going_to_expire, 1, 'Patron should be considered going to expire if dateexpiry is 10 days ahead and pref is 20');
337 { # Testing invalid is going to expiry date
338 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 30);
339 # mock_config does not work here, because of tz vs timezone subroutines
340 my $context = Test::MockModule->new('C4::Context');
341 $context->mock( 'tz', sub {
344 $patron->dateexpiry(DateTime->new( year => 2019, month => 12, day => 3 ))->store;
345 eval { $patron->is_going_to_expire };
346 is( $@, '', 'On invalid "is going to expire" date, the method should not crash with "Invalid local time for date in time zone"');
347 $context->unmock('tz');
354 subtest 'renew_account' => sub {
357 for my $date ( '2016-03-31', '2016-11-30', '2019-01-31', dt_from_string() ) {
358 my $dt = dt_from_string( $date, 'iso' );
359 Time::Fake->offset( $dt->epoch );
360 my $a_month_ago = $dt->clone->subtract( months => 1, end_of_month => 'limit' )->truncate( to => 'day' );
361 my $a_year_later = $dt->clone->add( months => 12, end_of_month => 'limit' )->truncate( to => 'day' );
362 my $a_year_later_minus_a_month = $a_month_ago->clone->add( months => 12, end_of_month => 'limit' )->truncate( to => 'day' );
363 my $a_month_later = $dt->clone->add( months => 1 , end_of_month => 'limit' )->truncate( to => 'day' );
364 my $a_year_later_plus_a_month = $a_month_later->clone->add( months => 12, end_of_month => 'limit' )->truncate( to => 'day' );
365 my $patron_category = $builder->build(
366 { source => 'Category',
368 enrolmentperiod => 12,
369 enrolmentperioddate => undef,
373 my $patron = $builder->build(
374 { source => 'Borrower',
376 dateexpiry => $a_month_ago,
377 categorycode => $patron_category->{categorycode},
378 date_renewed => undef, # Force builder to not populate the column for new patron
382 my $patron_2 = $builder->build(
383 { source => 'Borrower',
385 dateexpiry => $a_month_ago,
386 categorycode => $patron_category->{categorycode},
390 my $patron_3 = $builder->build(
391 { source => 'Borrower',
393 dateexpiry => $a_month_later,
394 categorycode => $patron_category->{categorycode},
398 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
399 my $retrieved_patron_2 = Koha::Patrons->find( $patron_2->{borrowernumber} );
400 my $retrieved_patron_3 = Koha::Patrons->find( $patron_3->{borrowernumber} );
402 is( $retrieved_patron->date_renewed, undef, "Date renewed is not set for patrons that have never been renewed" );
404 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'dateexpiry' );
405 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
406 my $expiry_date = $retrieved_patron->renew_account;
407 is( $expiry_date, $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
408 my $retrieved_expiry_date = Koha::Patrons->find( $patron->{borrowernumber} )->dateexpiry;
409 is( dt_from_string($retrieved_expiry_date), $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
410 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
411 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->renew_account should have logged' );
413 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'now' );
414 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
415 $expiry_date = $retrieved_patron->renew_account;
416 is( $expiry_date, $a_year_later, "today + 12 months must be $a_year_later" );
417 $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
418 is( $retrieved_patron->date_renewed, output_pref({ dt => $dt, dateformat => 'iso', dateonly => 1 }), "Date renewed is set when calling renew_account" );
419 $retrieved_expiry_date = $retrieved_patron->dateexpiry;
420 is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
421 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
422 is( $number_of_logs, 1, 'Without BorrowerLogs, Koha::Patron->renew_account should not have logged' );
424 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'combination' );
425 $expiry_date = $retrieved_patron_2->renew_account;
426 is( $expiry_date, $a_year_later, "today + 12 months must be $a_year_later" );
427 $retrieved_expiry_date = Koha::Patrons->find( $patron_2->{borrowernumber} )->dateexpiry;
428 is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
430 $expiry_date = $retrieved_patron_3->renew_account;
431 is( $expiry_date, $a_year_later_plus_a_month, "$a_month_later + 12 months must be $a_year_later_plus_a_month" );
432 $retrieved_expiry_date = Koha::Patrons->find( $patron_3->{borrowernumber} )->dateexpiry;
433 is( dt_from_string($retrieved_expiry_date), $a_year_later_plus_a_month, "$a_month_later + 12 months must be $a_year_later_plus_a_month" );
435 $retrieved_patron->delete;
436 $retrieved_patron_2->delete;
437 $retrieved_patron_3->delete;
442 subtest "move_to_deleted" => sub {
444 my $originally_updated_on = '2016-01-01 12:12:12';
445 my $patron = $builder->build( { source => 'Borrower',value => { updated_on => $originally_updated_on } } );
446 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
447 is( ref( $retrieved_patron->move_to_deleted ), 'Koha::Schema::Result::Deletedborrower', 'Koha::Patron->move_to_deleted should return the Deleted patron' )
448 ; # FIXME This should be Koha::Deleted::Patron
449 my $deleted_patron = $schema->resultset('Deletedborrower')
450 ->search( { borrowernumber => $patron->{borrowernumber} }, { result_class => 'DBIx::Class::ResultClass::HashRefInflator' } )
452 ok( $retrieved_patron->updated_on, 'updated_on should be set for borrowers table' );
453 ok( $deleted_patron->{updated_on}, 'updated_on should be set for deleted_borrowers table' );
454 isnt( $deleted_patron->{updated_on}, $retrieved_patron->updated_on, 'Koha::Patron->move_to_deleted should have correctly updated the updated_on column');
455 $deleted_patron->{updated_on} = $originally_updated_on; #reset for simplicity in comparing all other fields
456 is_deeply( $deleted_patron, $patron, 'Koha::Patron->move_to_deleted should have correctly moved the patron to the deleted table' );
457 $retrieved_patron->delete( $patron->{borrowernumber} ); # Cleanup
460 subtest "delete" => sub {
462 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
463 t::lib::Mocks::mock_preference( 'ListOwnershipUponPatronDeletion', 'transfer' );
464 t::lib::Mocks::mock_preference( 'ListOwnerDesignated', undef );
465 Koha::Virtualshelves->delete;
467 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
468 my $patron_for_sharing = $builder->build_object({ class => 'Koha::Patrons' });
469 my $staff_patron = $builder->build_object({ class => 'Koha::Patrons' });
470 t::lib::Mocks::mock_userenv({ patron => $staff_patron });
472 my $hold = $builder->build_object({ class => 'Koha::Holds', value => { borrowernumber => $patron->borrowernumber } });
473 my $modification = $builder->build_object({ class => 'Koha::Patron::Modifications', value => { borrowernumber => $patron->borrowernumber } });
474 my $private_list = Koha::Virtualshelf->new({
475 shelfname => "private",
476 owner => $patron->borrowernumber,
479 my $public_list = Koha::Virtualshelf->new({
480 shelfname => "public",
481 owner => $patron->borrowernumber,
484 my $list_to_share = Koha::Virtualshelf->new({
485 shelfname => "shared",
486 owner => $patron->borrowernumber,
490 $list_to_share->share("valid key")->accept( "valid key", $patron_for_sharing->borrowernumber );
491 $list_to_share->share("valid key")->accept( "valid key", $staff_patron->borrowernumber ); # this share should be removed at deletion too
492 my $deleted = $patron->delete;
493 is( ref($deleted), 'Koha::Patron', 'Koha::Patron->delete should return the deleted patron object if the patron has been correctly deleted' );
494 ok( $patron->borrowernumber, 'Still have the deleted borrowernumber' );
496 is( Koha::Patrons->find( $patron->borrowernumber ), undef, 'Koha::Patron->delete should have deleted the patron' );
498 is (Koha::Old::Holds->search({ reserve_id => $hold->reserve_id })->count, 1, q|Koha::Patron->delete should have cancelled patron's holds| );
500 is( Koha::Holds->search( { borrowernumber => $patron->borrowernumber } )->count, 0, q|Koha::Patron->delete should have cancelled patron's holds 2| );
502 my $transferred_lists = Koha::Virtualshelves->search({ owner => $staff_patron->borrowernumber })->count;
503 is( $transferred_lists, 2, 'Public and shared lists should stay in database under a different owner with a unique name, while private lists delete, with ListOwnershipPatronDeletion set to Transfer');
504 is( Koha::Virtualshelfshares->search({ borrowernumber => $staff_patron->borrowernumber })->count, 0, "New owner of list should have shares removed" );
505 is( Koha::Virtualshelfshares->search({ borrowernumber => $patron_for_sharing->borrowernumber })->count, 1, "But the other share is still there" );
506 is( Koha::Virtualshelves->search({ owner => $patron->borrowernumber })->count, 0, q|Koha::Patron->delete should have deleted patron's lists/removed their ownership| );
508 is( Koha::Patron::Modifications->search( { borrowernumber => $patron->borrowernumber } )->count, 0, q|Koha::Patron->delete should have deleted patron's modifications| );
510 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'DELETE', object => $patron->borrowernumber } )->count;
511 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->delete should have logged' );
513 # Test deletion with designated fallback owner
514 my $designated_owner = $builder->build_object({ class => 'Koha::Patrons' });
515 t::lib::Mocks::mock_preference( 'ListOwnerDesignated', $designated_owner->id );
516 $patron = $builder->build_object({ class => 'Koha::Patrons' });
517 $private_list = Koha::Virtualshelf->new({ shelfname => "PR1", owner => $patron->id })->store;
518 $public_list = Koha::Virtualshelf->new({ shelfname => "PU1", public => 1, owner => $patron->id })->store;
519 $list_to_share = Koha::Virtualshelf->new({ shelfname => "SH1", owner => $patron->id })->store;
520 $list_to_share->share("valid key")->accept( "valid key", $patron_for_sharing->id );
522 is( Koha::Virtualshelves->find( $private_list->id ), undef, 'Private list gone' );
523 is( $public_list->discard_changes->get_column('owner'), $designated_owner->id, 'Public list transferred' );
524 is( $list_to_share->discard_changes->get_column('owner'), $designated_owner->id, 'Shared list transferred' );
526 # Finally test deleting lists
527 t::lib::Mocks::mock_preference( 'ListOwnershipUponPatronDeletion', 'delete' );
528 Koha::Virtualshelves->delete;
529 my $patron2 = $builder->build_object({ class => 'Koha::Patrons' });
530 my $private_list2 = Koha::Virtualshelf->new({
531 shelfname => "private",
532 owner => $patron2->borrowernumber,
535 my $public_list2 = Koha::Virtualshelf->new({
536 shelfname => "public",
537 owner => $patron2->borrowernumber,
540 my $list_to_share2 = Koha::Virtualshelf->new({
541 shelfname => "shared",
542 owner => $patron2->borrowernumber,
545 $list_to_share2->share("valid key")->accept( "valid key", $patron_for_sharing->borrowernumber );
547 # Delete patron2, check if shelves and shares are now empty
549 is( Koha::Virtualshelves->count, 0, 'All lists should be gone now' );
550 is( Koha::Virtualshelfshares->count, 0, 'All shares should be gone too' );
553 subtest 'Koha::Patrons->delete' => sub {
556 my $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
557 my $patron2 = $builder->build_object({ class => 'Koha::Patrons' });
558 my $id1 = $patron1->borrowernumber;
559 my $set = Koha::Patrons->search({ borrowernumber => { -in => [$patron1->borrowernumber, $patron2->borrowernumber]}});
560 is( $set->count, 2, 'Two patrons found as expected' );
561 is( $set->delete({ move => 1 }), 2, 'Two patrons deleted' );
562 my $deleted_patrons = Koha::Old::Patrons->search({ borrowernumber => { -in => [$patron1->borrowernumber, $patron2->borrowernumber]}});
563 is( $deleted_patrons->count, 2, 'Patrons moved to deletedborrowers' );
565 # See other tests in t/db_dependent/Koha/Objects.t
568 subtest 'add_enrolment_fee_if_needed' => sub {
571 my $enrolmentfees = { K => 5, J => 10, YA => 20 };
572 foreach( keys %{$enrolmentfees} ) {
573 ( Koha::Patron::Categories->find( $_ ) // $builder->build_object({ class => 'Koha::Patron::Categories', value => { categorycode => $_ } }) )->enrolmentfee( $enrolmentfees->{$_} )->store;
575 my $enrolmentfee_K = $enrolmentfees->{K};
576 my $enrolmentfee_J = $enrolmentfees->{J};
577 my $enrolmentfee_YA = $enrolmentfees->{YA};
579 my %borrower_data = (
580 firstname => 'my firstname',
581 surname => 'my surname',
583 branchcode => $library->{branchcode},
586 my $borrowernumber = Koha::Patron->new(\%borrower_data)->store->borrowernumber;
587 $borrower_data{borrowernumber} = $borrowernumber;
589 my $patron = Koha::Patrons->find( $borrowernumber );
590 my $total = $patron->account->balance;
591 is( int($total), int($enrolmentfee_K), "New kid pay $enrolmentfee_K" );
593 t::lib::Mocks::mock_preference( 'FeeOnChangePatronCategory', 0 );
594 $borrower_data{categorycode} = 'J';
595 $patron->set(\%borrower_data)->store;
596 $total = $patron->account->balance;
597 is( int($total), int($enrolmentfee_K), "Kid growing and become a juvenile, but shouldn't pay for the upgrade " );
599 $borrower_data{categorycode} = 'K';
600 $patron->set(\%borrower_data)->store;
601 t::lib::Mocks::mock_preference( 'FeeOnChangePatronCategory', 1 );
603 $borrower_data{categorycode} = 'J';
604 $patron->set(\%borrower_data)->store;
605 $total = $patron->account->balance;
606 is( int($total), int($enrolmentfee_K + $enrolmentfee_J), "Kid growing and become a juvenile, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J ) );
608 # Check with calling directly Koha::Patron->get_enrolment_fee_if_needed
609 $patron->categorycode('YA')->store;
610 $total = $patron->account->balance;
612 int($enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA),
613 "Juvenile growing and become an young adult, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA )
619 subtest 'checkouts + pending_checkouts + overdues + old_checkouts' => sub {
622 my $library = $builder->build( { source => 'Branch' } );
623 my $biblionumber_1 = $builder->build_sample_biblio->biblionumber;
624 my $item_1 = $builder->build_sample_item(
626 library => $library->{branchcode},
627 biblionumber => $biblionumber_1,
630 my $item_2 = $builder->build_sample_item(
632 library => $library->{branchcode},
633 biblionumber => $biblionumber_1,
636 my $biblionumber_2 = $builder->build_sample_biblio->biblionumber;
637 my $item_3 = $builder->build_sample_item(
639 library => $library->{branchcode},
640 biblionumber => $biblionumber_2,
643 my $patron = $builder->build(
645 source => 'Borrower',
646 value => { branchcode => $library->{branchcode} }
650 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
651 my $checkouts = $patron->checkouts;
652 is( $checkouts->count, 0, 'checkouts should not return any issues for that patron' );
653 is( ref($checkouts), 'Koha::Checkouts', 'checkouts should return a Koha::Checkouts object' );
654 my $pending_checkouts = $patron->pending_checkouts;
655 is( $pending_checkouts->count, 0, 'pending_checkouts should not return any issues for that patron' );
656 is( ref($pending_checkouts), 'Koha::Checkouts', 'pending_checkouts should return a Koha::Checkouts object' );
657 my $old_checkouts = $patron->old_checkouts;
658 is( $old_checkouts->count, 0, 'old_checkouts should not return any issues for that patron' );
659 is( ref($old_checkouts), 'Koha::Old::Checkouts', 'old_checkouts should return a Koha::Old::Checkouts object' );
661 t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
663 AddIssue( $patron, $item_1->barcode, DateTime->now->subtract( days => 1 ) );
664 AddIssue( $patron, $item_2->barcode, DateTime->now->subtract( days => 5 ) );
665 AddIssue( $patron, $item_3->barcode );
667 $checkouts = $patron->checkouts;
668 is( $checkouts->count, 3, 'checkouts should return 3 issues for that patron' );
669 is( ref($checkouts), 'Koha::Checkouts', 'checkouts should return a Koha::Checkouts object' );
670 $pending_checkouts = $patron->pending_checkouts;
671 is( $pending_checkouts->count, 3, 'pending_checkouts should return 3 issues for that patron' );
672 is( ref($pending_checkouts), 'Koha::Checkouts', 'pending_checkouts should return a Koha::Checkouts object' );
674 my $first_checkout = $pending_checkouts->next;
675 is( $first_checkout->unblessed_all_relateds->{biblionumber}, $item_3->biblionumber, 'pending_checkouts should prefetch values from other tables (here biblio)' );
677 my $overdues = $patron->overdues;
678 is( $overdues->count, 2, 'Patron should have 2 overdues');
679 is( ref($overdues), 'Koha::Checkouts', 'Koha::Patron->overdues should return Koha::Checkouts' );
680 is( $overdues->next->itemnumber, $item_1->itemnumber, 'The issue should be returned in the same order as they have been done, first is correct' );
681 is( $overdues->next->itemnumber, $item_2->itemnumber, 'The issue should be returned in the same order as they have been done, second is correct' );
684 C4::Circulation::AddReturn( $item_1->barcode );
685 C4::Circulation::AddReturn( $item_2->barcode );
686 $old_checkouts = $patron->old_checkouts;
687 is( $old_checkouts->count, 2, 'old_checkouts should return 2 old checkouts that patron' );
688 is( ref($old_checkouts), 'Koha::Old::Checkouts', 'old_checkouts should return a Koha::Old::Checkouts object' );
691 Koha::Checkouts->search( { borrowernumber => $patron->borrowernumber } )->delete;
695 subtest 'get_routing_lists' => sub {
698 my $biblio = Koha::Biblio->new()->store();
699 my $subscription = Koha::Subscription->new({
700 biblionumber => $biblio->biblionumber,
704 my $patron = $builder->build( { source => 'Borrower' } );
705 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
707 is( $patron->get_routing_lists->count, 0, 'Retrieves correct number of routing lists: 0' );
709 my $routinglist_count = Koha::Subscription::Routinglists->count;
710 my $routinglist = Koha::Subscription::Routinglist->new({
711 borrowernumber => $patron->borrowernumber,
713 subscriptionid => $subscription->subscriptionid
716 is ($patron->get_routing_lists->count, 1, "Retrieves correct number of routing lists: 1");
718 my $routinglists = $patron->get_routing_lists;
719 is ($routinglists->next->ranking, 5, "Retrieves ranking: 5");
720 is( ref($routinglists), 'Koha::Subscription::Routinglists', 'get_routing_lists returns Koha::Subscription::Routinglists' );
722 my $subscription2 = Koha::Subscription->new({
723 biblionumber => $biblio->biblionumber,
726 my $routinglist2 = Koha::Subscription::Routinglist->new({
727 borrowernumber => $patron->borrowernumber,
729 subscriptionid => $subscription2->subscriptionid
732 is ($patron->get_routing_lists->count, 2, "Retrieves correct number of routing lists: 2");
734 $patron->delete; # Clean up for later tests
738 subtest 'get_age' => sub {
741 # Following tests implicitly assume timezone UTC
742 delete $C4::Context::context->{tz};
744 $ENV{TZ} = 'Etc/UTC';
746 my $patron = $builder->build( { source => 'Borrower' } );
747 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
751 today => '2020-02-28',
752 has_12 => { date => '2007-08-27', expected_age => 12 },
753 almost_18 => { date => '2002-03-01', expected_age => 17 },
754 has_18_today => { date => '2002-02-28', expected_age => 18 },
755 had_18_yesterday => { date => '2002-02-27', expected_age => 18 },
756 almost_16 => { date => '2004-02-29', expected_age => 15 },
757 has_16_today => { date => '2004-02-28', expected_age => 16 },
758 had_16_yesterday => { date => '2004-02-27', expected_age => 16 },
759 new_born => { date => '2020-01-27', expected_age => 0 },
762 today => '2020-02-29',
763 has_12 => { date => '2007-08-27', expected_age => 12 },
764 almost_18 => { date => '2002-03-01', expected_age => 17 },
765 has_18_today => { date => '2002-02-28', expected_age => 18 },
766 had_18_yesterday => { date => '2002-02-27', expected_age => 18 },
767 almost_16 => { date => '2004-03-01', expected_age => 15 },
768 has_16_today => { date => '2004-02-29', expected_age => 16 },
769 had_16_yesterday => { date => '2004-02-28', expected_age => 16 },
770 new_born => { date => '2020-01-27', expected_age => 0 },
773 today => '2020-03-01',
774 has_12 => { date => '2007-08-27', expected_age => 12 },
775 almost_18 => { date => '2002-03-02', expected_age => 17 },
776 has_18_today => { date => '2002-03-01', expected_age => 18 },
777 had_18_yesterday => { date => '2002-02-28', expected_age => 18 },
778 almost_16 => { date => '2004-03-02', expected_age => 15 },
779 has_16_today => { date => '2004-03-01', expected_age => 16 },
780 had_16_yesterday => { date => '2004-02-29', expected_age => 16 },
783 today => '2019-01-31',
784 has_12 => { date => '2006-08-27', expected_age => 12 },
785 almost_18 => { date => '2001-02-01', expected_age => 17 },
786 has_18_today => { date => '2001-01-31', expected_age => 18 },
787 had_18_yesterday => { date => '2001-01-30', expected_age => 18 },
788 almost_16 => { date => '2003-02-01', expected_age => 15 },
789 has_16_today => { date => '2003-01-31', expected_age => 16 },
790 had_16_yesterday => { date => '2003-01-30', expected_age => 16 },
794 $patron->dateofbirth( undef );
795 is( $patron->get_age, undef, 'get_age should return undef if no dateofbirth is defined' );
797 for my $date ( @dates ) {
799 my $dt = dt_from_string($date->{today});
801 Time::Fake->offset( $dt->epoch );
803 for my $k ( keys %$date ) {
804 next if $k eq 'today';
806 my $dob = $date->{$k};
807 $patron->dateofbirth( dt_from_string( $dob->{date}, 'iso' ) );
810 $dob->{expected_age},
812 "Today=%s, dob=%s, should be %d",
813 $date->{today}, $dob->{date}, $dob->{expected_age}
824 # Remove timezone change
825 delete $C4::Context::context->{tz};
828 subtest 'is_valid_age' => sub {
831 # Following tests implicitly assume timezone UTC
832 delete $C4::Context::context->{tz};
834 $ENV{TZ} = 'Etc/UTC';
836 my $dt = dt_from_string('2020-02-28');
838 Time::Fake->offset( $dt->epoch );
840 my $category = $builder->build({
841 source => 'Category',
843 categorycode => 'AGE_5_10',
844 dateofbirthrequired => 5,
848 $category = Koha::Patron::Categories->find( $category->{categorycode} );
850 my $patron = $builder->build({
851 source => 'Borrower',
853 categorycode => $category->categorycode
856 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
859 $patron->dateofbirth( undef );
860 is( $patron->is_valid_age, 1, 'Patron with no dateofbirth is always valid for any category');
864 today => '2020-02-28',
866 { date => '2007-08-27', expected_age => 12, valid => 0 },
868 { date => '2016-08-27', expected_age => 3, valid => 0 },
870 { date => '2013-02-28', expected_age => 7, valid => 1 },
872 { date => '2015-02-28', expected_age => 5, valid => 1 },
874 { date => '2015-03-01', expected_age => 4, valid => 0 },
876 { date => '2015-02-27', expected_age => 5, valid => 1 },
878 { date => '2009-02-28', expected_age => 11, valid => 0 },
880 { date => '2009-03-01', expected_age => 10, valid => 1 },
882 { date => '2009-02-27', expected_age => 11, valid => 0 },
886 for my $date ( @dates ) {
888 my $dt = dt_from_string($date->{today});
890 Time::Fake->offset( $dt->epoch );
892 for my $k ( sort keys %$date ) {
893 next if $k eq 'today';
895 my $dob = $date->{$k};
896 $patron->dateofbirth( dt_from_string( $dob->{date}, 'iso' ) );
898 $patron->is_valid_age,
901 "Today=%s, dob=%s, is %s, should be valid=%s in category %s",
902 $date->{today}, $dob->{date}, $dob->{expected_age}, $dob->{valid}, $category->categorycode
914 # Remove timezone change
915 delete $C4::Context::context->{tz};
918 subtest 'account' => sub {
921 my $patron = $builder->build({source => 'Borrower'});
923 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
924 my $account = $patron->account;
925 is( ref($account), 'Koha::Account', 'account should return a Koha::Account object' );
930 subtest 'search_upcoming_membership_expires' => sub {
933 my $expiry_days = 15;
934 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', $expiry_days );
935 my $nb_of_days_before = 1;
936 my $nb_of_days_after = 2;
938 my $builder = t::lib::TestBuilder->new();
940 my $library = $builder->build({ source => 'Branch' });
942 # before we add borrowers to this branch, add the expires we have now
943 # note that this pertains to the current mocked setting of the pref
944 # for this reason we add the new branchcode to most of the tests
945 my $nb_of_expires = Koha::Patrons->search_upcoming_membership_expires->count;
947 my $patron_1 = $builder->build({
948 source => 'Borrower',
950 branchcode => $library->{branchcode},
951 dateexpiry => dt_from_string->add( days => $expiry_days )
955 my $patron_2 = $builder->build({
956 source => 'Borrower',
958 branchcode => $library->{branchcode},
959 dateexpiry => dt_from_string->add( days => $expiry_days - $nb_of_days_before )
963 my $patron_3 = $builder->build({
964 source => 'Borrower',
966 branchcode => $library->{branchcode},
967 dateexpiry => dt_from_string->add( days => $expiry_days + $nb_of_days_after )
971 # Test without extra parameters
972 my $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires();
973 is( $upcoming_mem_expires->count, $nb_of_expires + 1, 'Get upcoming membership expires should return one new borrower.' );
976 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
977 is( $upcoming_mem_expires->count, 1, 'Test with branch parameter' );
978 my $expired = $upcoming_mem_expires->next;
979 is( $expired->surname, $patron_1->{surname}, 'Get upcoming membership expires should return the correct patron.' );
980 is( $expired->library->branchemail, $library->{branchemail}, 'Get upcoming membership expires should return the correct patron.' );
981 is( $expired->branchcode, $patron_1->{branchcode}, 'Get upcoming membership expires should return the correct patron.' );
983 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', 0 );
984 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
985 is( $upcoming_mem_expires->count, 0, 'Get upcoming membership expires with MembershipExpiryDaysNotice==0 should not return new records.' );
987 # Test MembershipExpiryDaysNotice == undef
988 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', undef );
989 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
990 is( $upcoming_mem_expires->count, 0, 'Get upcoming membership expires without MembershipExpiryDaysNotice should not return new records.' );
992 # Test the before parameter
993 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', 15 );
994 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode}, before => $nb_of_days_before });
995 is( $upcoming_mem_expires->count, 2, 'Expect two results for before');
996 # Test after parameter also
997 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode}, before => $nb_of_days_before, after => $nb_of_days_after });
998 is( $upcoming_mem_expires->count, 3, 'Expect three results when adding after' );
999 Koha::Patrons->search({ borrowernumber => { in => [ $patron_1->{borrowernumber}, $patron_2->{borrowernumber}, $patron_3->{borrowernumber} ] } })->delete;
1002 subtest 'holds and old_holds' => sub {
1005 my $library = $builder->build( { source => 'Branch' } );
1006 my $biblionumber_1 = $builder->build_sample_biblio->biblionumber;
1007 my $item_1 = $builder->build_sample_item(
1009 library => $library->{branchcode},
1010 biblionumber => $biblionumber_1,
1013 my $item_2 = $builder->build_sample_item(
1015 library => $library->{branchcode},
1016 biblionumber => $biblionumber_1,
1019 my $biblionumber_2 = $builder->build_sample_biblio->biblionumber;
1020 my $item_3 = $builder->build_sample_item(
1022 library => $library->{branchcode},
1023 biblionumber => $biblionumber_2,
1027 my $patron = $builder->build(
1029 source => 'Borrower',
1030 value => { branchcode => $library->{branchcode} }
1034 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1035 my $holds = $patron->holds;
1036 is( ref($holds), 'Koha::Holds',
1037 'Koha::Patron->holds should return a Koha::Holds objects' );
1038 is( $holds->count, 0, 'There should not be holds placed by this patron yet' );
1040 C4::Reserves::AddReserve(
1042 branchcode => $library->{branchcode},
1043 borrowernumber => $patron->borrowernumber,
1044 biblionumber => $biblionumber_1
1048 C4::Reserves::AddReserve(
1050 branchcode => $library->{branchcode},
1051 borrowernumber => $patron->borrowernumber,
1052 biblionumber => $biblionumber_2,
1053 expiration_date => dt_from_string->add( days => 2 )
1057 $holds = $patron->holds;
1058 is( $holds->count, 2, 'There should be 2 holds placed by this patron' );
1060 my $old_holds = $patron->old_holds;
1061 is( ref($old_holds), 'Koha::Old::Holds',
1062 'Koha::Patron->old_holds should return a Koha::Old::Holds objects' );
1063 is( $old_holds->count, 0, 'There should not be any old holds yet');
1065 my $hold = $holds->next;
1068 $old_holds = $patron->old_holds;
1069 is( $old_holds->count, 1, 'There should be 1 old (cancelled) hold');
1076 subtest 'search_patrons_to_anonymise' => sub {
1080 # TODO create a subroutine in t::lib::Mocks
1081 my $branch = $builder->build({ source => 'Branch' });
1082 my $userenv_patron = $builder->build_object({
1083 class => 'Koha::Patrons',
1084 value => { branchcode => $branch->{branchcode}, flags => 0 },
1086 t::lib::Mocks::mock_userenv({ patron => $userenv_patron });
1088 my $anonymous = $builder->build( { source => 'Borrower', }, );
1090 t::lib::Mocks::mock_preference( 'AnonymousPatron', $anonymous->{borrowernumber} );
1092 subtest 'Anonymous Patron should be undeleteable' => sub {
1095 my $anonymous_patron = Koha::Patrons->find( $anonymous->{borrowernumber} );
1096 throws_ok { $anonymous_patron->delete(); }
1097 'Koha::Exceptions::Patron::FailedDeleteAnonymousPatron',
1098 'Attempt to delete anonymous patron throws exception.';
1099 $anonymous_patron = Koha::Patrons->find( $anonymous->{borrowernumber} );
1100 is( $anonymous_patron->id, $anonymous->{borrowernumber}, "Anonymous Patron was not deleted" );
1103 subtest 'patron privacy is 1 (default)' => sub {
1106 t::lib::Mocks::mock_preference('IndependentBranches', 0);
1107 my $patron = $builder->build(
1108 { source => 'Borrower',
1109 value => { privacy => 1, }
1112 my $item_1 = $builder->build_sample_item;
1113 my $issue_1 = $builder->build(
1114 { source => 'Issue',
1116 borrowernumber => $patron->{borrowernumber},
1117 itemnumber => $item_1->itemnumber,
1121 my $item_2 = $builder->build_sample_item;
1122 my $issue_2 = $builder->build(
1123 { source => 'Issue',
1125 borrowernumber => $patron->{borrowernumber},
1126 itemnumber => $item_2->itemnumber,
1131 my ( $returned_1, undef, undef ) = C4::Circulation::AddReturn( $item_1->barcode, undef, undef, dt_from_string('2010-10-10') );
1132 my ( $returned_2, undef, undef ) = C4::Circulation::AddReturn( $item_2->barcode, undef, undef, dt_from_string('2011-11-11') );
1133 is( $returned_1 && $returned_2, 1, 'The items should have been returned' );
1135 my $patrons_to_anonymise = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->search( { 'me.borrowernumber' => $patron->{borrowernumber} } );
1136 is( ref($patrons_to_anonymise), 'Koha::Patrons', 'search_patrons_to_anonymise should return Koha::Patrons' );
1138 my $rows_affected = Koha::Old::Checkouts->search(
1141 Koha::Patrons->search_patrons_to_anonymise(
1142 { before => '2011-11-12' }
1143 )->get_column('borrowernumber')
1145 returndate => { '<' => '2011-10-11', }
1148 ok( $rows_affected > 0, 'AnonymiseIssueHistory should affect at least 1 row' );
1150 $patrons_to_anonymise = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } );
1151 is( $patrons_to_anonymise->count, 0, 'search_patrons_to_anonymise should return 0 after anonymisation is done' );
1153 my $dbh = C4::Context->dbh;
1154 my $sth = $dbh->prepare(q|SELECT borrowernumber FROM old_issues where itemnumber = ?|);
1155 $sth->execute($item_1->itemnumber);
1156 my ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1157 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'With privacy=1, the issue should have been anonymised' );
1158 $sth->execute($item_2->itemnumber);
1159 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1160 is( $borrowernumber_used_to_anonymised, $patron->{borrowernumber}, 'The issue should not have been anonymised, the returned date is later' );
1162 $rows_affected = Koha::Old::Checkouts->search(
1165 Koha::Patrons->search_patrons_to_anonymise(
1166 { before => '2011-11-12' }
1167 )->get_column('borrowernumber')
1169 returndate => { '<' => '2011-11-12', }
1172 $sth->execute($item_2->itemnumber);
1173 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1174 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue should have been anonymised, the returned date is before' );
1176 my $sth_reset = $dbh->prepare(q|UPDATE old_issues SET borrowernumber = ? WHERE itemnumber = ?|);
1177 $sth_reset->execute( $patron->{borrowernumber}, $item_1->itemnumber );
1178 $sth_reset->execute( $patron->{borrowernumber}, $item_2->itemnumber );
1179 $rows_affected = Koha::Old::Checkouts->search(
1182 Koha::Patrons->search_patrons_to_anonymise->get_column(
1187 $sth->execute($item_1->itemnumber);
1188 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1189 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 1 should have been anonymised, before parameter was not passed' );
1190 $sth->execute($item_2->itemnumber);
1191 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1192 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 2 should have been anonymised, before parameter was not passed' );
1194 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1197 subtest 'patron privacy is 0 (forever)' => sub {
1200 t::lib::Mocks::mock_preference('IndependentBranches', 0);
1201 my $patron = $builder->build(
1202 { source => 'Borrower',
1203 value => { privacy => 0, }
1206 my $item = $builder->build_sample_item;
1207 my $issue = $builder->build(
1208 { source => 'Issue',
1210 borrowernumber => $patron->{borrowernumber},
1211 itemnumber => $item->itemnumber,
1216 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->barcode, undef, undef, dt_from_string('2010-10-10') );
1217 is( $returned, 1, 'The item should have been returned' );
1219 my $dbh = C4::Context->dbh;
1220 my ($borrowernumber_used_to_anonymised) = $dbh->selectrow_array(q|
1221 SELECT borrowernumber FROM old_issues where itemnumber = ?
1222 |, undef, $item->itemnumber);
1223 is( $borrowernumber_used_to_anonymised, $patron->{borrowernumber}, 'With privacy=0, the issue should not be anonymised' );
1224 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1227 t::lib::Mocks::mock_preference( 'AnonymousPatron', '' );
1229 subtest 'AnonymousPatron is not defined' => sub {
1233 t::lib::Mocks::mock_preference('IndependentBranches', 0);
1234 my $patron = $builder->build(
1235 { source => 'Borrower',
1236 value => { privacy => 1, }
1239 my $item = $builder->build_sample_item;
1240 my $issue = $builder->build(
1241 { source => 'Issue',
1243 borrowernumber => $patron->{borrowernumber},
1244 itemnumber => $item->itemnumber,
1249 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->barcode, undef, undef, dt_from_string('2010-10-10') );
1250 is( $returned, 1, 'The item should have been returned' );
1251 my $patrons_to_anonymize = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } );
1252 ok( $patrons_to_anonymize->count > 0, 'search_patrons_to_anonymize' );
1254 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1257 subtest 'Logged in librarian is not superlibrarian & IndependentBranches' => sub {
1259 t::lib::Mocks::mock_preference( 'IndependentBranches', 1 );
1260 my $patron = $builder->build(
1261 { source => 'Borrower',
1262 value => { privacy => 1 } # Another branchcode than the logged in librarian
1265 my $item = $builder->build_sample_item;
1266 my $issue = $builder->build(
1267 { source => 'Issue',
1269 borrowernumber => $patron->{borrowernumber},
1270 itemnumber => $item->itemnumber,
1275 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->barcode, undef, undef, dt_from_string('2010-10-10') );
1276 is( Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->count, 0 );
1277 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1280 Koha::Patrons->find( $anonymous->{borrowernumber})->delete;
1281 $userenv_patron->delete;
1283 # Reset IndependentBranches for further tests
1284 t::lib::Mocks::mock_preference('IndependentBranches', 0);
1287 subtest 'libraries_where_can_see_patrons + can_see_patron_infos + search_limited' => sub {
1295 $nb_of_patrons = Koha::Patrons->search->count;
1296 my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_hide_patron_info => 1 } )->store;
1297 my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_hide_patron_info => 1 } )->store;
1298 my $library_11 = $builder->build( { source => 'Branch' } );
1299 my $library_12 = $builder->build( { source => 'Branch' } );
1300 my $library_21 = $builder->build( { source => 'Branch' } );
1301 $library_11 = Koha::Libraries->find( $library_11->{branchcode} );
1302 $library_12 = Koha::Libraries->find( $library_12->{branchcode} );
1303 $library_21 = Koha::Libraries->find( $library_21->{branchcode} );
1304 Koha::Library::Group->new(
1305 { branchcode => $library_11->branchcode, parent_id => $group_1->id } )->store;
1306 Koha::Library::Group->new(
1307 { branchcode => $library_12->branchcode, parent_id => $group_1->id } )->store;
1308 Koha::Library::Group->new(
1309 { branchcode => $library_21->branchcode, parent_id => $group_2->id } )->store;
1311 my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 4, ?)|); # 4 for borrowers
1312 # 2 patrons from library_11 (group1)
1313 # patron_11_1 see patron's infos from outside its group
1314 # Setting flags => undef to not be considered as superlibrarian
1315 my $patron_11_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_11->branchcode, flags => undef, }});
1316 $patron_11_1 = Koha::Patrons->find( $patron_11_1->{borrowernumber} );
1317 $sth->execute( $patron_11_1->borrowernumber, 'edit_borrowers' );
1318 $sth->execute( $patron_11_1->borrowernumber, 'view_borrower_infos_from_any_libraries' );
1319 # patron_11_2 can only see patron's info from its group
1320 my $patron_11_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_11->branchcode, flags => undef, }});
1321 $patron_11_2 = Koha::Patrons->find( $patron_11_2->{borrowernumber} );
1322 $sth->execute( $patron_11_2->borrowernumber, 'edit_borrowers' );
1323 # 1 patron from library_12 (group1)
1324 my $patron_12 = $builder->build({ source => 'Borrower', value => { branchcode => $library_12->branchcode, flags => undef, }});
1325 $patron_12 = Koha::Patrons->find( $patron_12->{borrowernumber} );
1326 # 1 patron from library_21 (group2) can only see patron's info from its group
1327 my $patron_21 = $builder->build({ source => 'Borrower', value => { branchcode => $library_21->branchcode, flags => undef, }});
1328 $patron_21 = Koha::Patrons->find( $patron_21->{borrowernumber} );
1329 $sth->execute( $patron_21->borrowernumber, 'edit_borrowers' );
1331 # Pfiou, we can start now!
1332 subtest 'libraries_where_can_see_patrons' => sub {
1337 t::lib::Mocks::mock_userenv({ patron => $patron_11_1 });
1338 @branchcodes = $patron_11_1->libraries_where_can_see_patrons;
1339 is_deeply( \@branchcodes, [], q|patron_11_1 has view_borrower_infos_from_any_libraries => No restriction| );
1341 t::lib::Mocks::mock_userenv({ patron => $patron_11_2 });
1342 @branchcodes = $patron_11_2->libraries_where_can_see_patrons;
1343 is_deeply( \@branchcodes, [ sort ( $library_11->branchcode, $library_12->branchcode ) ], q|patron_11_2 has not view_borrower_infos_from_any_libraries => Can only see patron's from its group| );
1345 t::lib::Mocks::mock_userenv({ patron => $patron_21 });
1346 @branchcodes = $patron_21->libraries_where_can_see_patrons;
1347 is_deeply( \@branchcodes, [$library_21->branchcode], q|patron_21 has not view_borrower_infos_from_any_libraries => Can only see patron's from its group| );
1349 subtest 'can_see_patron_infos' => sub {
1352 t::lib::Mocks::mock_userenv({ patron => $patron_11_1 });
1353 is( $patron_11_1->can_see_patron_infos( $patron_11_2 ), 1, q|patron_11_1 can see patron_11_2, from its library| );
1354 is( $patron_11_1->can_see_patron_infos( $patron_12 ), 1, q|patron_11_1 can see patron_12, from its group| );
1355 is( $patron_11_1->can_see_patron_infos( $patron_21 ), 1, q|patron_11_1 can see patron_11_2, from another group| );
1357 t::lib::Mocks::mock_userenv({ patron => $patron_11_2 });
1358 is( $patron_11_2->can_see_patron_infos( $patron_11_1 ), 1, q|patron_11_2 can see patron_11_1, from its library| );
1359 is( $patron_11_2->can_see_patron_infos( $patron_12 ), 1, q|patron_11_2 can see patron_12, from its group| );
1360 is( $patron_11_2->can_see_patron_infos( $patron_21 ), 0, q|patron_11_2 can NOT see patron_21, from another group| );
1362 subtest 'search_limited' => sub {
1365 t::lib::Mocks::mock_userenv({ patron => $patron_11_1 });
1366 my $total_number_of_patrons = $nb_of_patrons + 4; #we added four in these tests
1367 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons' );
1368 is( Koha::Patrons->search_limited->count, $total_number_of_patrons, 'patron_11_1 is allowed to see all patrons' );
1370 t::lib::Mocks::mock_userenv({ patron => $patron_11_2 });
1371 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1372 is( Koha::Patrons->search_limited->count, 3, 'patron_12_1 is not allowed to see patrons from other groups, only patron_11_1, patron_11_2 and patron_12' );
1374 t::lib::Mocks::mock_userenv({ patron => $patron_21 });
1375 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1376 is( Koha::Patrons->search_limited->count, 1, 'patron_21 is not allowed to see patrons from other groups, only himself' );
1378 $patron_11_1->delete;
1379 $patron_11_2->delete;
1384 subtest 'account_locked' => sub {
1386 my $patron = $builder->build({ source => 'Borrower', value => { login_attempts => 0 } });
1387 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1388 for my $value ( undef, '', 0 ) {
1389 t::lib::Mocks::mock_preference('FailedloginAttempts', $value);
1390 $patron->login_attempts(0)->store;
1391 is( $patron->account_locked, 0, 'Feature is disabled, patron account should not be considered locked' );
1392 $patron->login_attempts(1)->store;
1393 is( $patron->account_locked, 0, 'Feature is disabled, patron account should not be considered locked' );
1394 $patron->login_attempts(-1)->store;
1395 is( $patron->account_locked, 1, 'Feature is disabled but administrative lockout has been triggered' );
1398 t::lib::Mocks::mock_preference('FailedloginAttempts', 3);
1399 $patron->login_attempts(2)->store;
1400 is( $patron->account_locked, 0, 'Patron has 2 failed attempts, account should not be considered locked yet' );
1401 $patron->login_attempts(3)->store;
1402 is( $patron->account_locked, 1, 'Patron has 3 failed attempts, account should be considered locked yet' );
1403 $patron->login_attempts(4)->store;
1404 is( $patron->account_locked, 1, 'Patron could not have 4 failed attempts, but account should still be considered locked' );
1405 $patron->login_attempts(-1)->store;
1406 is( $patron->account_locked, 1, 'Administrative lockout triggered' );
1411 subtest 'is_child | is_adult' => sub {
1413 my $category = $builder->build_object(
1415 class => 'Koha::Patron::Categories',
1416 value => { category_type => 'A' }
1419 my $patron_adult = $builder->build_object(
1421 class => 'Koha::Patrons',
1422 value => { categorycode => $category->categorycode }
1425 $category = $builder->build_object(
1427 class => 'Koha::Patron::Categories',
1428 value => { category_type => 'I' }
1431 my $patron_adult_i = $builder->build_object(
1433 class => 'Koha::Patrons',
1434 value => { categorycode => $category->categorycode }
1437 $category = $builder->build_object(
1439 class => 'Koha::Patron::Categories',
1440 value => { category_type => 'C' }
1443 my $patron_child = $builder->build_object(
1445 class => 'Koha::Patrons',
1446 value => { categorycode => $category->categorycode }
1449 $category = $builder->build_object(
1451 class => 'Koha::Patron::Categories',
1452 value => { category_type => 'O' }
1455 my $patron_other = $builder->build_object(
1457 class => 'Koha::Patrons',
1458 value => { categorycode => $category->categorycode }
1461 is( $patron_adult->is_adult, 1, 'Patron from category A should be considered adult' );
1462 is( $patron_adult_i->is_adult, 1, 'Patron from category I should be considered adult' );
1463 is( $patron_child->is_adult, 0, 'Patron from category C should not be considered adult' );
1464 is( $patron_other->is_adult, 0, 'Patron from category O should not be considered adult' );
1466 is( $patron_adult->is_child, 0, 'Patron from category A should be considered child' );
1467 is( $patron_adult_i->is_child, 0, 'Patron from category I should be considered child' );
1468 is( $patron_child->is_child, 1, 'Patron from category C should not be considered child' );
1469 is( $patron_other->is_child, 0, 'Patron from category O should not be considered child' );
1472 $patron_adult->delete;
1473 $patron_adult_i->delete;
1474 $patron_child->delete;
1475 $patron_other->delete;
1478 subtest 'overdues' => sub {
1481 my $library = $builder->build( { source => 'Branch' } );
1482 my $biblionumber_1 = $builder->build_sample_biblio->biblionumber;
1483 my $item_1 = $builder->build_sample_item(
1485 library => $library->{branchcode},
1486 biblionumber => $biblionumber_1,
1489 my $item_2 = $builder->build_sample_item(
1491 library => $library->{branchcode},
1492 biblionumber => $biblionumber_1,
1495 my $item_3 = $builder->build_sample_item(
1497 library => $library->{branchcode},
1501 my $patron = $builder->build(
1503 source => 'Borrower',
1504 value => { branchcode => $library->{branchcode} }
1508 t::lib::Mocks::mock_preference({ branchcode => $library->{branchcode} });
1510 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1512 AddIssue( $patron, $item_1->barcode, DateTime->now->subtract( days => 1 ) );
1513 AddIssue( $patron, $item_2->barcode, DateTime->now->subtract( days => 5 ) );
1514 AddIssue( $patron, $item_3->barcode );
1516 my $overdues = $patron->overdues;
1517 is( $overdues->count, 2, 'Patron should have 2 overdues');
1518 is( $overdues->next->itemnumber, $item_1->itemnumber, 'The issue should be returned in the same order as they have been done, first is correct' );
1519 is( $overdues->next->itemnumber, $item_2->itemnumber, 'The issue should be returned in the same order as they have been done, second is correct' );
1521 my $o = $overdues->reset->next;
1522 my $unblessed_overdue = $o->unblessed_all_relateds;
1523 is( exists( $unblessed_overdue->{issuedate} ), 1, 'Fields from the issues table should be filled' );
1524 is( exists( $unblessed_overdue->{itemcallnumber} ), 1, 'Fields from the items table should be filled' );
1525 is( exists( $unblessed_overdue->{title} ), 1, 'Fields from the biblio table should be filled' );
1526 is( exists( $unblessed_overdue->{itemtype} ), 1, 'Fields from the biblioitems table should be filled' );
1529 $patron->checkouts->delete;
1533 subtest 'userid_is_valid' => sub {
1536 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1537 my $patron_category = $builder->build_object(
1539 class => 'Koha::Patron::Categories',
1540 value => { category_type => 'P', enrolmentfee => 0 }
1544 cardnumber => "123456789",
1545 firstname => "Tomasito",
1547 categorycode => $patron_category->categorycode,
1548 branchcode => $library->branchcode,
1551 my $expected_userid_patron_1 = 'tomasito.none';
1552 my $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1553 my $patron_1 = Koha::Patrons->find($borrowernumber);
1554 is( $patron_1->has_valid_userid, 1, "Should be valid when compared against them self" );
1555 is ( $patron_1->userid, $expected_userid_patron_1, 'The userid generated should be the one we expect' );
1557 $patron_1->userid( 'tomasito.non' );
1558 is( $patron_1->has_valid_userid, # FIXME Joubu: What is the difference with the next test?
1559 1, 'recently created userid -> unique (borrowernumber passed)' );
1561 $patron_1->userid( 'tomasitoxxx' );
1562 is( $patron_1->has_valid_userid,
1563 1, 'non-existent userid -> unique (borrowernumber passed)' );
1564 $patron_1->discard_changes; # We compare with the original userid later
1566 my $patron_not_in_storage = Koha::Patron->new( { userid => '' } );
1567 is( $patron_not_in_storage->has_valid_userid,
1568 0, 'userid exists for another patron, patron is not in storage yet' );
1570 $patron_not_in_storage = Koha::Patron->new( { userid => 'tomasitoxxx' } );
1571 is( $patron_not_in_storage->has_valid_userid,
1572 1, 'non-existent userid, patron is not in storage yet' );
1574 # Regression tests for BZ12226
1575 my $db_patron = Koha::Patron->new( { userid => C4::Context->config('user') } );
1576 is( $db_patron->has_valid_userid,
1577 0, 'Koha::Patron->has_valid_userid should return 0 for the DB user (Bug 12226)' );
1579 # Add a new borrower with the same userid but different cardnumber
1580 $data{cardnumber} = "987654321";
1581 my $new_borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1582 my $patron_2 = Koha::Patrons->find($new_borrowernumber);
1583 $patron_2->userid($patron_1->userid);
1584 is( $patron_2->has_valid_userid,
1585 0, 'The userid is already in used, it cannot be used for another patron' );
1587 my $new_userid = 'a_user_id';
1588 $data{cardnumber} = "234567890";
1589 $data{userid} = 'a_user_id';
1590 $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1591 my $patron_3 = Koha::Patrons->find($borrowernumber);
1592 is( $patron_3->userid, $new_userid,
1593 'Koha::Patron->store should insert the given userid' );
1601 $nb_of_patrons = Koha::Patrons->search->count;
1602 $retrieved_patron_1->delete;
1603 is( Koha::Patrons->search->count, $nb_of_patrons - 1, 'Delete should have deleted the patron' );
1605 subtest 'BorrowersLog tests' => sub {
1608 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
1609 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
1611 my $cardnumber = $patron->cardnumber;
1612 $patron->set( { cardnumber => 'TESTCARDNUMBER' });
1615 my @logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber } );
1616 my $log_info = from_json( $logs[0]->info );
1617 is( $log_info->{cardnumber}->{after}, 'TESTCARDNUMBER', 'Got correct new cardnumber' );
1618 is( $log_info->{cardnumber}->{before}, $cardnumber, 'Got correct old cardnumber' );
1619 is( scalar @logs, 1, 'With BorrowerLogs, one detailed MODIFY action should be logged for the modification.' );
1621 t::lib::Mocks::mock_preference( 'TrackLastPatronActivity', 1 );
1622 $patron->track_login();
1623 @logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber } );
1624 is( scalar @logs, 1, 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs');
1627 $schema->storage->txn_rollback;
1629 subtest 'Test Koha::Patrons::merge' => sub {
1632 my $schema = Koha::Database->new()->schema();
1634 my $resultsets = $Koha::Patron::RESULTSET_PATRON_ID_MAPPING;
1636 $schema->storage->txn_begin;
1638 my $keeper = $builder->build_object({ class => 'Koha::Patrons' });
1639 my $loser_1 = $builder->build({ source => 'Borrower' })->{borrowernumber};
1640 my $loser_2 = $builder->build({ source => 'Borrower' })->{borrowernumber};
1642 my $anonymous_patron_orig = C4::Context->preference('AnonymousPatron');
1643 my $anonymous_patron = $builder->build({ source => 'Borrower' })->{borrowernumber};
1644 t::lib::Mocks::mock_preference( 'AnonymousPatron', $anonymous_patron );
1646 while (my ($r, $field) = each(%$resultsets)) {
1647 $builder->build({ source => $r, value => { $field => $keeper->id } });
1648 $builder->build({ source => $r, value => { $field => $loser_1 } });
1649 $builder->build({ source => $r, value => { $field => $loser_2 } });
1652 $schema->resultset($r)->search( { $field => $keeper->id } );
1653 is( $keeper_rs->count(), 1, "Found 1 $r rows for keeper" );
1656 $schema->resultset($r)->search( { $field => $loser_1 } );
1657 is( $loser_1_rs->count(), 1, "Found 1 $r rows for loser_1" );
1660 $schema->resultset($r)->search( { $field => $loser_2 } );
1661 is( $loser_2_rs->count(), 1, "Found 1 $r rows for loser_2" );
1664 my $results = $keeper->merge_with([ $loser_1, $loser_2 ]);
1666 while (my ($r, $field) = each(%$resultsets)) {
1668 $schema->resultset($r)->search( {$field => $keeper->id } );
1669 is( $keeper_rs->count(), 3, "Found 2 $r rows for keeper" );
1672 is( Koha::Patrons->find($loser_1), undef, 'Loser 1 has been deleted' );
1673 is( Koha::Patrons->find($loser_2), undef, 'Loser 2 has been deleted' );
1674 is( ref Koha::Patrons->find($anonymous_patron), 'Koha::Patron', 'Anonymous Patron was not deleted' );
1676 $anonymous_patron = Koha::Patrons->find($anonymous_patron);
1677 $results = $anonymous_patron->merge_with( [ $keeper->id ] );
1678 is( $results, undef, "Anonymous patron cannot have other patrons merged into it" );
1679 is( Koha::Patrons->search( { borrowernumber => $keeper->id } )->count, 1, "Patron from attempted merge with AnonymousPatron still exists" );
1681 subtest 'extended attributes' => sub {
1685 $builder->build_object( { class => 'Koha::Patrons' } );
1687 $builder->build_object( { class => 'Koha::Patrons' } );
1689 my $attribute_type_normal_1 = $builder->build_object(
1691 class => 'Koha::Patron::Attribute::Types',
1692 value => { repeatable => 0, unique_id => 0 }
1695 my $attribute_type_normal_2 = $builder->build_object(
1697 class => 'Koha::Patron::Attribute::Types',
1698 value => { repeatable => 0, unique_id => 0 }
1702 my $attribute_type_repeatable = $builder->build_object(
1704 class => 'Koha::Patron::Attribute::Types',
1705 value => { repeatable => 1, unique_id => 0 }
1711 code => $attribute_type_normal_1->code,
1712 attribute => 'from attr 1'
1715 code => $attribute_type_repeatable->code,
1716 attribute => 'from attr repeatable'
1722 code => $attribute_type_normal_2->code,
1723 attribute => 'to attr 2'
1726 code => $attribute_type_repeatable->code,
1727 attribute => 'to attr repeatable'
1731 $keep_patron->extended_attributes($attr_keep);
1732 $merge_patron->extended_attributes($attr_merge);
1734 $keep_patron->merge_with( [ $merge_patron->borrowernumber ] );
1735 my $merged_attributes = $keep_patron->extended_attributes;
1736 is( $merged_attributes->count, 4 );
1738 sub compare_attributes {
1739 my ( $got, $expected, $code ) = @_;
1743 sort $got->search( { code => $code } )
1744 ->get_column('attribute')
1752 $attribute_type_normal_1->code
1757 $attribute_type_normal_2->code
1761 [ 'from attr repeatable', 'to attr repeatable' ],
1762 $attribute_type_repeatable->code
1766 $keep_patron->delete;
1767 $merge_patron->delete;
1769 # Recreate but don't expect an exception if 2 non-repeatable attributes exist, pick the one from the patron we keep
1771 $builder->build_object( { class => 'Koha::Patrons' } );
1773 $builder->build_object( { class => 'Koha::Patrons' } );
1775 $keep_patron->extended_attributes($attr_keep);
1776 $merge_patron->extended_attributes(
1780 code => $attribute_type_normal_1->code,
1781 attribute => 'yet another attribute for non-repeatable'
1786 $keep_patron->merge_with( [ $merge_patron->borrowernumber ] );
1787 $merged_attributes = $keep_patron->extended_attributes;
1788 is( $merged_attributes->count, 4 );
1792 $attribute_type_normal_1->code
1797 $attribute_type_normal_2->code
1801 [ 'from attr repeatable', 'to attr repeatable' ],
1802 $attribute_type_repeatable->code
1807 t::lib::Mocks::mock_preference( 'AnonymousPatron', '' );
1808 $schema->storage->txn_rollback;
1811 subtest '->store' => sub {
1813 my $schema = Koha::Database->new->schema;
1814 $schema->storage->txn_begin;
1816 my $patron_1 = $builder->build_object({class=> 'Koha::Patrons'});
1817 my $patron_2 = $builder->build_object({class=> 'Koha::Patrons'});
1819 throws_ok { $patron_2->userid( $patron_1->userid )->store; }
1820 'Koha::Exceptions::Patron::InvalidUserid',
1821 'Koha::Patron->store raises an exception on duplicate ID';
1823 # Clear userid and check regeneration
1824 $patron_2->userid(undef)->store;
1825 like( $patron_2->userid, qr/\w+\.\w+/, 'Userid regenerated' ); # old school userid
1826 $patron_2->userid('')->store;
1827 like( $patron_2->userid, qr/\w+\.\w+/, 'Userid regenerated' ); # old school userid
1828 $patron_2->userid(0)->store;
1829 like( $patron_2->userid, qr/\w+\.\w+/, 'Userid regenerated' ); # old school userid
1832 t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
1833 my $password = 'password';
1834 $patron_1->set_password({ password => $password });
1835 like( $patron_1->password, qr|^\$2|, 'Password should be hashed using bcrypt (start with $2)' );
1836 my $digest = $patron_1->password;
1837 $patron_1->surname('xxx')->store;
1838 is( $patron_1->password, $digest, 'Password should not have changed on ->store');
1840 # Test uppercasesurnames
1841 t::lib::Mocks::mock_preference( 'uppercasesurnames', 1 );
1842 my $surname = lc $patron_1->surname;
1843 $patron_1->surname($surname)->store;
1844 isnt( $patron_1->surname, $surname,
1845 'Surname converts to uppercase on store.');
1846 t::lib::Mocks::mock_preference( 'uppercasesurnames', 0 );
1847 $patron_1->surname($surname)->store;
1848 is( $patron_1->surname, $surname,
1849 'Surname remains unchanged on store.');
1852 $patron_1->relationship("")->store;
1853 is( $patron_1->relationship, undef, );
1855 $schema->storage->txn_rollback;
1857 subtest 'skip updated_on for BorrowersLog' => sub {
1859 $schema->storage->txn_begin;
1860 t::lib::Mocks::mock_preference('BorrowersLog', 1);
1861 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
1862 $patron->updated_on(dt_from_string($patron->updated_on)->add( seconds => 1 ))->store;
1863 my $logs = Koha::ActionLogs->search({ module =>'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber });
1864 is($logs->count, 0, '->store should not have generated a log for updated_on') or diag 'Log generated:'.Dumper($logs->unblessed);
1865 $schema->storage->txn_rollback;
1868 subtest 'create user usage' => sub {
1870 $schema->storage->txn_begin;
1872 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1873 my $patron_category = $builder->build_object(
1875 class => 'Koha::Patron::Categories',
1876 value => { category_type => 'P', enrolmentfee => 0 }
1880 cardnumber => "123456789",
1881 firstname => "Tômà sÃtó",
1882 surname => "Ñoné",
1883 password => 'Funk3y',
1884 categorycode => $patron_category->categorycode,
1885 branchcode => $library->branchcode,
1888 # Enable notifying patrons of password changes for these tests
1889 t::lib::Mocks::mock_preference( 'NotifyPasswordChange', 1 );
1890 my $new_patron = Koha::Patron->new( \%data )->store();
1891 my $queued_notices = Koha::Notice::Messages->search(
1892 { borrowernumber => $new_patron->borrowernumber }
1895 $queued_notices->count, 0,
1896 "No notice queued when NotifyPasswordChange enabled and this is a new patron"
1899 $schema->storage->txn_rollback;
1903 subtest '->set_password' => sub {
1907 t::lib::Mocks::mock_preference( 'EmailFieldPrecedence', 'emailpro|email' );
1909 $schema->storage->txn_begin;
1911 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { login_attempts => 3 } } );
1913 # Disable logging password changes for these tests
1914 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
1916 # Disable notifying patrons of password changes for these tests
1917 t::lib::Mocks::mock_preference( 'NotifyPasswordChange', 0 );
1919 # Password-length tests
1920 t::lib::Mocks::mock_preference( 'minPasswordLength', undef );
1921 throws_ok { $patron->set_password({ password => 'ab' }); }
1922 'Koha::Exceptions::Password::TooShort',
1923 'minPasswordLength is undef, fall back to 3, fail test';
1925 'Password length (2) is shorter than required (3)',
1926 'Exception parameters passed correctly'
1929 t::lib::Mocks::mock_preference( 'minPasswordLength', 2 );
1930 throws_ok { $patron->set_password({ password => 'ab' }); }
1931 'Koha::Exceptions::Password::TooShort',
1932 'minPasswordLength is 2, fall back to 3, fail test';
1934 t::lib::Mocks::mock_preference( 'minPasswordLength', 5 );
1935 throws_ok { $patron->set_password({ password => 'abcb' }); }
1936 'Koha::Exceptions::Password::TooShort',
1937 'minPasswordLength is 5, fail test';
1939 # Trailing spaces tests
1940 throws_ok { $patron->set_password({ password => 'abcD12d ' }); }
1941 'Koha::Exceptions::Password::WhitespaceCharacters',
1942 'Password contains trailing spaces, exception is thrown';
1944 # Require strong password tests
1945 t::lib::Mocks::mock_preference( 'RequireStrongPassword', 1 );
1946 throws_ok { $patron->set_password({ password => 'abcd a' }); }
1947 'Koha::Exceptions::Password::TooWeak',
1948 'Password is too weak, exception is thrown';
1950 # Refresh patron from DB, just to make sure
1951 $patron->discard_changes;
1952 is( $patron->login_attempts, 3, 'Previous tests kept login attemps count' );
1954 $patron->set_password({ password => 'abcD12 34' });
1955 $patron->discard_changes;
1957 is( $patron->login_attempts, 0, 'Changing the password resets the login attempts count' );
1959 lives_ok { $patron->set_password({ password => 'abcd a', skip_validation => 1 }) }
1960 'Password is weak, but skip_validation was passed, so no exception thrown';
1963 t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
1964 $patron->login_attempts(3)->store;
1965 my $old_digest = $patron->password;
1966 $patron->set_password({ password => 'abcd a' });
1967 $patron->discard_changes;
1969 isnt( $patron->password, $old_digest, 'Password has been updated' );
1970 ok( checkpw_hash('abcd a', $patron->password), 'Password hash is correct' );
1971 is( $patron->login_attempts, 0, 'Login attemps have been reset' );
1973 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
1974 is( $number_of_logs, 0, 'Without BorrowerLogs, Koha::Patron->set_password doesn\'t log password changes' );
1976 # Enable logging password changes
1977 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
1978 $patron->set_password({ password => 'abcd b' });
1980 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
1981 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->set_password does log password changes' );
1983 # Enable notifying patrons of password changes
1984 t::lib::Mocks::mock_preference( 'NotifyPasswordChange', 1 );
1985 $patron->set_password({ password => 'abcd c' });
1986 my $queued_notices = Koha::Notice::Messages->search({ borrowernumber => $patron->borrowernumber });
1987 is( $queued_notices->count, 1, "One notice queued when NotifyPasswordChange enabled" );
1988 my $THE_notice = $queued_notices->next;
1989 is( $THE_notice->status, 'failed', "The notice was handled immediately and failed on wrong email address."); #FIXME Mock sending mail
1990 $schema->storage->txn_rollback;
1993 $schema->storage->txn_begin;
1994 subtest 'filter_by_expiration_date' => sub {
1996 my $count1 = Koha::Patrons->filter_by_expiration_date({ days => 28 })->count;
1997 my $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
1998 $patron1->dateexpiry( dt_from_string->subtract(days => 27) )->store;
1999 is( Koha::Patrons->filter_by_expiration_date({ days => 28 })->count, $count1, 'No more expired' );
2000 $patron1->dateexpiry( dt_from_string->subtract(days => 28) )->store;
2001 is( Koha::Patrons->filter_by_expiration_date({ days => 28 })->count, $count1 + 1, 'One more expired' );
2002 $patron1->dateexpiry( dt_from_string->subtract(days => 29) )->store;
2003 is( Koha::Patrons->filter_by_expiration_date({ days => 28 })->count, $count1 + 1, 'Same number again' );
2006 subtest 'search_unsubscribed' => sub {
2009 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 3 );
2010 t::lib::Mocks::mock_preference( 'UnsubscribeReflectionDelay', '' );
2011 is( Koha::Patrons->search_unsubscribed->count, 0, 'Empty delay should return empty set' );
2013 my $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
2014 my $patron2 = $builder->build_object({ class => 'Koha::Patrons' });
2016 t::lib::Mocks::mock_preference( 'UnsubscribeReflectionDelay', 0 );
2017 Koha::Patron::Consents->delete; # for correct counts
2018 Koha::Patron::Consent->new({ borrowernumber => $patron1->borrowernumber, type => 'GDPR_PROCESSING', refused_on => dt_from_string })->store;
2019 is( Koha::Patrons->search_unsubscribed->count, 1, 'Find patron1' );
2021 # Add another refusal but shift the period
2022 t::lib::Mocks::mock_preference( 'UnsubscribeReflectionDelay', 2 );
2023 Koha::Patron::Consent->new({ borrowernumber => $patron2->borrowernumber, type => 'GDPR_PROCESSING', refused_on => dt_from_string->subtract(days=>2) })->store;
2024 is( Koha::Patrons->search_unsubscribed->count, 1, 'Find patron2 only' );
2026 # Try another (special) attempts setting
2027 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 0 );
2028 # Lockout is now disabled
2029 # Patron2 still matches: refused earlier, not locked
2030 is( Koha::Patrons->search_unsubscribed->count, 1, 'Lockout disabled' );
2033 subtest 'search_anonymize_candidates' => sub {
2035 my $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
2036 my $patron2 = $builder->build_object({ class => 'Koha::Patrons' });
2037 $patron1->anonymized(0);
2038 $patron1->dateexpiry( dt_from_string->add(days => 1) )->store;
2039 $patron2->anonymized(0);
2040 $patron2->dateexpiry( dt_from_string->add(days => 1) )->store;
2042 t::lib::Mocks::mock_preference( 'PatronAnonymizeDelay', q{} );
2043 is( Koha::Patrons->search_anonymize_candidates->count, 0, 'Empty set' );
2045 t::lib::Mocks::mock_preference( 'PatronAnonymizeDelay', 0 );
2046 my $cnt = Koha::Patrons->search_anonymize_candidates->count;
2047 $patron1->dateexpiry( dt_from_string->subtract(days => 1) )->store;
2048 $patron2->dateexpiry( dt_from_string->subtract(days => 3) )->store;
2049 is( Koha::Patrons->search_anonymize_candidates->count, $cnt+2, 'Delay 0' );
2051 t::lib::Mocks::mock_preference( 'PatronAnonymizeDelay', 2 );
2052 $patron1->dateexpiry( dt_from_string->add(days => 1) )->store;
2053 $patron2->dateexpiry( dt_from_string->add(days => 1) )->store;
2054 $cnt = Koha::Patrons->search_anonymize_candidates->count;
2055 $patron1->dateexpiry( dt_from_string->subtract(days => 1) )->store;
2056 $patron2->dateexpiry( dt_from_string->subtract(days => 3) )->store;
2057 is( Koha::Patrons->search_anonymize_candidates->count, $cnt+1, 'Delay 2' );
2059 t::lib::Mocks::mock_preference( 'PatronAnonymizeDelay', 4 );
2060 $patron1->dateexpiry( dt_from_string->add(days => 1) )->store;
2061 $patron2->dateexpiry( dt_from_string->add(days => 1) )->store;
2062 $cnt = Koha::Patrons->search_anonymize_candidates->count;
2063 $patron1->dateexpiry( dt_from_string->subtract(days => 1) )->store;
2064 $patron2->dateexpiry( dt_from_string->subtract(days => 3) )->store;
2065 is( Koha::Patrons->search_anonymize_candidates->count, $cnt, 'Delay 4' );
2067 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 3 );
2068 $patron1->dateexpiry( dt_from_string->subtract(days => 5) )->store;
2069 $patron1->login_attempts(0)->store;
2070 $patron2->dateexpiry( dt_from_string->subtract(days => 5) )->store;
2071 $patron2->login_attempts(0)->store;
2072 $cnt = Koha::Patrons->search_anonymize_candidates({locked => 1})->count;
2073 $patron1->login_attempts(3)->store;
2074 is( Koha::Patrons->search_anonymize_candidates({locked => 1})->count,
2075 $cnt+1, 'Locked flag' );
2077 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', q{} );
2078 # Patron 1 still on 3 == locked
2079 is( Koha::Patrons->search_anonymize_candidates({locked => 1})->count,
2080 $cnt+1, 'Still expect same number for FailedLoginAttempts empty' );
2081 $patron1->login_attempts(0)->store;
2083 is( Koha::Patrons->search_anonymize_candidates({locked => 1})->count,
2084 $cnt, 'Patron 1 unlocked' );
2087 subtest 'search_anonymized' => sub {
2089 my $patron1 = $builder->build_object( { class => 'Koha::Patrons' } );
2091 t::lib::Mocks::mock_preference( 'PatronRemovalDelay', q{} );
2092 is( Koha::Patrons->search_anonymized->count, 0, 'Empty set' );
2094 t::lib::Mocks::mock_preference( 'PatronRemovalDelay', 1 );
2095 $patron1->dateexpiry( dt_from_string );
2096 $patron1->anonymized(0)->store;
2097 my $cnt = Koha::Patrons->search_anonymized->count;
2098 $patron1->anonymized(1)->store;
2099 is( Koha::Patrons->search_anonymized->count, $cnt, 'Number unchanged' );
2100 $patron1->dateexpiry( dt_from_string->subtract(days => 1) )->store;
2101 is( Koha::Patrons->search_anonymized->count, $cnt+1, 'Found patron1' );
2104 subtest 'lock' => sub {
2107 my $patron1 = $builder->build_object( { class => 'Koha::Patrons' } );
2108 my $patron2 = $builder->build_object( { class => 'Koha::Patrons' } );
2109 my $hold = $builder->build_object({
2110 class => 'Koha::Holds',
2111 value => { borrowernumber => $patron1->borrowernumber },
2114 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 3 );
2115 my $expiry = dt_from_string->add(days => 1);
2116 $patron1->dateexpiry( $expiry );
2118 is( $patron1->login_attempts, Koha::Patron::ADMINISTRATIVE_LOCKOUT, 'Check login_attempts' );
2119 is( $patron1->dateexpiry, $expiry, 'Not expired yet' );
2120 is( $patron1->holds->count, 1, 'No holds removed' );
2122 $patron1->lock({ expire => 1, remove => 1});
2123 isnt( $patron1->dateexpiry, $expiry, 'Expiry date adjusted' );
2124 is( $patron1->holds->count, 0, 'Holds removed' );
2126 # Disable lockout feature
2127 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', q{} );
2128 $patron1->login_attempts(0);
2129 $patron1->dateexpiry( $expiry );
2132 is( $patron1->login_attempts, Koha::Patron::ADMINISTRATIVE_LOCKOUT, 'Check login_attempts' );
2134 # Trivial wrapper test (Koha::Patrons->lock)
2135 $patron1->login_attempts(0)->store;
2136 Koha::Patrons->search({ borrowernumber => [ $patron1->borrowernumber, $patron2->borrowernumber ] })->lock;
2137 $patron1->discard_changes; # refresh
2138 $patron2->discard_changes;
2139 is( $patron1->login_attempts, Koha::Patron::ADMINISTRATIVE_LOCKOUT, 'Check login_attempts patron 1' );
2140 is( $patron2->login_attempts, Koha::Patron::ADMINISTRATIVE_LOCKOUT, 'Check login_attempts patron 2' );
2143 subtest 'anonymize' => sub {
2146 my $patron1 = $builder->build_object( { class => 'Koha::Patrons' } );
2147 my $patron2 = $builder->build_object( { class => 'Koha::Patrons' } );
2149 # First try patron with issues
2150 my $issue = $builder->build_object({ class => 'Koha::Checkouts', value => { borrowernumber => $patron2->borrowernumber } });
2151 warning_like { $patron2->anonymize } qr/still has issues/, 'Skip patron with issues';
2154 t::lib::Mocks::mock_preference( 'BorrowerMandatoryField', 'surname|email|cardnumber' );
2155 my $surname = $patron1->surname; # expect change, no clear
2156 my $branchcode = $patron1->branchcode; # expect skip
2157 $patron1->anonymize;
2158 is($patron1->anonymized, 1, 'Check flag' );
2160 is( $patron1->dateofbirth, undef, 'Birth date cleared' );
2161 is( $patron1->firstname, undef, 'First name cleared' );
2162 isnt( $patron1->surname, $surname, 'Surname changed' );
2163 ok( $patron1->surname =~ /^\w{10}$/, 'Mandatory surname randomized' );
2164 is( $patron1->branchcode, $branchcode, 'Branch code skipped' );
2165 is( $patron1->email, undef, 'Email was mandatory, must be cleared' );
2167 # Test wrapper in Koha::Patrons
2168 $patron1->surname($surname)->store; # restore
2169 my $rs = Koha::Patrons->search({ borrowernumber => [ $patron1->borrowernumber, $patron2->borrowernumber ] })->anonymize;
2170 $patron1->discard_changes; # refresh
2171 isnt( $patron1->surname, $surname, 'Surname patron1 changed again' );
2172 $patron2->discard_changes; # refresh
2173 is( $patron2->firstname, undef, 'First name patron2 cleared' );
2176 subtest 'queue_notice' => sub {
2179 my $dbh = C4::Context->dbh;
2180 t::lib::Mocks::mock_preference( 'EmailFieldPrimary', 'email' );
2181 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2182 my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
2183 my $letter_e = $builder->build_object( {
2184 class => 'Koha::Notice::Templates',
2186 branchcode => $branch->branchcode,
2187 message_transport_type => 'email',
2191 my $letter_p = $builder->build_object( {
2192 class => 'Koha::Notice::Templates',
2194 code => $letter_e->code,
2195 module => $letter_e->module,
2196 branchcode => $branch->branchcode,
2197 message_transport_type => 'print',
2201 my $letter_s = $builder->build_object( {
2202 class => 'Koha::Notice::Templates',
2204 code => $letter_e->code,
2205 module => $letter_e->module,
2206 branchcode => $branch->branchcode,
2207 message_transport_type => 'sms',
2212 my $letter_params = {
2213 letter_code => $letter_e->code,
2214 branchcode => $letter_e->branchcode,
2215 module => $letter_e->module,
2216 borrowernumber => $patron->borrowernumber,
2218 borrowers => $patron->borrowernumber,
2221 my @mtts = ('email');
2223 is( $patron->queue_notice(), undef, "Nothing is done if no params passed");
2224 is( $patron->queue_notice({ letter_params => $letter_params }),undef, "Nothing done if only letter");
2226 $patron->queue_notice({ letter_params => $letter_params, message_transports => \@mtts }),
2227 {sent => ['email'] }, "Email sent"
2229 $patron->email("")->store;
2231 $patron->queue_notice({ letter_params => $letter_params, message_transports => \@mtts }),
2232 {sent => ['print'],fallback => ['email']}, "Email fallsback to print if no email"
2236 $patron->queue_notice({ letter_params => $letter_params, message_transports => \@mtts }),
2237 {sent => ['print','sms'],fallback => ['email']}, "Email fallsback to print if no email, sms sent"
2239 $patron->smsalertnumber("")->store;
2240 my $counter = Koha::Notice::Messages->search({borrowernumber => $patron->borrowernumber })->count;
2242 $patron->queue_notice({ letter_params => $letter_params, message_transports => \@mtts }),
2243 {sent => ['print'],fallback => ['email','sms']}, "Email fallsback to print if no emai, sms fallsback to print if no sms, only one print sent"
2245 is( Koha::Notice::Messages->search({borrowernumber => $patron->borrowernumber })->count, $counter+1,"Count of queued notices went up by one");
2247 # Enable notification for Hold_Filled - Things are hardcoded here but should work with default data
2248 $dbh->do(q|INSERT INTO borrower_message_preferences( borrowernumber, message_attribute_id ) VALUES ( ?, ?)|, undef, $patron->borrowernumber, 4 );
2249 my $borrower_message_preference_id = $dbh->last_insert_id(undef, undef, "borrower_message_preferences", undef);
2250 $dbh->do(q|INSERT INTO borrower_message_transport_preferences( borrower_message_preference_id, message_transport_type) VALUES ( ?, ? )|, undef, $borrower_message_preference_id, 'email' );
2252 is( $patron->queue_notice({ letter_params => $letter_params, message_transports => \@mtts, message_name => 'Hold_Filled' }),undef, "Nothing done if transports and name sent");
2254 $patron->email(q|awesome@ismymiddle.name|)->store;
2256 $patron->queue_notice({ letter_params => $letter_params, message_name => 'Hold_Filled' }),
2257 {sent => ['email'] }, "Email sent when using borrower preferences"
2259 $counter = Koha::Notice::Messages->search({borrowernumber => $patron->borrowernumber })->count;
2261 $patron->queue_notice({ letter_params => $letter_params, message_name => 'Hold_Filled', test_mode => 1 }),
2262 {sent => ['email'] }, "Report that email sent when using borrower preferences in test_mode"
2264 is( Koha::Notice::Messages->search({borrowernumber => $patron->borrowernumber })->count, $counter,"Count of queued notices not increased in test mode");
2267 subtest 'filter_by_amount_owed' => sub {
2270 my $library = $builder->build({source => 'Branch' });
2271 my $category = $builder->build({source => 'Category' });
2273 my $new_patron_cf_1 = Koha::Patron->new(
2275 cardnumber => 'test_cn_cf_1',
2276 branchcode => $library->{branchcode},
2277 categorycode => $category->{categorycode},
2278 surname => 'surname for patron1',
2279 firstname => 'firstname for patron1',
2280 userid => 'a_nonexistent_userid_cf_1',
2283 my $new_patron_cf_2 = Koha::Patron->new(
2285 cardnumber => 'test_cn_cf_2',
2286 branchcode => $library->{branchcode},
2287 categorycode => $category->{categorycode},
2288 surname => 'surname for patron2',
2289 firstname => 'firstname for patron2',
2290 userid => 'a_nonexistent_userid_cf_2',
2293 my $new_patron_cf_3 = Koha::Patron->new(
2295 cardnumber => 'test_cn_cf_3',
2296 branchcode => $library->{branchcode},
2297 categorycode => $category->{categorycode},
2298 surname => 'surname for patron3',
2299 firstname => 'firstname for patron3',
2300 userid => 'a_nonexistent_userid_cf_3',
2304 my $results = Koha::Patrons->search(
2306 'me.borrowernumber' => [
2307 $new_patron_cf_1->borrowernumber,
2308 $new_patron_cf_2->borrowernumber,
2309 $new_patron_cf_3->borrowernumber
2314 my $fine1 = $builder->build(
2316 source => 'Accountline',
2318 borrowernumber => $new_patron_cf_1->borrowernumber,
2319 amountoutstanding => 12.00,
2321 debit_type_code => 'OVERDUE',
2322 branchcode => $library->{branchcode}
2326 my $fine2 = $builder->build(
2328 source => 'Accountline',
2330 borrowernumber => $new_patron_cf_2->borrowernumber,
2331 amountoutstanding => 8.00,
2333 debit_type_code => 'OVERDUE',
2334 branchcode => $library->{branchcode}
2339 my $fine3 = $builder->build(
2341 source => 'Accountline',
2343 borrowernumber => $new_patron_cf_2->borrowernumber,
2344 amountoutstanding => 10.00,
2346 debit_type_code => 'OVERDUE',
2347 branchcode => $library->{branchcode}
2352 my $filtered = $results->filter_by_amount_owed();
2353 is( ref($filtered), 'Koha::Patrons',
2354 'Koha::Patrons->filter_by_amount_owed should return a Koha::Patrons result set in a scalar context'
2357 my $lower_limit = 12.00;
2358 my $upper_limit = 16.00;
2360 # Catch user with 1 x 12.00 fine and user with no fines.
2362 $results->filter_by_amount_owed( { less_than => $upper_limit } );
2363 is( $filtered->_resultset->as_subselect_rs->count, 2,
2364 "filter_by_amount_owed({ less_than => $upper_limit }) found two patrons"
2367 # Catch user with 1 x 8.00 and 1 x 10.00 fine
2369 $results->filter_by_amount_owed( { more_than => $lower_limit } );
2370 is( $filtered->_resultset->as_subselect_rs->count, 1,
2371 "filter_by_amount_owed({ more_than => $lower_limit }) found two patrons"
2374 # User with 2 fines falls above upper limit - Excluded,
2375 # user with 1 fine falls below lower limit - Excluded
2376 # and user with no fines falls below lower limit - Excluded.
2377 $filtered = $results->filter_by_amount_owed(
2378 { more_than => $lower_limit, less_than => $upper_limit } );
2379 is( $filtered->_resultset->as_subselect_rs->count, 0,
2380 "filter_by_amount_owed({ more_than => $lower_limit, less_than => $upper_limit }) found zero patrons"
2383 my $library2 = $builder->build({source => 'Branch' });
2384 my $fine4 = $builder->build(
2386 source => 'Accountline',
2388 borrowernumber => $new_patron_cf_2->borrowernumber,
2389 amountoutstanding => 10.00,
2391 debit_type_code => 'HOLD',
2392 branchcode => $library2->{branchcode}
2397 # Catch only the user with a HOLD fee over 6.00
2398 $filtered = $results->filter_by_amount_owed( { more_than => 6.00, debit_type => 'HOLD' } );
2399 is( $filtered->_resultset->as_subselect_rs->count, 1,
2400 "filter_by_amount_owed({ more_than => 6.00, debit_type => 'HOLD' }) found one patron"
2403 # Catch only the user with a fee over 6.00 at the specified library
2404 $filtered = $results->filter_by_amount_owed( { more_than => 6.00, library => $library2->{branchcode} } );
2405 is( $filtered->_resultset->as_subselect_rs->count, 1,
2406 "filter_by_amount_owed({ more_than => 6.00, library => $library2->{branchcode} }) found one patron"
2410 subtest 'libraries_where_can_edit_items() and can_edit_items_from() tests' => sub {
2413 $schema->storage->txn_begin;
2414 my $dbh = $schema->storage->dbh;
2416 $dbh->do("DELETE FROM library_groups");
2423 my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_limit_item_editing => 1 } )->store;
2424 my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_limit_item_editing => 1 } )->store;
2425 my $library_1A = $builder->build( { source => 'Branch' } );
2426 my $library_1B = $builder->build( { source => 'Branch' } );
2427 my $library_2A = $builder->build( { source => 'Branch' } );
2428 $library_1A = Koha::Libraries->find( $library_1A->{branchcode} );
2429 $library_1B = Koha::Libraries->find( $library_1B->{branchcode} );
2430 $library_2A = Koha::Libraries->find( $library_2A->{branchcode} );
2431 Koha::Library::Group->new( { branchcode => $library_1A->branchcode, parent_id => $group_1->id } )->store;
2432 Koha::Library::Group->new( { branchcode => $library_1B->branchcode, parent_id => $group_1->id } )->store;
2433 Koha::Library::Group->new( { branchcode => $library_2A->branchcode, parent_id => $group_2->id } )->store;
2435 my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 9, ?)|); # 9 for editcatalogue
2436 # 2 patrons from library_1A (group1)
2437 # patron_1A_1 see patron's infos from outside its group
2438 # Setting flags => undef to not be considered as superlibrarian
2439 my $patron_1A_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2440 $patron_1A_1 = Koha::Patrons->find( $patron_1A_1->{borrowernumber} );
2441 $sth->execute( $patron_1A_1->borrowernumber, 'edit_items' );
2442 $sth->execute( $patron_1A_1->borrowernumber, 'edit_any_item' );
2443 # patron_1A_2 can only see patron's info from its group
2444 my $patron_1A_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2445 $patron_1A_2 = Koha::Patrons->find( $patron_1A_2->{borrowernumber} );
2446 $sth->execute( $patron_1A_2->borrowernumber, 'edit_items' );
2447 # 1 patron from library_1B (group1)
2448 my $patron_1B = $builder->build({ source => 'Borrower', value => { branchcode => $library_1B->branchcode, flags => undef, }});
2449 $patron_1B = Koha::Patrons->find( $patron_1B->{borrowernumber} );
2450 # 1 patron from library_2A (group2) can only see patron's info from its group
2451 my $patron_2A = $builder->build({ source => 'Borrower', value => { branchcode => $library_2A->branchcode, flags => undef, }});
2452 $patron_2A = Koha::Patrons->find( $patron_2A->{borrowernumber} );
2453 $sth->execute( $patron_2A->borrowernumber, 'edit_items' );
2455 subtest 'libraries_where_can_edit_items' => sub {
2460 @branchcodes = $patron_1A_1->libraries_where_can_edit_items;
2461 is_deeply( \@branchcodes, [], "patron_1A_1 has edit_any_item => No restrictions" );
2463 @branchcodes = $patron_1A_2->libraries_where_can_edit_items;
2464 is_deeply( \@branchcodes, [ sort ( $library_1A->branchcode, $library_1B->branchcode ) ], "patron_1A_2 doesn't have edit_any_item => Can only edit items from its group" );
2466 @branchcodes = $patron_2A->libraries_where_can_edit_items;
2467 is_deeply( \@branchcodes, [$library_2A->branchcode], "patron_2A doesn't have edit_any_item => Can only see patron's from its group" );
2470 subtest 'can_edit_items_from' => sub {
2473 t::lib::Mocks::mock_userenv({ patron => $patron_1A_1 });
2474 is( $patron_1A_1->can_edit_items_from( $library_1A->id ), 1, "patron_1A_1 can see patron_1A_2, from its library" );
2475 is( $patron_1A_1->can_edit_items_from( $library_1B->id ), 1, "patron_1A_1 can see patron_1B, from its group" );
2476 is( $patron_1A_1->can_edit_items_from( $library_2A->id ), 1, "patron_1A_1 can see patron_1A_2, from another group" );
2478 t::lib::Mocks::mock_userenv({ patron => $patron_1A_2 });
2479 is( $patron_1A_2->can_edit_items_from( $library_1A->id ), 1, "patron_1A_2 can see patron_1A_1, from its library" );
2480 is( $patron_1A_2->can_edit_items_from( $library_1B->id ), 1, "patron_1A_2 can see patron_1B, from its group" );
2481 is( $patron_1A_2->can_edit_items_from( $library_2A->id ), 0, "patron_1A_2 can NOT see patron_2A, from another group" );
2485 subtest 'filter_by_have_permission' => sub {
2488 $schema->storage->txn_begin;
2490 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2491 my $patron_1 = $builder->build_object(
2493 class => 'Koha::Patrons',
2494 value => { flags => 1, branchcode => $library->branchcode }
2498 my $patron_2 = $builder->build_object( # 4096 = 1 << 12 for suggestions
2500 class => 'Koha::Patrons',
2501 value => { flags => 4096, branchcode => $library->branchcode }
2505 my $patron_3 = $builder->build_object(
2507 class => 'Koha::Patrons',
2508 value => { flags => 0, branchcode => $library->branchcode }
2513 source => 'UserPermission',
2515 borrowernumber => $patron_3->borrowernumber,
2517 code => 'order_manage',
2524 Koha::Patrons->search( { branchcode => $library->branchcode } )
2525 ->filter_by_have_permission('suggestions.suggestions_manage')
2526 ->get_column('borrowernumber')
2528 [ $patron_1->borrowernumber, $patron_2->borrowernumber ],
2529 'Superlibrarian and patron with suggestions.suggestions_manage'
2534 Koha::Patrons->search( { branchcode => $library->branchcode } )
2535 ->filter_by_have_permission('acquisition.order_manage')
2536 ->get_column('borrowernumber')
2538 [ $patron_1->borrowernumber, $patron_3->borrowernumber ],
2539 'Superlibrarian and patron with acquisition.order_manage'
2544 Koha::Patrons->search( { branchcode => $library->branchcode } )
2545 ->filter_by_have_permission('parameters.manage_cities')
2546 ->get_column('borrowernumber')
2548 [ $patron_1->borrowernumber ],
2549 'Only Superlibrarian is returned'
2554 Koha::Patrons->search( { branchcode => $library->branchcode } )
2555 ->filter_by_have_permission('suggestions')
2556 ->get_column('borrowernumber')
2558 [ $patron_1->borrowernumber, $patron_2->borrowernumber ],
2559 'Superlibrarian and patron with suggestions'
2563 Koha::Patrons->search( { branchcode => $library->branchcode } )
2564 ->filter_by_have_permission('dont_exist.subperm');
2565 } 'Koha::Exceptions::ObjectNotFound';
2568 $schema->storage->txn_rollback;
2571 $schema->storage->txn_rollback;