3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use Test::More tests => 58;
26 use_ok('C4::Members');
29 my $dbh = C4::Context->dbh;
32 $dbh->{AutoCommit} = 0;
33 $dbh->{RaiseError} = 1;
35 my $CARDNUMBER = 'TESTCARD01';
36 my $FIRSTNAME = 'Marie';
37 my $SURNAME = 'Mcknight';
38 my $CATEGORYCODE = 'S';
39 my $BRANCHCODE = 'CPL';
41 my $CHANGED_FIRSTNAME = "Marry Ann";
42 my $EMAIL = "Marie\@email.com";
43 my $EMAILPRO = "Marie\@work.com";
44 my $ETHNICITY = "German";
45 my $PHONE = "555-12123";
47 # XXX should be randomised and checked against the database
48 my $IMPOSSIBLE_CARDNUMBER = "XYZZZ999";
50 my $INDEPENDENT_BRANCHES_PREF = 'IndependentBranches';
52 # XXX make a non-commit transaction and rollback rather than insert/delete
54 #my ($usernum, $userid, $usercnum, $userfirstname, $usersurname, $userbranch, $branchname, $userflags, $emailaddress, $branchprinter)= @_;
67 C4::Context->_new_userenv ('DUMMY_SESSION_ID');
68 C4::Context::set_userenv ( @USERENV );
70 my $userenv = C4::Context->userenv
71 or BAIL_OUT("No userenv");
73 # Make a borrower for testing
75 cardnumber => $CARDNUMBER,
76 firstname => $FIRSTNAME,
78 categorycode => $CATEGORYCODE,
79 branchcode => $BRANCHCODE,
81 dateexpiry => '9999-12-31',
85 my $addmem=AddMember(%data);
86 ok($addmem, "AddMember()");
88 # It's not really a Move, it's a Copy.
89 my $result = MoveMemberToDeleted($addmem);
90 ok($result,"MoveMemberToDeleted()");
92 my $sth = $dbh->prepare("SELECT * from borrowers WHERE borrowernumber=?");
93 $sth->execute($addmem);
94 my $MemberAdded = $sth->fetchrow_hashref;
96 $sth = $dbh->prepare("SELECT * from deletedborrowers WHERE borrowernumber=?");
97 $sth->execute($addmem);
98 my $MemberMoved = $sth->fetchrow_hashref;
100 is_deeply($MemberMoved,$MemberAdded,"Confirm MoveMemberToDeleted.");
102 my $member=GetMemberDetails("",$CARDNUMBER)
103 or BAIL_OUT("Cannot read member with card $CARDNUMBER");
105 ok ( $member->{firstname} eq $FIRSTNAME &&
106 $member->{surname} eq $SURNAME &&
107 $member->{categorycode} eq $CATEGORYCODE &&
108 $member->{branchcode} eq $BRANCHCODE
110 or diag("Mismatching member details: ".Dumper(\%data, $member));
112 is($member->{dateofbirth}, undef, "Empty dates handled correctly");
114 $member->{firstname} = $CHANGED_FIRSTNAME;
115 $member->{email} = $EMAIL;
116 $member->{ethnicity} = $ETHNICITY;
117 $member->{phone} = $PHONE;
118 $member->{emailpro} = $EMAILPRO;
120 my $changedmember=GetMemberDetails("",$CARDNUMBER);
121 ok ( $changedmember->{firstname} eq $CHANGED_FIRSTNAME &&
122 $changedmember->{email} eq $EMAIL &&
123 $changedmember->{ethnicity} eq $ETHNICITY &&
124 $changedmember->{phone} eq $PHONE &&
125 $changedmember->{emailpro} eq $EMAILPRO
127 or diag("Mismatching member details: ".Dumper($member, $changedmember));
129 C4::Context->set_preference( $INDEPENDENT_BRANCHES_PREF, '0' );
130 C4::Context->clear_syspref_cache();
132 my $results = Search($CARDNUMBER);
133 ok (@$results == 1, "Search cardnumber returned only one result")
134 or diag("Multiple members with Card $CARDNUMBER: ".Dumper($results));
135 ok (_find_member($results), "Search cardnumber")
136 or diag("Card $CARDNUMBER not found in the resultset: ".Dumper($results));
138 my @searchstring=($SURNAME);
139 $results = Search(\@searchstring);
140 ok (_find_member($results), "Search (arrayref)")
141 or diag("Card $CARDNUMBER not found in the resultset: ".Dumper($results));
143 $results = Search(\@searchstring,undef,undef,undef,["surname"]);
144 ok (_find_member($results), "Surname Search (arrayref)")
145 or diag("Card $CARDNUMBER not found in the resultset: ".Dumper($results));
147 $results = Search("$CHANGED_FIRSTNAME $SURNAME", "surname");
148 ok (_find_member($results), "Full name Search (string)")
149 or diag("Card $CARDNUMBER not found in the resultset: ".Dumper($results));
151 @searchstring=($PHONE);
152 $results = Search(\@searchstring,undef,undef,undef,["phone"]);
153 ok (_find_member($results), "Phone Search (arrayref)")
154 or diag("Card $CARDNUMBER not found in the resultset: ".Dumper($results));
156 $results = Search($PHONE,undef,undef,undef,["phone"]);
157 ok (_find_member($results), "Phone Search (string)")
158 or diag("Card $CARDNUMBER not found in the resultset: ".Dumper($results));
160 C4::Context->set_preference( $INDEPENDENT_BRANCHES_PREF, '1' );
161 C4::Context->clear_syspref_cache();
163 $results = Search("$CHANGED_FIRSTNAME $SURNAME", "surname");
164 ok (!_find_member($results), "Full name Search (string) for independent branches, different branch")
165 or diag("Card $CARDNUMBER found in the resultset for independent branches: ".Dumper(C4::Context->preference($INDEPENDENT_BRANCHES_PREF), $results));
167 @searchstring=($SURNAME);
168 $results = Search(\@searchstring);
169 ok (!_find_member($results), "Search (arrayref) for independent branches, different branch")
170 or diag("Card $CARDNUMBER found in the resultset for independent branches: ".Dumper(C4::Context->preference($INDEPENDENT_BRANCHES_PREF), $results));
172 $USERENV[$BRANCH_IDX] = $BRANCHCODE;
173 C4::Context::set_userenv ( @USERENV );
175 $results = Search("$CHANGED_FIRSTNAME $SURNAME", "surname");
176 ok (_find_member($results), "Full name Search (string) for independent branches, same branch")
177 or diag("Card $CARDNUMBER not found in the resultset for independent branches: ".Dumper(C4::Context->preference($INDEPENDENT_BRANCHES_PREF), $results));
179 @searchstring=($SURNAME);
180 $results = Search(\@searchstring);
181 ok (_find_member($results), "Search (arrayref) for independent branches, same branch")
182 or diag("Card $CARDNUMBER not found in the resultset for independent branches: ".Dumper(C4::Context->preference($INDEPENDENT_BRANCHES_PREF), $results));
184 C4::Context->set_preference( 'CardnumberLength', '' );
185 C4::Context->clear_syspref_cache();
187 my $checkcardnum=C4::Members::checkcardnumber($CARDNUMBER, "");
188 is ($checkcardnum, "1", "Card No. in use");
190 $checkcardnum=C4::Members::checkcardnumber($IMPOSSIBLE_CARDNUMBER, "");
191 is ($checkcardnum, "0", "Card No. not used");
193 C4::Context->set_preference( 'CardnumberLength', '4' );
194 C4::Context->clear_syspref_cache();
196 $checkcardnum=C4::Members::checkcardnumber($IMPOSSIBLE_CARDNUMBER, "");
197 is ($checkcardnum, "2", "Card number is too long");
199 my $age=GetAge("1992-08-14", "2011-01-19");
200 is ($age, "18", "Age correct");
202 $age=GetAge("2011-01-19", "1992-01-19");
203 is ($age, "-19", "Birthday In the Future");
205 C4::Context->set_preference( 'AutoEmailPrimaryAddress', 'OFF' );
206 C4::Context->clear_syspref_cache();
208 my $notice_email = GetNoticeEmailAddress($member->{'borrowernumber'});
209 is ($notice_email, $EMAIL, "GetNoticeEmailAddress returns correct value when AutoEmailPrimaryAddress is off");
211 C4::Context->set_preference( 'AutoEmailPrimaryAddress', 'emailpro' );
212 C4::Context->clear_syspref_cache();
214 $notice_email = GetNoticeEmailAddress($member->{'borrowernumber'});
215 is ($notice_email, $EMAILPRO, "GetNoticeEmailAddress returns correct value when AutoEmailPrimaryAddress is emailpro");
217 ok(!$member->{is_expired}, "GetMemberDetails() indicates that patron is not expired");
218 ModMember(borrowernumber => $member->{'borrowernumber'}, dateexpiry => '2001-01-1');
219 $member = GetMemberDetails($member->{'borrowernumber'});
220 ok($member->{is_expired}, "GetMemberDetails() indicates that patron is expired");
223 my $message_type = 'B';
224 my $message = 'my message';
225 my $messages_count = GetMessagesCount($member->{borrowernumber}, $message_type, $BRANCHCODE);
226 is( $messages_count, 0, 'GetMessagesCount returns the number of messages correclty' );
228 is( AddMessage(), undef, 'AddMessage without argument returns undef' );
229 is( AddMessage(undef, $message_type, $message, $BRANCHCODE), undef, 'AddMessage without the borrower number returns undef' );
230 is( AddMessage($member->{borrowernumber}, undef, $message, $BRANCHCODE), undef, 'AddMessage without the message type returns undef' );
231 is( AddMessage($member->{borrowernumber}, $message_type, undef, $BRANCHCODE), undef, 'AddMessage without the message returns undef' );
232 is( AddMessage($member->{borrowernumber}, $message_type, $message, undef), undef, 'AddMessage without the branch code returns undef' );
233 is( AddMessage($member->{borrowernumber}, $message_type, $message, $BRANCHCODE), 1, 'AddMessage functions correctly' );
235 $messages_count = GetMessagesCount();
236 is( $messages_count, 0, 'GetMessagesCount without argument returns 0' );
237 $messages_count = GetMessagesCount(undef, $message_type, $BRANCHCODE);
238 is( $messages_count, '0', 'GetMessagesCount without the borrower number returns the number of messages' );
239 $messages_count = GetMessagesCount($member->{borrowernumber}, undef, $BRANCHCODE);
240 is( $messages_count, '1', 'GetMessagesCount without the message type returns the total number of messages' );
241 $messages_count = GetMessagesCount($member->{borrowernumber}, $message_type, undef);
242 is( $messages_count, '1', 'GetMessagesCount without the branchcode returns the total number of messages' );
243 $messages_count = GetMessagesCount($member->{borrowernumber}, $message_type, $BRANCHCODE);
244 is( $messages_count, '1', 'GetMessagesCount returns the number of messages correctly' );
246 my $messages = GetMessages();
247 is( @$messages, 0, 'GetMessages without argument returns 0' );
248 $messages = GetMessages($member->{borrowernumber}, $message_type, $BRANCHCODE);
249 is( @$messages, 1, 'GetMessages returns the correct number of messages' );
250 is( $messages->[0]->{borrowernumber}, $member->{borrowernumber}, 'GetMessages returns the borrower number correctly' );
251 is( $messages->[0]->{message_type}, $message_type, 'GetMessages returns the message type correclty' );
252 is( $messages->[0]->{message}, $message, 'GetMessages returns the message correctly' );
253 is( $messages->[0]->{branchcode}, $BRANCHCODE, 'GetMessages returns the branch code correctly' );
255 $messages_count = GetMessagesCount($member->{borrowernumber}, $message_type, $BRANCHCODE);
256 is( $messages_count, 1, 'GetMessagesCount returns the number of messages correclty' );
259 $messages = GetMessages($member->{borrowernumber}, $message_type, $BRANCHCODE);
260 is( @$messages, 1, 'DeleteMessage without message id does not delete messages' );
261 DeleteMessage($messages->[0]->{message_id});
262 $messages = GetMessages($member->{borrowernumber}, $message_type, $BRANCHCODE);
263 is( @$messages, 0, 'DeleteMessage deletes a message correctly' );
267 DelMember($member->{borrowernumber});
268 $results = Search($CARDNUMBER,undef,undef,undef,["cardnumber"]);
269 ok (!_find_member($results), "Delete member")
270 or diag("Card $CARDNUMBER found for the deleted member in the resultset: ".Dumper($results));
274 cardnumber => "123456789",
275 firstname => "Tomasito",
280 dateexpiry => '9999-12-31',
284 my $borrowernumber = AddMember( %data );
285 is( Check_Userid( 'tomasito', $borrowernumber ), 1,
286 'recently created userid -> unique (borrowernumber passed)' );
287 is( Check_Userid( 'tomasitoxxx', $borrowernumber ), 1,
288 'non-existent userid -> unique (borrowernumber passed)' );
289 is( Check_Userid( 'tomasito', '' ), 0,
290 'userid exists (blank borrowernumber)' );
291 is( Check_Userid( 'tomasitoxxx', '' ), 1,
292 'non-existent userid -> unique (blank borrowernumber)' );
294 # Add a new borrower with the same userid but different cardnumber
295 $data{ cardnumber } = "987654321";
296 my $new_borrowernumber = AddMember( %data );
297 is( Check_Userid( 'tomasito', '' ), 0,
298 'userid not unique (blank borrowernumber)' );
299 is( Check_Userid( 'tomasito', $borrowernumber ), 0,
300 'userid not unique (first borrowernumber passed)' );
301 is( Check_Userid( 'tomasito', $new_borrowernumber ), 0,
302 'userid not unique (second borrowernumber passed)' );
304 # Regression tests for BZ12226
305 is( Check_Userid( C4::Context->config('user'), '' ), 0,
306 'Check_Userid should return 0 for the DB user (Bug 12226)');
308 subtest 'GetMemberAccountBalance' => sub {
312 my $members_mock = new Test::MockModule('C4::Members');
313 $members_mock->mock( 'GetMemberAccountRecords', sub {
315 { amountoutstanding => '7', accounttype => 'Rent' },
316 { amountoutstanding => '5', accounttype => 'Res' },
317 { amountoutstanding => '3', accounttype => 'Pay' } );
318 return ( 15, \@accountlines );
321 # do not count holds charges
322 C4::Context->set_preference( 'HoldsInNoissuesCharge', '1' );
323 C4::Context->set_preference( 'ManInvInNoissuesCharge', '0' );
324 my ($total, $total_minus_charges,
325 $other_charges) = C4::Members::GetMemberAccountBalance(123);
326 is( $total, 15 , "Total calculated correctly");
327 is( $total_minus_charges, 15, "Holds charges are not count if HoldsInNoissuesCharge=1");
328 is( $other_charges, 0, "Holds charges are not considered if HoldsInNoissuesCharge=1");
330 C4::Context->set_preference( 'HoldsInNoissuesCharge', '0' );
331 ($total, $total_minus_charges,
332 $other_charges) = C4::Members::GetMemberAccountBalance(123);
333 is( $total, 15 , "Total calculated correctly");
334 is( $total_minus_charges, 10, "Holds charges are count if HoldsInNoissuesCharge=0");
335 is( $other_charges, 5, "Holds charges are considered if HoldsInNoissuesCharge=1");
341 my ($resultset) = @_;
342 my $found = $resultset && grep( { $_->{cardnumber} && $_->{cardnumber} eq $CARDNUMBER } @$resultset );