3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use Test::More tests => 59;
25 use t::lib::TestBuilder;
28 use DateTime::Duration;
39 use Koha::Notice::Templates;
41 use Koha::Patron::Categories;
44 require_ok('C4::Reserves');
48 my $database = Koha::Database->new();
49 my $schema = $database->schema();
50 $schema->storage->txn_begin();
51 my $dbh = C4::Context->dbh;
53 my $builder = t::lib::TestBuilder->new;
55 my $frameworkcode = q//;
58 t::lib::Mocks::mock_preference('ReservesNeedReturns', 1);
60 # Somewhat arbitrary field chosen for age restriction unit tests. Must be added to db before the framework is cached
61 $dbh->do("update marc_subfield_structure set kohafield='biblioitems.agerestriction' where tagfield='521' and tagsubfield='a' and frameworkcode=?", undef, $frameworkcode);
62 my $cache = Koha::Caches->get_instance;
63 $cache->clear_from_cache("MarcStructure-0-$frameworkcode");
64 $cache->clear_from_cache("MarcStructure-1-$frameworkcode");
65 $cache->clear_from_cache("default_value_for_mod_marc-");
66 $cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
70 my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
71 my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
72 my $branch_3 = $builder->build({ source => 'Branch' })->{ branchcode };
74 my $category_1 = $builder->build({ source => 'Category' })->{ categorycode };
75 my $category_2 = $builder->build({ source => 'Category' })->{ categorycode };
77 my $itemtype = $builder->build(
78 { source => 'Itemtype', value => { notforloan => undef } } )->{itemtype};
80 t::lib::Mocks::mock_userenv({ branchcode => $branch_1 });
82 my $bibnum = $builder->build_sample_biblio({frameworkcode => $frameworkcode})->biblionumber;
84 # Create a helper item instance for testing
85 my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
86 { homebranch => $branch_1,
87 holdingbranch => $branch_1,
93 my $biblio_with_no_item = $builder->build({
98 # Modify item; setting barcode.
99 my $testbarcode = '97531';
100 ModItem({ barcode => $testbarcode }, $bibnum, $itemnumber);
104 firstname => 'my firstname',
105 surname => 'my surname',
106 categorycode => $category_1,
107 branchcode => $branch_1,
109 Koha::Patron::Categories->find($category_1)->set({ enrolmentfee => 0})->store;
110 my $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
111 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
112 my $biblionumber = $bibnum;
113 my $barcode = $testbarcode;
120 my $checkitem = undef;
123 my $branchcode = Koha::Libraries->search->next->branchcode;
125 AddReserve($branchcode, $borrowernumber, $biblionumber,
126 $bibitems, $priority, $resdate, $expdate, $notes,
127 'a title', $checkitem, $found);
129 my ($status, $reserve, $all_reserves) = CheckReserves($itemnumber, $barcode);
131 is($status, "Reserved", "CheckReserves Test 1");
133 ok(exists($reserve->{reserve_id}), 'CheckReserves() include reserve_id in its response');
135 ($status, $reserve, $all_reserves) = CheckReserves($itemnumber);
136 is($status, "Reserved", "CheckReserves Test 2");
138 ($status, $reserve, $all_reserves) = CheckReserves(undef, $barcode);
139 is($status, "Reserved", "CheckReserves Test 3");
141 my $ReservesControlBranch = C4::Context->preference('ReservesControlBranch');
142 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
144 'ItemHomeLib' eq GetReservesControlBranch(
145 { homebranch => 'ItemHomeLib' },
146 { branchcode => 'PatronHomeLib' }
147 ), "GetReservesControlBranch returns item home branch when set to ItemHomeLibrary"
149 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
151 'PatronHomeLib' eq GetReservesControlBranch(
152 { homebranch => 'ItemHomeLib' },
153 { branchcode => 'PatronHomeLib' }
154 ), "GetReservesControlBranch returns patron home branch when set to PatronLibrary"
156 t::lib::Mocks::mock_preference( 'ReservesControlBranch', $ReservesControlBranch );
159 ### Regression test for bug 10272
162 $requesters{$branch_1} = Koha::Patron->new({
163 branchcode => $branch_1,
164 categorycode => $category_2,
165 surname => "borrower from $branch_1",
166 })->store->borrowernumber;
167 for my $i ( 2 .. 5 ) {
168 $requesters{"CPL$i"} = Koha::Patron->new({
169 branchcode => $branch_1,
170 categorycode => $category_2,
171 surname => "borrower $i from $branch_1",
172 })->store->borrowernumber;
174 $requesters{$branch_2} = Koha::Patron->new({
175 branchcode => $branch_2,
176 categorycode => $category_2,
177 surname => "borrower from $branch_2",
178 })->store->borrowernumber;
179 $requesters{$branch_3} = Koha::Patron->new({
180 branchcode => $branch_3,
181 categorycode => $category_2,
182 surname => "borrower from $branch_3",
183 })->store->borrowernumber;
185 # Configure rules so that $branch_1 allows only $branch_1 patrons
186 # to request its items, while $branch_2 will allow its items
187 # to fill holds from anywhere.
189 $dbh->do('DELETE FROM issuingrules');
190 $dbh->do('DELETE FROM branch_item_rules');
191 $dbh->do('DELETE FROM branch_borrower_circ_rules');
192 $dbh->do('DELETE FROM default_borrower_circ_rules');
193 $dbh->do('DELETE FROM default_branch_item_rules');
194 $dbh->do('DELETE FROM default_branch_circ_rules');
195 $dbh->do('DELETE FROM default_circ_rules');
197 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
198 VALUES (?, ?, ?, ?)},
203 # CPL allows only its own patrons to request its items
205 q{INSERT INTO default_branch_circ_rules (branchcode, maxissueqty, holdallowed, returnbranch)
206 VALUES (?, ?, ?, ?)},
208 $branch_1, 10, 1, 'homebranch',
211 # ... while FPL allows anybody to request its items
213 q{INSERT INTO default_branch_circ_rules (branchcode, maxissueqty, holdallowed, returnbranch)
214 VALUES (?, ?, ?, ?)},
216 $branch_2, 10, 2, 'homebranch',
219 my $bibnum2 = $builder->build_sample_biblio({frameworkcode => $frameworkcode})->biblionumber;
221 my ($itemnum_cpl, $itemnum_fpl);
222 ( undef, undef, $itemnum_cpl ) = AddItem(
223 { homebranch => $branch_1,
224 holdingbranch => $branch_1,
225 barcode => 'bug10272_CPL',
230 ( undef, undef, $itemnum_fpl ) = AddItem(
231 { homebranch => $branch_2,
232 holdingbranch => $branch_2,
233 barcode => 'bug10272_FPL',
240 # Ensure that priorities are numbered correcly when a hold is moved to waiting
242 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum2));
243 AddReserve($branch_3, $requesters{$branch_3}, $bibnum2,
244 $bibitems, 1, $resdate, $expdate, $notes,
245 'a title', $checkitem, $found);
246 AddReserve($branch_2, $requesters{$branch_2}, $bibnum2,
247 $bibitems, 2, $resdate, $expdate, $notes,
248 'a title', $checkitem, $found);
249 AddReserve($branch_1, $requesters{$branch_1}, $bibnum2,
250 $bibitems, 3, $resdate, $expdate, $notes,
251 'a title', $checkitem, $found);
252 ModReserveAffect($itemnum_cpl, $requesters{$branch_3}, 0);
254 # Now it should have different priorities.
255 my $biblio = Koha::Biblios->find( $bibnum2 );
256 my $holds = $biblio->holds({}, { order_by => 'reserve_id' });;
257 is($holds->next->priority, 0, 'Item is correctly waiting');
258 is($holds->next->priority, 1, 'Item is correctly priority 1');
259 is($holds->next->priority, 2, 'Item is correctly priority 2');
261 my @reserves = Koha::Holds->search({ borrowernumber => $requesters{$branch_3} })->waiting();
262 is( @reserves, 1, 'GetWaiting got only the waiting reserve' );
263 is( $reserves[0]->borrowernumber(), $requesters{$branch_3}, 'GetWaiting got the reserve for the correct borrower' );
266 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum2));
267 AddReserve($branch_3, $requesters{$branch_3}, $bibnum2,
268 $bibitems, 1, $resdate, $expdate, $notes,
269 'a title', $checkitem, $found);
270 AddReserve($branch_2, $requesters{$branch_2}, $bibnum2,
271 $bibitems, 2, $resdate, $expdate, $notes,
272 'a title', $checkitem, $found);
273 AddReserve($branch_1, $requesters{$branch_1}, $bibnum2,
274 $bibitems, 3, $resdate, $expdate, $notes,
275 'a title', $checkitem, $found);
277 # Ensure that the item's home library controls hold policy lookup
278 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
281 # Return the CPL item at FPL. The hold that should be triggered is
282 # the one placed by the CPL patron, as the other two patron's hold
283 # requests cannot be filled by that item per policy.
284 (undef, $messages, undef, undef) = AddReturn('bug10272_CPL', $branch_2);
285 is( $messages->{ResFound}->{borrowernumber},
286 $requesters{$branch_1},
287 'restrictive library\'s items only fill requests by own patrons (bug 10272)');
289 # Return the FPL item at FPL. The hold that should be triggered is
290 # the one placed by the RPL patron, as that patron is first in line
291 # and RPL imposes no restrictions on whose holds its items can fill.
293 # Ensure that the preference 'LocalHoldsPriority' is not set (Bug 15244):
294 t::lib::Mocks::mock_preference( 'LocalHoldsPriority', '' );
296 (undef, $messages, undef, undef) = AddReturn('bug10272_FPL', $branch_2);
297 is( $messages->{ResFound}->{borrowernumber},
298 $requesters{$branch_3},
299 'for generous library, its items fill first hold request in line (bug 10272)');
301 $biblio = Koha::Biblios->find( $biblionumber );
302 $holds = $biblio->holds;
303 is($holds->count, 1, "Only one reserves for this biblio");
304 my $reserve_id = $holds->next->reserve_id;
306 # Tests for bug 9761 (ConfirmFutureHolds): new CheckReserves lookahead parameter, and corresponding change in AddReturn
307 # Note that CheckReserve uses its lookahead parameter and does not check ConfirmFutureHolds pref (it should be passed if needed like AddReturn does)
308 # Test 9761a: Add a reserve without date, CheckReserve should return it
309 $resdate= undef; #defaults to today in AddReserve
310 $expdate= undef; #no expdate
311 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
312 AddReserve($branch_1, $requesters{$branch_1}, $bibnum,
313 $bibitems, 1, $resdate, $expdate, $notes,
314 'a title', $checkitem, $found);
315 ($status)=CheckReserves($itemnumber,undef,undef);
316 is( $status, 'Reserved', 'CheckReserves returns reserve without lookahead');
317 ($status)=CheckReserves($itemnumber,undef,7);
318 is( $status, 'Reserved', 'CheckReserves also returns reserve with lookahead');
320 # Test 9761b: Add a reserve with future date, CheckReserve should not return it
321 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
322 t::lib::Mocks::mock_preference('AllowHoldDateInFuture', 1);
323 $resdate= dt_from_string();
324 $resdate->add_duration(DateTime::Duration->new(days => 4));
325 $resdate=output_pref($resdate);
326 $expdate= undef; #no expdate
327 AddReserve($branch_1, $requesters{$branch_1}, $bibnum,
328 $bibitems, 1, $resdate, $expdate, $notes,
329 'a title', $checkitem, $found);
330 ($status)=CheckReserves($itemnumber,undef,undef);
331 is( $status, '', 'CheckReserves returns no future reserve without lookahead');
333 # Test 9761c: Add a reserve with future date, CheckReserve should return it if lookahead is high enough
334 ($status)=CheckReserves($itemnumber,undef,3);
335 is( $status, '', 'CheckReserves returns no future reserve with insufficient lookahead');
336 ($status)=CheckReserves($itemnumber,undef,4);
337 is( $status, 'Reserved', 'CheckReserves returns future reserve with sufficient lookahead');
339 # Test 9761d: Check ResFound message of AddReturn for future hold
340 # Note that AddReturn is in Circulation.pm, but this test really pertains to reserves; AddReturn uses the ConfirmFutureHolds pref when calling CheckReserves
341 # In this test we do not need an issued item; it is just a 'checkin'
342 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 0);
343 (my $doreturn, $messages)= AddReturn('97531',$branch_1);
344 is($messages->{ResFound}//'', '', 'AddReturn does not care about future reserve when ConfirmFutureHolds is off');
345 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 3);
346 ($doreturn, $messages)= AddReturn('97531',$branch_1);
347 is(exists $messages->{ResFound}?1:0, 0, 'AddReturn ignores future reserve beyond ConfirmFutureHolds days');
348 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 7);
349 ($doreturn, $messages)= AddReturn('97531',$branch_1);
350 is(exists $messages->{ResFound}?1:0, 1, 'AddReturn considers future reserve within ConfirmFutureHolds days');
352 # End of tests for bug 9761 (ConfirmFutureHolds)
354 # test marking a hold as captured
355 my $hold_notice_count = count_hold_print_messages();
356 ModReserveAffect($itemnumber, $requesters{$branch_1}, 0);
357 my $new_count = count_hold_print_messages();
358 is($new_count, $hold_notice_count + 1, 'patron notified when item set to waiting');
360 # test that duplicate notices aren't generated
361 ModReserveAffect($itemnumber, $requesters{$branch_1}, 0);
362 $new_count = count_hold_print_messages();
363 is($new_count, $hold_notice_count + 1, 'patron not notified a second time (bug 11445)');
365 # avoiding the not_same_branch error
366 t::lib::Mocks::mock_preference('IndependentBranches', 0);
368 DelItemCheck( $bibnum, $itemnumber),
370 'item that is captured to fill a hold cannot be deleted',
373 my $letter = ReserveSlip( { branchcode => $branch_1, borrowernumber => $requesters{$branch_1}, biblionumber => $bibnum } );
374 ok(defined($letter), 'can successfully generate hold slip (bug 10949)');
376 # Tests for bug 9788: Does Koha::Item->current_holds return a future wait?
377 # 9788a: current_holds does not return future next available hold
378 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
379 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 2);
380 t::lib::Mocks::mock_preference('AllowHoldDateInFuture', 1);
381 $resdate= dt_from_string();
382 $resdate->add_duration(DateTime::Duration->new(days => 2));
383 $resdate=output_pref($resdate);
384 AddReserve($branch_1, $requesters{$branch_1}, $bibnum,
385 $bibitems, 1, $resdate, $expdate, $notes,
386 'a title', $checkitem, $found);
387 my $item = Koha::Items->find( $itemnumber );
388 $holds = $item->current_holds;
389 my $dtf = Koha::Database->new->schema->storage->datetime_parser;
390 my $future_holds = $holds->search({ reservedate => { '>' => $dtf->format_date( dt_from_string ) } } );
391 is( $future_holds->count, 0, 'current_holds does not return a future next available hold');
392 # 9788b: current_holds does not return future item level hold
393 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
394 AddReserve($branch_1, $requesters{$branch_1}, $bibnum,
395 $bibitems, 1, $resdate, $expdate, $notes,
396 'a title', $itemnumber, $found); #item level hold
397 $future_holds = $holds->search({ reservedate => { '>' => $dtf->format_date( dt_from_string ) } } );
398 is( $future_holds->count, 0, 'current_holds does not return a future item level hold' );
399 # 9788c: current_holds returns future wait (confirmed future hold)
400 ModReserveAffect( $itemnumber, $requesters{$branch_1} , 0); #confirm hold
401 $future_holds = $holds->search({ reservedate => { '>' => $dtf->format_date( dt_from_string ) } } );
402 is( $future_holds->count, 1, 'current_holds returns a future wait (confirmed future hold)' );
403 # End of tests for bug 9788
405 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
406 # Tests for CalculatePriority (bug 8918)
407 my $p = C4::Reserves::CalculatePriority($bibnum2);
408 is($p, 4, 'CalculatePriority should now return priority 4');
410 AddReserve($branch_1, $requesters{'CPL2'}, $bibnum2,
411 $bibitems, $p, $resdate, $expdate, $notes,
412 'a title', $checkitem, $found);
413 $p = C4::Reserves::CalculatePriority($bibnum2);
414 is($p, 5, 'CalculatePriority should now return priority 5');
415 #some tests on bibnum
416 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
417 $p = C4::Reserves::CalculatePriority($bibnum);
418 is($p, 1, 'CalculatePriority should now return priority 1');
419 #add a new reserve and confirm it to waiting
420 AddReserve($branch_1, $requesters{$branch_1}, $bibnum,
421 $bibitems, $p, $resdate, $expdate, $notes,
422 'a title', $itemnumber, $found);
423 $p = C4::Reserves::CalculatePriority($bibnum);
424 is($p, 2, 'CalculatePriority should now return priority 2');
425 ModReserveAffect( $itemnumber, $requesters{$branch_1} , 0);
426 $p = C4::Reserves::CalculatePriority($bibnum);
427 is($p, 1, 'CalculatePriority should now return priority 1');
428 #add another biblio hold, no resdate
429 AddReserve($branch_1, $requesters{'CPL2'}, $bibnum,
430 $bibitems, $p, $resdate, $expdate, $notes,
431 'a title', $checkitem, $found);
432 $p = C4::Reserves::CalculatePriority($bibnum);
433 is($p, 2, 'CalculatePriority should now return priority 2');
434 #add another future hold
435 t::lib::Mocks::mock_preference('AllowHoldDateInFuture', 1);
436 $resdate= dt_from_string();
437 $resdate->add_duration(DateTime::Duration->new(days => 1));
438 AddReserve($branch_1, $requesters{'CPL3'}, $bibnum,
439 $bibitems, $p, output_pref($resdate), $expdate, $notes,
440 'a title', $checkitem, $found);
441 $p = C4::Reserves::CalculatePriority($bibnum);
442 is($p, 2, 'CalculatePriority should now still return priority 2');
443 #calc priority with future resdate
444 $p = C4::Reserves::CalculatePriority($bibnum, $resdate);
445 is($p, 3, 'CalculatePriority should now return priority 3');
446 # End of tests for bug 8918
448 # Tests for cancel reserves by users from OPAC.
449 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
450 AddReserve($branch_1, $requesters{$branch_1}, $item_bibnum,
451 $bibitems, 1, undef, $expdate, $notes,
452 'a title', $checkitem, '');
453 my (undef, $canres, undef) = CheckReserves($itemnumber);
455 is( CanReserveBeCanceledFromOpac(), undef,
456 'CanReserveBeCanceledFromOpac should return undef if called without any parameter'
459 CanReserveBeCanceledFromOpac( $canres->{resserve_id} ),
461 'CanReserveBeCanceledFromOpac should return undef if called without the reserve_id'
464 CanReserveBeCanceledFromOpac( undef, $requesters{CPL} ),
466 'CanReserveBeCanceledFromOpac should return undef if called without borrowernumber'
469 my $cancancel = CanReserveBeCanceledFromOpac($canres->{reserve_id}, $requesters{$branch_1});
470 is($cancancel, 1, 'Can user cancel its own reserve');
472 $cancancel = CanReserveBeCanceledFromOpac($canres->{reserve_id}, $requesters{$branch_2});
473 is($cancancel, 0, 'Other user cant cancel reserve');
475 ModReserveAffect($itemnumber, $requesters{$branch_1}, 1);
476 $cancancel = CanReserveBeCanceledFromOpac($canres->{reserve_id}, $requesters{$branch_1});
477 is($cancancel, 0, 'Reserve in transfer status cant be canceled');
479 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
480 AddReserve($branch_1, $requesters{$branch_1}, $item_bibnum,
481 $bibitems, 1, undef, $expdate, $notes,
482 'a title', $checkitem, '');
483 (undef, $canres, undef) = CheckReserves($itemnumber);
485 ModReserveAffect($itemnumber, $requesters{$branch_1}, 0);
486 $cancancel = CanReserveBeCanceledFromOpac($canres->{reserve_id}, $requesters{$branch_1});
487 is($cancancel, 0, 'Reserve in waiting status cant be canceled');
489 # End of tests for bug 12876
492 ####### Testing Bug 13113 - Prevent juvenile/children from reserving ageRestricted material >>>
495 t::lib::Mocks::mock_preference( 'AgeRestrictionMarker', 'FSK|PEGI|Age|K' );
497 #Reserving an not-agerestricted Biblio by a Borrower with no dateofbirth is tested previously.
499 #Set the ageRestriction for the Biblio
500 my $record = GetMarcBiblio({ biblionumber => $bibnum });
501 my ( $ageres_tagid, $ageres_subfieldid ) = GetMarcFromKohaField( "biblioitems.agerestriction" );
502 $record->append_fields( MARC::Field->new($ageres_tagid, '', '', $ageres_subfieldid => 'PEGI 16') );
503 C4::Biblio::ModBiblio( $record, $bibnum, $frameworkcode );
505 is( C4::Reserves::CanBookBeReserved($borrowernumber, $biblionumber)->{status} , 'OK', "Reserving an ageRestricted Biblio without a borrower dateofbirth succeeds" );
507 #Set the dateofbirth for the Borrower making them "too young".
508 $borrower->{dateofbirth} = DateTime->now->add( years => -15 );
509 Koha::Patrons->find( $borrowernumber )->set({ dateofbirth => $borrower->{dateofbirth} })->store;
511 is( C4::Reserves::CanBookBeReserved($borrowernumber, $biblionumber)->{status} , 'ageRestricted', "Reserving a 'PEGI 16' Biblio by a 15 year old borrower fails");
513 #Set the dateofbirth for the Borrower making them "too old".
514 $borrower->{dateofbirth} = DateTime->now->add( years => -30 );
515 Koha::Patrons->find( $borrowernumber )->set({ dateofbirth => $borrower->{dateofbirth} })->store;
517 is( C4::Reserves::CanBookBeReserved($borrowernumber, $biblionumber)->{status} , 'OK', "Reserving a 'PEGI 16' Biblio by a 30 year old borrower succeeds");
519 is( C4::Reserves::CanBookBeReserved($borrowernumber, $biblio_with_no_item->{biblionumber})->{status} , '', "Biblio with no item. Status is empty");
521 ####### EO Bug 13113 <<<
524 $item = GetItem($itemnumber);
526 ok( C4::Reserves::IsAvailableForItemLevelRequest($item, $borrower), "Reserving a book on item level" );
528 # tests for MoveReserve in relation to ConfirmFutureHolds (BZ 14526)
529 # hold from A pos 1, today, no fut holds: MoveReserve should fill it
530 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
531 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 0);
532 t::lib::Mocks::mock_preference('AllowHoldDateInFuture', 1);
533 AddReserve($branch_1, $borrowernumber, $item_bibnum,
534 $bibitems, 1, undef, $expdate, $notes, 'a title', $checkitem, '');
535 MoveReserve( $itemnumber, $borrowernumber );
536 ($status)=CheckReserves( $itemnumber );
537 is( $status, '', 'MoveReserve filled hold');
538 # hold from A waiting, today, no fut holds: MoveReserve should fill it
539 AddReserve($branch_1, $borrowernumber, $item_bibnum,
540 $bibitems, 1, undef, $expdate, $notes, 'a title', $checkitem, 'W');
541 MoveReserve( $itemnumber, $borrowernumber );
542 ($status)=CheckReserves( $itemnumber );
543 is( $status, '', 'MoveReserve filled waiting hold');
544 # hold from A pos 1, tomorrow, no fut holds: not filled
545 $resdate= dt_from_string();
546 $resdate->add_duration(DateTime::Duration->new(days => 1));
547 $resdate=output_pref($resdate);
548 AddReserve($branch_1, $borrowernumber, $item_bibnum,
549 $bibitems, 1, $resdate, $expdate, $notes, 'a title', $checkitem, '');
550 MoveReserve( $itemnumber, $borrowernumber );
551 ($status)=CheckReserves( $itemnumber, undef, 1 );
552 is( $status, 'Reserved', 'MoveReserve did not fill future hold');
553 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
554 # hold from A pos 1, tomorrow, fut holds=2: MoveReserve should fill it
555 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 2);
556 AddReserve($branch_1, $borrowernumber, $item_bibnum,
557 $bibitems, 1, $resdate, $expdate, $notes, 'a title', $checkitem, '');
558 MoveReserve( $itemnumber, $borrowernumber );
559 ($status)=CheckReserves( $itemnumber, undef, 2 );
560 is( $status, '', 'MoveReserve filled future hold now');
561 # hold from A waiting, tomorrow, fut holds=2: MoveReserve should fill it
562 AddReserve($branch_1, $borrowernumber, $item_bibnum,
563 $bibitems, 1, $resdate, $expdate, $notes, 'a title', $checkitem, 'W');
564 MoveReserve( $itemnumber, $borrowernumber );
565 ($status)=CheckReserves( $itemnumber, undef, 2 );
566 is( $status, '', 'MoveReserve filled future waiting hold now');
567 # hold from A pos 1, today+3, fut holds=2: MoveReserve should not fill it
568 $resdate= dt_from_string();
569 $resdate->add_duration(DateTime::Duration->new(days => 3));
570 $resdate=output_pref($resdate);
571 AddReserve($branch_1, $borrowernumber, $item_bibnum,
572 $bibitems, 1, $resdate, $expdate, $notes, 'a title', $checkitem, '');
573 MoveReserve( $itemnumber, $borrowernumber );
574 ($status)=CheckReserves( $itemnumber, undef, 3 );
575 is( $status, 'Reserved', 'MoveReserve did not fill future hold of 3 days');
576 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
578 $cache->clear_from_cache("MarcStructure-0-$frameworkcode");
579 $cache->clear_from_cache("MarcStructure-1-$frameworkcode");
580 $cache->clear_from_cache("default_value_for_mod_marc-");
581 $cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
583 subtest '_koha_notify_reserve() tests' => sub {
587 my $wants_hold_and_email = {
593 letter_code => 'HOLD'
596 my $mp = Test::MockModule->new( 'C4::Members::Messaging' );
598 $mp->mock("GetMessagingPreferences",$wants_hold_and_email);
600 $dbh->do('DELETE FROM letter');
602 my $email_hold_notice = $builder->build({
605 message_transport_type => 'email',
608 module => 'reserves',
613 my $sms_hold_notice = $builder->build({
616 message_transport_type => 'sms',
619 module => 'reserves',
624 my $hold_borrower = $builder->build({
625 source => 'Borrower',
627 smsalertnumber=>'5555555555',
630 })->{borrowernumber};
632 C4::Reserves::AddReserve(
633 $item->{homebranch}, $hold_borrower,
634 $item->{biblionumber} );
636 ModReserveAffect($item->{itemnumber}, $hold_borrower, 0);
637 my $sms_message_address = $schema->resultset('MessageQueue')->search({
638 letter_code => 'HOLD',
639 message_transport_type => 'sms',
640 borrowernumber => $hold_borrower,
641 })->next()->to_address();
642 is($sms_message_address, undef ,"We should not populate the sms message with the sms number, sending will do so");
644 my $email_message_address = $schema->resultset('MessageQueue')->search({
645 letter_code => 'HOLD',
646 message_transport_type => 'email',
647 borrowernumber => $hold_borrower,
648 })->next()->to_address();
649 is($email_message_address, undef ,"We should not populate the hold message with the email address, sending will do so");
653 subtest 'ReservesNeedReturns' => sub {
656 my $biblioitem = $builder->build_object( { class => 'Koha::Biblioitems' } );
657 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
658 my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes', value => { rentalcharge => 0 } } );
660 biblionumber => $biblioitem->biblionumber,
661 biblioitemnumber => $biblioitem->biblioitemnumber,
662 homebranch => $library->branchcode,
663 holdingbranch => $library->branchcode,
664 itype => $itemtype->itemtype,
666 my $item = $builder->build_object( { class => 'Koha::Items', value => $item_info } );
667 my $patron = $builder->build_object(
669 class => 'Koha::Patrons',
670 value => { branchcode => $library->branchcode, }
675 my ( $hold_id, $hold );
677 t::lib::Mocks::mock_preference('ReservesNeedReturns', 0); # '0' means 'Automatically mark a hold as found and waiting'
678 $hold_id = C4::Reserves::AddReserve(
679 $library->branchcode, $patron->borrowernumber,
680 $item->biblionumber, '',
683 "title for fee", $item->itemnumber,
685 $hold = Koha::Holds->find($hold_id);
686 is( $hold->priority, 0, 'If ReservesNeedReturns is 0, priority must have been set to 0' );
687 is( $hold->found, 'W', 'If ReservesNeedReturns is 0, found must have been set waiting' );
689 $hold->delete; # cleanup
691 t::lib::Mocks::mock_preference('ReservesNeedReturns', 1); # '0' means "Don't automatically mark a hold as found and waiting"
692 $hold_id = C4::Reserves::AddReserve(
693 $library->branchcode, $patron->borrowernumber,
694 $item->biblionumber, '',
697 "title for fee", $item->itemnumber,
699 $hold = Koha::Holds->find($hold_id);
700 is( $hold->priority, $priority, 'If ReservesNeedReturns is 1, priority must not have been set to changed' );
701 is( $hold->found, undef, 'If ReservesNeedReturns is 1, found must not have been set waiting' );
704 subtest 'ChargeReserveFee tests' => sub {
708 my $library = $builder->build_object({ class => 'Koha::Libraries' });
709 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
712 my $title = 'A title';
714 my $context = Test::MockModule->new('C4::Context');
715 $context->mock( userenv => { branch => $library->id } );
717 my $line = C4::Reserves::ChargeReserveFee( $patron->id, $fee, $title );
719 is( ref($line), 'Koha::Account::Line' , 'Returns a Koha::Account::Line object');
720 ok( $line->is_debit, 'Generates a debit line' );
721 is( $line->accounttype, 'Res' , 'generates Res accounttype');
722 is( $line->borrowernumber, $patron->id , 'generated line belongs to the passed patron');
723 is( $line->amount, $fee , 'amount set correctly');
724 is( $line->amountoutstanding, $fee , 'amountoutstanding set correctly');
725 is( $line->description, "Reserve Charge - $title" , 'Hardcoded description is generated');
726 is( $line->branchcode, $library->id , "Library id is picked from userenv and stored correctly" );
729 sub count_hold_print_messages {
730 my $message_count = $dbh->selectall_arrayref(q{
733 WHERE letter_code = 'HOLD'
734 AND message_transport_type = 'print'
736 return $message_count->[0]->[0];
739 # we reached the finish
740 $schema->storage->txn_rollback();