t/db_dependent/Suggestions.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19
  20 use DateTime::Duration;
  21 use Test::More tests => 91;
  22 use Test::Warn;
  23
  24 use t::lib::Mocks;
  25 use t::lib::TestBuilder;
  26
  27 use C4::Context;
  28 use C4::Letters qw( GetQueuedMessages GetMessage );
  29 use C4::Budgets qw( AddBudgetPeriod AddBudget GetBudget );
  30 use Koha::Database;
  31 use Koha::DateUtils qw( dt_from_string output_pref );
  32 use Koha::Libraries;
  33 use Koha::Patrons;
  34 use Koha::Suggestions;
  35
  36 BEGIN {
  37     use_ok('C4::Suggestions', qw( GetSuggestion ModSuggestion GetSuggestionInfo GetSuggestionFromBiblionumber GetSuggestionInfoFromBiblionumber GetSuggestionByStatus ConnectSuggestionAndBiblio DelSuggestion MarcRecordFromNewSuggestion GetUnprocessedSuggestions DelSuggestionsOlderThan ));
  38 }
  39
  40 my $schema  = Koha::Database->new->schema;
  41 $schema->storage->txn_begin;
  42 my $dbh = C4::Context->dbh;
  43 my $builder = t::lib::TestBuilder->new;
  44
  45 t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0");
  46
  47 # Reset item types to only the default ones
  48 $dbh->do(q|DELETE FROM itemtypes;|);
  49 my $sql = qq|
  50 INSERT INTO itemtypes (itemtype, description, rentalcharge, notforloan, imageurl, summary) VALUES
  51 ('BK', 'Books',5,0,'bridge/book.png',''),
  52 ('MX', 'Mixed Materials',5,0,'bridge/kit.png',''),
  53 ('CF', 'Computer Files',5,0,'bridge/computer_file.png',''),
  54 ('MP', 'Maps',5,0,'bridge/map.png',''),
  55 ('VM', 'Visual Materials',5,1,'bridge/dvd.png',''),
  56 ('MU', 'Music',5,0,'bridge/sound.png',''),
  57 ('CR', 'Continuing Resources',5,0,'bridge/periodical.png',''),
  58 ('REF', 'Reference',0,1,'bridge/reference.png','');|;
  59 $dbh->do($sql);
  60 $dbh->do(q|DELETE FROM suggestions|);
  61 $dbh->do(q|DELETE FROM issues|);
  62 $dbh->do(q|DELETE FROM borrowers|);
  63 $dbh->do(q|DELETE FROM letter|);
  64 $dbh->do(q|DELETE FROM message_queue|);
  65 $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'CHECKED', 'my content')|);
  66 $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'NEW_SUGGESTION', 'Content for new suggestion')|);
  67
  68 # Add CPL if missing.
  69 if (not defined Koha::Libraries->find('CPL')) {
  70     Koha::Library->new({ branchcode => 'CPL', branchname => 'Centerville' })->store;
  71 }
  72
  73 my $patron_category = $builder->build({ source => 'Category' });
  74
  75 my $member = {
  76     firstname => 'my firstname',
  77     surname => 'my surname',
  78     categorycode => $patron_category->{categorycode},
  79     branchcode => 'CPL',
  80     smsalertnumber => 12345,
  81 };
  82
  83 my $member2 = {
  84     firstname => 'my firstname',
  85     surname => 'my surname',
  86     categorycode => $patron_category->{categorycode},
  87     branchcode => 'CPL',
  88     email => 'to@example.com',
  89 };
  90
  91 my $borrowernumber = Koha::Patron->new($member)->store->borrowernumber;
  92 my $borrowernumber2 = Koha::Patron->new($member2)->store->borrowernumber;
  93
  94 my $biblio_1 = $builder->build_object({ class => 'Koha::Biblios' });
  95 my $my_suggestion = {
  96     title         => 'my title',
  97     author        => 'my author',
  98     publishercode => 'my publishercode',
  99     suggestedby   => $borrowernumber,
 100     biblionumber  => $biblio_1->biblionumber,
 101     branchcode    => 'CPL',
 102     managedby     => '',
 103     manageddate   => '',
 104     accepteddate  => dt_from_string,
 105     note          => 'my note',
 106     quantity      => '', # Insert an empty string into int to catch strict SQL modes errors
 107 };
 108
 109 my $budgetperiod_id = AddBudgetPeriod({
 110     budget_period_startdate   => '2008-01-01',
 111     budget_period_enddate     => '2008-12-31',
 112     budget_period_description => 'MAPERI',
 113     budget_period_active      => 1,
 114 });
 115
 116 my $budget_id = AddBudget({
 117     budget_code      => 'ABCD',
 118     budget_amount    => '123.132000',
 119     budget_name      => 'ABCD',
 120     budget_notes     => 'This is a note',
 121     budget_period_id => $budgetperiod_id,
 122 });
 123 my $my_suggestion_with_budget = {
 124     title         => 'my title 2',
 125     author        => 'my author 2',
 126     publishercode => 'my publishercode 2',
 127     suggestedby   => $borrowernumber,
 128     branchcode    => '', # This should not fail be set to undef instead
 129     biblionumber  => $biblio_1->biblionumber,
 130     managedby     => '',
 131     manageddate   => '',
 132     accepteddate  => dt_from_string,
 133     note          => 'my note',
 134     budgetid      => $budget_id,
 135 };
 136 my $my_suggestion_with_budget2 = {
 137     title         => 'my title 3',
 138     author        => 'my author 3',
 139     publishercode => 'my publishercode 3',
 140     suggestedby   => $borrowernumber2,
 141     biblionumber  => $biblio_1->biblionumber,
 142     managedby     => '',
 143     manageddate   => '',
 144     accepteddate  => dt_from_string,
 145     note          => 'my note',
 146     budgetid      => $budget_id,
 147 };
 148 my $my_suggestion_without_suggestedby = {
 149     title         => 'my title',
 150     author        => 'my author',
 151     publishercode => 'my publishercode',
 152     suggestedby   => undef,
 153     biblionumber  => $biblio_1->biblionumber,
 154     branchcode    => 'CPL',
 155     managedby     => '',
 156     manageddate   => '',
 157     accepteddate  => dt_from_string,
 158     note          => 'my note',
 159     quantity      => '', # Insert an empty string into int to catch strict SQL modes errors
 160 };
 161
 162 my $my_suggestion_object = Koha::Suggestion->new($my_suggestion)->store;
 163 my $my_suggestionid = $my_suggestion_object->id;
 164 isnt( $my_suggestionid, 0, 'Suggestion is correctly saved' );
 165 my $my_suggestion_with_budget_object = Koha::Suggestion->new($my_suggestion_with_budget)->store;
 166 my $my_suggestionid_with_budget = $my_suggestion_with_budget_object->id;
 167
 168 is( GetSuggestion(), undef, 'GetSuggestion without the suggestion id returns undef' );
 169 my $suggestion = GetSuggestion($my_suggestionid);
 170 is( $suggestion->{title}, $my_suggestion->{title}, 'Suggestion stores the title correctly' );
 171 is( $suggestion->{author}, $my_suggestion->{author}, 'Suggestion stores the author correctly' );
 172 is( $suggestion->{publishercode}, $my_suggestion->{publishercode}, 'Suggestion stores the publishercode correctly' );
 173 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'Suggestion stores the borrower number correctly' );
 174 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'Suggestion stores the biblio number correctly' );
 175 is( $suggestion->{STATUS}, 'ASKED', 'Suggestion stores a suggestion with the status ASKED by default' );
 176 is( $suggestion->{managedby}, undef, 'Suggestion stores empty string as undef for non existent foreign key (integer)' );
 177 is( $suggestion->{manageddate}, undef, 'Suggestion stores empty string as undef for date' );
 178 is( $suggestion->{budgetid}, undef, 'Suggestion should set budgetid to NULL if not given' );
 179
 180 is( ModSuggestion(), undef, 'ModSuggestion without the suggestion returns undef' );
 181 my $mod_suggestion1 = {
 182     title         => 'my modified title',
 183     author        => 'my modified author',
 184     publishercode => 'my modified publishercode',
 185     managedby     => '',
 186     manageddate   => '',
 187 };
 188 my $status = ModSuggestion($mod_suggestion1);
 189 is( $status, undef, 'ModSuggestion without the suggestion id returns undef' );
 190
 191 $mod_suggestion1->{suggestionid} = $my_suggestionid;
 192 $status = ModSuggestion($mod_suggestion1);
 193 is( $status, 1, 'ModSuggestion modifies one entry' );
 194 $suggestion = GetSuggestion($my_suggestionid);
 195 is( $suggestion->{title}, $mod_suggestion1->{title}, 'ModSuggestion modifies the title  correctly' );
 196 is( $suggestion->{author}, $mod_suggestion1->{author}, 'ModSuggestion modifies the author correctly' );
 197 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'ModSuggestion modifies the publishercode correctly' );
 198 is( $suggestion->{managedby}, undef, 'ModSuggestion stores empty string as undef for non existent foreign key (integer)' );
 199 is( $suggestion->{manageddate}, undef, 'ModSuggestion stores empty string as undef for date' );
 200 isnt( $suggestion->{accepteddate}, undef, 'ModSuggestion does not update a non given date value' );
 201 is( $suggestion->{note}, 'my note', 'ModSuggestion should not erase data if not given' );
 202
 203 my $messages = C4::Letters::GetQueuedMessages({
 204     borrowernumber => $borrowernumber
 205 });
 206 is( @$messages, 0, 'ModSuggestions does not send an email if the status is not updated' );
 207
 208 my $mod_suggestion2 = {
 209     STATUS       => 'STALLED',
 210     suggestionid => $my_suggestionid,
 211 };
 212 warning_is { $status = ModSuggestion($mod_suggestion2) }
 213            "No suggestions STALLED letter transported by email",
 214            "ModSuggestion status warning is correct";
 215 is( $status, 1, "ModSuggestion Status OK");
 216
 217 my $mod_suggestion3 = {
 218     STATUS       => 'CHECKED',
 219     suggestionid => $my_suggestionid,
 220 };
 221
 222 #Test the message_transport_type of suggestion notices
 223
 224 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is disabled
 225 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 0 );
 226 $status = ModSuggestion($mod_suggestion3);
 227 is( $status, 1, 'ModSuggestion modifies one entry' );
 228 $suggestion = GetSuggestion($my_suggestionid);
 229 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'ModSuggestion modifies the status correctly' );
 230 $messages = C4::Letters::GetQueuedMessages({
 231     borrowernumber => $borrowernumber
 232 });
 233 is( @$messages, 1, 'ModSuggestion sends an email if the status is updated' );
 234 is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is disabled the suggestion message_transport_type is always email');
 235
 236 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is enabled and the borrower has a smsalertnumber and no email
 237 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 1 );
 238 ModSuggestion($mod_suggestion3);
 239 $messages = C4::Letters::GetQueuedMessages({
 240     borrowernumber => $borrowernumber
 241 });
 242 is ($messages->[1]->{message_transport_type}, 'sms', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is sms if the borrower has no email');
 243
 244 #Make a new suggestion for a borrower with defined email and no smsalertnumber
 245 my $my_suggestion_2_object = Koha::Suggestion->new($my_suggestion_with_budget2)->store();
 246 my $my_suggestion_2_id = $my_suggestion_2_object->id;
 247
 248 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is enabled and the borrower has a defined email and no smsalertnumber
 249 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 1 );
 250 my $mod_suggestion4 = {
 251     STATUS       => 'CHECKED',
 252     suggestionid => $my_suggestion_2_id,
 253 };
 254 ModSuggestion($mod_suggestion4);
 255 $messages = C4::Letters::GetQueuedMessages({
 256     borrowernumber => $borrowernumber2
 257 });
 258 is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is email if the borrower has an email');
 259
 260 {
 261     # Hiding the expected warning displayed by DBI
 262     # DBD::mysql::st execute failed: Incorrect date value: 'invalid date!' for column 'manageddate'
 263     local *STDERR;
 264     open STDERR, '>', '/dev/null';
 265
 266     $mod_suggestion4->{manageddate} = 'invalid date!';
 267     ModSuggestion($mod_suggestion4);
 268     $messages = C4::Letters::GetQueuedMessages({
 269         borrowernumber => $borrowernumber2
 270     });
 271
 272     close STDERR;
 273     is (scalar(@$messages), 1, 'No new letter should have been generated if the update raised an error');
 274 }
 275
 276 is( GetSuggestionInfo(), undef, 'GetSuggestionInfo without the suggestion id returns undef' );
 277 $suggestion = GetSuggestionInfo($my_suggestionid);
 278 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfo returns the suggestion id correctly' );
 279 is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfo returns the title correctly' );
 280 is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfo returns the author correctly' );
 281 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfo returns the publisher code correctly' );
 282 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
 283 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfo returns the biblio number correctly' );
 284 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfo returns the status correctly' );
 285 is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfo returns the surname correctly' );
 286 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfo returns the firstname correctly' );
 287 is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
 288
 289
 290 is( GetSuggestionFromBiblionumber(), undef, 'GetSuggestionFromBiblionumber without the biblio number returns undef' );
 291 is( GetSuggestionFromBiblionumber(2), undef, 'GetSuggestionFromBiblionumber with an invalid biblio number returns undef' );
 292 is( GetSuggestionFromBiblionumber($biblio_1->biblionumber), $my_suggestionid, 'GetSuggestionFromBiblionumber functions correctly' );
 293
 294
 295 is( GetSuggestionInfoFromBiblionumber(), undef, 'GetSuggestionInfoFromBiblionumber without the biblio number returns undef' );
 296 is( GetSuggestionInfoFromBiblionumber(2), undef, 'GetSuggestionInfoFromBiblionumber with an invalid biblio number returns undef' );
 297 $suggestion = GetSuggestionInfoFromBiblionumber($biblio_1->biblionumber);
 298 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfoFromBiblionumber returns the suggestion id correctly' );
 299 is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfoFromBiblionumber returns the title correctly' );
 300 is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfoFromBiblionumber returns the author correctly' );
 301 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfoFromBiblionumber returns the publisher code correctly' );
 302 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumber returns the borrower number correctly' );
 303 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfoFromBiblionumber returns the biblio number correctly' );
 304 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfoFromBiblionumber returns the status correctly' );
 305 is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfoFromBiblionumber returns the surname correctly' );
 306 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfoFromBiblionumber returns the firstname correctly' );
 307 is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumeber returns the borrower number correctly' );
 308
 309
 310 my $suggestions = GetSuggestionByStatus();
 311 is( @$suggestions, 0, 'GetSuggestionByStatus without the status returns an empty array' );
 312 $suggestions = GetSuggestionByStatus('CHECKED');
 313 is( @$suggestions, 2, 'GetSuggestionByStatus returns the correct number of suggestions' );
 314 is( $suggestions->[0]->{suggestionid}, $my_suggestionid, 'GetSuggestionByStatus returns the suggestion id correctly' );
 315 is( $suggestions->[0]->{title}, $mod_suggestion1->{title}, 'GetSuggestionByStatus returns the title correctly' );
 316 is( $suggestions->[0]->{author}, $mod_suggestion1->{author}, 'GetSuggestionByStatus returns the author correctly' );
 317 is( $suggestions->[0]->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionByStatus returns the publisher code correctly' );
 318 is( $suggestions->[0]->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' );
 319 is( $suggestions->[0]->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionByStatus returns the biblio number correctly' );
 320 is( $suggestions->[0]->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionByStatus returns the status correctly' );
 321 is( $suggestions->[0]->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionByStatus returns the surname correctly' );
 322 is( $suggestions->[0]->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionByStatus returns the firstname correctly' );
 323 is( $suggestions->[0]->{branchcodesuggestedby}, $member->{branchcode}, 'GetSuggestionByStatus returns the branch code correctly' );
 324 is( $suggestions->[0]->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' );
 325 is( $suggestions->[0]->{categorycodesuggestedby}, $member->{categorycode}, 'GetSuggestionByStatus returns the category code correctly' );
 326
 327
 328 is( ConnectSuggestionAndBiblio(), '0E0', 'ConnectSuggestionAndBiblio without arguments returns 0E0' );
 329 my $biblio_2 = $builder->build_object({ class => 'Koha::Biblios' });
 330 my $connect_suggestion_and_biblio = ConnectSuggestionAndBiblio($my_suggestionid, $biblio_2->biblionumber);
 331 is( $connect_suggestion_and_biblio, '1', 'ConnectSuggestionAndBiblio returns 1' );
 332 $suggestion = GetSuggestion($my_suggestionid);
 333 is( $suggestion->{biblionumber}, $biblio_2->biblionumber, 'ConnectSuggestionAndBiblio updates the biblio number correctly' );
 334
 335 my $del_suggestion = {
 336     title => 'my deleted title',
 337     STATUS => 'CHECKED',
 338     suggestedby => $borrowernumber,
 339 };
 340 my $del_suggestion_object = Koha::Suggestion->new($del_suggestion)->store();
 341 my $del_suggestionid = $del_suggestion_object->id;
 342
 343 is( DelSuggestion(), '0E0', 'DelSuggestion without arguments returns 0E0' );
 344 is( DelSuggestion($borrowernumber), '', 'DelSuggestion without the suggestion id returns an empty string' );
 345 is( DelSuggestion(undef, $my_suggestionid), '', 'DelSuggestion with an invalid borrower number returns an empty string' );
 346 $suggestion = DelSuggestion($borrowernumber, $my_suggestionid);
 347 is( $suggestion, 1, 'DelSuggestion deletes one suggestion' );
 348
 349 $suggestions = GetSuggestionByStatus('CHECKED');
 350 is( @$suggestions, 2, 'DelSuggestion deletes one suggestion' );
 351 is( $suggestions->[1]->{title}, $del_suggestion->{title}, 'DelSuggestion deletes the correct suggestion' );
 352
 353 # Test budgetid fk
 354 $my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
 355 my $my_suggestionid_test_budget_object = Koha::Suggestion->new($my_suggestion)->store;
 356 my $my_suggestionid_test_budgetid = $my_suggestionid_test_budget_object->id;
 357 $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
 358 is( $suggestion->{budgetid}, undef, 'Suggestion Should set budgetid to NULL if equals an empty string' );
 359
 360 $my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
 361 ModSuggestion( $my_suggestion );
 362 $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
 363 is( $suggestion->{budgetid}, undef, 'Suggestion Should set budgetid to NULL if equals an empty string' );
 364
 365 my $suggestion2 = {
 366     title => "Cuisine d'automne",
 367     author => "Catherine",
 368     itemtype => "LIV"
 369 };
 370
 371 my $record = MarcRecordFromNewSuggestion($suggestion2);
 372
 373 is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
 374
 375 my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title', '');
 376
 377 is($record->field( $title_tag )->subfield( $title_subfield ), "Cuisine d'automne", "Record from suggestion title should be 'Cuisine d'automne'");
 378
 379 my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
 380
 381 is($record->field( $author_tag )->subfield( $author_subfield ), "Catherine", "Record from suggestion author should be 'Catherine'");
 382
 383 subtest 'GetUnprocessedSuggestions' => sub {
 384     plan tests => 11;
 385     $dbh->do(q|DELETE FROM suggestions|);
 386     my $my_suggestionid         = Koha::Suggestion->new($my_suggestion)->store->id;
 387     my $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 388     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return 0 if a suggestion has been processed but not linked to a fund' );
 389     my $status     = ModSuggestion($mod_suggestion1);
 390     my $suggestion = GetSuggestion($my_suggestionid);
 391     is( $suggestion->{budgetid}, undef, 'ModSuggestion should set budgetid to NULL if not given' );
 392     ModSuggestion( { suggestionid => $my_suggestionid, budgetid => $budget_id } );
 393     $suggestion = GetSuggestion($my_suggestionid);
 394     is( $suggestion->{budgetid}, $budget_id, 'ModSuggestion should modify budgetid if given' );
 395
 396     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 397     is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
 398
 399     warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } ) }
 400                 'No suggestions REJECTED letter transported by email',
 401                 'Warning raised if no REJECTED letter by email';
 402     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 403     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
 404
 405     warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } ); }
 406                 'No suggestions ASKED letter transported by email',
 407                 'Warning raised if no ASKED letter by email';
 408     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 409     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should use 0 as default value for days' );
 410     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(4);
 411     is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion suggested 4 days ago' );
 412     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(3);
 413     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should not return the suggestion, it has not been suggested 3 days ago' );
 414     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(5);
 415     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should not return the suggestion, it has not been suggested 5 days ago' );
 416 };
 417
 418 subtest 'DelSuggestionsOlderThan' => sub {
 419     plan tests => 6;
 420
 421     Koha::Suggestions->delete;
 422
 423     # Add four suggestions; note that STATUS needs uppercase (FIXME)
 424     my $d1 = output_pref({ dt => dt_from_string->add(days => -2), dateformat => 'sql' });
 425     my $d2 = output_pref({ dt => dt_from_string->add(days => -4), dateformat => 'sql' });
 426     my $sugg01 = $builder->build({ source => 'Suggestion', value => { manageddate => $d1, date => $d2, STATUS => 'ASKED' }});
 427     my $sugg02 = $builder->build({ source => 'Suggestion', value => { manageddate => $d1, date => $d2, STATUS => 'CHECKED' }});
 428     my $sugg03 = $builder->build({ source => 'Suggestion', value => { manageddate => $d2, date => $d2, STATUS => 'ASKED' }});
 429     my $sugg04 = $builder->build({ source => 'Suggestion', value => { manageddate => $d2, date => $d2, STATUS => 'ACCEPTED' }});
 430
 431     # Test no parameter: should do nothing
 432     C4::Suggestions::DelSuggestionsOlderThan();
 433     is( Koha::Suggestions->count, 4, 'No suggestions deleted' );
 434     # Test zero: should do nothing too
 435     C4::Suggestions::DelSuggestionsOlderThan(0);
 436     is( Koha::Suggestions->count, 4, 'No suggestions deleted again' );
 437     # Test negative value
 438     C4::Suggestions::DelSuggestionsOlderThan(-1);
 439     is( Koha::Suggestions->count, 4, 'No suggestions deleted for -1' );
 440
 441     # Test positive values
 442     C4::Suggestions::DelSuggestionsOlderThan(5);
 443     is( Koha::Suggestions->count, 4, 'No suggestions>5d deleted' );
 444     C4::Suggestions::DelSuggestionsOlderThan(3);
 445     is( Koha::Suggestions->count, 3, '1 suggestions>3d deleted' );
 446     C4::Suggestions::DelSuggestionsOlderThan(1);
 447     is( Koha::Suggestions->count, 2, '1 suggestions>1d deleted' );
 448 };
 449
 450 subtest 'EmailPurchaseSuggestions' => sub {
 451     plan tests => 11;
 452
 453     $dbh->do(q|DELETE FROM message_queue|);
 454
 455     t::lib::Mocks::mock_preference( "KohaAdminEmailAddress",
 456         'noreply@hosting.com' );
 457
 458     # EmailPurchaseSuggestions set to disabled
 459     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0" );
 460     Koha::Suggestion->new($my_suggestion)->store;
 461     my $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 462         {
 463             borrowernumber => $borrowernumber
 464         }
 465     );
 466     is( @$newsuggestions_messages, 0,
 467         'New suggestion does not send an email when EmailPurchaseSuggestions disabled' );
 468
 469     # EmailPurchaseSuggestions set to BranchEmailAddress
 470     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 471         "BranchEmailAddress" );
 472     Koha::Suggestion->new($my_suggestion)->store;
 473
 474     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 475     Koha::Suggestion->new($my_suggestion)->store;
 476
 477     Koha::Libraries->find('CPL')->update( { branchemail => 'branchemail@hosting.com' } );
 478     Koha::Suggestion->new($my_suggestion)->store;
 479
 480     Koha::Libraries->find('CPL')->update( { branchreplyto => 'branchemail@b.c' } );
 481     Koha::Suggestion->new($my_suggestion)->store;
 482
 483     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 484         {
 485             borrowernumber => $borrowernumber
 486         }
 487     );
 488     isnt( @$newsuggestions_messages, 0, 'New suggestions sends an email wne EmailPurchaseSuggestions enabled' );
 489     my $message1 =
 490       C4::Letters::GetMessage( $newsuggestions_messages->[0]->{message_id} );
 491     is( $message1->{to_address}, 'noreply@hosting.com',
 492 'BranchEmailAddress falls back to KohaAdminEmailAddress if branchreplyto, branchemail and ReplytoDefault are not set'
 493     );
 494     my $message2 =
 495       C4::Letters::GetMessage( $newsuggestions_messages->[1]->{message_id} );
 496     is( $message2->{to_address}, 'library@b.c',
 497 'BranchEmailAddress falls back to ReplytoDefault if neither branchreplyto or branchemail are set'
 498     );
 499     my $message3 =
 500       C4::Letters::GetMessage( $newsuggestions_messages->[2]->{message_id} );
 501     is( $message3->{to_address}, 'branchemail@hosting.com',
 502 'BranchEmailAddress uses branchemail if branch_replto is not set'
 503     );
 504     my $message4 =
 505       C4::Letters::GetMessage( $newsuggestions_messages->[3]->{message_id} );
 506     is( $message4->{to_address}, 'branchemail@b.c',
 507 'BranchEmailAddress uses branchreplyto in preference to branchemail when set'
 508     );
 509
 510     # EmailPurchaseSuggestions set to KohaAdminEmailAddress
 511     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 512         "KohaAdminEmailAddress" );
 513
 514     t::lib::Mocks::mock_preference( "ReplytoDefault", undef );
 515     Koha::Suggestion->new($my_suggestion)->store;
 516
 517     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 518     Koha::Suggestion->new($my_suggestion)->store;
 519
 520     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 521         {
 522             borrowernumber => $borrowernumber
 523         }
 524     );
 525     my $message5 =
 526       C4::Letters::GetMessage( $newsuggestions_messages->[4]->{message_id} );
 527     is( $message5->{to_address},
 528         'noreply@hosting.com', 'KohaAdminEmailAddress uses KohaAdminEmailAddress when ReplytoDefault is not set' );
 529     my $message6 =
 530       C4::Letters::GetMessage( $newsuggestions_messages->[5]->{message_id} );
 531     is( $message6->{to_address},
 532         'library@b.c', 'KohaAdminEmailAddress uses ReplytoDefualt when ReplytoDefault is set' );
 533
 534     # EmailPurchaseSuggestions set to EmailAddressForSuggestions
 535     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 536         "EmailAddressForSuggestions" );
 537
 538     t::lib::Mocks::mock_preference( "ReplytoDefault", undef );
 539     Koha::Suggestion->new($my_suggestion)->store;
 540
 541     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 542     Koha::Suggestion->new($my_suggestion)->store;
 543
 544     t::lib::Mocks::mock_preference( "EmailAddressForSuggestions",
 545         'suggestions@b.c' );
 546     Koha::Suggestion->new($my_suggestion)->store;
 547
 548     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 549         {
 550             borrowernumber => $borrowernumber
 551         }
 552     );
 553     my $message7 =
 554       C4::Letters::GetMessage( $newsuggestions_messages->[6]->{message_id} );
 555     is( $message7->{to_address},
 556         'noreply@hosting.com', 'EmailAddressForSuggestions uses KohaAdminEmailAddress when neither EmailAddressForSuggestions or ReplytoDefault are set' );
 557
 558     my $message8 =
 559       C4::Letters::GetMessage( $newsuggestions_messages->[7]->{message_id} );
 560     is( $message8->{to_address},
 561         'library@b.c', 'EmailAddressForSuggestions uses ReplytoDefault when EmailAddressForSuggestions is not set' );
 562
 563     my $message9 =
 564       C4::Letters::GetMessage( $newsuggestions_messages->[8]->{message_id} );
 565     is( $message9->{to_address},
 566         'suggestions@b.c', 'EmailAddressForSuggestions uses EmailAddressForSuggestions when set' );
 567 };
 568
 569 subtest 'ModSuggestion should work on suggestions without a suggester' => sub {
 570     plan tests => 2;
 571
 572     $dbh->do(q|DELETE FROM suggestions|);
 573     my $my_suggestionid = Koha::Suggestion->new($my_suggestion_without_suggestedby)->store()->id;
 574     $suggestion = GetSuggestion($my_suggestionid);
 575     is( $suggestion->{suggestedby}, undef, "Suggestedby is undef" );
 576
 577     ModSuggestion(
 578         {
 579             suggestionid => $my_suggestionid,
 580             STATUS       => 'CHECKED',
 581             note         => "Test note"
 582         }
 583     );
 584     $suggestion = GetSuggestion($my_suggestionid);
 585
 586     is( $suggestion->{note}, "Test note", "ModSuggestion works on suggestions without a suggester" );
 587 };
 588
 589 subtest 'Suggestion with ISBN' => sub {
 590     my $suggestion_with_isbn = {
 591         isbn     => '1940997232',
 592         title    => "The Clouds",
 593         author   => "Aristophanes",
 594     };
 595     my $record = MarcRecordFromNewSuggestion( $suggestion_with_isbn );
 596     is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
 597
 598     my ($isbn_tag, $isbn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.isbn', '');
 599     is($record->field( $isbn_tag )->subfield( $isbn_subfield ), "1940997232", "ISBN Record from suggestion ISBN should be '1940997232'");
 600
 601     my ($issn_tag, $issn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.issn', '');
 602     is($record->field( $issn_tag )->subfield( $issn_subfield ), "1940997232", "ISSN Record from suggestion ISBN should also be '1940997232'");
 603
 604     my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title', '');
 605     is($record->field( $title_tag), undef, "Record from suggestion title should be empty");
 606
 607     my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
 608     is($record->field( $author_tag), undef, "Record from suggestion author should be empty");
 609 };
 610
 611 $schema->storage->txn_rollback;