3 # This file is a test script for C4::VirtualShelves.pm
4 # Author : Antoine Farnault, antoine@koha-fr.org
5 # Larger modifications by Jonathan Druart and Marcel de Rooy
8 use Test::More tests => 96;
11 use C4::Biblio qw( AddBiblio DelBiblio );
13 use C4::Members qw( AddMember );
16 my $dbh = C4::Context->dbh;
17 $dbh->{RaiseError} = 1;
18 $dbh->{AutoCommit} = 0;
20 # Create some borrowers
22 for my $i ( 1 .. 10 ) {
23 my $borrowernumber = AddMember(
24 firstname => 'my firstname',
25 surname => 'my surname ' . $i,
29 push @borrowernumbers, $borrowernumber;
32 # Creating some biblios
35 my ($biblionumber)= AddBiblio(MARC::Record->new, '');
37 push @biblionumbers, $biblionumber;
40 #----------------------------------------------------------------------#
44 #----------------------------------------------------------------------#
46 use_ok('C4::VirtualShelves');
48 #-----------------------TEST AddShelf function------------------------#
49 # usage : $shelfnumber = &AddShelf( $shelfname, $owner, $category);
51 # creating shelves (could be <10 when names are not unique)
54 my $name= randomname();
55 my $catg= int(rand(2))+1;
56 my $ShelfNumber= AddShelf(
61 $borrowernumbers[$i]);
64 ok($ShelfNumber > -1, "created shelf"); # Shelf creation successful;
67 my $t= C4::VirtualShelves::_CheckShelfName(
68 $name, $catg, $borrowernumbers[$i], 0);
69 is($t, 0, "Name clash expected on shelf creation");
72 number => $ShelfNumber,
75 owner => $borrowernumbers[$i],
76 }; #also push the errors
79 # try to create shelves with duplicate names
81 if($shelves[$i]->{number}<0) {
82 ok(1, 'skip duplicate test for earlier name clash');
85 my @shlf=GetShelf($shelves[$i]->{number}); #number, name, owner, catg, ...
87 # A shelf name is not per se unique!
88 if( $shlf[3]==2 ) { #public list: try to create with same name
89 my $badNumShelf= AddShelf( {
90 shelfname=> $shelves[$i]->{name},
92 }, $borrowernumbers[$i]);
93 is($badNumShelf, -1, 'do not create public lists with duplicate names');
94 #AddShelf returns -1 if name already exist.
95 DelShelf($badNumShelf) if $badNumShelf>-1; #delete if went wrong..
97 else { #private list, try to add another one for SAME user (owner)
98 my $badNumShelf= defined($shlf[2])? AddShelf(
100 shelfname=> $shelves[$i]->{name},
104 is($badNumShelf, -1, 'do not create private lists with duplicate name for same user');
105 DelShelf($badNumShelf) if $badNumShelf>-1; #delete if went wrong..
109 #-----------TEST AddToShelf & GetShelfContents & DelFromShelf functions--------------#
110 # usage : &AddToShelf($biblionumber, $shelfnumber);
111 # usage : $biblist = &GetShelfContents($shelfnumber);
112 # usage : $biblist = GetShelfContents($shelfnumber);
116 my $bib = $biblionumbers[int(rand(9))];
117 my $shelfnumber = $shelves[int(rand(9))]->{number};
119 ok(1, 'skip add to list-test for shelf -1');
120 ok(1, 'skip counting list entries for shelf -1');
124 my $key = "$bib\t$shelfnumber";
125 my $should_fail = exists($used{$key}) ? 1 : 0;
126 #FIXME We assume here that we have permission to add..
127 #The different permissions could be tested too.
129 my ($biblistBefore,$countbefore) = GetShelfContents($shelfnumber);
130 my $status = AddToShelf($bib,$shelfnumber,$borrowernumbers[$i]);
131 my ($biblistAfter,$countafter) = GetShelfContents($shelfnumber);
134 ok(!defined($status), 'failed to add to list when we should');
136 ok(defined($status), 'added to list when we should');
139 if (defined $status) {
140 is($countbefore, $countafter - 1, 'added bib to list'); # the bib has been successfuly added.
142 is($countbefore, $countafter, 'did not add duplicate bib to list');
148 #-----------------------TEST ModShelf & GetShelf functions------------------------#
149 # usage : ModShelf($shelfnumber, $shelfname, $owner, $category )
150 # usage : (shelfnumber,shelfname,owner,category) = GetShelf($shelfnumber);
153 my $rand = int(rand(9));
154 my $numA = $shelves[$rand]->{number};
156 ok(1, 'Skip ModShelf test for shelf -1');
157 ok(1, 'Skip ModShelf test for shelf -1');
158 ok(1, 'Skip ModShelf test for shelf -1');
161 my $newname= randomname();
163 shelfname => $newname,
164 category => 3-$shelves[$rand]->{catg}, # tric: 1->2 and 2->1
166 #check name change (with category change)
167 if(C4::VirtualShelves::_CheckShelfName($newname,$shelf->{category},
168 $shelves[$rand]->{owner}, $numA)) {
169 ModShelf($numA,$shelf);
170 my ($numB,$nameB,$ownerB,$categoryB) = GetShelf($numA);
171 is($numA, $numB, 'modified shelf');
172 is($shelf->{shelfname}, $nameB, '... and name change took');
173 is($shelf->{category}, $categoryB, '... and category change took');
176 ok(1, "No ModShelf for $newname") for 1..3;
180 #----------------------- TEST AddShare ----------------------------------------#
182 #first count the number of shares in the table
183 my $sql_sharecount="select count(*) from virtualshelfshares";
184 my $cnt1=$dbh->selectrow_array($sql_sharecount);
186 #try to add a share without shelfnumber: should fail
187 AddShare(0, 'abcdefghij');
188 my $cnt2=$dbh->selectrow_array($sql_sharecount);
189 is($cnt1,$cnt2, "Did not add an invalid share record");
191 #add another share: should be okay
192 #AddShare assumes that you tested if category==private (so we could actually
193 #be doing something illegal here :)
194 my $n=$shelves[0]->{number};
196 ok(1, 'Skip AddShare for shelf -1');
199 AddShare($n, 'abcdefghij');
200 my $cnt3=$dbh->selectrow_array($sql_sharecount);
201 is(1+$cnt2, $cnt3, "Added one new share record with invitekey");
204 #----------------------- TEST AcceptShare -------------------------------------#
206 # test accepting a wrong key
207 my $testkey= 'keyisgone9';
208 my $acctest="delete from virtualshelfshares where invitekey=?";
209 $dbh->do($acctest,undef,($testkey)); #just be sure it does not exist
210 $acctest="select shelfnumber from virtualshelves";
211 my ($accshelf)= $dbh->selectrow_array($acctest);
212 is(AcceptShare($accshelf,$testkey,$borrowernumbers[0]),undef,'Did not accept invalid key');
214 # test accepting a good key
215 if( AddShare($accshelf,$testkey) && $borrowernumbers[0] ) {
216 is(AcceptShare($accshelf, $testkey, $borrowernumbers[0]),1,'Accepted share');
218 else { #cannot accept if addshared failed somehow
219 ok(1, 'Skipped second AcceptShare test');
222 #----------------------- TEST IsSharedList ------------------------------------#
225 my $sql="select count(*) from virtualshelfshares where shelfnumber=? and borrowernumber is not null";
226 my $sh=$shelves[$i]->{number};
227 my ($n)=$dbh->selectrow_array($sql,undef,($sh));
228 is(IsSharedList($sh),$n? 1: '', "Checked IsSharedList for shelf $sh");
231 #----------------TEST DelShelf & DelFromShelf functions------------------------#
234 my $shelfnumber = $shelves[$i]->{number};
236 ok(1, 'Skip DelShelf for shelf -1');
239 my $status = DelShelf($shelfnumber);
240 is($status, 1, "deleted shelf $shelfnumber and its contents");
243 #----------------------- TEST RemoveShare -------------------------------------#
245 my $remshr_test="select borrowernumber, shelfnumber from virtualshelfshares where borrowernumber is not null";
246 my @remshr_shelf= $dbh->selectrow_array($remshr_test);
248 is(RemoveShare(@remshr_shelf),1,'Removed a shelf share');
251 ok(1,'Skipped RemoveShare test');
254 #----------------------- SOME SUBS --------------------------------------------#
259 $rv.= ('a'..'z','A'..'Z',0..9) [int(rand()*62)];