Bug 1859 - Notice fields: can't select multiple fields at once
authorOwen Leonard <oleonard@myacpl.org>
Fri, 13 May 2016 00:35:01 +0000 (20:35 -0400)
committerJulian Maurice <julian.maurice@biblibre.com>
Tue, 17 May 2016 05:45:49 +0000 (07:45 +0200)
commit09a7c74306d4787c832d27a2fa13fc02b9c097a2
tree780f7d64b144ec98f9250f922ff5462f9555432d
parent83b1f1226e39f191689dfe6818d5adb958c262b3
Bug 1859 - Notice fields: can't select multiple fields at once

When selecting database fields to appear in a notice, selecting multiple
fields at once doesn't work correctly. The selected fields are grouped
together between << and >> instead of each being bracketed separately.

This patch corrects this problem. Also changed: Removal of 'onclick';
Conversion of 'insert' button to a Bootstrap buttons styled with a Font
Awesome icon; HTML validation error fixes.

To test, apply the patch and go to Tools -> Notices & Slips.

- Edit any notice.
- Select a notice version to edit (Email, Print, etc.).
- Confirm that the "Insert" button looks correct.
- Using ctrl+click, select multiple database fields to add to the
  notice. Confirm that clicking the "Insert" button adds the fields
  correctly.
- Confirm that there are no HTML validation errors.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 9b99d7810176726fe28c65d17c7f93dcd95cdd09)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt