Bug 25726: make holds to pull ignore holds where found is not null and itemnumber...
authorAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Fri, 12 Jun 2020 13:51:16 +0000 (13:51 +0000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Fri, 18 Sep 2020 17:36:11 +0000 (19:36 +0200)
commit0ed8da203bdbd05a95b5921d9c7f90987b24f81a
treeac120a910c2a564f9492114aa187ac4ba42a762c
parented4fbbcbee730d5dc26f6c1379091d65522875d0
Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null

To test:
1- place 2 bib-level holds on available items
2- confirm they both show on Holds to Pull
3- edit one hold from the database to set found='T'
4- reload Holds to Pull, confirm it is now empty
5- apply patch
6- Reload Holds to Pull
7- confirm it now shows the hold you did not edit

Signed-off-by: donnab <donna@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Using capitals for SQL reserved words; added a FIXME
Tested with:
    update reserves set found='T', itemnumber=NULL where reserve_id=...
This should be a workaround while we fix the underlying problem.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 56220d211d7b5c4e2622787f9ea38ab12c8868f5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit cb76501776b3d03cf7c513b50c6b38630740416e)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
(cherry picked from commit 39547a6279e418823a23809c813dc198a07eca75)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
circ/pendingreserves.pl