]> git.koha-community.org Git - koha.git/commit
Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm
authorNick Clemens <nick@bywatersolutions.com>
Wed, 16 Jan 2019 13:19:45 +0000 (13:19 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 25 Feb 2019 13:27:17 +0000 (13:27 +0000)
commit185dd71db731fa164810b3dbea38fc08ee1bed68
tree6dee94e78e195869c0d9d179e1df354987fe1ff4
parent189b33d1ea1592ff680534072f0cf7b3860079aa
Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm

AddIssue already checks for holds in the item being issued and deals with them

The sip code, additionally, does not consider that multiple holds per bib
is allowed

To test:
 0 - Apply only first patch (unit tests)
 1 - Place two holds for a patron on a bib
 2 - Checkout that item via sip_cli_emulator
 3 - Note all holds are cancelled/filled
 4 - prove -v t/db_dependent/SIP/Transaction.t
 5 - it fails
 6 - Apply second patch
 7 - prove tests, all green
 8 - Place two holds on a single bib for one patron again
 9 - Checkout the item via sip_cli_emulator
10 - Only one holds is filled

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit c3b41cb12465249cc87ed8866855e06e61842872)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/SIP/ILS/Transaction/Checkout.pm