]> git.koha-community.org Git - koha.git/commit
Bug 26999: (follow-up) Simplify code
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 15 Mar 2021 11:33:49 +0000 (08:33 -0300)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Sat, 24 Apr 2021 14:46:29 +0000 (14:46 +0000)
commit20d66fdfd6736e09ffbbe2ee55be6a295c0c5fad
treefc44603f53bbf320f29a6351878c98dab5e58ae0
parenta0ef98df2602daabcfbfd01fd6cf8dfafc8876d8
Bug 26999: (follow-up) Simplify code

Doing
$ git grep pickup_locations_code

shows there's some calculated data that is not actually used anywhere.
We can get rid of it.

This patch also reuses $item_object (which is in the same loop scope) to
avoid an extra DB call.

To test:
1. Run:
   $ git grep pickup_locations_code
=> FAIL: It is only used/set as a comma separated string, inside
request.pl
2. Apply this patch
3. Repeat 1
=> SUCCESS: The unused stuff is not there anymore
4. Open the page for placing some holds
=> SUCCESS: It doesn't explode
5. Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 0fd2be61e8376ad0db0f8ecf1eacde706cec6816)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 7ca4b8e15c968b763d58b428a1aed26a293d08b8)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
reserve/request.pl