Bug 29525: Make Koha::Hold->cancel anonymize if required
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 12 Jan 2022 19:32:24 +0000 (16:32 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 11 Feb 2022 00:44:22 +0000 (14:44 -1000)
commit2f3926965f846f507f233dc552fb032301d35536
tree0a006b5ee4c66f2cb4e3e2fb6d60cdae009b0643
parentc96977ede271ac91e9d2d28f1cdd30787ab35585
Bug 29525: Make Koha::Hold->cancel anonymize if required

This patch makes cancelling a hold anonymize it on the same call, if
settings require it (i.e. if borrowers.privacy is set to 2).

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: The code actually does what it is meant to
3. Try on the UI, cancelling a hold, noticing it gets anonymized if the
   patron has privacy == always/2.
4. Sign off :-D

Note: AnonymousPatron should be set. Otherwise it would set NULL. But
that's fine, that's what Koha does already.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Hold.pm
t/db_dependent/Koha/Hold.t