Bug 23679: fix software error when trying to transfer an unknown barcode
authorFridolin Somers <fridolin.somers@biblibre.com>
Thu, 26 Sep 2019 07:09:15 +0000 (09:09 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 8 Oct 2019 07:45:34 +0000 (09:45 +0200)
commit43f15f13123c705bb750af43a74997e581b48719
tree68f9918d364955af58980bc29f0fd6ac502315a2
parentd851b3019b7504beb7c0e9fcb55694f475ba5e56
Bug 23679: fix software error when trying to transfer an unknown barcode

When trying to transfer an unknown barcode in
/cgi-bin/koha/circ/branchtransfers.pl you get the error :

Can't call method "itemnumber" on an undefined value at
/home/koha/src/C4/Circulation.pm line 319.

This comes from C4::Circulation::transferbook which should stop when
finding unknown barcode.

Test plan :
1) Go to /cgi-bin/koha/circ/branchtransfers.pl
2) Enter a barcode not existing in database
3) Without patch you get a software error, with patch you get a message
   saying 'No Item with barcode'
4) Enter a barcode existing in database and check transfer is OK

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 3848a3a772e2202ac3339bd241adcef987e48361)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Circulation.pm