Bug 27745: prevent warning for uninitialized value as a hash key
authorPetro Vashchuk <stalkernoid@gmail.com>
Wed, 3 Mar 2021 09:32:48 +0000 (11:32 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 12 Mar 2021 07:56:54 +0000 (08:56 +0100)
commit4b6e421f1f40bd99cba0c380510824f4a45894cd
tree7e0c25cc74225cf497869a364e5524d6a66276a3
parent1100dcf0fc69de841eef23f8e1b3c1b390b48fbc
Bug 27745: prevent warning for uninitialized value as a hash key

When you edit and save items with an empty "c - Shelving location"
field, it gets stored into the database as "NULL",
which is allowed in the database, and the field is not "required",
so this seems expected.

But when the search page is rendered, it gets value by location key
($shelflocations->{ $item->{location} }) which gives undef warning.

Solved by checking if $item->{location} is perl true.

To reproduce:
    1) Edit the book or create new one with an empty shelving location.
    2) Use the search feature to have that book in the searched list.
    3) Check plack-intranet-error.log to find "Use of uninitialized
value in hash element" error.
    4) Apply the patch.
    5) Repeat the search and check the logs again to ensure that error
didn't appear again.

Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ebf123bf139b28d274ade70016c1af0e3aeffb1b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Search.pm