Bug 17988 - Select2 prevents correct tag expand/minimize functionality
authorOleg Vasylenko <synapse.ova@gmail.com>
Wed, 25 Jan 2017 10:01:05 +0000 (12:01 +0200)
committerMason James <mtj@kohaaloha.com>
Wed, 22 Feb 2017 20:36:21 +0000 (09:36 +1300)
commit53eef191ebd1848316c0969196e63dfd185cf419
treedb2a819d11540b8f2bfc118a78313d458c8d1e85
parent6c1d46b8e847939e88d381aaccbe6b96634f7dd5
Bug 17988 - Select2 prevents correct tag expand/minimize functionality

Overview:
Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure.
Because of that, expanding fields to show all hidden subfields does not work properly.

Steps to Reproduce:
1. Open some book in the editor or create new (cataloguing/addbiblio.pl)
2. Try to minimize or expand fields, that have among subfields the following:
— Thesaurus driven subfield → subfield with Select2
— Hidden subfield.

Actual Results:
 — some fields become hidden, some not, and vice versa
 — in the console, you'll see «Uncaught TypeError: Cannot read property 'match' of null»

Expected Results:
 — all subfields should minimize/maximize completely

Additional Information:
This happens because Select2 adds some divs, that do not have ID property.
The following patch adds check for the needed attribute existance.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
koha-tmpl/intranet-tmpl/prog/js/cataloging.js