Bug 22948: Markup error in OPAC bibliographic detail template
authorOwen Leonard <oleonard@myacpl.org>
Tue, 21 May 2019 14:27:40 +0000 (14:27 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 11 Jun 2019 14:49:11 +0000 (14:49 +0000)
commit5a930ccf299c7f7aeeac9d8de185fb1d8d24e9c9
tree9faf87e5eefb50cfce7b0242a68367d8ac427538
parent9c4c9d17e4c48db760d0f75e01f0a85c9c443e11
Bug 22948: Markup error in OPAC bibliographic detail template

This patch addresses one markup problem in opac-detail.tt which triggers
a validation error.

To reproduce the problem, view the normal bibliographic detail page for
a record in the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "The aria-labelledby attribute must point to an element in the same
   document."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the "Save record -> Dublin Core" menu item. It should trigger a
modal window.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a3da6d6825f686099d8e23a1abff061071d679ad)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 1baddd190fe1ed72e66298a6b01394e86e58d0fe)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc