Bug 16587 - opac-sendbasket.pl is open to XSS
authorChris Cormack <chris@bigballofwax.co.nz>
Wed, 25 May 2016 14:01:41 +0000 (14:01 +0000)
committerJulian Maurice <julian.maurice@biblibre.com>
Wed, 31 Aug 2016 09:33:37 +0000 (11:33 +0200)
commit64353ccb2dd4f276d3adb6d770daff2294614618
tree04747d68132a21470952d0eb408e427c6679f04a
parent0e7d621121821437b28fe24779bcd1cf8f9f6f04
Bug 16587 - opac-sendbasket.pl is open to XSS

To test
1/ Hit a url like
http://localhost:8080/cgi-bin/koha/opac-sendbasket.pl?email_add=%3Cscript%3Ealert(%27XSS%27)%3C%2Fscript%3Ezz%40zz&comment=tes&bib_list=3

Where bib_list is a valid basket number
2/ Notice you get a javascript alert showing
3/ Apply patch
4/ Notice the text is now escaped

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 05a014b7668e0c4fa662821f7774ac733fd0cc7f)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt