Bug 24114: Remove warn statements from Koha::Patrons
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 26 Nov 2019 10:11:35 +0000 (11:11 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Wed, 8 Apr 2020 15:00:09 +0000 (15:00 +0000)
commit7399a8de944674dfdb1ffb9dd014427d7750dd14
treef79e30a800af9347df89d561445c8299fcd23e99
parentc9154e6e83614f4808d529a967e150e6b08bcd41
Bug 24114: Remove warn statements from Koha::Patrons

The warn must be done in the cronjob.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Followed this test plan (with two follow-ups applied):
[1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef
[2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job:
    Locked 0 patrons
    Anonymized 1 patrons
    Deleted 0 patrons
[3] Pick borrower, set expiry to NOW-3. Run cleanup job:
    Locked 0 patrons
    Anonymized 0 patrons
    Deleted 1 patrons

Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit d7f922eb63c420375f42ab419d9db154650fbd4d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/Patrons.pm
misc/cronjobs/cleanup_database.pl