]> git.koha-community.org Git - koha.git/commit
Bug 17916 - "Delete MARC modification template" fails to actually delete it
authorOwen Leonard <oleonard@myacpl.org>
Tue, 25 Apr 2017 13:15:13 +0000 (13:15 +0000)
committerKatrin Fischer <katrin.fischer.83@web.de>
Sat, 13 May 2017 12:20:11 +0000 (14:20 +0200)
commit91c0b29534aff07b4469ce4999386984ed2e9fd0
tree8a9d066407ff00418da06bc3c9e39d273fb13af1
parent609c2700886d32cf206726bdcd48e0f31fd7cd98
Bug 17916 - "Delete MARC modification template" fails to actually delete it

The MARC modification templates' 'Delete' button fails because the event
handler has a "preventDefault" but the outcome of the confirmation
function must return true or false.

This patch removes the "preventDefault" from the .delete_template click
handler as well as a redundant onclick attribute from the delete link
itself.

To test, apply the patch and go to Tools -> MARC modification templates.
Clicking the delete button for any existing template should work
correctly.

Followed test plan, worked as intended

Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 3fddc0d73724c6c5f1aafe6842c488304b79f306)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js