Bug 22947: Markup error in OPAC preferences file
authorOwen Leonard <oleonard@myacpl.org>
Tue, 21 May 2019 13:19:17 +0000 (13:19 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 11 Jun 2019 14:11:14 +0000 (14:11 +0000)
commitb0b4973bdc622f3913bbde9f9acf57826e82c906
tree53b4a8bb2e248fa6b57e57667afea762e715366a
parent12b38e85e541f50aa1ea2ccee86f4239396a9b54
Bug 22947: Markup error in OPAC preferences file

This patch corrects a markup error in the OPAC .pref file which can
cause display problems. The patch also corrects a validator warning by
changing at <tt> to a <code>.

To reproduce the problem, go to Administration -> Global system
preferences -> OPAC.

Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses two specific errors:

 - "Unclosed element code."
 - "The tt element is obsolete. Use CSS instead."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the display.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 87cbb27826a9d03a424e8c944293669157924a01)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 327977abd6fe95ff8ee8f743d690e3efc45501d5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref