Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc)
authorPetro Vashchuk <stalkernoid@gmail.com>
Mon, 22 Feb 2021 11:46:44 +0000 (13:46 +0200)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Sun, 25 Apr 2021 15:16:05 +0000 (15:16 +0000)
commitbb23ab9fe31929ce9ebc736e1e92bd48faf6ec3c
tree331650595490563dbc37e8563fe45639311258e3
parenta9b1f1eab889189f8ebcc28479035aecf7be1726
Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc)

Some of the books have subfield "a" of field "035" absent
and it's possible to have such
(it doesn't says "Require" in the interface),
which causes "Use of uninitialized value $oclc in pattern match (m//)"
error.

Solved by screening regex with check for empty variables before the
match.

To reproduce:
    1) Edit existing book or create a new one with empty marc
subfield "a" of field "035"
    2) Use the search feature that will find it along with some other
books.
    3) Check /var/log/koha/kohadev/plack-intranet-error.log to find
"Use of uninitialized value $oclc in pattern match (m//)" error.
    4) Apply the patch.
    5) Repeat the search and check the logs again to ensure
that error didn't appear again.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit a34e1f9f0d32e4cf0f282016e52166d309b25ef7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 4f618fb33a80d7f757dc0c95832b6d6c7d71f819)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
C4/Koha.pm