Bug 27395: Add a warning to PatronSelfRegistrationDefaultCategory
authorEden Bacani <eden.bacani@gmail.com>
Tue, 19 Jan 2021 21:21:51 +0000 (21:21 +0000)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Tue, 9 Feb 2021 22:00:57 +0000 (22:00 +0000)
commitc01dd7a8fb3cf82226a9ca525f49ad0d12e05d68
tree2001e34d5907f4904b38433266d5c2ba66dcbe0f
parenta84c0b0b65451756c0af2f086b34b0f1339fb793
Bug 27395: Add a warning to PatronSelfRegistrationDefaultCategory

This patch adds a warning to the PatronSelfRegistrationDefaultCategory system
preference to not use a regular patron category for self registration.

If a regular patron category code is used and the cleanup_database cronjob is setup
to delete unverified and unfinished OPAC self registrations, it permanently and
and unrecoverably deletes all patrons that have registered more than
PatronSelfRegistrationExpireTemporaryAccountsDelay days ago.

It also removes unnecessary apostrophes at the end of two self registration
and modification system preference descriptions.

Test plan:
1. Apply the patch.
2. Check that the warning message for the PatronSelfRegistrationDefaultCategory
   system preference is clear and makes sense.
3. Sign off!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 065c955cc67b6f113c9fb5d5ed918ba1400b5af9)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit aea5a5800a6a4aead6e8fa61fd8a12d2e9b5f1e4)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref