Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Wed, 17 Feb 2021 12:28:03 +0000 (14:28 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 8 Mar 2021 15:35:52 +0000 (16:35 +0100)
commitdfd1d58f6787ea19d38fff939523243c2de9a5e5
tree4876a071d7c2964d8ca59a3dc656689118f1c8d5
parente07c676e43ed8cdca3e7bd67e6979786ed79ae6b
Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred

Items that are attached to a hold and being transferred (found = T) is
final decision and you cannot checkout those to other patrons.

To test (if you have applied all patches from bug 25690):
 1) prove t/db_dependent/SIP/Transaction.t => passes

To test (if you don't have all patches):
 1) Create hold and set pickup library to something else where the
    item is at
 2) Return the item and it should confirm the hold and start transfer
 3) Apply this patch
 4) Try to checkout this item now to some other patron via SIP2 and
    notice it doesn't allow it
 5) Revert this patch
 6) Notice you can now checkout somebody else's hold that is being transferred!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 9b5913d308e4aa03306c5275d0e638e922a6db32)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/SIP/ILS/Item.pm