Bug 24892: Resolve uninitialized warns from opac-memberentry
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 18 Mar 2020 13:54:52 +0000 (13:54 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 13 Apr 2020 19:54:32 +0000 (19:54 +0000)
commitf117fa6f97a10008071e029d4fdc7a516f22200f
tree31ad8ca00ca3963161927ef7ab93228da4650fb9
parent798f176f2908ad7b53b6da6341c512a4398d6b86
Bug 24892: Resolve uninitialized warns from opac-memberentry

Especially line 500 (current master).

Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.

Simple fix, not completely trivial due to adding xor ;)

Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 44d91396128a38a29b21f643f2e6439383a03e5c)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
opac/opac-memberentry.pl