Owen Leonard [Tue, 16 Oct 2012 18:12:13 +0000 (14:12 -0400)]
Bug 8931 - submit buttons have blue background
This patch specifies a transparent background for fieldsets
and divs with the class "action," which are typically containers
for the submit/cancel actions.
For testers, a good example page to view is the "set library" page.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Passed-QA-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Lyon3 Team [Mon, 29 Oct 2012 10:59:44 +0000 (11:59 +0100)]
Bug 8978: Patron's dateexpiry erroneously updated when in UnwantedField
If dateexpiry field was absent because it has been included in
UnWantedField syspref list, the script assumed that the date has
been forgotten and updated it when clicking on 'save' button.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Jared Camins-Esakov [Wed, 31 Oct 2012 21:22:35 +0000 (17:22 -0400)]
Merge branch 'bug_8982' into 3.12-master
MJ Ray [Tue, 30 Oct 2012 10:14:49 +0000 (10:14 +0000)]
Bug 8982 make koha-create accept --database option
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Owen Leonard [Tue, 30 Oct 2012 15:07:04 +0000 (11:07 -0400)]
Bug 8707 - tags always say approved
Template scope error caused an incorrect state on the
approval/rejection buttons when viewing rejected tags.
To test, go to Tags and view the list of rejected tags.
In the "Actions" column, the "rejected" button should be
greyed out, and the "approve" button active.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Jared Camins-Esakov [Wed, 31 Oct 2012 19:10:02 +0000 (15:10 -0400)]
Correct a typo in docs/history.txt and add 3.6.x releases
Owen Leonard [Mon, 29 Oct 2012 19:24:37 +0000 (15:24 -0400)]
Bug 8980 - Untranslatable strings in modborrowers.pl
This patch removes the declaration of interface labels
from the script and puts it in the template where the
labels can be translated. The labels have been modified
to match those used on the patron entry form.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Fridolyn SOMERS [Wed, 17 Oct 2012 08:53:29 +0000 (10:53 +0200)]
Bug 8936: Search RSS feeds does not show there items when subscribing in Firefox
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Fridolyn SOMERS [Fri, 26 Oct 2012 08:50:58 +0000 (10:50 +0200)]
Bug 8973: HTML and URL escape missing in OPAC templates
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Thu, 25 Oct 2012 18:00:42 +0000 (14:00 -0400)]
Bug 8665 follow-up: add missing line to XSLT
The DOM transformer was missing a line from a previous development,
resulting in the MARC21 authorities DOM indexing stylesheet being
regenerated with a missing line. This patch readds the missing line
to the transformer, and provides the corrected authority-zebra-indexdefs.
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Thu, 4 Oct 2012 12:52:48 +0000 (08:52 -0400)]
Bug 8665: DOM indexing fails to index some bib records
Use a user-specified field for z:id.
This patch also fixes an excess space before the index in the MARC21
biblio index definitions, which someone fixed in the generated file
but not in the source file it should have been fixed in.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Maxime Pelletier [Wed, 24 Oct 2012 21:22:02 +0000 (17:22 -0400)]
Bug 8966 Koha::Calendar::is_holiday truncates the date
* Create a local copy of the date instead of calling truncate directly on the date
* Add a test to properly test that the issue is fixed
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mark Tompsett [Wed, 19 Sep 2012 07:04:33 +0000 (15:04 +0800)]
Bug 8749 - Missing Ubuntu library files in ubuntu.*.packages
Added:
libtemplate-plugin-htmltotext-perl install
into the four files, as this is available in the
debian.koha-community.org repository.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Thu, 25 Oct 2012 14:56:52 +0000 (10:56 -0400)]
Bug 8961: Fix typo in offline circ help
Signed-off-by: Marc Veron <veron@veron.ch>
Tiny typo fix in HTML text.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Magnus Enger [Thu, 18 Oct 2012 09:56:47 +0000 (11:56 +0200)]
Bug 8941 - Make title display properly for NORMARC OPAC detail view
Authors and materialtype were displayed to the right of the title.
This patch simly adds class="title" to the h1 that holds the title.
To test:
- Set marcflavour = NORMARC
- Check a detail view in the OPAC and see that the display is wrong
- Apply the patch
- Check that the detail view now looks good
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Wed, 26 Sep 2012 21:03:28 +0000 (17:03 -0400)]
Bug 8823: CatalogModuleRelink Creates Multiple Links between Bib and Auth record
On 3.8.x, it was possible for multiple automatically generated
authorities to be linked to a single heading. This patch deletes
previous links from headings prior to linking them to
automatically-generated headings. This patch also corrects a
potential problem wherein multiple authorities might be generated if
a record is edited repeatedly in quick succession. The latter problem
exists on Master and 3.6.x as well, and the code that corrects the
multiple linkages is equally applicable if seemingly unnecessary.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Thu, 4 Oct 2012 14:34:49 +0000 (10:34 -0400)]
Bug 8253 - fix fine doubling, when upgrading from 3.6 to 3.8 - Add de-duplication script
This script will remove these duplicate fines. To use, repeatably run this
script until there are no more duplicates in the database.
(fix_accountlines_rmdupfines_bug8253.pl)
Duplicate fines would happen if you upgraded to a 3.8 version that does not have the
bug8253 patch, and the misc/cronjobs/fines.pl is run. In 3.8 an upgrade to a more
granular date/time was not addressed for pre-existing fine entries and this script
removes the resulting duplicates. It also intelligently preserves the amount outstanding
for payments already applied. If your version already had the bug8253 patch at the time
of the upgrade, duplicate fines should not have been generatd.
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mason James [Tue, 2 Oct 2012 22:09:41 +0000 (11:09 +1300)]
Bug 8253 - Fine doubling
Provides a fix that during database upgrade, fines are correclty
formatted. Once the misc/cronjobs/fines.pl is run in the
upgraded database, it will not result in duplicate fines being
generated.
Signed-off-by: wajasu <matted-34813@mypacks.net>
Jared Camins-Esakov [Fri, 19 Oct 2012 12:33:04 +0000 (08:33 -0400)]
Bug 8947: [SIGNED-OFF] XSLT fallback logic backwards
The logic for the XSLT fallback was backwards, which meant that
non-English installations of the CCSR theme were unable to use XSLT
stylesheets. This patch corrects the logic.
To test:
1) Switch to the ccsr OPAC theme.
2) Switch to a language other than English for the OPAC.
3) Turn on the default XSLT stylesheets for the OPAC.
4) Do a search or view a record that would result in something being
displayed with XSLT. This will work after the patch, but not before.
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised!
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Fri, 26 Oct 2012 15:31:31 +0000 (17:31 +0200)]
Bug 8939 follow-up welcome to Robert Williams 194th contributor
also fixing Mathieu Saby number (193th instead of a duplicate 192nd)
Robert Williams [Thu, 18 Oct 2012 00:58:23 +0000 (13:58 +1300)]
Bug 8939 : Fines being charged during the grace period
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mathieu Saby [Tue, 23 Oct 2012 20:09:31 +0000 (22:09 +0200)]
Bug 8958: Make facets more UNIMARC compliant (revision 1)
Suppressions : I suppressed some indexes not existing in Unimarc : 603, 502,
504
Corrections :
- Places : 651 was Marc21 => I put the right value (607)
- Topics : 600a => 600ab (name/surname) ; 604a => 604at (author/title)
To test, take a record with 607, 600ab, 601ab, 604at, do a research matching
this record, and check if facets looks nicer that before...
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Works as described. 607 for Places is very useful! Other tweakings make sense.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Sat, 13 Oct 2012 02:49:07 +0000 (22:49 -0400)]
Bug 8914: Blank search that returns invalid authorities fails under Plack
When doing a search with no terms for the default authority type under
Plack, you will get a segfault if it returns any records that do not
have any authority type. As far as I can tell, this cannot be reproduced
under CGI/Apache.
To test:
Confirm that you don't get an error if you click the Submit button in
the authorities sections in the staff client and OPAC without entering
a term or changing the authority type.
You may or may not be able to reproduce the problem prior to applying
the patch, but that is the only situation in which I managed to trigger
it.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Mon, 1 Oct 2012 17:36:48 +0000 (13:36 -0400)]
Bug 8213 - "Cancel All" button on holds over tab cancels both holds over and holds waiting
Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Lyon3 Team [Mon, 8 Oct 2012 17:06:04 +0000 (19:06 +0200)]
Question marks in series title facet links
When series title include a question or exclamation mark, theese must be removed
to prevent search failure.
http://bugs.koha-community.org/show_bug.cgi?id=8888
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Before the patch: Series facet links with ! or ? return no results.
After the patch the same links return valid results.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Marc Veron [Mon, 8 Oct 2012 16:33:43 +0000 (18:33 +0200)]
Bug 8885 - OPAC with ccsr theme in IE9
Microsoft-specific filter statements removed from koha-tmpl/opac-tmpl/ccsr/en/css/opac.css
...now background colors show as expected...
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Adrien Saurat [Fri, 21 Sep 2012 13:48:53 +0000 (15:48 +0200)]
Bug 8234: fixes date sort on 'Transfers to receive' page
Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Thu, 25 Oct 2012 14:08:31 +0000 (16:08 +0200)]
Bug 8895 follow-up fix for Jonathan's QA comment
useless use of defined($data->{value}) because it's set to "" 2 lines earlier
Marc Veron [Wed, 10 Oct 2012 05:49:36 +0000 (07:49 +0200)]
Bug 8895 - Warning in systempreferences.pl: Use of uninitialized value in length...
Clicking on Local use tab in system preferences results in warning in log file:
systempreferences.pl: Use of uninitialized value in length at (...)/admin/systempreferences.pl line 456
Reason: content field "value" in table "systempreferences" can be NULL (and is tested for length).
Added test for "defined" at to places.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Thu, 11 Oct 2012 19:05:07 +0000 (15:05 -0400)]
Bug 8905: Error when accessing invalid authority
The GetAuthority shim does not check that authority retrieval was
successful, and therefore can call ->record on an undefined value.
This can be reproduced by trying to load an invalid authority record
using bulkmarcimport. There may be other ways to trigger it, but I'm
not sure what they are.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
another way to trigger this error is just forging your URL with a wrong
authid !
Mark Tompsett [Fri, 12 Oct 2012 06:29:59 +0000 (14:29 +0800)]
Bug 8910 - silent warnings triggered in about.pl
In order to detect the apache version, there are multiple
commands used. These may not all exist, which triggers error log
entries. By simply adding " 2> /dev/null", the errors are no
longer generated.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mark Tompsett [Thu, 27 Sep 2012 06:12:00 +0000 (14:12 +0800)]
Bug 8834 - Call to C4::Context::preference fails to pass $self in Circulation.pm
Changed:
my $circcontrol = C4::Context::preference('CircControl');
To:
my $circcontrol = C4::Context->preference('CircControl');
This will pass $self and 'CircControl' which will then prevent
a "Use of uninitialized value" error log entry.
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Magnus Enger [Sun, 30 Sep 2012 07:57:37 +0000 (09:57 +0200)]
Bug 8568 - Fix some errors in docs for scripts provided by the Debian packages
1. Create a page for koha-run-backups
2. Fix the synopsis for koha-foreach
3. Add koha-create and koha-run-backups to koha-common
To test
- Convert the changed xml files to man pages with
$ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl koha-x.xml
- View generated pages with e.g.
$ man -l koha-x.8"
(Replace x with the names of the changed files)
- Check that the changes make sense
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Works as described. I was able to produce the 3 man files, load them with man
command, and see the added information properly formated.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Colin Campbell [Fri, 28 Sep 2012 10:48:18 +0000 (11:48 +0100)]
Bug 8841 Duedate should be set to end of expiry day
When reducing duedate to patron's expiry date
it should be set to end of that day not 00:00
take account of the fact that the borrower
expiry date will have no hours/minutes
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jonathan Druart [Wed, 19 Sep 2012 07:59:59 +0000 (09:59 +0200)]
But 8787: don't load the page if OpacMaintenance is ON
If the syspref OpacMaintenance is ON, it is useless to loaded the
requested page.
To test:
- switch on the syspref OpacMaintenace
- check in your apache access log, zebra log, etc. the requested page is
not loaded (i.e. on the opac-search.pl page)
Signed-off-by: Marc Veron <veron@veron.ch>
Checked by watching other_vhosts_access.log
Works as expected
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mark Tompsett [Mon, 1 Oct 2012 08:29:22 +0000 (16:29 +0800)]
Bug 8849 - Error log generated when not a demo system
Changed two lines similar to:
unless (C4::Context->config('demo') == 1) {
into lines similar to:
unless (C4::Context->config('demo')) {
By removing the == 1, undefined = false without an error. The
value of demo is supposedly set by a koha-conf.xml variable,
but there is very little documentation on this "demo mode"
beyond the set it to 1 in koha conf for demo mode. Also, demo
doesn't exist in the default koha-conf.xml file generated.
So anyone who knows to create it, will likely create it the
proper way and with the proper value.
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Thu, 11 Oct 2012 19:57:41 +0000 (15:57 -0400)]
Bug 8907 - Last updated date does not appear on currency edit form
No value for $date was getting passed to the format_date function.
This patch changes the way the timestamp is passed.
Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Mon, 22 Oct 2012 12:13:12 +0000 (14:13 +0200)]
Bug 8953 - opac-userupdate encoding issues
This script has various encoding problems:
1. parametars from CGI are not encoded in utf-8, so when they are
compared with utf-8 strings from database every field with
utf-8 characters will be reported in e-mail as changed
2. when sending e-mail, wide characters are passed to Mail::Sendmail
which results in software error if edited field has utf-8 characters
(because of first point, this happend if ANY fields has utf-8 chars)
3. when declaring encoding for outgoing e-mail utf-8 is more correct
than just utf8
Test scenario:
1. open opac-userupdate and edit user which has utf-8 characters in
at least one field (firstname and surname are common examples)
2. edit one of other fields and add utf-8 character to it
3. verify that e-mail with changes arrived with just edited field
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Robin Sheat [Wed, 24 Oct 2012 05:51:07 +0000 (18:51 +1300)]
Bug 8890 - move two more db dependent tests
* t/AuthoritiesMarc.t
* t/SuggestionEngine_ExplodedTerms.t
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Tue, 16 Oct 2012 09:41:03 +0000 (05:41 -0400)]
Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN
This patch removes the usage of the database in Koha::Borrower::Files'
BEGIN block. It also removes the export-related declarations, since
they were unused, and unnecessary in a module called in an object-oriented
fashion.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Jared Camins-Esakov [Tue, 16 Oct 2012 09:14:42 +0000 (05:14 -0400)]
Bug 8890: don't try to load DB-dependent modules
C4::Members::Statistics uses the database in its BEGIN {} block,
which breaks the package build process. This patch causes it to be
skipped in the 00-load test.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Jared Camins-Esakov [Tue, 16 Oct 2012 08:45:43 +0000 (04:45 -0400)]
Bug 8890: C4/HoldsQueue requires DB
This counter-patch moves all database handling code into subroutines
in C4::HoldsQueue. This fixes the test, and is required for persistent
environments like Plack.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Paul Poulain [Wed, 24 Oct 2012 13:44:33 +0000 (15:44 +0200)]
Merge remote-tracking branch 'origin/new/bug_3652'
Chris Hall [Wed, 17 Oct 2012 01:32:19 +0000 (14:32 +1300)]
bug 3652 fixing XSS vulnerabilities in opac-search
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Mon, 15 Oct 2012 15:58:30 +0000 (11:58 -0400)]
Bug 3652: close XSS vulnerabilities in opac-export
The opac-export.pl script had a number of XSS vulnerabilities relating
to its error handling.
To test:
1) Go to /cgi-bin/koha/opac-export.pl?op=export&bib=2&format=<h2>evil</h2>
(substituting a valid biblionumber for the '2')
2) Notice that "evil" is rendered as an h2 heading.
3) Apply patch.
4) Notice that you now see the h2 tags, and they are not rendered by
the browser.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Wed, 24 Oct 2012 13:30:24 +0000 (15:30 +0200)]
Bug 3652 follow-up reverting call to param('bib')
could probably also be removed in opac-detail.pl, but it was still here before Jared patch.
So, in case something is still using bib I haven't removed this call
Jared Camins-Esakov [Mon, 15 Oct 2012 15:45:38 +0000 (11:45 -0400)]
Bug 3652: close XSS vulnerabilities on biblionumber and authid
Previously we did not sanitize biblionumber and authids passed in by
the user.
To test:
1) Go to /cgi-bin/koha/opac-detail.pl?biblionumber=2hi (substituting a
valid biblionumber for the 2).
2) Notice the presence of "2hi" on this page, and also on the ISBD and
MARC views.
3) Go to /cgi-bin/koha/opac-authoritiesdetail.pl?authid=2bye
(substituting a valid authid for the 2).
4) Notice the presence of "2bye" on this page.
3) Apply patch.
4) Notice that "2hi" and "2bye" strings are gone.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Julian Maurice [Thu, 11 Oct 2012 12:20:57 +0000 (14:20 +0200)]
Bug 8903: Pass invoiceid to ModReceiveOrder
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 18:09:56 +0000 (14:09 -0400)]
Bug 8945: Update comments help file
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 18:07:10 +0000 (14:07 -0400)]
Bug 8945: Hold help file
This patch updates the holds help file.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 18:01:13 +0000 (14:01 -0400)]
Bug 8945: Reports Help Files
This patch updates the reports help files for 3.10.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 16:13:49 +0000 (12:13 -0400)]
Bug 8945: Update patron card creator help files
Links to the manual updated, no other changes needed at this time.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 16:03:46 +0000 (12:03 -0400)]
Bug 8945: Update offline circ help files
This patch adds in a help file for the FF offline processer and
updates the other help file.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 15:50:03 +0000 (11:50 -0400)]
Bug 8945: Add patron routing list help file
This patch adds a missing help file to the members folder.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 15:43:45 +0000 (11:43 -0400)]
Bug 8945: Update patron help files
This patch adds two missing help files and updates the
existing help files in the members folder.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 15:22:09 +0000 (11:22 -0400)]
Bug 8945: Label help files
This patch just updates the manual links in the label
folder becaue no other functionality has changed.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 15:10:41 +0000 (11:10 -0400)]
Bug 8945: Circulation help files
Updates circulation help files.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 14:36:48 +0000 (10:36 -0400)]
Bug 8945: Add missing detail help file to catalog
This patch adds a missing help file to the catalogue
folder.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 14:33:17 +0000 (10:33 -0400)]
Bug 8945: Cataloging Help Files
This patch adds one missing help file for analytics and updates
the others.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 13:55:40 +0000 (09:55 -0400)]
Bug 8945: Catalogue Help Files
This patch updates the catalogue help files.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 13:52:42 +0000 (09:52 -0400)]
Bug 8945: Authority Help Files
This patch updates authority help files.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 13:24:16 +0000 (09:24 -0400)]
Bug 8945: Administration Help Files
This patch adds the help file for the transport cost matrix
and updates all others. Still needed is a help file for
'did you mean'.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 12:05:22 +0000 (08:05 -0400)]
Bug 8945: Acquisitions Help Files for 3.10
This patch adds a few missing help files and updates all
of the existing help files for 3.10.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 19 Oct 2012 11:35:07 +0000 (07:35 -0400)]
Bug 8945: Update help files for 3.10
This patch updates help files that are not in any
specific module folder.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Sun, 14 Oct 2012 14:19:15 +0000 (10:19 -0400)]
Bug 8944: Fix invoices search wording
When the invoices page has no results it asks the user
to use the form on the left to search. This patch fixes the
wording to make it a bit clearer.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 12 Oct 2012 14:27:46 +0000 (10:27 -0400)]
Bug 8912 - Remove unused hold-menu.inc
hold-menu.inc is not used on any page in Koha and
can be safely removed.
To confirm, search the Koha source for "hold-menu.inc." No
instances should be found.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Wed, 17 Oct 2012 16:35:28 +0000 (12:35 -0400)]
Bug 8935 - transport cost matrix could be prettier
Correcting the template so that it follows established
interface patterns and coding guidelines:
- Form contents in a fieldset
- Submit button in a fieldset with class "action" and
with a "Cancel" link.
- Errors displayed in a <div class="dialog alert">
(no custom error classes necessary).
- Valid markup.
- No JavaScript errors (to that end, the patch removes a
call to a non-existent function, show_transport_cost_matrix)
http://bugs.koha-community.org/show_bug.cgi?id=8936
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
still works as expected and is much more visually appealing.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Frédéric Demians [Wed, 3 Oct 2012 15:55:50 +0000 (17:55 +0200)]
Bug 8870 UNIMARC authorities search doesn't display information properly
- Note field (3xx) are not displayed on search result page. We get
'HASH()' text.
- Parallel/Other forms (7xx) are not displayed, with language name in front of
heading, both on result and detail page.
- Note are not displayed.
- On result page, seealso form are displayed, but end with a superfluous '--'
- Style the result page, with condensed block, and space between them.
- Done both on OPAC/staff
To be applied on 3.8.x after bug 8523.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Sat, 13 Oct 2012 11:33:31 +0000 (07:33 -0400)]
Bug 8934: Fix transport cost matrix help language
The transport cost matrix has a typo (arbitrarymax) and the help
text could be worded better. This patch makes those changes.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Mon, 15 Oct 2012 17:20:31 +0000 (13:20 -0400)]
Bug 8923 [Revised] Add ids to repeated pagination menus to allow for CSS customization
This patch adds ids to each pagination menu on the OPAC search
results page so that they can be customized via CSS or JavaScript.
To test, modify OpacUserCSS to hide ids "top-pages" and "bottom-pages"
and confirm that they are hidden.
Also fixed is an unescaped ampersand introduced by Bug 8209.
Revision removes debugging changes to an unrelated file.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Sat, 13 Oct 2012 11:11:10 +0000 (07:11 -0400)]
Bug 8933: Update transport cost matrix styles
The transport cost matrix is capitlized wrong (based on our
rules). This patch fixes capitalization errors and adds the
matrix to the admin menu where it was missing before.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Mon, 22 Oct 2012 15:30:41 +0000 (17:30 +0200)]
Bug 8916 follow-up adding Mathieu Saby to contributors list
Also adding 3.8.6 release
Mathieu Saby [Sat, 13 Oct 2012 08:36:37 +0000 (10:36 +0200)]
Bug 8916: Hide Curriculum index in advanced search if marcflavor = unimarc
This patch hides curriculum option value in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc and koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt if marcflavor = UNIMARC
To test
- set marcflavour to UNIMARC, this option should be hidden in the index list in opac and staff interface advanced search
- set marcflavour to MARC21, this option should be visible, as before
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Wed, 10 Oct 2012 18:33:04 +0000 (14:33 -0400)]
Bug 8898 - Remove unused mainmenu include and related styles in the staff client
This patch removes the mainmenu and additem-menu includes and #navigation
references in staff-global.css which were used by those includes.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jonathan Druart [Wed, 19 Sep 2012 13:05:03 +0000 (15:05 +0200)]
Babeltheque: Remove the unused tab on the opac detail page
http://bugs.koha-community.org/show_bug.cgi?id=8792
Signed-off-by: Marc Veron <veron@veron.ch>
Babeltheque tab is removed as expected
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Mon, 22 Oct 2012 15:07:37 +0000 (17:07 +0200)]
Bug 7483 follow-up replacing tabs by 4 spaces in both templates
Adrien Saurat [Tue, 18 Sep 2012 12:51:28 +0000 (14:51 +0200)]
Bug 7483: fixes on breadcrumbs in Authority administration
Better breadcrumbs for the following pages:
- auth_tag_structure.pl
- auth_subfields_structure.pl
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Mon, 22 Oct 2012 13:00:25 +0000 (15:00 +0200)]
Bug 8724 follow-up DBRev number
Tomas Cohen Arazi [Tue, 4 Sep 2012 18:02:51 +0000 (15:02 -0300)]
Bug 8724 - Upgrade from NoZebra installs is broken
Properly set the relevant NoZebra and QueryRemoveStopwords sysprefs to 0 to fix issues on upgrades.
Also removes the sysprefs from preferences/searching.pref
Regards
To+
Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Frédéric Demians [Wed, 11 Apr 2012 15:36:40 +0000 (17:36 +0200)]
Bug 3087 Fix Z39.50 server to return the correct record syntax
Modify Makefile.PL and Zebra configuration files in order to parametrized
biblio record type returned by Zebra Z39.50 server.
How to test:
- Test with a MARC21 and a UNIMARC DB
- Do a new installation
- Search from OPAC
- Search from a Z39.50 client like yaz-client: syntax = MARC21/UNIMARC must be
choosed
- It was working for MARC21: it continues to work
- It wasn't working for UNIMARC: it works now, both in OPAC and from a Z39.50
client
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Works fine for MARC21. Frederic looked at UNIMARC. Magnus looked at NORMARC.
GRS1 works okay for me. I still have issues with DOM, but they are not directly related to changes in this patch.
A followup is still needed for packaging (debian/templates).
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Fri, 19 Oct 2012 16:03:36 +0000 (18:03 +0200)]
Merge remote-tracking branch 'origin/new/bug_8525'
Nicole C. Engard [Thu, 27 Sep 2012 19:05:18 +0000 (15:05 -0400)]
Follow up: Bug 8525: Update preference description
The feature in bug 8525 added highlighting to the detail
pages in the opac. This patch updates the preference to
note this change.
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Fri, 19 Oct 2012 16:03:02 +0000 (18:03 +0200)]
Merge remote-tracking branch 'origin/new/bug_7986'
Nicole C. Engard [Sat, 13 Oct 2012 06:48:01 +0000 (02:48 -0400)]
Bug 7986 Follow Up: Fix ExportRemoveFields
This preference was in the code as a choice but should be a list
of fields to exclude. This patch makes that change and updates
the description to fit more with the standard set by other
preferences.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 12 Oct 2012 20:55:54 +0000 (16:55 -0400)]
Bug 7986 Follow Up: Update ExportWithCsvProfile
The ExportWithCsvProfile preference was on its own file
(tools.pref) when in reality it belonged on the circulation
tab. This patch removes the tools.pref file and moves the
ExportWithCsvProfile preference and updates the text
around it to make it clearer.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Mirko Tietgen [Thu, 4 Oct 2012 11:26:26 +0000 (13:26 +0200)]
Bug 4177 opaccloud missing from the system preferences interface
There is no option to toggle the (existing) syspref OpacCloud. This patch adds one.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Inserted tags manually, enabled system preference, tag subject cloud displays nicely.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mark Tompsett [Tue, 2 Oct 2012 13:07:18 +0000 (21:07 +0800)]
Bug 8861 - Undefined variables in batchMod.pl trigger error logs
Initialized $op, and changed lines like "$op => 1" and
"$error => 1" into separate, conditional template param calls.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Frédéric Demians [Fri, 5 Oct 2012 08:45:18 +0000 (10:45 +0200)]
Bug 1963 Problem with deleted biblio in a virtual shelf
This bug reappear in HEAD/3.8. When trying to display a virtual shelf
(list) containing a deleted biblio, this error message is displayed:
Software error:
Can't call method "field" on an undefined value at ....C4/Koha.pm line
1231.
This fix modify SQL query retrieving biblios, just skipping records from
virtual shelf table with no linked record in biblio table: LEFT JOIN
replace with JOIN.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Wed, 17 Oct 2012 16:04:30 +0000 (18:04 +0200)]
Merge remote-tracking branch 'origin/new/bug_4118'
Nicole C. Engard [Fri, 12 Oct 2012 00:45:31 +0000 (20:45 -0400)]
Bug 4118: Follow up: Add ccode to kohastructure for stats
CCode was added to the statistics table in this bug, but
was not added to kohastructure.sql. This patch adds it
with comment to the kohastructure.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Wed, 17 Oct 2012 16:01:06 +0000 (18:01 +0200)]
Merge remote-tracking branch 'origin/new/bug_5356'
Jonathan Druart [Tue, 16 Oct 2012 07:31:08 +0000 (09:31 +0200)]
Bug 5356: Followup Change font in the layout3pages pdf
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Mon, 15 Oct 2012 07:07:50 +0000 (09:07 +0200)]
Bug 3652: [SIGNED-OFF] XSS fixes - follow up
Fixes a typo in the html filter that causes a problem when using the
paging in the OPAC result lists.
(forgot to commit my change when testing the original XSS patches)
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I triggered the error with this query string:
/cgi-bin/koha/opac-search.pl?idx=kw&q=o'reilly&offset=40&sort_by=author_az
After applying the patch the error is gone.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Wed, 17 Oct 2012 15:31:09 +0000 (17:31 +0200)]
Merge remote-tracking branch 'origin/new/bug_8585'
Nicole C. Engard [Fri, 12 Oct 2012 01:23:48 +0000 (21:23 -0400)]
Follow up to Bug 8585: add missing word to preference
The preference added in this bug is missing the word
'day(s)'. This patch adds it in.
http://bugs.koha-community.org/show_bug.cgi?id=4118
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Tue, 16 Oct 2012 16:18:13 +0000 (18:18 +0200)]
Bug 7143 follow-up replace tabs by 4 spaces
Chris Cormack [Sun, 14 Oct 2012 19:52:27 +0000 (08:52 +1300)]
Bug 7143 : New committer to history
Chris Cormack [Tue, 9 Oct 2012 21:13:48 +0000 (10:13 +1300)]
Bug 7143: Adding new developers to the history file
Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Paul Poulain [Tue, 16 Oct 2012 16:13:51 +0000 (18:13 +0200)]
Merge remote-tracking branch 'origin/new/bug_7751'
Nicole C. Engard [Thu, 11 Oct 2012 23:52:21 +0000 (19:52 -0400)]
:x
The preference used to read 'loan period by' but it's
actually reducing the checkout period 'to' the number
of days entered in the preference. This patch changes
'by' to 'to'.
Signed-off-by: Marc Veron <veron@veron.ch>
Tiny patch, text change only, text apears as expected.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>