Owen Leonard [Thu, 9 Sep 2010 16:07:44 +0000 (12:07 -0400)]
Fix for Bug 5075 - Terms not highlighted w/ xslt on
- XSLT didn't contain the class markup which acts as a hook
for the JavaScript highlighting system.
- Standard results page also contained a typo which
prevented data other than title and author from
being highlighted
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
b558c0db5ad9125a947454b5ba8892f996553ab4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Wed, 6 Oct 2010 16:13:02 +0000 (12:13 -0400)]
Fix for Bug 5254 - no need to scroll left to right on acq z search
- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
line breaks, improving table width and horizontal scrolling.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
f987d35a2241a6178406a3d92ccbf9277087f2d1)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Tue, 21 Sep 2010 12:10:34 +0000 (08:10 -0400)]
bug 5235 : circ receipt should include name
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
ace0ce3f8da9e353f1e06eac0c26ead67b765eed)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Fri, 22 Oct 2010 13:08:57 +0000 (14:08 +0100)]
Bug 5315: Remove references to obsolete variable nbstatements
Trying to see the wood from the trees
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
9e5366734b744de2035f0668e7db94e399daacad)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Tue, 26 Oct 2010 16:14:46 +0000 (12:14 -0400)]
bug 5309: tweak so that background progress doesn't exit immediately
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
48ab366b57a1ba59c1bf706308944b388666769d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Tue, 26 Oct 2010 15:28:21 +0000 (11:28 -0400)]
fix use of outdated boilerplate
* New code *must* have an accurate copyright statement;
it isn't 2000-2002 any more.
* Enable warnings in new code, don't do
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
0187e38ad7826172859467991d6766ca37e31d2c)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Srdjan Jankovic [Fri, 15 Oct 2010 00:53:11 +0000 (13:53 +1300)]
bug 5309: Adjust progres bar
Also added some test facilities
wr73785
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
e2e1dfd86e2f4a6ef63829551c58c728633fa893)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Srdjan Jankovic [Tue, 12 Oct 2010 17:03:26 +0000 (13:03 -0400)]
bug5027: skip unticked checkboxes when submitting in the background.
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
3a4f36b002a5651716efe68242f6711fad936448)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Thu, 11 Nov 2010 21:38:42 +0000 (10:38 +1300)]
Bug 5385 - Fixing an error that crept in with the POD cleanup
(cherry picked from commit
9c6db56a3f807c819be5e724f423a212fa4b362c)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Thu, 11 Nov 2010 14:43:47 +0000 (09:43 -0500)]
bug 4305: add a couple test cases for _isbn_cleanup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
bcedff69bcef3a887575c34f53e2c26153da61c1)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Thu, 11 Nov 2010 14:02:13 +0000 (09:02 -0500)]
Bug 4305 Improve code flow
Use the ISBN Object's method to format the string
rather than add extra code to do it
Clean up the code flow for clarity
Benchmarking shows its a bit faster too
Don't add to the number of Test::Perl::Critic warnings
for no benefit
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c95b5153e0ed5585c8331273a42fc29d75f9f10f)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Andrew Elwell [Thu, 11 Nov 2010 13:18:47 +0000 (08:18 -0500)]
Bug 5385: POD Cleanups (part 2)
More podchecker cleanups to eliminate warnings / errors
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
efa66f1f556dcff71779c9b89148f2bb99149e51)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Andrew Elwell [Thu, 11 Nov 2010 13:18:46 +0000 (08:18 -0500)]
Bug 5385: POD Cleanups (part 1)
working through the master branch to eliminate all
podchecker warnings/errors
Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
9fa574f6097b8fc1eb9efc5321141ec0d23d3268)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Thu, 11 Nov 2010 12:39:32 +0000 (07:39 -0500)]
Bug 5112: Organisation does not show links to professionals
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
63fdd8768acc42cf1b02a655506d6ea97c11fe14)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Thu, 11 Nov 2010 17:41:25 +0000 (06:41 +1300)]
Merge remote branch 'kc/new/bug_5386' into kcmaster
(cherry picked from commit
af1d8290317d7602616d7269fd40109ccf8a3f8d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Thu, 11 Nov 2010 08:06:00 +0000 (09:06 +0100)]
Test modules compile
Script to test modules compile, when used with a pre-commit hook this
can test before a commit
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
7ecf2c2dc42d443d819ed04e3a11065f2802d51a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Thu, 11 Nov 2010 08:33:48 +0000 (21:33 +1300)]
Merge remote branch 'kc/new/bug_5105' into kcmaster
(cherry picked from commit
235cf872a5c40a0baae554bdb28ec98c4520c528)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Wed, 10 Nov 2010 22:33:10 +0000 (11:33 +1300)]
Merge remote branch 'kc/master' into new/bug_5105
Conflict fixed
Conflicts:
opac/opac-detail.pl
(cherry picked from commit
dcb86689f73089ceaa789a92c34e78200d05af61)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Frédéric Demians [Wed, 10 Nov 2010 22:00:54 +0000 (23:00 +0100)]
Fix bug on opac-detail.pl with switch statement
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
5e1b8167c24e0322d94bfc919556d927d875cf97)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Wed, 10 Nov 2010 13:45:33 +0000 (08:45 -0500)]
Bug 5003: Can not search for organisation by name
Rebased to current HEAD, small error fixed.
Should also apply to 3.2
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
863830f3f91110bdbd930755139f844870234ccc)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Wed, 10 Nov 2010 05:09:37 +0000 (00:09 -0500)]
bug 5380: remove copy-and-paste from authorities/detail.pl
MARC editor code not needed here.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
2c794d1af77879134ab0e84198d3827625384e70)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Wed, 10 Nov 2010 04:48:33 +0000 (23:48 -0500)]
bug 5372: identify empty field in authority record correctly
This is the sibling to the fix for this bug for the bib
editor. However, note that this change won't have a
direct effect yet, as currently you can't specify a
default value for a field or subfield in the authority
MARC frameworks. See bug 4887.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
daabd936d6cb13bd680652da5a32fd1ce354684a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Mon, 8 Nov 2010 23:01:02 +0000 (12:01 +1300)]
Ukranian and Russian syspref language updates
(cherry picked from commit
1aef81c354eb17c2cf2d557cac78d4e37c30a046)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Mon, 8 Nov 2010 23:00:40 +0000 (12:00 +1300)]
Russian and Ukranian opac language updates
(cherry picked from commit
a3226d5ce618bfe5ced3723e8c87013b5ba7b26e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Mon, 8 Nov 2010 22:59:41 +0000 (11:59 +1300)]
Staff interface .po file updates
(cherry picked from commit
6d22b87543272f6f0c1d02cfa42a031e0dc520ba)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Mon, 8 Nov 2010 20:52:32 +0000 (21:52 +0100)]
Bug 5370: Fix all references to koha.org
Thx to Brooke for helping with the wiki.
This is the last patch.
We will have to change some more links, after translate.koha.org was moved.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d829dc1c6ab8fb20426c0cd377456d02fdac6598)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Mon, 8 Nov 2010 06:42:41 +0000 (19:42 +1300)]
Merge branch 'trivial_bugs' of git://git.koha-community.org/wip/koha-fbc into kcmaster
(cherry picked from commit
ce54fe0323a8ab523ae8992ff269bf82fea2dd10)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Marcel de Rooy [Thu, 4 Nov 2010 11:38:45 +0000 (11:38 +0000)]
Bug 4515 (Few very small errors in opac-search.pl) RESENT fixing whitespace warning
Loop on results should stop before $i==@servers. Adding fix for warnings on undefined values in comparison for lines 485, 488 and 510.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
a3ceef434ed17a1a1ad57c70cfbbc8f1fdf5d736)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Frédéric Demians [Wed, 3 Nov 2010 17:38:35 +0000 (18:38 +0100)]
Bug 4472 Apply it to MARC21
For French installation of Koha using MARC21, the same issues as UNIMARC
affects handling of by translation scripts.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c616cb5081b4e96a586fae1e5601d5d495c8794d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Thu, 28 Oct 2010 14:24:59 +0000 (10:24 -0400)]
Fix for Bug 5214 - undefined itype images cause broken image icon in request.pl
Also fixes the same bug on the Itemtypes administration page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
fbbab73492a5448884d3f258a0e9401a55021da6)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Thu, 28 Oct 2010 13:23:12 +0000 (09:23 -0400)]
bug 5236: remove hidemytags from CSS as well
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c49600aaa79844aff8a845e915cfd784484147e1)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Thu, 28 Oct 2010 13:05:21 +0000 (09:05 -0400)]
bug 5219: tidy cleanup_database.pl
Includes a bit of cleanup of the enhancement patch
for bug 5074 - adding comments about old and new
behavior isn't necessary for such small changes.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
072896d66be675f6ec32b46267fb57b649b4eb03)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Frédéric Demians [Sun, 7 Nov 2010 13:33:36 +0000 (14:33 +0100)]
Bug 5372 (v2) Existing value can be replace by default value
The way an existing value was tested was wrong. 0 is a valid value but a
false value for Perl.
=> replace privious proposal.
[3.2] Should also apply.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
07cfc5d69c83795a8ab1ad6168251f9aab9f87df)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Sun, 7 Nov 2010 10:59:00 +0000 (11:59 +0100)]
Bug 5370: Fix all the references to koha.org
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
6df634855cc62a5f31b419ecd1946500bf576065)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Sun, 7 Nov 2010 07:42:49 +0000 (08:42 +0100)]
Bug 5370: Fix all references to koha.org
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
9f688ad92b04377bcb37b04448292e43509df80b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Sun, 7 Nov 2010 06:10:06 +0000 (07:10 +0100)]
Bug 5370: Fix references to koha.org and other old websites
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
35cf30ef15943240e823b7cdfc0d233727a4011d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger [Sat, 6 Nov 2010 06:56:01 +0000 (01:56 -0500)]
Adding 3.2 Release Maintainer to Release Team List
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
8dded0c2692e67473cad71384dd26971d27c6f22)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Frédéric Demians [Fri, 5 Nov 2010 11:23:08 +0000 (12:23 +0100)]
Bug 5368 Browse Shelf link appears when no itemcallnumber
Suppress Browse Shelf link on OPAC detail page when there is no item
call number.
[3.2] Should also apply on 3.2
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
e40b180d1de686d90caf7fd25d514b445280acdc)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nahuel ANGELINETTI [Fri, 5 Nov 2010 13:13:21 +0000 (09:13 -0400)]
(MT 2985) simplify CanBookBeReserved
The function was too complex for so simple stuff, not we check if one of all items of the record can be issued.
[Note by Galen Charlton: not only does this patch simplify the routine,
it also makes it behave correctly.]
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
363c1ca9f9392403b98f3a3604c1345320f4a8c4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger [Fri, 5 Nov 2010 00:27:49 +0000 (20:27 -0400)]
Updating Version Number to 3.02.00.006
Galen Charlton [Tue, 2 Nov 2010 02:09:10 +0000 (22:09 -0400)]
bug 5149: follow-up - remove extraneous character in link
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
b96617dea8fcd35d4f4f2f19860a2b7f14489e97)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Tue, 2 Nov 2010 02:09:09 +0000 (22:09 -0400)]
bug 5149 fix broken link to noItemTypeImages preference
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
36df1f6cdf231c72527d79bb08efeca01dd0e902)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Sat, 30 Oct 2010 20:29:24 +0000 (16:29 -0400)]
bug 5110 move NewItemsDefaultLocation to cataloging tab
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
140fde57def7d146a633769ffdbb405222044432)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 30 Oct 2010 20:25:19 +0000 (16:25 -0400)]
Fix for Bug 4963, sys prefs need date hints and/or picker
This patch adds the standard date format hint used elsewhere
in the interface.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
51405bcce471dd38b59425d1b3b6609e1d595572)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
ByWater Solutions [Sat, 30 Oct 2010 13:50:29 +0000 (09:50 -0400)]
Bug 4254 - adding new patron advanced notice doesn't save
This was due to poorly constructed SQL which returned duplicate values for
certain fields. This patch corrects that SQL.
NOTE: There is also a formatting problem with the message prefs display table
when it is displayed in moremember.pl. This is due to there being no logic to
tell the table in that context to display checkboxes as appropriate. This patch
does not fix that. Bug 5328 has been opened for this problem.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
321eed98334bac3564b0b11abf3fb6fe34074f0d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 30 Oct 2010 05:52:50 +0000 (01:52 -0400)]
Fix for Bug 5082 - Not translatable name of default framework 'Default' in MARCdetail.tmpl
This patch also fixes an unreported bug where switching from any
other framework to 'Default' would bring up no MARC data.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
b0e29e5595f5d92cbd9a66ab306652a01d6382ed)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 30 Oct 2010 05:52:49 +0000 (01:52 -0400)]
Fix for Bug 4980 - Acq: pull down 'Restrict access to:' for funds not translatable
Applied Owen's patch to current head, updated de-DE translation. The pull down values are now translated.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
bd28366523c0778f496a310395f4481348e30ccf)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 30 Oct 2010 05:52:48 +0000 (01:52 -0400)]
Fix for Bug 5142, Untranslatable strings in tag review template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c4de64629d7f0853f3919cb5d09f98b2c0c60c03)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 30 Oct 2010 05:52:47 +0000 (01:52 -0400)]
Fix for Bug 5056, Untranslatable strings in members.js
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
100099d429c3b092d9c3a9a7c65427499092d4b6)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 30 Oct 2010 05:36:57 +0000 (01:36 -0400)]
Fix for Bug 5136, Replace SQL with call to GetAuthorisedValues
An embedded query in circulation.pl for BOR_NOTES authorized
values can be replaced with a call to GetAuthorisedValues
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
82d2cf464be0439b9d52de1d951baa856a4e60a4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 30 Oct 2010 05:33:42 +0000 (01:33 -0400)]
Fix for Bug 5135 - Authorized value input maxlength should match table column
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
81b3ca97eab7235dbff94d30e09e6d4325f21604)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Sat, 30 Oct 2010 04:48:19 +0000 (00:48 -0400)]
bug 5171 change 'edit items' to read 'edit item' when next to 1 item
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
3d66c2153b8be4192da055782f23ad08f2f9845f)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Sat, 30 Oct 2010 04:48:18 +0000 (00:48 -0400)]
bug 5168 change link text from holdings to items
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c3aa3d96819c32439ffa6f727367b679a1a24813)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Jared CAMINS-ESAKOV [Sat, 30 Oct 2010 03:49:15 +0000 (23:49 -0400)]
Fix bug 3811; Index language as word
An incorrect definition in record.abs was resulting in searches on languages returning incorrect results. By changing the indexing mode from numeric to word, this patch fixes that problem.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
68dc783c7e3b4f2721ef5efccc98934e8700f8d2)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 30 Oct 2010 03:49:14 +0000 (23:49 -0400)]
bug 5311: correction to database update
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
0d84902eca94fca399040e3c0088ee74f69cf68c)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Jared Camins-Esakov [Sat, 30 Oct 2010 03:49:13 +0000 (23:49 -0400)]
Update language mappings to fix Bug 5311
This patch updates the language_rfc4646_to_iso639 mapping table with the
correct mappings for several languages that were not mapped correctly to
the codes used in MARC, including Finnish (which was not mapped at all),
and Armenian (which was mapped to an obsolete code). This patch also
changes English and French to use the proper three-letter codes, which
will eliminate false positives when, for example, limiting by French
brings up results in Afrikaans.
This patch adds the changes to the updatedatabase.pl script, and removes
the incorrectly specified DBversion in the previous patch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Sat, 30 Oct 2010 02:35:44 +0000 (22:35 -0400)]
bug 5190: improve linking to MARC field documentation
* zero-pad tag numbers as needed
* handle special case for linking to UNIMARC 0XX vs. 1-8XX
* add a wrapper function
* add comment about the poor linkability of IFLA's UNIMARC documentation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
141ec0b9bcfa0bcf34d82cbb7ddc722a078e216e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 30 Oct 2010 02:35:43 +0000 (22:35 -0400)]
bug 5190: link to MARC21/UNIMARC online doc in the bib editor
Patch from Tomás Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
29432ee42cf25d79f28054eaea85f46edc688d1b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Sat, 30 Oct 2010 00:28:49 +0000 (20:28 -0400)]
bug 5326 fix link to old prefs editor on patron attributes
on the patron attributes page if you have ExtendedPatronAttributes
turned off the error points you to the old sys prefs editor - this
patch fixes that
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
45a6cca1a17093291dc6ab0883578b79bff0b6e7)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Sat, 30 Oct 2010 00:28:48 +0000 (20:28 -0400)]
bug 5326 fix extended patron attribute error
the error message if you have ExtendedPatronAttributes turned
off linked to the old sys prefs editor, link has been updated.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
83f03fb9d3bbbf5101a7209f934e91b7876fc2dc)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 29 Oct 2010 12:37:41 +0000 (08:37 -0400)]
Fix for Bug 5137, Remove obsolete code counting issues by item type in circ
The removed section of code contained a "my $dbh = C4::Context->dbh"
which was required for the query of BOR_NOTES. That line has been
moved accordingly.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
b2bda465d770c078b14eef8493c0554143d90cc4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 29 Oct 2010 12:29:02 +0000 (08:29 -0400)]
Fix for Bug 5008 - "Remove" link missing when Cart in expanded view
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
0d41ba7300a228217ac32a1169bf24b0e79aff98)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Fri, 29 Oct 2010 12:23:41 +0000 (08:23 -0400)]
bug 4986 move serials prefs from cataloging tab to serials tab
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d1593acec727c6aa06fc0d3159c62b454d225518)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 29 Oct 2010 12:15:37 +0000 (08:15 -0400)]
Fix for Bug 5114 - Can't edit basket in Internet Explorer
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
0bb33cd7ceee5cdb8bf2a5bcde552257f2279cfb)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Fri, 29 Oct 2010 12:10:44 +0000 (08:10 -0400)]
bug 5019 remove link to funds
This patch renames the link to budgets to say 'budgets & funds'
and removes the links to funds (which went no where).
This patch also adds the acq menu to the budget pages.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d5eb56dd528d29aace607f2994ff7fc2c132db57)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Frédéric Demians [Fri, 29 Oct 2010 11:47:33 +0000 (07:47 -0400)]
Bug 5177 Selecting default sort result by syspref
Syspref .pref file was defining a code for descending order which wasn't
expected by .tmpl files... 'desc' instead of 'dsc'.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
aa7df17f7c63ae51f8d2088b795af6d92b85e6a0)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Wed, 3 Nov 2010 20:31:03 +0000 (16:31 -0400)]
Bug 5363 - Removing unused module (C4::Cache::FastMemcached)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger [Wed, 3 Nov 2010 18:42:50 +0000 (14:42 -0400)]
Correcting Version Number for 3.2.x branch
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Wed, 3 Nov 2010 17:49:00 +0000 (13:49 -0400)]
bug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x
Note that OPACXSLTResultsDisplay and OPACXSLTDetailsDisplay
are boolean parameters in 3.2.x, not string parameters.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Wed, 3 Nov 2010 17:28:24 +0000 (06:28 +1300)]
Updating version number and fixing the xxx in updatedatabase ... my bad
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Mon, 1 Nov 2010 12:23:35 +0000 (08:23 -0400)]
bug 5308: add foreign key constraints as well
Follows up on previous patch to require that routing
list entries be linked to subscriptions and patrons.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Srdjan Jankovic [Fri, 15 Oct 2010 00:58:00 +0000 (13:58 +1300)]
bug 5308: subscriptionroutinglist more strict
borrowernumber and subscriptionid NOT NULL, UNIQUE(subscriptionid, borrowernumber)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Mon, 25 Oct 2010 14:16:19 +0000 (10:16 -0400)]
bug 2567: let 008/15-17 and 008/24-27 be set
Fixes bug where the MARC21 008 plugin was falsely
claiming that it set the illustration and nature of
contents positions by deriving it from other fields
in the bib records.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Wed, 27 Oct 2010 12:24:03 +0000 (08:24 -0400)]
bug 5318: fix value of r4 rank weight
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 30 Oct 2010 04:40:15 +0000 (00:40 -0400)]
bug 4991: follow-up tweaks
* make some strings translatable
* display library name instead of code in add/edit
holiday panel
* minor textual fixes to hints
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Mon, 12 Jul 2010 20:41:28 +0000 (16:41 -0400)]
Fix for Bug 4991, Overhaul of Calendar interface
- Put hints, key, and existing holidays into right column
- Style entry form for added clarity and consistency with other
forms in Koha
- Change the way dynamically displayed hints are shown to better
match existing static hints in Koha's interface
- Add branch name (instead of branch code) for clarity
- Add the ability to add and edit holiday titles (previously
only description could be edited).
- Add links to the list of existing single-day holidays and
exceptions which opens the calendar to that month/year
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 30 Oct 2010 05:13:23 +0000 (01:13 -0400)]
tweak wording of merge target
Since the merge functionality is for merging biblio
records, not items, made the language more precise.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Sat, 30 Oct 2010 05:13:22 +0000 (01:13 -0400)]
add missing help file for merging records
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Wed, 27 Oct 2010 12:24:04 +0000 (08:24 -0400)]
bug 5301: improve escaping of XML characters in bib output
<, >, ', or " in an item call number will no longer make
the bib displays break when using XSLT mode.
Added a new routine to C4::Koha, xml_escape(), to implement
converting &, <, >, ', and " to their corresponding
entities.
Patch loosely based on work done by Daniel Latrémolière <daniel.latremoliere@bulac.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Thu, 28 Oct 2010 12:09:47 +0000 (08:09 -0400)]
bug 5243: avoid crash when saving authority records on certain setups
This does not seem to occur on all platforms - C4::Search
exports SimpleSearch() by default - but adding the 'C4::Search::'
qualifier certainly doesn't hurt things.
Patch by Fridolyn Somers <fridolyn.somers@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Fri, 29 Oct 2010 11:40:37 +0000 (07:40 -0400)]
bug 5162: follow-up patch to not clear hidden input setting attribute type
Otherwise, can't saved new attributes set from a cloned
input or select control.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 29 Oct 2010 11:40:36 +0000 (07:40 -0400)]
Fix for Bug 5162, patron attributes 'new' link should create blank value
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Marcel de Rooy [Thu, 28 Oct 2010 13:05:20 +0000 (09:05 -0400)]
Enhancement 5074 (Adding possibility to cleanup_database.pl to purge only older sessions) [UPDATED for master]
Currently, the misc/cronjobs script cleanup_database truncates the session table (deleting all records, including active sessions).
With an additional parameter sessdays, this behavior could be changed or (perhaps better) extended. If the parameter sessdays is passed along with a number of days, the script only deletes older session records. This is accomplished by examining the values of lasttime, atime or ctime in the record.
So, calling the script like:
./cleanup_database.pl -v -sessions -sessdays 7
will only delete sessions records older than 7 days. The "old style" call
./cleanup_database.pl -v -sessions
still works too and truncates the table as before.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Thu, 28 Oct 2010 15:53:51 +0000 (11:53 -0400)]
bug 5050 move language prefs to I18N/L10N tab
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Thu, 28 Oct 2010 15:42:12 +0000 (11:42 -0400)]
bug 5151 removed bolded terms in breadcrumbs
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Liz Rea [Thu, 28 Oct 2010 14:00:03 +0000 (10:00 -0400)]
bug 5237: Testing renewals on patron barcodes with + signs at the end
According to notes in bug, patch was originally by Chris Cormack.
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Thu, 28 Oct 2010 13:52:47 +0000 (09:52 -0400)]
bug 5163 change title of holds to pull page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Thu, 28 Oct 2010 13:45:04 +0000 (09:45 -0400)]
bug 5258 change 'order' to 'order line' on receive page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Thu, 28 Oct 2010 13:39:09 +0000 (09:39 -0400)]
Bug 5224 Remove the adjective Shopping from basket
New orders breadcrumbs were using the inappropriate term
Shopping basket whereas basket is used elsewhere
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Thu, 28 Oct 2010 13:35:15 +0000 (09:35 -0400)]
BUG 5239 add space between number and words in acq search
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Thu, 28 Oct 2010 13:29:23 +0000 (09:29 -0400)]
Fix for Bug 5221 - Preselect tab containing itemtype/authval image in use
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Thu, 28 Oct 2010 13:23:11 +0000 (09:23 -0400)]
Fix for Bug 5236 - "hide my tags" link does nothing
Removing the link. The suggested functionality doesn't
seem useful.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Wed, 27 Oct 2010 11:48:22 +0000 (07:48 -0400)]
remove unused template include
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Tue, 26 Oct 2010 13:28:50 +0000 (09:28 -0400)]
Fix for Bug 5223, 'related subjects' should read 'subjects'
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Tue, 26 Oct 2010 13:00:51 +0000 (09:00 -0400)]
Fix for Bug 4261 - keyword mapping should show which framework the map is for
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Mon, 1 Nov 2010 02:35:12 +0000 (22:35 -0400)]
history updates - recent releases
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sun, 31 Oct 2010 22:25:47 +0000 (18:25 -0400)]
bug 5327: follow-up to fix SIP tests
* removed t/SIP_SIPServer.t - despite the file name,
C4/SIP/SIPserver.pm is not actually a module and
cannot be 'used' or 'required'
* set module search path so that t/SIP_ILS.t and
t/SIP_Sip.t will pass
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Sun, 31 Oct 2010 22:25:46 +0000 (18:25 -0400)]
Bug 5327: More basic unit tests for C4 modules
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Sun, 31 Oct 2010 22:25:21 +0000 (18:25 -0400)]
History updates
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sun, 31 Oct 2010 04:46:39 +0000 (00:46 -0400)]
remove extraneous semicolon
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>