Owen Leonard [Thu, 25 Feb 2010 14:43:15 +0000 (09:43 -0500)]
Use CSS3 box-shadow property for Cart tooltip
The OPAC Cart tooltip ("Your cart is empty," "1 item(s) added to your
Cart") currently uses a jQuery plugin to generate a drop shadow.
This works cross-browser, but has a high failure rate with regard
to hiding the shadow consistently, resulting in an orphan shadow
after the tooltip has been hidden. I propose to instead use the
new CSS3 property "box-shadow" (-moz-box-shadow and -webkit-box-
shadow for FireFox and Safari/Chrome). Currently Internet Explorer
does not support this property. I think this is an
acceptable tradeoff for more stable functionality.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 4 May 2010 15:13:22 +0000 (11:13 -0400)]
release notes updates suggested by Nicole Engard
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 4 May 2010 13:29:08 +0000 (09:29 -0400)]
start of release notes for 3.2
NOTE: this is not exhaustive; please send me additions for
features you have written.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 4 May 2010 12:36:21 +0000 (08:36 -0400)]
fix various errors reported by xt/author/translatable-templates.t
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 4 May 2010 11:57:51 +0000 (07:57 -0400)]
copy new NPL icons from OPAC to staff
Fixes problem found by xt/author/icondirectories.t
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 4 May 2010 11:50:34 +0000 (07:50 -0400)]
fix template structure error found by xt/author/valid-templates.t
Also fixed XHTML validity error
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Sat, 1 May 2010 20:38:48 +0000 (16:38 -0400)]
bug 4442 rename batch edit tools
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Mon, 3 May 2010 16:33:37 +0000 (17:33 +0100)]
Bug 4151 - Add DateTime to Perl dependencies
Used in Sip.pm
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Mon, 3 May 2010 13:58:20 +0000 (09:58 -0400)]
Fix for Bug 4436, reserve should say 'hold'
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Tue, 13 Oct 2009 00:29:53 +0000 (20:29 -0400)]
Bug 2889: Added zebra striping to the table in dictionary.tmpl.
Also fixed a couple of minor XHTML errors.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Fri, 26 Mar 2010 16:41:28 +0000 (16:41 +0000)]
Bug 2889 Remove toggle in boraccount display
Also remove the reverse column if no contents to be displayed
( otherwise looks like a markup error )
Rationalize the main loop now toggle not required
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 3 May 2010 13:18:58 +0000 (09:18 -0400)]
followup - update SCO to recognize ITEMNOTSAMEBRANCH
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Michael Hafen [Tue, 30 Mar 2010 20:58:50 +0000 (14:58 -0600)]
on checkout ask for confirmation if borrower from different branch
With IndependantBranches on check that the borrower is from the same branch as
the librarian. If not then ask for confirmation. This check is skipped for
SuperLibrarians.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Ian Walls [Mon, 5 Apr 2010 17:00:02 +0000 (17:00 +0000)]
Fixes bug 4369: Local use does not update datelastseen
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 3 May 2010 11:46:33 +0000 (07:46 -0400)]
Merge branch 'bug4036' of git://git.librarypolice.com/git/koha-galen into to-push
Galen Charlton [Sat, 1 May 2010 16:43:07 +0000 (12:43 -0400)]
bug 4036, 4405: overdue and fine day block improvements
* Adopted wording suggested by Kyle Hall for the
USERBLOCKEDREMAINING and USERBLOCKEDOVERDUE circulation blocks
* Updated IsMemberBlocked so that if a patron has accrued
fine days, that will be tested for first before testing
to see if the patron has current overdue items; this solves
a problem introduced in the patch series for bug 4505 where
accrued fine days would be ignored if (a) the patron has
current overdue items but (b) the library has chosen to
set the OverduesBlockCirc syspref to noblock.
* Now correctly assigns the USERBLOCKEDREMAINING and USERBLOCKEDOVERDUE
blocks; prior to this patch, they had been swapped.
FIXME: IsMemberBlock ought to be split into two functions
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 16:08:17 +0000 (12:08 -0400)]
bug 4429: do not include items due today in overdue count
Use curdate() instead of now() in GetMemberIssuesAndFines.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 15:58:23 +0000 (11:58 -0400)]
bug 4036: do not count item overdue if it is due today
* use curdate() instead of now() to test whether item is overdue
* enhanced POD of IsMemberBlocked
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 18:32:44 +0000 (14:32 -0400)]
bug 4396: remove reerences to bi_notforloan
These were causing the OPAC details place hold button to disappear
in circumstances where a bib-level item type was set to a non-loanable
item type even when item-level_itypes was on.
This change does mean that if item-level_itypes is not turned on,
the hold button will now appear for bibs whose bib-level item type
has its not-for-loan flag set; however, if this is a problem, a
better long-term fix would be to use CanBookBeReserved() instead.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 18:15:42 +0000 (14:15 -0400)]
simplify logic for displaying item status
Flatten the tmpl_if tree for determining the item status
to display and tweaked the order in which statuses are checked to
1. (circ reality) item on loan
2. (circ reality) item in transit
3. (circ reality) item wating at hold shelf
4. (item status that makes circ impossible) item withdrawn
5. (item status that makes circ impossible) item lost
6. (policy that implies no circ but in-house use possible) item not-for-loan per item
7. (policy that implies no circ but in-house use possible) item not-for-loan per item type
8 (item status that *might* affect circ) damaged
8. (fallback) item available
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 18:02:32 +0000 (14:02 -0400)]
bug 4396: clarify return of itemtype-level notforloan flag
* GetItemsInfo now includes a notforloan_per_itemtype key
with the value of the item type's notforloan setting, correctly
set based on the value of the item-level_itypes syspref
* Adjusted OPAC details item status display to use that
notforloan_per_itemtype key
NOTE: one of the assumptions of item-level_itypes is that
you can have either bib-level item types or item-level
item types, but not both in the same database. In particular,
it does not establish a hierarchy where Koha checks the
item-level itemtype first, then the bib-level.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 17:40:20 +0000 (13:40 -0400)]
bug 4396: create new OPAC template include for item status
As part of preparing to work on bug 4396 (item level item types not
working correctly when biblioitem-level item type is not for loan),
moving the item status template logic to a separate include to make
it easier to work with.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Sun, 2 May 2010 21:54:54 +0000 (09:54 +1200)]
Adding another developer to the history
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sun, 2 May 2010 01:25:02 +0000 (21:25 -0400)]
Bug 4432: Fixes XHTML in serials-edit.tmpl.
Replaces a reference to an undefined variable, num, with a defined variable to create unique ids.
Also adds zebra striping to the table.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sun, 2 May 2010 00:25:31 +0000 (20:25 -0400)]
Bug 4200: Fixes adding a member to a routing list after filtering results.
Adds a hidden field for subscriptionid to the filter form.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 1 May 2010 23:37:06 +0000 (19:37 -0400)]
Bug 3883: Fixes blank line in routing list.
The blank line was being caused by the SELECT statement in the getroutinglist fuction of C4::Serials. The LEFT join in the select statement was creating a single row result of NULL. Changed the LEFT join to an INNER join.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 14:48:25 +0000 (10:48 -0400)]
bug 4505 followup - template changes
* fix syntax error
* adjust wording - "patron" instead of "borrower"
* handle case where overdue items should require
confirmation of loan by operator
* fix typo in system preference template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 14:42:39 +0000 (10:42 -0400)]
bug 4505 followup: fixes to database update
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 14:36:39 +0000 (10:36 -0400)]
bug 4405 followup - fix typo
As much as circ staff may want to block circulation to
over-rude patrons, Koha probably shouldn't be trying to make
that determination on its own. :)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Sun, 25 Apr 2010 22:30:55 +0000 (10:30 +1200)]
Bug 4405 - Overdues block check out
[Documentation note by RM:
This patch adds a new system preference, OverduesBlockCirc,
that can take one of three values:
- noblock: checkouts permitted even if patrons
have overdue items (default)
- confirmation: circ operator asked to confirm checkout
- block: checkouts to patrons who have overdue
items are forbidden
]
Squashed commit of the following:
commit
6a1f66e0686a14d8a89abfc3fe5978dabd0b7af7
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date: Mon Apr 26 10:27:39 2010 +1200
Tidy up ready to send patch
commit
4d1398df18dcce4fd888cf17a0e2955fdf6ee1e4
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date: Mon Apr 26 10:26:15 2010 +1200
Bug 4405 - tidy up
commit
3daeb71bc6b690e18dda96aa3c767c2bb0521038
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date: Mon Apr 26 10:02:04 2010 +1200
Bug 4405 - Overdues block checkout
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Fri, 30 Apr 2010 22:19:53 +0000 (00:19 +0200)]
(bug #4319) allow reserves on waiting items
This add a function to check the reserve status, and add a check in IsAvailableForItemLevelRequest() to allow request on items that are waiting
Conflicts solved:
C4/Reserves.pm
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 13:44:29 +0000 (09:44 -0400)]
fix DBrev 132
* renamed index; there was already an index named 'lang' on language_description
* removed reference to ersataz DB rev number
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Fri, 30 Apr 2010 22:19:51 +0000 (00:19 +0200)]
Performance enhancing DBRev:132
Adding an index on language_descriptions table in order to boost searches
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Fri, 30 Apr 2010 22:19:49 +0000 (00:19 +0200)]
MT3228 : trailing space block search
Removing trailing searchs befor operands which block searches
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 1 May 2010 13:16:22 +0000 (09:16 -0400)]
fix description of DB rev 131
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Fri, 30 Apr 2010 22:19:48 +0000 (00:19 +0200)]
Transport_type print missing
This type is quite important for all the print notices
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Fri, 30 Apr 2010 22:19:47 +0000 (00:19 +0200)]
MT3346 : overdue_notices
-csv was not working as advertised.
This feature is now working as it is forecast
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Fri, 30 Apr 2010 22:19:46 +0000 (00:19 +0200)]
MT3438 : faulty subscription-add branch selection
branch selection could lead to two branches selected
this patch removes the faulty line
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Fri, 30 Apr 2010 22:19:45 +0000 (00:19 +0200)]
MT3499 : cataloguing authid not reported
authid would not be correctly updated in bibliorecord.
Biblio record would not receive the correct authid in subfield 9
but some erroneous data
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Fri, 30 Apr 2010 22:19:44 +0000 (00:19 +0200)]
MT3448 : searchauthorities problems
Problems with searching authorities :
The same index was always used
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Fri, 30 Apr 2010 22:19:43 +0000 (00:19 +0200)]
MT3440: Display only borrower's messages in borrower's profile
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Fri, 30 Apr 2010 22:01:13 +0000 (18:01 -0400)]
Bug 4428: fixes minor XHTML errors in shelves.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 30 Apr 2010 19:00:16 +0000 (15:00 -0400)]
Fix for Bug 4409, I18N/L10N tab not highlighted
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 30 Apr 2010 16:48:53 +0000 (12:48 -0400)]
Markup corrections to fix for Bug 4248
- Missing "=" in attribute
- TMPL_IF nested in HTML tag, which breaks translation script
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 30 Apr 2010 13:08:25 +0000 (09:08 -0400)]
bug 4256: fix patron replication when using LDAP with auth_by_bind
Patch compiled from diffs created by Dobrica Pavlinušić <dpavlin@rot13.org> to:
* enable patron replication when using LDAP with auth_by_bind
* not scribble over extended patron attributes
* fix failure logging in to OPAC if patron has no extended attributes
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 30 Apr 2010 13:49:17 +0000 (09:49 -0400)]
bug 1532: ensure that empty hold request expiration is represented as NULL
Fixes bug reported by Colin Campbell where reserves.expiratedate
was defaulting to '0000-00-00' instead of NULL.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 30 Apr 2010 13:44:17 +0000 (09:44 -0400)]
fix typo in DBrev - should be 3.01.00.129
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Ian Walls [Tue, 6 Apr 2010 16:13:59 +0000 (16:13 +0000)]
Bug 4334: Fixes double quotes error on ODUE line of sample_notices in all languages but French. The error was preventing sample_notices, and any foreign key dependent tables, from loading. This blocked enhancement message preference editing.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Tue, 15 Dec 2009 23:21:47 +0000 (12:21 +1300)]
Bug 3785 - Fixing a bug that was stopping holds if no maximum number was set
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Kyle M Hall [Mon, 1 Mar 2010 16:57:29 +0000 (11:57 -0500)]
Bugfix 4123 - CanBookBeRenewed fixed.
In Circulation::CanBookBeRenewed categorycode and itemtype were not being checked for * wildcard
if a specific code was not given.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Wed, 17 Feb 2010 20:57:05 +0000 (21:57 +0100)]
Adds missing hint for upload-type syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Sébastien Hinderer [Thu, 19 Nov 2009 09:38:33 +0000 (10:38 +0100)]
Fix typo admin/in brnaches template.
The branch notes were not displayed because the variable was called
branchnotesl rather than branchnotes
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Mason James [Wed, 3 Mar 2010 00:53:08 +0000 (13:53 +1300)]
Enhancment [3.4] Bug 4288: Hide circular 'Log in to Your Account' link in opac-auth.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Ian Walls [Mon, 29 Mar 2010 12:52:16 +0000 (12:52 +0000)]
Fixes bug 4201: Holds priority listings assigning large numbers
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nahuel ANGELINETTI [Wed, 10 Mar 2010 21:26:37 +0000 (22:26 +0100)]
(bug #3798) fix changing request branch
a variable was wrong in template.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 30 Apr 2010 09:49:19 +0000 (05:49 -0400)]
bug 4333 followup - fix an uninitialized value warning
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Fri, 30 Apr 2010 08:46:01 +0000 (09:46 +0100)]
Bug 4333 Fix erroneous message re Active Currency
Script was incorrectly asking user to define an active currency
Now test for active currency in the standard way
Use the currency routines in Budgets where applicable
Move the code paths in the if else to subroutines to clarify flow
Enable warnings
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 15 Oct 2009 16:01:00 +0000 (12:01 -0400)]
BUG 3715 added state to label
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nahuel ANGELINETTI [Tue, 2 Mar 2010 16:16:58 +0000 (17:16 +0100)]
(bug #4295) fix overduerules edition
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Fri, 26 Feb 2010 00:20:53 +0000 (19:20 -0500)]
bug 3981 follow up change GST to 'Tax Rate' in EN-US
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Fri, 12 Feb 2010 00:48:15 +0000 (19:48 -0500)]
bug 4170 updated overdue rules
I added a note that this tool should not be used for
advanced notices. The fact that the Delay is required
is actually true based on the tests we did - which
is another bug.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jean-André Santoni [Fri, 5 Feb 2010 13:01:50 +0000 (14:01 +0100)]
Added "ordered" column in acqui-home budget display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Sun, 8 Nov 2009 09:28:59 +0000 (10:28 +0100)]
Improve detail page MARC21 XSL file for 505 and 520 tags
Some tags weren't displayed propertly:
505 If there is no indicator 1, content label is not displayed and
then repeated 505 tags are also incorrecly displayed. This patch
add a default label.
502 Wasn't displayed at all. Added in this patch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Tue, 16 Feb 2010 20:46:51 +0000 (21:46 +0100)]
MT2588: minor changes in column order & display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nahuel ANGELINETTI [Mon, 1 Mar 2010 15:21:36 +0000 (16:21 +0100)]
(bug #4287) add enrolment period update in 22 to 30 script
this fix the upgrade script, to upgrade the enrolment period, that is no more in years, but in month unity.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Fri, 5 Feb 2010 13:01:48 +0000 (14:01 +0100)]
MT2345 : Changes on contracts
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jean-André Santoni [Fri, 5 Feb 2010 13:01:47 +0000 (14:01 +0100)]
Hide basket actions if no basket
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jean-André Santoni [Fri, 5 Feb 2010 13:01:44 +0000 (14:01 +0100)]
New contract button
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Ian Walls [Mon, 22 Mar 2010 17:46:55 +0000 (17:46 +0000)]
Fixes bug 4326: Items marked as returned yesterday
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
J. David Bavousett [Mon, 14 Sep 2009 13:24:36 +0000 (09:24 -0400)]
Bug 3619 - C4::Letters::_send_message_by_email does not obey AutoEmailPrimaryAddress
This enhancement would cause C4::Letters::_send_message_by_email to obey the
syspref.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Fri, 18 Sep 2009 09:07:35 +0000 (11:07 +0200)]
Improve OAI Server MARC21 and UNIMARC XSL
Dublin Core schema name space was repeated for each field
as attribute rather than at <oai_dc:dc> level. This reduces
significantly the size of OAI server responses.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
David Birmingham [Wed, 7 Oct 2009 21:27:35 +0000 (17:27 -0400)]
Fix to ORDER BY SQL in lists feature
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Sébastien Hinderer [Sat, 17 Oct 2009 21:01:52 +0000 (23:01 +0200)]
Perl documentation fixup in C4/Items.pm.
The documentation of the DelItem function did not menton the $dbh.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Wed, 10 Mar 2010 21:26:28 +0000 (22:26 +0100)]
Fixing members order when string searched
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sun, 28 Feb 2010 20:49:38 +0000 (15:49 -0500)]
Bug 4285: Intranet bib display links to opac-search.pl, instead of catalogue/search.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Kyle M Hall [Thu, 4 Mar 2010 16:15:47 +0000 (16:15 +0000)]
Search Patrons - Make patron search more forgiving.
Patron search has only been searching fields for names
that either match or begin with the given search terms.
This is too strict a search.
For example, take the name "Billie Jo Robinson", "Billie Jo"
being the firstname, and "Robinson" being the last name. If one
were to search for "Billie Jo", this patron would not appear in
the search results.
To remedy this, the search
type has been changed from 'begins_with' to 'contain'.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Kyle M Hall [Thu, 4 Mar 2010 16:17:05 +0000 (16:17 +0000)]
Circulation - Disable Barcode Field If Item Needs Confirmation
When issuing items, if a confirmation screen comes up,
another item can still be scanned into the barcode field.
If a librarian does not notice the confirmation dialog,
he or she may continue scanning items without confirming
the issue and thus give a patron an item without it actually
being issued to the patron.
This patch disables the barcode field until the confirmation
question is answered.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Wed, 24 Mar 2010 08:24:21 +0000 (09:24 +0100)]
MT2621 : Fix simple barcodes display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 29 Apr 2010 15:06:54 +0000 (11:06 -0400)]
Fix for Bug 4271, Offer choice of destination for save biblio operation
A follow-up to the fix for Bug 4121, the user should be able to control whether
the action of saving a bibliographic record takes them to the add item screen
or the detail screen, independently of whether they are adding or modifying the
record.
The addition of a "split button" would leave the default action in place if the
user clicked the "main" part of the button. Clicking on the menu would give the
user specific choices.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
J. David Bavousett [Tue, 23 Feb 2010 20:47:56 +0000 (15:47 -0500)]
Bug 4257: Make advance notices actually go out by avoiding null selects
The wrong variable was used to select the number of days-until-due; this fixes it to use
the borrower's preference setting.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Wed, 10 Mar 2010 21:25:44 +0000 (22:25 +0100)]
Fixing Tests on SQLHelper
one test was failing for want of correct parameters
An other one was not correctly described
test on search with a simple string fails because was done with branchcode and start_with includes NULL branches
Removing branchcode from filtercolumns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jared CAMINS-ESAKOV [Fri, 9 Apr 2010 17:24:27 +0000 (13:24 -0400)]
Bug 4371: Display MARC21 field 773 w/XSLT
Display MARC21 field 773 in the OPAC detail view when XSLT is enabled.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jared CAMINS-ESAKOV [Fri, 9 Apr 2010 17:24:26 +0000 (13:24 -0400)]
Bug 4370: Fix ind1 semantics for MARC21 780/785
When using XSLT stylesheets for display, show MARC21 fields 780 and 785 on the OPAC details page only when ind1=0, as specified by the standard.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Wed, 10 Mar 2010 21:26:18 +0000 (22:26 +0100)]
MT 2553 : Adds a Cancel button
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Fri, 23 Apr 2010 04:56:10 +0000 (06:56 +0200)]
Bug 4404: Untranslated strings in staff search result page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 24 Feb 2010 16:59:46 +0000 (16:59 +0000)]
Bug 4248 Rework Cities dropdown for members entry
Garry Collum's patch correctly identified the core flaw in operation
looking closer revealed some other flaws (2 "blank" options, some vars
and documentation belonging to a superceded version, etc.
Changed GetCities to return a structure rather than the messy two returns
Let the template do the concatenation and removed the CGI::Popup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 30 Apr 2010 02:20:12 +0000 (22:20 -0400)]
Revert "Bug 4248: Fixes zip code in cities town pull down list."
This reverts commit
2eac2e7242aa2685df8f511c49bbf50cb55be4fd.
Garry Collum [Wed, 24 Feb 2010 01:17:31 +0000 (20:17 -0500)]
Bug 4248: Fixes zip code in cities town pull down list.
Adds zip code to the GetCities function. This function is only used in memberentry.pl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Wed, 24 Feb 2010 12:31:12 +0000 (07:31 -0500)]
update circ/fine rules help file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jane Wagner [Thu, 25 Feb 2010 17:59:08 +0000 (12:59 -0500)]
Bug 4210 Acq suggestions don't have LibraryName value passed
Updated to current head. The various acquisitions suggestion templates have a LibraryName field, but no value is passed for that field. Added a parameter for that data.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jane Wagner [Wed, 11 Nov 2009 13:40:16 +0000 (08:40 -0500)]
Bug 3782 Update installer info for z39.50 targets
New York Public Library and New York University Library have changed their z39.50 connection information; this patch updates the installer files to the current setups.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jane Wagner [Mon, 2 Nov 2009 20:05:01 +0000 (15:05 -0500)]
Bug 3750 Modify XSLT to display subfield n of 111/711 and remove period after 110/710
If a 111/711 uses a subfield n (Number of part/section/meeting), XSLT wasn't displaying it which made for an incomplete display.
e.g., International Conference on Concurrency Theory 1999 : Eindhoven, Netherlands)
instead of 10th International Conference on Concurrency Theory 1999 : Eindhoven, Netherlands)
I've added it to show before subfield a if present. I've also removed the period that XSLT puts in the results and display after the last occurrence of a 110/710. It's fairly standard practice for these entries to have a period in the MARC record, so the XSLT display was showing a double period.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jane Wagner [Mon, 16 Nov 2009 19:20:28 +0000 (14:20 -0500)]
Bug 3788 XSLT does not obey viewISBD syspref
Modified XSLT.pm and MARC21slim2OPACDetail.xsl to obey the viewISBD syspref
setting in the OPAC.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Sun, 25 Apr 2010 19:44:33 +0000 (07:44 +1200)]
Bug 4372 - Fix for bookcount.pl not counting started transfers as seeing an item
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jane Wagner [Tue, 13 Apr 2010 17:48:56 +0000 (13:48 -0400)]
Bug 4377 Create default HOLD_PRINT notice file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Wed, 10 Mar 2010 21:26:36 +0000 (22:26 +0100)]
MT2464 : branch_transfer_limit.pl usability change
Adds branchnames along with branchcodes for display
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Fri, 26 Mar 2010 10:25:38 +0000 (11:25 +0100)]
removing AutoCommit=0, the last item is not commited
For an unknown reason, the last item batch updated is NOT updated.
After investigating a LOT (more than 3 hours), it appears the problem comes from the AutoCommit=0
I tried to solve it, but failed. So I remove the AutoCommit=0 option.
this result in a loss of perfs, but it's not a big problem I think. OTH, now everything is updated !
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Wed, 24 Mar 2010 08:24:20 +0000 (09:24 +0100)]
Bug Fixing batchmod.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Wed, 24 Mar 2010 08:24:19 +0000 (09:24 +0100)]
MT 2553 : Adds background job for items batch modification
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Wed, 24 Mar 2010 08:24:18 +0000 (09:24 +0100)]
MT 2269, Follow-up : Granular permissions for items batch modification and deletion
Change of permissions names
Change of branch title in guided reports
Add a "Select All / Clean All" on items selection
Add a link to item when a given item cannot be deleted
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>