Owen Leonard [Sat, 13 Nov 2010 18:42:35 +0000 (13:42 -0500)]
Fix for Bug 4851 - Batch delete shouldn't show delete button if no items were found
- Adding template flag to indicate valid results (hidden or not)
- Clarifying warning messages based on various outcomes
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
e6ebf10bba5d9ebec0f8d9995df16d2eb384f44f)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 19:14:39 +0000 (14:14 -0500)]
Fix for Bug 5048, Error in menu/submenu for select language in intranet
Patch for HEAD. This issue was apparently solved quite a while
ago in the OPAC. This patch copies that solution over to the staff client.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
1024eceec715fed2f5c38ac6998ff9be75240280)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 19:34:42 +0000 (14:34 -0500)]
Fix for Bug 5030 - Improve handling of duplicate patrons
- Making duplicate patron warning dialog simpler but more explicit
- Pointing duplicate patron preview window to new brief version
of moremember.pl to display more patron details than the previous
version.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
9f0495238de31cbdcacabe8f3986081f150ae2cb)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Frédéric Demians [Thu, 25 Nov 2010 07:55:05 +0000 (08:55 +0100)]
Bug 5444 Fix misc/translate script for 'standard' Koha install
[3.2] Should apply
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
be65390d0693dc13c5d58b71a13ade5e2689e6b7)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Ian Walls [Tue, 30 Nov 2010 07:19:49 +0000 (02:19 -0500)]
Bug 4449: AllowHoldPolicyOverride does not override all hold policies
This patch provides a universal override to any hold policy if the AllowHoldPolicyOverride is set.
Amongst other overrides, this patch allows missing, non-checked out items to be placed on hold even with AllowShelfHolds turned off.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
5e8b078651624cee7bc4f86e206cf36c8ace9c4d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 19:42:05 +0000 (14:42 -0500)]
Fix for Bug 5029 - Update patron deletion error page
- Styling error message with "dialog alert" class
- Adding sidebar patron details to match other patron pages
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
f7b3b0c75b3dd21dd9c1899f0e5103c3b8798810)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sun, 14 Nov 2010 03:37:10 +0000 (22:37 -0500)]
bug 5405: remove disused script catalogue/suggest.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
9753368626e631ebb06929278d408453186c2528)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 19 Nov 2010 00:37:16 +0000 (19:37 -0500)]
Further fixes for Bug 5142 - Untranslatable strings in tag review template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
470dc1d37c457b9919200c61e369a4fb6207dbc1)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Thu, 25 Nov 2010 20:18:06 +0000 (09:18 +1300)]
Adding 3.2.1 release to the history
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
a1aa1eea166c86dda5fdbc158c2499d4bb014474)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Thu, 25 Nov 2010 20:05:39 +0000 (09:05 +1300)]
Fixing formatting and links in the history document
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
5a71ffa0d3554faa08632fb748af1f5039c48921)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Fri, 26 Nov 2010 14:39:18 +0000 (14:39 +0000)]
Fix some compile time errors reported in test suite
redeclaration of itemnumber in RotatingCollections
A couple of errors caused by retaining commas in qw()
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
bc3dcdd733576fb66dd6431de29a2e401b77bd04)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Fri, 26 Nov 2010 16:31:35 +0000 (16:31 +0000)]
Bug 5448: Refactor Boolean.pm
Remove unnecesssary export
Use Exporter according to best practices
Use Carp not warn so we know where the error string came from
Don't create warnings manipulating undefined input
Replace package variables by lexicals
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
f08b33a9122aa908bb49a513b0ccd29c3c2b7562)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Fri, 26 Nov 2010 16:31:34 +0000 (16:31 +0000)]
Bug 5448 Use Test::More in Boolean.t
Use Test::More's structure as more readable
Replaced a test of an used function with a use_ok test
of the module
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
78be08c73e4265a996c4777a90757fd66991320a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Ian Walls [Tue, 30 Nov 2010 07:25:30 +0000 (02:25 -0500)]
Fixes bug 5232: Shelfname won't display on high-numbered lists
This bugfix adds an explicit GetShelf for the specific shelfnumber when viewing that individual shelfnumber. This captures the
shelfname, which was originally pulled from shelflist->{$shelfnumber}, which may not have been populated if the List in question was
beyond the 20th private or public list in the system.
Also adds a more explicit sort: the sort from the CGI takes top priority, then it falls back to the default sort for the list, and
ultimate falls to 'title' if neither CGI nor default sort exist.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
31439fc51adc7e32a2eff6608bf91e08fcbf0ade)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Fri, 26 Nov 2010 17:27:13 +0000 (17:27 +0000)]
Bug 5450 Avoid a name clash in ILSDI modules
C4::ILSDI::Utility exports a subroutine CanBookBeReserved
Both ILSDI were also importing a subroutine of that name from
C4::Reserves Remove conflict by listing subroutines
imported from C4::Reserves explicitly
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
b9ccc5184197e2bf4bf6697edfdb9e70963fdee6)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Tue, 30 Nov 2010 15:14:23 +0000 (10:14 -0500)]
Fix for Bug 5402, "add to cart" shown on checkbox hover
This patch removes the title hint altogether. The checkbox might
be used for the cart, lists, holds, or tags, and expressing this
in a title hint seems overly complicated.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
e7321e1a7f471157b4ae24738eb70c54b0798f31)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 17:58:55 +0000 (12:58 -0500)]
bug 4451 followup - don't need /g for this replace
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d056b2f62a7f971126590236bee54a344d526fb7)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 17:58:54 +0000 (12:58 -0500)]
Fix for Bug 4451 Batch item tool can't process file with Windows line endings
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
3f5d9537db4b07a993cc0a11fd4c03acb1859d20)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 17:55:02 +0000 (12:55 -0500)]
Fix for Bug 4981, Tweak style of item listing on MARC display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
781b4e5fae89021c69c5de5e621faebb6457dd31)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 03:00:26 +0000 (22:00 -0500)]
Fix for Bug 5051, Renewal due date doesn't always show on patron Checkout tab
Display of the renewal date footer in the template was conditional upon
the existence of checkouts from today.
In order to fix this bug it was necessary to repeat the markup for the
table footer twice in the template, so I created an include file for it.
The same include file can now be used in moremember.tmpl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
083d3b1a929707a84fe4c97d4c815198bef9e1dc)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 12 Nov 2010 21:12:11 +0000 (16:12 -0500)]
Fix for Bug 5269 - link to patron edit form when editing turned off
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
16c891092fec9b413fb5cb86cc4a0f8f7c43888f)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 12 Nov 2010 20:59:47 +0000 (15:59 -0500)]
Fix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time
This fix corrects the behavior of the checkboxes whether the user clicks the
checkbox itself or the <td> around it. Tested on a PC in Firefox 3.6, Chrome,
Safari 5, and IE 8.
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
cc57c2688d73046ee4930869d2d7fabdc8dd37ca)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 21:50:30 +0000 (16:50 -0500)]
Updating Version Number to 3.02.01.001
bug 5127: database update to add the suggestion notification templates
Being especially careful to not scribble over any ones
that the library might have already defined.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 21:35:43 +0000 (16:35 -0500)]
bug 5127: sample notice templates for suggestions
* supply default suggestion status change email
templates.
* remove the deprecated mail_suggestion_*.tmpl files
There are a couple suggestion statuses referred to
in the code and suggestion management page that currently
do not have notice templates defined: ASK and CHECKED. These
seem to be internal, so perhaps default message templates
are not needed for these.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
7fd45b986197721f1486bea61a20a717d4217c4a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 21:27:47 +0000 (16:27 -0500)]
bug 4211: ensure that suggestion emails have full details
Because of how the ModFoo routines work, if you are only
changing selected columns but are also using the change
as a trigger to place a message in the queue, you need
to fetch the full row before generating the message.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
d3df54d05245b3fa11f052b4c09104bdd2531e31)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 20:43:27 +0000 (15:43 -0500)]
bug 4211: more fixes to suggestion letter template handling
* Now displays the correct list of fields to choose
for suggestion letters.
* Clean up mixture of old and new column selection code
introduced in commit
88bb1b63, thereby restoring
the intent of the patch for bug 3522.
* Enable suggestion library to be used in suggestion
letter templates
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
994d6e2aac6092b7c852546eeca2253f59270e53)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Thu, 12 Aug 2010 21:44:46 +0000 (09:44 +1200)]
Bug 4211: This patch should provide a working way to send out mail from suggestions
Your suggestion notices template needs to contain things like
<<suggestions.title>>
<<suggestions.author>>
etc
Squashed commit of the following:
commit
3f4278bbe8d4c68be9f72d50e1eef6a411dc873d
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date: Fri Aug 13 09:41:34 2010 +1200
bug 4211 parsing the letter before we enqueue it
commit
ecdc0ff34c1aa9b96b68d541423ca693e2d63e67
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date: Fri Aug 13 09:32:09 2010 +1200
Changing the query to fetch suggestions data, this is needed for suggestion mail to be sent
commit
ece11d015b945ce119cf7cbc5e2563f4bc8aecf9
Author: Owen Leonard <oleonard@myacpl.org>
Date: Thu Aug 12 12:36:26 2010 -0400
Fix for Bug 4211, Acquisitions actions on suggestions don't generate email
Assuming 1) The patch for Bug 5126 is approved and 2) Suggestions
notices are added by hand (or from default sql--see Bug 5127) this
correction should get suggestions notices properly enqueued.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
commit
5c3bbe7d557b1994be72518746217fc6fc4e5b83
Author: Owen Leonard <oleonard@myacpl.org>
Date: Thu Aug 12 12:27:33 2010 -0400
Fix for Bug 5126 - Suggestions module missing from "add notice" form
- Adding "suggestions" entry
- Re-ordering options in alphabetical order
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
b1c2d560b66272ec34c1bbd380db24452be9bc3f)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger [Mon, 29 Nov 2010 19:43:24 +0000 (14:43 -0500)]
Updating Version Number to 3.02.01.000
Updating version number for 3.2.1 release.
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Sat, 20 Nov 2010 13:00:01 +0000 (14:00 +0100)]
Bug 5175: Publisher link breaks display, if no publisher exists
If there is no publisher the empty publisher link will break the record display
in staff and intranet.
This patch adds a check for existence of subfield b.
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger [Thu, 18 Nov 2010 03:58:00 +0000 (22:58 -0500)]
Release Notes for 3.02.01.000
Owen Leonard [Mon, 15 Nov 2010 23:13:32 +0000 (18:13 -0500)]
Another bug 5004 fix, this time for road types
The road types interface didn't block deletion of road
types in use, but the script included the same queries
that cities.pl did, as if it intended to.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
14b66041f0dc08a5618985b44e1816a6c9978f45)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Mon, 15 Nov 2010 13:09:11 +0000 (08:09 -0500)]
Fix for Bug 5004, Don't block deletion of cities when instances exist in borrowers table
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
a36a7e1e61ac0ef7b2b79065432f028edef9d49e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Tomás Cohen Arazi [Wed, 17 Nov 2010 14:43:10 +0000 (09:43 -0500)]
Bug 5412 double quotes break coins and thus search results in some scenarios
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d13d96614b7008e37bcb45106b65862548818218)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Frédéric Demians [Mon, 15 Nov 2010 23:11:09 +0000 (18:11 -0500)]
Bug 5204 Followup
- Typo
- Duplicate 955 tag
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
879363c36c4531a4cc528e758ab20cf7a735575e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Zeno0 Tajoli [Mon, 15 Nov 2010 17:47:27 +0000 (18:47 +0100)]
bug 5204: Unimarc XSLT, from French to English.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
9ee8ffba792dcfac53de8d5fc154f05137eea2d3)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Wed, 17 Nov 2010 22:28:52 +0000 (11:28 +1300)]
German and italian language updates
(cherry picked from commit
182eb4eca7c31c3b6ab4456078974e98ffaab376)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
MJ Ray [Wed, 13 Oct 2010 01:17:05 +0000 (02:17 +0100)]
Display available error information during bulkmarcimport
(cherry picked from commit
65f8573b5d414591d22ce1b0d60afea9293f5704)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Thu, 5 Aug 2010 20:19:13 +0000 (17:19 -0300)]
Misspell: Quanity -> Quantity
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
ad06fd90c62f14ef7fabea875ae9177359e4df43)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Wed, 25 Aug 2010 14:33:25 +0000 (10:33 -0400)]
Misspells: deleteing -> deleting
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
587cacee7b025596f26ced4897df1a2308618206)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Wed, 11 Aug 2010 20:47:52 +0000 (17:47 -0300)]
Bug 5118: Misspelled word: Currencey
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
de621bdaff9956b1201bfdb57fcee538b9ccedbd)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Wed, 11 Aug 2010 21:12:16 +0000 (18:12 -0300)]
Bug 5117: Misspelled word Organisztion
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
46660b9f6ccf11a762ad19edb0dc12692f45975b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Wed, 11 Aug 2010 21:29:15 +0000 (18:29 -0300)]
Bug 5119: Misspelled word correspounding
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
34811af873c593bd7e09f0a07205ba474032a42a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Wed, 11 Aug 2010 23:38:56 +0000 (20:38 -0300)]
Bug 5121 - Misspelled words: stripts biographyl Begininning
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
3b2f23c7da6ff8abc63b1f09b93de5971a80e16d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Thu, 12 Aug 2010 01:08:57 +0000 (22:08 -0300)]
Additional fix Bug 5122 - Misspelled word: transfered
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
7b2dbbd6b7df56a57b9a6fe70c305e415c0563a6)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Thu, 12 Aug 2010 00:54:54 +0000 (21:54 -0300)]
Bug 5122 - Misspelled word: transfered
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
444fade0208ddedd45f80e08e9cbe4b396d4faad)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Thu, 12 Aug 2010 01:23:51 +0000 (22:23 -0300)]
Bug 5123 - Misspelled words: Depdending Commited flutucations
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
13d84315ea9123d437e364607a2cbb0c9bedff31)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Thu, 12 Aug 2010 02:52:05 +0000 (23:52 -0300)]
Bug 5124 - Duplicate and Misspelled words: periodicy outputing
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
914a73cac4313e26e8d254edcfef2fb36157ecaa)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Fri, 13 Aug 2010 00:43:01 +0000 (21:43 -0300)]
Bug 5132 - Misspelled words: Acquistion Succesfully professionnal
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
a2bc823707e449774be16ac4c254531c1b52a091)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Fri, 13 Aug 2010 01:48:12 +0000 (22:48 -0300)]
Bug 5133 - Misspelled words: reservior notifiying deleete + recieving
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
e1eda06c7a52ba0c82cb9ea067e060692d1847de)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Fri, 13 Aug 2010 02:43:19 +0000 (23:43 -0300)]
Bug 5134 - Misspelled words: exisiting anomolies genereated
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
dc51da6c883baaf15b0a0ddf73054a28b8757685)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Bernardo Gonzalez Kriegel [Thu, 12 Aug 2010 23:10:45 +0000 (20:10 -0300)]
Bug 5130 - Misspelled words: biblographic delimeter extention
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
d942e5581960dd2de02dc6a878c036c5a336ee20)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Fri, 12 Nov 2010 20:41:51 +0000 (15:41 -0500)]
Bug 5059: Inconsistent use of ordering price and list price in vendor form
Changes Ordering price to List price and make spelling more consistent.
Patch originally send for 3.2, still applied to HEAD without conflicts.
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
315293868420ddce37d0402b327feedceda750ad)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 04:22:24 +0000 (23:22 -0500)]
Corrected patch for Bug 4520, facets "show more" doesn't work
Re-doing Nahuel's fix so that it applies to master
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
bd90bb02a4d976010d302cfe175c6a1dd8fb9627)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger [Wed, 17 Nov 2010 22:09:59 +0000 (17:09 -0500)]
Beginning of Release Notes for 3.02.01.000
Marcel de Rooy [Wed, 17 Nov 2010 12:18:00 +0000 (12:18 +0000)]
Bug 5066 (Log timestamp consistently in _session_log)
Small fix with thanks to Galen.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
1bd67e28e563c00d270686f89ceecdeb93230f36)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Mon, 15 Nov 2010 23:19:26 +0000 (18:19 -0500)]
Bug 2122 follow-up for authorities editor
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c55f8ffca7337587a746ae6dda30d9c6508e3da7)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Mon, 15 Nov 2010 13:02:48 +0000 (08:02 -0500)]
Fix for Bug 2122, Grayed out Fields not always visible
- Adding "readonly" class to readonly fields to guarantee
that readonly state is indicated visually
- Adding "locked" icon to the background of readonly
fields for additional visual feedback
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
240ce5a31c278e86af5f3d465bdd6c011c951068)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Tue, 16 Nov 2010 23:33:49 +0000 (18:33 -0500)]
Fix for Bug 5152 - confirm buttons different styles on lists
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
61c7ba41042488577174c145c5fce677d408daea)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Tue, 16 Nov 2010 23:43:43 +0000 (18:43 -0500)]
Fix for Bug 5037 - If patron category is empty it shouldn't show
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
bbb0819f0f22b9387ddc209b7f0997c3b507b51d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Tue, 16 Nov 2010 23:52:36 +0000 (18:52 -0500)]
Fix for Bug 3013, Value builder for 006 and 008 need choices for all format types
This partial fix adds a complete list of values for 006/00, "Form of material,"
following the list found here: http://www.loc.gov/marc/bibliographic/bd006.html
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
b050029c656cd9c4828ea3ef00d4f2dd1d34b8f5)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Wed, 17 Nov 2010 00:33:38 +0000 (19:33 -0500)]
Bug 4074 Fix fail to parse simple qualified search
Searches such as au,phr and kw,wrdl were passing through the regexes
that should replace colon with equals
add wrdl and phr
use trn so not just rtrn is spotted
Where we were checking for multiple spaces specify that in the
regex not just two spaces
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
b97c4dba7a183e826ac8c1b37d0261f0327f12c2)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Mon, 15 Nov 2010 12:55:43 +0000 (07:55 -0500)]
Brooke caught my april fools trick, its not 20004 yet!
Ok it wasn't an april fools trick, but just a typo, april fools trick
sounds better though right?
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
0fa9ade9ffb48c10db40c0789fa5f5509ec63082)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 17:05:47 +0000 (12:05 -0500)]
bug 4866 follow-up - minor code formatting cleanup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
20be558069cec2a620c60dce913709b6e3e4dc29)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Marcel de Rooy [Sat, 13 Nov 2010 17:05:46 +0000 (12:05 -0500)]
Bug 4866 for master (Enable Change event for item plugins)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
baee3e5c9bd93ac028e7142b0a52e3912ce5098e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 03:53:23 +0000 (22:53 -0500)]
Fix for Bug 4913 - Budget pages should show currency name instead of symbol
This patch adds a new include file to handle the display of the active
currency name and a warning if no currency is active.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
4b69538f9bf6809126cc404a7bc09b02c3830328)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 03:48:41 +0000 (22:48 -0500)]
Fix for Bug 4912 - After editing private list redirect to private lists
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
38360b766c32ab89c6e5ee87d2459692b47f2b29)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 12 Nov 2010 22:03:42 +0000 (23:03 +0100)]
Fix for Bug 5175, XSL view doesn't link publisher name to search
Fixes the doubled up display of the publisher.
This patch fixes the bug in both the OPAC and staff client
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c0272a6b66e053a86010c7eb8fce1bf080bf428b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 12 Nov 2010 20:58:00 +0000 (21:58 +0100)]
Fix for Bug 5210, back button on batch modification result page useless
I can't see any good use for a back button here, so I'm taking it out.
An improvement might be to build in a method to resubmit the same batch
of barcodes/item numbers again so that you could make additional
changes to the same set.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
fa43573b5871f04c15f354def4954d6e70ba36b8)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger [Fri, 12 Nov 2010 15:30:45 +0000 (16:30 +0100)]
Bug 5381 - Fines in notices prints always 0.00
This was due to passing off the biblionumber to GetFines rather than the itemnumber.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c1463e72554639e2f913d335d6008b2fa912dbb9)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 20:00:22 +0000 (15:00 -0500)]
Additional fix for Bug 4423 - Staff Client XSLT is just a copy of the OPAC one
- Adding "Lists that include this title" links
- Also correcting minor XHTML error in the same section of opac-detail.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
0a2698237875b8481e14e6890388fe618081b4d1)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 14:36:15 +0000 (09:36 -0500)]
bug 5400: new test case to find files with merge conflict markers
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
4cef5ec9611cc2fbbd245472b60e1580f6f8b4b5)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Tue, 7 Sep 2010 13:48:03 +0000 (15:48 +0200)]
Fix for Bug 4498 - Acq always shows '1 suggestions waiting'
- Removing 'suggestions waiting' link from left-hand menu. A plain
'suggestions' link is still shown if suggestions are enabled.
- Putting back the 'pending suggestions' box that used to appear
on the Acquisitions home page. This will show, with a count
of pending suggestions, only if suggestions are turned on and
there are pending suggestions.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d9de6ebab3ecca5e967c658541c0ec62db0ae2e7)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger [Sat, 13 Nov 2010 18:16:42 +0000 (13:16 -0500)]
Updating Version Number to 3.02.00.007
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Fri, 12 Nov 2010 20:54:50 +0000 (15:54 -0500)]
Bug 5396: New system preference UseTablesortForCirc
This system preference allows the librarian to toggle on or off whether the JQuery tablesort is used on the
circ/circulation.pl page. For patrons with many checkouts, this sort may cause very slow page loading (and
therefore slow circulation transaction time), depending on the browser and local machine used. Staff can
still see a sortable list of current checkouts on the members/moremember.pl page.
My revision prevents the template from including *any* tablesorter code if the
preference is feature is turned off: both the circulation list and
the holds list will have no jQuery tablesorter.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d9db65a17e83f64c5858c6fd7ad8dc0d1e7660ab)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 03:41:32 +0000 (22:41 -0500)]
bug 4359: make other pages in the OPAC respect noItemTypeImages
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
7a945dbc284a9fc98fda06a49bbac0712bce4fea)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Sat, 13 Nov 2010 03:41:31 +0000 (22:41 -0500)]
bug 4359 follow-up: noItemTypeImages should just control image display
Tweaked so that the item type column is always displayed in the
checkout history in the OPAC; noItemTypeImages now just controls
whether the icon displays.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
3357d811ee95c8de8beacd0fb93a979109051b44)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 03:41:30 +0000 (22:41 -0500)]
Fix for Bug 4359, noItemTypeImages not active in OPAC
- Auth.pm put the noItemTypeImages preference under "intranet only."
Moved it to "OPAC or intranet."
- Added check for the preference on the OPAC advanced search page.
- Improved logic for displaying images on the reading history page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d4f02c469bdb9626f456aadf160c9ffc9ad23863)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 04:16:56 +0000 (23:16 -0500)]
Fix for Bug 3271, Missing message when adding to a list with no items selected
There is no visible Lists button to "attach" our warning to
as there is in the OPAC, so warning message is displayed via
a javascript alert.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
fcb3668512341d70d3e222426ea6317130793744)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 04:28:00 +0000 (23:28 -0500)]
Partial fix for Bug 4924, Public/Internal notes missing in staff normal view
This fix adds only public notes. A div is added as a hook for styling
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
be547448368cad2b599e52eb71fc8c6ce39f77c1)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Sat, 13 Nov 2010 04:33:54 +0000 (23:33 -0500)]
Fix for Bug 4933, Link to subfield's edit tab from subfield structure admin
- Also corrects framework display in the case of the default
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
1586306866e84a47d29ba1cf2194d0ccb7cf04c5)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Fri, 12 Nov 2010 12:35:47 +0000 (07:35 -0500)]
Bug 5392 Initialize vars used in building url strings
If no failures are to be added to the to the strings for redirect
the corresponding variables are undefined causing warnings
to be logged. Initialize them so that the error log is not
being filled with trivia.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
bd93bfdbc4087166369ac0e7dbc146cb199ecceb)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Fri, 12 Nov 2010 20:24:04 +0000 (15:24 -0500)]
BUG 5058: small layout correction of vendor form
Rebased to HEAD, should also apply to 3.2
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
d39dd6d857af999430df0fbe571a5bffde7a287d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Fri, 12 Nov 2010 12:35:45 +0000 (07:35 -0500)]
Bug 4979: Acq: input fields for new record are too short
Patch rebased to HEAD, should also apply to 3.2
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
ed0ccd9f574b1f4895fa51dfe6850215be39d8db)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Fri, 12 Nov 2010 14:10:37 +0000 (15:10 +0100)]
bug 5393 [SIGNED-OFF]: add test case to check well-formedness of XML/XSLT files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
35d2008ef001f19c16f29a25626a7190c75218a8)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Fri, 12 Nov 2010 12:35:46 +0000 (07:35 -0500)]
Bug 4305: Add test case for ISBN-13 to ISBN-10 conversion
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
51eb4fa12ec316fb8bf249ec0ae9c96a56f4639e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Thu, 11 Nov 2010 15:26:16 +0000 (10:26 -0500)]
bug 5389: mark Business::ISBN as a required dependency
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
11d54188f8302aea7cade2d4a9afdaa2f5eb0c7a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Thu, 9 Sep 2010 16:07:44 +0000 (12:07 -0400)]
Fix for Bug 5075 - Terms not highlighted w/ xslt on
- XSLT didn't contain the class markup which acts as a hook
for the JavaScript highlighting system.
- Standard results page also contained a typo which
prevented data other than title and author from
being highlighted
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
b558c0db5ad9125a947454b5ba8892f996553ab4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Owen Leonard [Wed, 6 Oct 2010 16:13:02 +0000 (12:13 -0400)]
Fix for Bug 5254 - no need to scroll left to right on acq z search
- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
line breaks, improving table width and horizontal scrolling.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
f987d35a2241a6178406a3d92ccbf9277087f2d1)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Nicole Engard [Tue, 21 Sep 2010 12:10:34 +0000 (08:10 -0400)]
bug 5235 : circ receipt should include name
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
ace0ce3f8da9e353f1e06eac0c26ead67b765eed)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Fri, 22 Oct 2010 13:08:57 +0000 (14:08 +0100)]
Bug 5315: Remove references to obsolete variable nbstatements
Trying to see the wood from the trees
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
9e5366734b744de2035f0668e7db94e399daacad)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Tue, 26 Oct 2010 16:14:46 +0000 (12:14 -0400)]
bug 5309: tweak so that background progress doesn't exit immediately
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
48ab366b57a1ba59c1bf706308944b388666769d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Tue, 26 Oct 2010 15:28:21 +0000 (11:28 -0400)]
fix use of outdated boilerplate
* New code *must* have an accurate copyright statement;
it isn't 2000-2002 any more.
* Enable warnings in new code, don't do
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
0187e38ad7826172859467991d6766ca37e31d2c)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Srdjan Jankovic [Fri, 15 Oct 2010 00:53:11 +0000 (13:53 +1300)]
bug 5309: Adjust progres bar
Also added some test facilities
wr73785
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
e2e1dfd86e2f4a6ef63829551c58c728633fa893)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Srdjan Jankovic [Tue, 12 Oct 2010 17:03:26 +0000 (13:03 -0400)]
bug5027: skip unticked checkboxes when submitting in the background.
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit
3a4f36b002a5651716efe68242f6711fad936448)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Cormack [Thu, 11 Nov 2010 21:38:42 +0000 (10:38 +1300)]
Bug 5385 - Fixing an error that crept in with the POD cleanup
(cherry picked from commit
9c6db56a3f807c819be5e724f423a212fa4b362c)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton [Thu, 11 Nov 2010 14:43:47 +0000 (09:43 -0500)]
bug 4305: add a couple test cases for _isbn_cleanup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
bcedff69bcef3a887575c34f53e2c26153da61c1)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Colin Campbell [Thu, 11 Nov 2010 14:02:13 +0000 (09:02 -0500)]
Bug 4305 Improve code flow
Use the ISBN Object's method to format the string
rather than add extra code to do it
Clean up the code flow for clarity
Benchmarking shows its a bit faster too
Don't add to the number of Test::Perl::Critic warnings
for no benefit
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
c95b5153e0ed5585c8331273a42fc29d75f9f10f)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Andrew Elwell [Thu, 11 Nov 2010 13:18:47 +0000 (08:18 -0500)]
Bug 5385: POD Cleanups (part 2)
More podchecker cleanups to eliminate warnings / errors
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
efa66f1f556dcff71779c9b89148f2bb99149e51)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Andrew Elwell [Thu, 11 Nov 2010 13:18:46 +0000 (08:18 -0500)]
Bug 5385: POD Cleanups (part 1)
working through the master branch to eliminate all
podchecker warnings/errors
Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
9fa574f6097b8fc1eb9efc5321141ec0d23d3268)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Katrin Fischer [Thu, 11 Nov 2010 12:39:32 +0000 (07:39 -0500)]
Bug 5112: Organisation does not show links to professionals
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit
63fdd8768acc42cf1b02a655506d6ea97c11fe14)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>