]> git.koha-community.org Git - koha.git/log
koha.git
15 years ago(bug #2998) fix search sorting containing "="
Nahuel ANGELINETTI [Tue, 3 Mar 2009 16:48:15 +0000 (17:48 +0100)]
(bug #2998) fix search sorting containing "="

just modify the way to parse the actual args

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdate autobarcode syspref for french framework
Nahuel ANGELINETTI [Tue, 3 Mar 2009 13:16:17 +0000 (14:16 +0100)]
Update autobarcode syspref for french framework

This patch just update the syspref to use incremental|annual|hbyymmincr|OFF instead of "YesNo".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2995) Set a default encoding for e-mails
Nahuel ANGELINETTI [Tue, 3 Mar 2009 10:16:24 +0000 (11:16 +0100)]
(bug #2995) Set a default encoding for e-mails

Just set a default encoding as utf8 if none is provided.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agochanges to OPAC results and detail XSLT
Galen Charlton [Wed, 11 Feb 2009 23:01:01 +0000 (17:01 -0600)]
changes to OPAC results and detail XSLT

Various changes to OPAC search results and bib
detail display for MARC21.

* Search results

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a, displayed under author
[3] New other title field from 246$a$b, displayed under call number

* Bib details

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a$b, displayed under publisher
[3] New description field from 300$a$b$c$e$g, under the edition.
[4] New other title field from the 246$i$a$b$h$f$g$n$p, above the
    uniform title field.
[6] All 6XX fields are displayed in the subjects field.
[7] '--' now separates subdivisions in subject headings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agodisplay library name instead of code in limit description
Galen Charlton [Wed, 25 Feb 2009 19:29:41 +0000 (13:29 -0600)]
display library name instead of code in limit description

The OPAC and staff search results page will now display
the library name instead of the library code in the limit
part of the search description, e.g.,

"kw,wrdl: cat branch:Centerville" instead of
"kw,wrdl: cat branch:CPL"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoResubmitting: Change to how email link is displayed for on-hold items
Owen Leonard [Thu, 26 Feb 2009 20:50:40 +0000 (14:50 -0600)]
Resubmitting: Change to how email link is displayed for on-hold items

Email link should only display when the on-hold item is being checked in at its destination branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agominor corrections to check-url.pl
Galen Charlton [Thu, 26 Feb 2009 21:15:53 +0000 (15:15 -0600)]
minor corrections to check-url.pl

* removed ersataz YAML::XS dependency
* use 'return' instead of 'return undef'
* minor language changes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoURLs checker enhancement (bug #2959)
Frederic Demians [Tue, 17 Feb 2009 09:23:13 +0000 (10:23 +0100)]
URLs checker enhancement (bug #2959)

Improve URLs checker script in the way (half way) pointed out by Galen:

- A C4::URL::Checker class handle URL checking. This class is not yet
  in a separate file in C4 directory. This class would be easily
  extended to accomodate authorities URLs checking.
- Script output can now be formatted in CSV or HTML. HTML version
  link directly to MARC biblio record editor.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2968 - SIP ACS_STATUS message (98) misreported config.
Joe Atzberger [Thu, 19 Feb 2009 16:20:07 +0000 (10:20 -0600)]
Bug 2968 - SIP ACS_STATUS message (98) misreported config.

The *_ok methods in ILS.pm were targeting the wrong depth.
This also resolves a longstanding FIXME on to_bool() warning like:
    Argument "\x{66}\x{61}..." isn't numeric in numeric ne (!=) at /ILS.pm line 94.

The example_institution_dump.sh essentially provides the proof test case for this patch.
Run it before/after on SIPconfig.xml where "MAIN" has checkout="true" and checkin="true".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding additional information and consolidating display of information in holds queue...
Owen Leonard [Fri, 20 Feb 2009 16:59:28 +0000 (10:59 -0600)]
Adding additional information and consolidating display of information in holds queue report

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoConsistency check between Makefile.pl and about.pl We weren't picking up JSOM so...
Andrew Elwell [Sun, 22 Feb 2009 13:53:08 +0000 (14:53 +0100)]
Consistency check between Makefile.pl and about.pl We weren't picking up JSOM so admin/item_circulation_alerts.pl gave a 500 internal server error if JOSM not installed.

 Also sorted packages.debian alphabetically so that we can maintain
 easier.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agomore Minor documentation fixes
Andrew Elwell [Fri, 20 Feb 2009 14:34:51 +0000 (15:34 +0100)]
more Minor documentation fixes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor documentation typos
Andrew Elwell [Thu, 19 Feb 2009 11:01:55 +0000 (12:01 +0100)]
Minor documentation typos

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpgrade jquery dimensions plugin. Correction to Cart js to match.
Owen Leonard [Thu, 26 Feb 2009 20:14:36 +0000 (14:14 -0600)]
Upgrade jquery dimensions plugin. Correction to Cart js to match.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding information that patron is restricted/address in doubt to hold notification...
Owen Leonard [Thu, 26 Feb 2009 18:58:31 +0000 (12:58 -0600)]
Adding information that patron is restricted/address in doubt to hold notification screen

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrection: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only...
Owen Leonard [Thu, 26 Feb 2009 19:17:52 +0000 (13:17 -0600)]
Correction: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only if GoogleJackets is on)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2988: apply correct hold policy
Galen Charlton [Thu, 26 Feb 2009 16:42:53 +0000 (10:42 -0600)]
bug 2988: apply correct hold policy

Item type was not retrieved in a query, leading to a case
where an item could be selected by build_holds_queue.pl
to fill a hold request even where forbidden by the
library and item type-level policy.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUsing "escape=html" on TMPL_VAR containing SQL to prevent HTML from breaking when...
Owen Leonard [Wed, 25 Feb 2009 14:38:37 +0000 (08:38 -0600)]
Using "escape=html" on TMPL_VAR containing SQL to prevent HTML from breaking when SQL includes double-quotes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1546 - REPLACE statements
John Beppu [Thu, 26 Feb 2009 19:19:28 +0000 (13:19 -0600)]
bug 1546 - REPLACE statements

A REPLACE statement in tools/letter.pl was indirectly corrupting data
in the message_transports table.  It has been replaced with code that
does an UPDATE or INSERT depending on whether the row existed or not.

Also, to protect data in the message_transports table further, letters
which have entries in the message_transports table are no longer
deletable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoEnabling listing of category codes when "new patron" button is displayed.
Owen Leonard [Tue, 24 Feb 2009 16:10:03 +0000 (10:10 -0600)]
Enabling listing of category codes when "new patron" button is displayed.

circulation.pl lacked the code to check whether category codes existed, meaning it would only display category types.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd option to inventory tool to ignore copies on loan
Michael Hafen [Tue, 24 Feb 2009 19:05:50 +0000 (12:05 -0700)]
Add option to inventory tool to ignore copies on loan

This adds an option to the inventory tool causing it to ignore copies
currently on loan.  This is good if you want to do inventory, but don't
want to update the date-last-seen on items currently on loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemoving check for non-existent OPACDisplayItypes sytem pref which prevented itemtype...
Owen Leonard [Wed, 25 Feb 2009 17:02:06 +0000 (11:02 -0600)]
Removing check for non-existent OPACDisplayItypes sytem pref which prevented itemtype icons from appearing on opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2984, Error when generating CSV output from "Generate labels for Batch...
Owen Leonard [Wed, 25 Feb 2009 21:17:15 +0000 (15:17 -0600)]
Fix for Bug 2984, Error when generating CSV output from "Generate labels for Batch" button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2939) delete a warning
Nahuel ANGELINETTI [Tue, 3 Feb 2009 08:47:45 +0000 (09:47 +0100)]
(bug #2939) delete a warning

just add a default value to $sep

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2952 followup
Galen Charlton [Thu, 12 Feb 2009 23:04:20 +0000 (17:04 -0600)]
bug 2952 followup

The feature in question is described in bug 2952; to
summarize the enhancement, which the earlier patch
description did not do, the list of bibs in an
import record batch now includes a column linking
each import record to the bib that was actually created
or updated when the import batch was committed.

The improvements in this patch are:

* If bib in import batch has not been committed, it
  has not been linked to a matching new or updated bib.
  In that case, do not create a link to a guaranteed
  404 (/cgi-bin/koha/catalogue/detail.pl?biblionumber=)

* When reverting an import batch, set matched_biblionumber
  to NULL for affected records - otherwise, the Bib
  column will include links to bibs that may no longer
  exist.

* Fixed a minor HTML validation error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2952: 1 char typo
Mason James [Tue, 10 Feb 2009 02:38:15 +0000 (15:38 +1300)]
bug 2952: 1 char typo

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agopatch for feature 2952 - v3
Mason James [Tue, 10 Feb 2009 01:48:26 +0000 (14:48 +1300)]
patch for feature 2952 - v3

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanges to improve keyboard access to global search box tabs.
Owen Leonard [Tue, 10 Feb 2009 20:45:36 +0000 (14:45 -0600)]
Changes to improve keyboard access to global search box tabs.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2955: fix remaining calls to GetMarcFromKohaField
Galen Charlton [Thu, 12 Feb 2009 22:28:41 +0000 (16:28 -0600)]
bug 2955: fix remaining calls to GetMarcFromKohaField

This includes part of a patch from Henri-Damien Laurent
that could not be applied because Chris and Joe patches
happened to win the race.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoA new script to check URLs in 856$u field
Frederic Demians [Tue, 10 Feb 2009 06:13:30 +0000 (07:13 +0100)]
A new script to check URLs in 856$u field

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMoved several etch packages from cpan install to the packages.debian.
Andrew Elwell [Mon, 9 Feb 2009 21:30:53 +0000 (22:30 +0100)]
Moved several etch packages from cpan install to the packages.debian.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2956) fix another results calculation
Nahuel ANGELINETTI [Thu, 12 Feb 2009 14:58:35 +0000 (15:58 +0100)]
(bug #2956) fix another results calculation

this patch fix more about 4XX plugin, for results display and calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agokohabug 2955 (2/2) GetMarcFromKohaField now requires $framework
Chris Nighswonger [Wed, 11 Feb 2009 17:15:00 +0000 (12:15 -0500)]
kohabug 2955 (2/2) GetMarcFromKohaField now requires $framework

Failure to pass the $framework parameter by dateaccessioned.pl causes
GetMarcFromKohaField to return 0,0 which breaks the value builder. The
patch
submitted corrects this.

This patch is build against the current 3.1.x HEAD, however, this bug
also
affects the 3.0.x codebase and should be applied there as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMake sax_parser_print provide more obvious feedback.
Joe Atzberger [Tue, 10 Feb 2009 20:16:31 +0000 (14:16 -0600)]
Make sax_parser_print provide more obvious feedback.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrecting title of link to admin/itemtypes.pl from "Item types and circulationcodes...
Owen Leonard [Tue, 10 Feb 2009 20:45:47 +0000 (14:45 -0600)]
Correcting title of link to admin/itemtypes.pl from "Item types and circulationcodes" to just "Item types." Ccodes are authorized values.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadd some search indexes to opac advanced search that are on quick search
Michael Hafen [Mon, 2 Feb 2009 23:24:53 +0000 (16:24 -0700)]
add some search indexes to opac advanced search that are on quick search

This adds ISBN and Call Number, which are in the quick search index
list, but are not in the advanced search index lists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agokohabug 2955 GetMarcFromKohaField now requires $framework
Chris Nighswonger [Wed, 11 Feb 2009 16:44:12 +0000 (11:44 -0500)]
kohabug 2955 GetMarcFromKohaField now requires $framework

Failure to pass the $framework parameter by barcode.pl causes
GetMarcFromKohaField to return 0,0 which breaks the value builder. The
patch
submitted corrects this.

This patch is build against the current 3.1.x HEAD, however, this bug
also
affects the 3.0.x codebase and should be applied there as well.

fbcbug 4

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2956) fix 4xx plugin pagination
Nahuel ANGELINETTI [Thu, 12 Feb 2009 14:38:52 +0000 (15:38 +0100)]
(bug #2956) fix 4xx plugin pagination

this patch rework the calculation of the pagination and of results

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2957) import Date_to_Days
Nahuel ANGELINETTI [Thu, 12 Feb 2009 15:04:52 +0000 (16:04 +0100)]
(bug #2957) import Date_to_Days

This patch import Date_to_Days from Data::Calc, else CalcFine can crash.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoreduce bib fetches during search and OPAC display
Galen Charlton [Tue, 10 Feb 2009 22:38:11 +0000 (16:38 -0600)]
reduce bib fetches during search and OPAC display

Speed up bib search and OPAC bib display, especially
when the XSLT OPAC results and details display sysprefs are
ON, by passing an existing MARC::Record object to three
functions:

C4::Biblio::get_biblio_authorised_values()
C4::XSLT::XSLTParse4Display()
C4::XSLT::transformMARCXML4XSLT (internal)

These functions previously fetched the bib from the
database, incurring the cost of DB retrieval and MARCXML
parsing even though client code already had a
MARC::Record object available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2126: reduce round-off errors in fine balance
Galen Charlton [Thu, 12 Feb 2009 20:20:43 +0000 (14:20 -0600)]
bug 2126: reduce round-off errors in fine balance

If a patron has a number of fine transactions, the
total could be wrong.  This is particularly noticeable
when a patron has a zero balance, as summing a group
of floating point values derived from decimal(6,2) columns
can result a scalar value that is not zero.

Koha really should be using integral arithmetic
or appropriate accounting modules to do fine and
acquisitions calculations.  Using floating point scalars
for monetary amounts is always a mistake.

This patch also prevents an account maintenance
fee from being applied when renewing a patron if the
amount would be 0.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdded empty item call number test to copies for reserve; added ending punctuation...
Daniel Sweeney [Wed, 4 Feb 2009 16:46:25 +0000 (10:46 -0600)]
Added empty item call number test to copies for reserve; added ending punctuation to availability statuses.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixes to two issues with status display on OPAC:
Joshua Ferraro [Wed, 4 Feb 2009 16:46:24 +0000 (10:46 -0600)]
Fixes to two issues with status display on OPAC:

1. rather than testing for notforloan == -1, test for any negative values to set the On order status
2. in cases where itemcallnumber is blank or null, don't display the itemcallnumber brackets []

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDisplays the itemcallnumber in brackets next to location in XSL Results
Joshua Ferraro [Wed, 4 Feb 2009 16:46:21 +0000 (10:46 -0600)]
Displays the itemcallnumber in brackets next to location in XSL Results

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDistinguish between items marked 'not for loan' and 'Available'
Joshua Ferraro [Wed, 4 Feb 2009 16:46:23 +0000 (10:46 -0600)]
Distinguish between items marked 'not for loan' and 'Available'

This patch works with XSL* sysprefs == ON, a future patch will address XSL sysprefs==OFF

Items with notforloan set to a negative number still designate an 'ordered' status

Some items are marked 'not for loan' by setting that value at the item level, others by assigning
that value to that item's itemtype. This patch works for both scenarios.

Specific changes this patch introduces to the OPAC:

* Adds a new OPAC results page key 'Copies available for reference:'
* Changes 'Copies available at:' to 'Copies available for loan:'
* Changes the availability limit label in opac-advsearch from:
    'Only items currently available' to 'Only items currently
available for loan or reference
* Displays the authorised value for the specific notforloan value in the OPAC detail page in
parentheses next to 'Not for Loan'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding warnings to request/ files
Joshua Ferraro [Wed, 4 Feb 2009 16:46:22 +0000 (10:46 -0600)]
Adding warnings to request/ files

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoholds policies fixes
Galen Charlton [Fri, 30 Jan 2009 21:21:29 +0000 (15:21 -0600)]
holds policies fixes

* use item branch instead of patron's branch to
look up the applicable hold policies - this makes
requesting in the OPAC consistent with the intranet.
* when generating pick list using build_holds_queue.pl, only match items
to patrons if request is allowed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2940 - private shelf (list) display error on 2nd and subsequent pages.
Joe Atzberger [Mon, 2 Feb 2009 20:36:19 +0000 (14:36 -0600)]
Bug 2940 - private shelf (list) display error on 2nd and subsequent pages.

The before/after URL for the 2nd page of list elements:
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-shelves.pl?display=privateshelves?viewshelf=120&itemoff=2
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-shelves.pl?viewshelf=120&display=privateshelves&itemoff=2

The change in query string arguments is incidental, the prevention of multiple "?" is essential.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoGetMarcFromKohaField needs 2 args, or there's no point.
Joe Atzberger [Wed, 4 Feb 2009 21:55:49 +0000 (15:55 -0600)]
GetMarcFromKohaField needs 2 args, or there's no point.

GetMarcFromKohaField returns (0,0) without the $frameworkcode argument.
Note the argument can be "", but it must not be undefined.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAvoid XSLT stylesheet building for each biblio record to transform
Frederic Demians [Thu, 5 Feb 2009 07:26:13 +0000 (08:26 +0100)]
Avoid XSLT stylesheet building for each biblio record to transform

In XSLT.pm, put XSLT stylesheet object in a session variable in order
to avoid to build it for each biblio to parse: useful on search
result page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdated INSTALL.debian and debian.packages for new dependencies
J. David Bavousett [Thu, 5 Feb 2009 21:27:30 +0000 (15:27 -0600)]
Updated INSTALL.debian and debian.packages for new dependencies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agotweak Inventory tool and sub in C4/Items so call number min and max are not required
Michael Hafen [Tue, 3 Feb 2009 23:46:25 +0000 (16:46 -0700)]
tweak Inventory tool and sub in C4/Items so call number min and max are not required

This changes the setting if default values in the inventory tool where
the min and max call number are concerned.  Also changes how the query
is formed in C4/Items so that these two are not required.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 356: removed redundant interface
John Beppu [Thu, 5 Feb 2009 22:36:22 +0000 (16:36 -0600)]
bug 356: removed redundant interface

The messaging tab already provided a way to configure these
notifications, so this isn't needed.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2911: popup calendar not available in IE
Owen Leonard [Sat, 7 Feb 2009 20:39:18 +0000 (14:39 -0600)]
Fix for Bug 2911: popup calendar not available in IE

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremove editor settings
Galen Charlton [Wed, 4 Feb 2009 20:47:10 +0000 (14:47 -0600)]
remove editor settings

Me, I use ed(1) for everything...

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoreconciled DB revs: now at 013
Galen Charlton [Wed, 4 Feb 2009 20:19:51 +0000 (14:19 -0600)]
reconciled DB revs: now at 013

15 years agobug 341: Use the Right Branch
John Beppu [Tue, 3 Feb 2009 22:02:14 +0000 (16:02 -0600)]
bug 341: Use the Right Branch

When sending circulation alerts, use the branch that the
event happened on instead of $item->{homebranch}.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 324: Setting to_address
John Beppu [Tue, 3 Feb 2009 22:02:13 +0000 (16:02 -0600)]
bug 324: Setting to_address

- Enqueue the messages with a to_address.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 323: Item Circulation Alerts UI Fixes
John Beppu [Tue, 3 Feb 2009 22:02:12 +0000 (16:02 -0600)]
bug 323: Item Circulation Alerts UI Fixes

- fixed cross browser issues.  (IE and Safari don't let you say
  someobject.class, presumably because "class" is a keyword that's reserved
  for future versions of JS.  Firefox and Opera allow it.)

- added text to the grid for added clarity.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago[Checkout Slips Part 3 14/16] SQL
John Beppu [Tue, 3 Feb 2009 22:02:11 +0000 (16:02 -0600)]
[Checkout Slips Part 3 14/16] SQL

- fixed syntax errors (thanks Dan)
- made sample_notices.sql mandatory

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTests for New Modules
John Beppu [Tue, 3 Feb 2009 22:02:10 +0000 (16:02 -0600)]
Tests for New Modules

- KohaTest::Category
- KohaTest::ItemCirculationAlertPreference
- KohaTest::ItemType
- KohaTest::Message

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPerl Modules
John Beppu [Tue, 3 Feb 2009 22:02:09 +0000 (16:02 -0600)]
Perl Modules

- C4::Letters:EnqueueLetter() is aware of new fields in message_queue table
- C4::Circulation::SendCirculationAlert() actually works
- C4::Category cleanup
- C4::ItemType cleanup
- C4::Message is a new module.
  It presents yet another way to interact with the message_queue.
  You can now take messages that have already been queued and modify
  their contents before they're sent out.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBrand New UI for Alert Configuration
John Beppu [Tue, 3 Feb 2009 22:02:08 +0000 (16:02 -0600)]
Brand New UI for Alert Configuration

- grid layout (javascript required now)
- makes distinction between checkin and checkout messages
- no longer have to click on a button to submit the branch selection form

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemoved RSS Option from UI
John Beppu [Tue, 3 Feb 2009 22:02:07 +0000 (16:02 -0600)]
Removed RSS Option from UI

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRevised Schema
John Beppu [Tue, 3 Feb 2009 22:02:06 +0000 (16:02 -0600)]
Revised Schema

- removed 'rss' transport
- made the messages non-digest
- updated the default text of the templates in the letters table
- [table] item_circulation_alert_preferences
  - added notification column
  - removed is_enabled column
- [table] message_queue
  - added metadata column
  - added letter_code column

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agowhitespace cleanup
John Beppu [Tue, 3 Feb 2009 22:02:05 +0000 (16:02 -0600)]
whitespace cleanup

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSending Circulation Alerts part 1
John Beppu [Tue, 3 Feb 2009 22:02:04 +0000 (16:02 -0600)]
Sending Circulation Alerts part 1

- Added code to AddIssue to send an alert when appropriate.
- Added code to AddReturn to send an alert when appropriate.
- Added a sub called SendCirculationAlert() that DOESN'T ACTUALLY WORK YET.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew C4 Modules
John Beppu [Tue, 3 Feb 2009 22:02:03 +0000 (16:02 -0600)]
New C4 Modules

* C4::Category
  - patron categories as objects
  - an all() method to return all the categories as a list
* C4::ItemType
  - itemtypes as objects
  - an all() method to return all the item types as a list
* C4::ItemCirculationAlertPreference
  - wrapper around the item_circulation_alert_preference table
  - create() and delete() methods for easy manipulation of the preferences
  - I regret giving it such a long name.
  - The item_type column should've been named itemtype to make it
    more similar to pre-existing tables.  Oh well.

(C4::Category and C4::ItemType were made so that I wouldn't have to
write SQL inside my CGI scripts.
Their main purpose is to provide an easy way to get a list of
patron categories and item types.
Do not be fooled by the amount of POD.
There's actually very little code in these modules.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBranch Level Notification Config
John Beppu [Tue, 3 Feb 2009 22:02:02 +0000 (16:02 -0600)]
Branch Level Notification Config

- This will allow admins to disable notifications for any combination of
  branch, patron category, and item_type.
- Still working on this...

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPOD for C4::Members::Messaging
John Beppu [Tue, 3 Feb 2009 22:01:59 +0000 (16:01 -0600)]
POD for C4::Members::Messaging

- fixed typos and formatting.
- added notes on how to add new kinds of messages.
- added notes on the tables being used.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMessaging Preferences for Intranet
John Beppu [Tue, 3 Feb 2009 22:02:00 +0000 (16:02 -0600)]
Messaging Preferences for Intranet

- Added ability to modify per-user messaging preferences.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMessaging Preferences for OPAC
John Beppu [Tue, 3 Feb 2009 22:02:01 +0000 (16:02 -0600)]
Messaging Preferences for OPAC

- Added ability to request a messaging config change.
  (Apparently, users aren't allowed to directly change these settings.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSchema Changes for Email Checkout Slips
John Beppu [Tue, 3 Feb 2009 22:01:58 +0000 (16:01 -0600)]
Schema Changes for Email Checkout Slips

- new table, item_circulation_alert_preferences
- new data:
  - letter -- 2 new templates
  - message_transport_types -- feed
  - message_attributes -- Item Check-in and Item Checkout
  - message_transports -- for each attribute and for each transport_type...

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoShowing totals for charges and replacement costs on patron detail screen and print...
Owen Leonard [Tue, 3 Feb 2009 20:59:55 +0000 (14:59 -0600)]
Showing totals for charges and replacement costs on patron detail screen and print view.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMove opaclanguagesdisplay to I18N/L10N tab where opaclanguages pref is.
Owen Leonard [Tue, 3 Feb 2009 21:00:06 +0000 (15:00 -0600)]
Move opaclanguagesdisplay to I18N/L10N tab where opaclanguages pref is.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2938)[follow previous] Add new report in menus
Nahuel ANGELINETTI [Mon, 2 Feb 2009 08:28:27 +0000 (09:28 +0100)]
(bug #2938)[follow previous] Add new report in menus

Just adding the new report in miscellaneous menus

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2938) add a serials subscriptions report
Nahuel ANGELINETTI [Fri, 30 Jan 2009 16:20:26 +0000 (17:20 +0100)]
(bug #2938) add a serials subscriptions report

this patch add a report for serials.
It's have to limit branch/bookseller, and excluding expired serials.
It's possible to export in CSV format.
This patch will have another, to add this report in menus.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixes SQL typo and return value in GetImportBatchStatus()
Mason James [Mon, 2 Feb 2009 12:33:21 +0000 (01:33 +1300)]
fixes SQL typo and return value in GetImportBatchStatus()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPrevent js failure if syspref "gist" is undefined.
Joe Atzberger [Wed, 21 Jan 2009 01:18:22 +0000 (19:18 -0600)]
Prevent js failure if syspref "gist" is undefined.

The javascript is malformed and therefore fails the onsubmit check if
gist does not receive a value.  This patch allows failover to default 0.
Also removed an unused dbh.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor rework of template js.
Joe Atzberger [Wed, 21 Jan 2009 01:18:25 +0000 (19:18 -0600)]
Minor rework of template js.

Lines explicitly ended with semicolons.  Allow some better behavior if TMPL_VAR's
are undefined or zero.

Note FIXME added.  I believe this is part of the fragmentary integration of
Katipo code for GST.  Would be obliged if someone with access there can confirm.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2870, fixes non-populating of guarantor fields
Mason James [Wed, 28 Jan 2009 12:28:52 +0000 (01:28 +1300)]
bug 2870, fixes non-populating of guarantor fields

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDelete a "=" added lastly and make this script not working
Nahuel ANGELINETTI [Wed, 28 Jan 2009 13:57:18 +0000 (14:57 +0100)]
Delete a "=" added lastly and make this script not working

It seems no one use this script, because it cannot work.
This patch delete a "=".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup and perltidy.
Joe Atzberger [Wed, 28 Jan 2009 19:25:48 +0000 (13:25 -0600)]
Cleanup and perltidy.

Add "use warnings", remove unused variables and unnecessary finish/disconnect
at the end.  This script could be improved to run only on tables that need to
be altered instead of touching all of them.  It should also probably contain
warnings to the effect that it does not rescue your DATA that was forced into
whatever encoding the table used previously.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoObsolete harness for tests, replaced by make and other test structures.
Joe Atzberger [Wed, 28 Jan 2009 19:39:43 +0000 (13:39 -0600)]
Obsolete harness for tests, replaced by make and other test structures.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoholds policy followup - fix column definition
Galen Charlton [Thu, 15 Jan 2009 21:26:20 +0000 (15:26 -0600)]
holds policy followup - fix column definition

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to holds policies - fix itype
Galen Charlton [Thu, 15 Jan 2009 21:26:18 +0000 (15:26 -0600)]
followup to holds policies - fix itype

Overriding items.itype from biblioitems.itemtype
is needed only with item-level_itypes is OFF.

[LL bug 321]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrected several typos that caused the installer to fail when creating the Koha...
Daniel Sweeney [Thu, 15 Jan 2009 21:26:19 +0000 (15:26 -0600)]
Corrected several typos that caused the installer to fail when creating the Koha schema.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobump DB rev 011 -> 012
Galen Charlton [Thu, 15 Jan 2009 21:26:16 +0000 (15:26 -0600)]
bump DB rev 011 -> 012

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agolanguage fix: "branch" => "library"
Galen Charlton [Thu, 15 Jan 2009 21:26:17 +0000 (15:26 -0600)]
language fix: "branch" => "library"

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDatabase updates for hold policies
Jesse Weaver [Thu, 15 Jan 2009 21:26:15 +0000 (15:26 -0600)]
Database updates for hold policies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDatabase changes and new sysprefs for holds policies
Jesse Weaver [Thu, 15 Jan 2009 21:26:14 +0000 (15:26 -0600)]
Database changes and new sysprefs for holds policies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd holds policies
Jesse Weaver [Thu, 15 Jan 2009 21:26:13 +0000 (15:26 -0600)]
Add holds policies

This adds holds policy creation support to smart rules and read support to
C4/Circulation.pm, and the two reservation pages. It also adds a system
preference, AllowHoldPolicyOverride, to control whether the staff can override
these policies.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUnescape some double quotes, that make a validation error.
Nahuel ANGELINETTI [Wed, 7 Jan 2009 15:23:14 +0000 (16:23 +0100)]
Unescape some double quotes, that make a validation error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRelated to earlier patch: adding body id to add flexibility to CSS customizations.
Owen Leonard [Fri, 9 Jan 2009 02:03:53 +0000 (20:03 -0600)]
Related to earlier patch: adding body id to add flexibility to CSS customizations.

This patch adds a different id to opac-shelves, opac-suggestions, and opac-tags based on whether or not the user is logged in, allowing for changes to style based on logged-in status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2908 followup - use "list", not "shelf"
Galen Charlton [Mon, 12 Jan 2009 22:16:47 +0000 (16:16 -0600)]
bug 2908 followup - use "list", not "shelf"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2909) fix the attachment base64 encoding
Nahuel ANGELINETTI [Mon, 12 Jan 2009 09:45:53 +0000 (10:45 +0100)]
(bug #2909) fix the attachment base64 encoding

this patch change the attachment encoding, else if the file is too large, koha throws an error.
This solution was found on koha list in a Joshua's e-mail

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2908) adding send shelf by e-mail feature
Nahuel ANGELINETTI [Mon, 12 Jan 2009 09:36:31 +0000 (10:36 +0100)]
(bug #2908) adding send shelf by e-mail feature

This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobump DB rev 010 -> 011
Galen Charlton [Mon, 12 Jan 2009 21:16:58 +0000 (15:16 -0600)]
bump DB rev 010 -> 011

15 years agoBug 2578: remove unwanted intranetuserjs syspref - Database revision 3.01.00.011
Andrew Moore [Mon, 29 Dec 2008 19:37:24 +0000 (13:37 -0600)]
Bug 2578: remove unwanted intranetuserjs syspref - Database revision 3.01.00.011

The default syspref setting for intranetuserjs should be empty. At one
time, an unwanted value accidently got put in there. This removes the
syspref only if it equals the unwanted value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2687 followup: Increase maxlength attribute to support 64 characters
Danny Bouman [Thu, 20 Nov 2008 14:35:26 +0000 (09:35 -0500)]
bug 2687 followup: Increase maxlength attribute to support 64 characters

Modified the borrower attribute and borrower password fields to support a maxlength of 64 characters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>