Owen Leonard [Fri, 12 Nov 2010 22:03:42 +0000 (23:03 +0100)]
Fix for Bug 5175, XSL view doesn't link publisher name to search
Fixes the doubled up display of the publisher.
This patch fixes the bug in both the OPAC and staff client
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Fri, 12 Nov 2010 20:58:00 +0000 (21:58 +0100)]
Fix for Bug 5210, back button on batch modification result page useless
I can't see any good use for a back button here, so I'm taking it out.
An improvement might be to build in a method to resubmit the same batch
of barcodes/item numbers again so that you could make additional
changes to the same set.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 14 Nov 2010 09:27:33 +0000 (22:27 +1300)]
Merge remote branch 'kc/new/bug_5381' into kcmaster
Chris Nighswonger [Fri, 12 Nov 2010 15:30:45 +0000 (16:30 +0100)]
Bug 5381 - Fines in notices prints always 0.00
This was due to passing off the biblionumber to GetFines rather than the itemnumber.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 13 Nov 2010 20:00:22 +0000 (15:00 -0500)]
Additional fix for Bug 4423 - Staff Client XSLT is just a copy of the OPAC one
- Adding "Lists that include this title" links
- Also correcting minor XHTML error in the same section of opac-detail.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sat, 13 Nov 2010 20:42:23 +0000 (09:42 +1300)]
Merge remote branch 'kc/new/bug_4498' into kcmaster
Galen Charlton [Sat, 13 Nov 2010 14:36:15 +0000 (09:36 -0500)]
bug 5400: new test case to find files with merge conflict markers
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Tue, 7 Sep 2010 13:48:03 +0000 (15:48 +0200)]
Fix for Bug 4498 - Acq always shows '1 suggestions waiting'
- Removing 'suggestions waiting' link from left-hand menu. A plain
'suggestions' link is still shown if suggestions are enabled.
- Putting back the 'pending suggestions' box that used to appear
on the Acquisitions home page. This will show, with a count
of pending suggestions, only if suggestions are turned on and
there are pending suggestions.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sat, 13 Nov 2010 16:40:55 +0000 (05:40 +1300)]
Removing merge commit
Galen Charlton [Sat, 13 Nov 2010 03:41:32 +0000 (22:41 -0500)]
bug 4359: make other pages in the OPAC respect noItemTypeImages
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Sat, 13 Nov 2010 03:41:31 +0000 (22:41 -0500)]
bug 4359 follow-up: noItemTypeImages should just control image display
Tweaked so that the item type column is always displayed in the
checkout history in the OPAC; noItemTypeImages now just controls
whether the icon displays.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 13 Nov 2010 03:41:30 +0000 (22:41 -0500)]
Fix for Bug 4359, noItemTypeImages not active in OPAC
- Auth.pm put the noItemTypeImages preference under "intranet only."
Moved it to "OPAC or intranet."
- Added check for the preference on the OPAC advanced search page.
- Improved logic for displaying images on the reading history page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Fri, 12 Nov 2010 20:54:50 +0000 (15:54 -0500)]
Bug 5396: New system preference UseTablesortForCirc
This system preference allows the librarian to toggle on or off whether the JQuery tablesort is used on the
circ/circulation.pl page. For patrons with many checkouts, this sort may cause very slow page loading (and
therefore slow circulation transaction time), depending on the browser and local machine used. Staff can
still see a sortable list of current checkouts on the members/moremember.pl page.
My revision prevents the template from including *any* tablesorter code if the
preference is feature is turned off: both the circulation list and
the holds list will have no jQuery tablesorter.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 13 Nov 2010 04:16:56 +0000 (23:16 -0500)]
Fix for Bug 3271, Missing message when adding to a list with no items selected
There is no visible Lists button to "attach" our warning to
as there is in the OPAC, so warning message is displayed via
a javascript alert.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 13 Nov 2010 04:28:00 +0000 (23:28 -0500)]
Partial fix for Bug 4924, Public/Internal notes missing in staff normal view
This fix adds only public notes. A div is added as a hook for styling
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 13 Nov 2010 04:33:54 +0000 (23:33 -0500)]
Fix for Bug 4933, Link to subfield's edit tab from subfield structure admin
- Also corrects framework display in the case of the default
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Fri, 12 Nov 2010 14:10:37 +0000 (15:10 +0100)]
bug 5393 [SIGNED-OFF]: add test case to check well-formedness of XML/XSLT files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Fri, 12 Nov 2010 22:33:45 +0000 (11:33 +1300)]
Merge remote branch 'kc/new/bug_5059' into kcmaster
Chris Cormack [Fri, 12 Nov 2010 22:33:41 +0000 (11:33 +1300)]
Merge remote branch 'kc/new/bug_5058' into kcmaster
Katrin Fischer [Fri, 12 Nov 2010 20:41:51 +0000 (15:41 -0500)]
Bug 5059: Inconsistent use of ordering price and list price in vendor form
Changes Ordering price to List price and make spelling more consistent.
Patch originally send for 3.2, still applied to HEAD without conflicts.
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Fri, 12 Nov 2010 20:24:04 +0000 (15:24 -0500)]
BUG 5058: small layout correction of vendor form
Rebased to HEAD, should also apply to 3.2
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Fri, 12 Nov 2010 17:47:45 +0000 (06:47 +1300)]
Merge remote branch 'kc/new/bug_4979' into kcmaster
Chris Cormack [Fri, 12 Nov 2010 17:47:26 +0000 (06:47 +1300)]
Merge remote branch 'kc/new/bug_5392' into kcmaster
Colin Campbell [Fri, 12 Nov 2010 12:35:47 +0000 (07:35 -0500)]
Bug 5392 Initialize vars used in building url strings
If no failures are to be added to the to the strings for redirect
the corresponding variables are undefined causing warnings
to be logged. Initialize them so that the error log is not
being filled with trivia.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Fri, 12 Nov 2010 12:35:46 +0000 (07:35 -0500)]
Bug 4305: Add test case for ISBN-13 to ISBN-10 conversion
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Fri, 12 Nov 2010 12:35:45 +0000 (07:35 -0500)]
Bug 4979: Acq: input fields for new record are too short
Patch rebased to HEAD, should also apply to 3.2
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Thu, 11 Nov 2010 15:26:16 +0000 (10:26 -0500)]
bug 5389: mark Business::ISBN as a required dependency
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 11 Nov 2010 21:47:38 +0000 (10:47 +1300)]
Merge remote branch 'kc/new/bug_4305' into kcmaster
Chris Cormack [Thu, 11 Nov 2010 21:38:42 +0000 (10:38 +1300)]
Bug 5385 - Fixing an error that crept in with the POD cleanup
Chris Cormack [Thu, 11 Nov 2010 21:38:42 +0000 (10:38 +1300)]
Bug 5385 - Fixing an error that crept in with the POD cleanup
Galen Charlton [Thu, 11 Nov 2010 14:43:47 +0000 (09:43 -0500)]
bug 4305: add a couple test cases for _isbn_cleanup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Thu, 11 Nov 2010 14:02:13 +0000 (09:02 -0500)]
Bug 4305 Improve code flow
Use the ISBN Object's method to format the string
rather than add extra code to do it
Clean up the code flow for clarity
Benchmarking shows its a bit faster too
Don't add to the number of Test::Perl::Critic warnings
for no benefit
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Andrew Elwell [Thu, 11 Nov 2010 13:18:47 +0000 (08:18 -0500)]
Bug 5385: POD Cleanups (part 2)
More podchecker cleanups to eliminate warnings / errors
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Andrew Elwell [Thu, 11 Nov 2010 13:18:46 +0000 (08:18 -0500)]
Bug 5385: POD Cleanups (part 1)
working through the master branch to eliminate all
podchecker warnings/errors
Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 11 Nov 2010 12:39:32 +0000 (07:39 -0500)]
Bug 5112: Organisation does not show links to professionals
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 11 Nov 2010 17:41:25 +0000 (06:41 +1300)]
Merge remote branch 'kc/new/bug_5386' into kcmaster
Galen Charlton [Thu, 11 Nov 2010 13:30:13 +0000 (08:30 -0500)]
bug 5386: remove dep on Path::Class from t/00-load.t
File::Spec is a core module, Path::Class isn't; not yet
worth adding a new dependency.
Also some minor whitepace cleanup.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 11 Nov 2010 08:33:48 +0000 (21:33 +1300)]
Merge remote branch 'kc/new/bug_5105' into kcmaster
Frédéric Demians [Thu, 11 Nov 2010 08:11:00 +0000 (09:11 +0100)]
Bug 5105 Regression test for switch statement
Add a test identifying Perl scripts and modules using switch statements.
This test file follow Chris pre-hook naming convention in order to be
triggered for patch submissions.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 11 Nov 2010 08:06:00 +0000 (09:06 +0100)]
Test modules compile
Script to test modules compile, when used with a pre-commit hook this
can test before a commit
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 10 Nov 2010 22:33:10 +0000 (11:33 +1300)]
Merge remote branch 'kc/master' into new/bug_5105
Conflict fixed
Conflicts:
opac/opac-detail.pl
Colin Campbell [Wed, 8 Sep 2010 13:16:32 +0000 (14:16 +0100)]
Bug 5105 - Remove use of depreciated Switch module
Use of switch generates errors in perl 12 and above
Replaced uses of the Switch module by if- else constructs
Removed some mixed space+tab indentation around these where
it generated visual confusion
As of perl 10 you can use given/when constructs but this is not
supported in earlier perls.
Frédéric Demians [Wed, 10 Nov 2010 22:00:54 +0000 (23:00 +0100)]
Fix bug on opac-detail.pl with switch statement
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Wed, 10 Nov 2010 13:45:33 +0000 (08:45 -0500)]
Bug 5003: Can not search for organisation by name
Rebased to current HEAD, small error fixed.
Should also apply to 3.2
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 10 Nov 2010 05:09:37 +0000 (00:09 -0500)]
bug 5380: remove copy-and-paste from authorities/detail.pl
MARC editor code not needed here.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 10 Nov 2010 04:48:33 +0000 (23:48 -0500)]
bug 5372: identify empty field in authority record correctly
This is the sibling to the fix for this bug for the bib
editor. However, note that this change won't have a
direct effect yet, as currently you can't specify a
default value for a field or subfield in the authority
MARC frameworks. See bug 4887.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 8 Nov 2010 23:01:02 +0000 (12:01 +1300)]
Ukranian and Russian syspref language updates
Chris Cormack [Mon, 8 Nov 2010 23:00:40 +0000 (12:00 +1300)]
Russian and Ukranian opac language updates
Chris Cormack [Mon, 8 Nov 2010 22:59:41 +0000 (11:59 +1300)]
Staff interface .po file updates
Chris Cormack [Mon, 8 Nov 2010 21:49:01 +0000 (10:49 +1300)]
Merge remote branch 'kc/new/bug_5370' into kcmaster
Katrin Fischer [Mon, 8 Nov 2010 20:52:32 +0000 (21:52 +0100)]
Bug 5370: Fix all references to koha.org
Thx to Brooke for helping with the wiki.
This is the last patch.
We will have to change some more links, after translate.koha.org was moved.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 8 Nov 2010 06:42:41 +0000 (19:42 +1300)]
Merge branch 'trivial_bugs' of git://git.koha-community.org/wip/koha-fbc into kcmaster
Marcel de Rooy [Thu, 4 Nov 2010 11:38:45 +0000 (11:38 +0000)]
Bug 4515 (Few very small errors in opac-search.pl) RESENT fixing whitespace warning
Loop on results should stop before $i==@servers. Adding fix for warnings on undefined values in comparison for lines 485, 488 and 510.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédéric Demians [Wed, 3 Nov 2010 17:38:35 +0000 (18:38 +0100)]
Bug 4472 Apply it to MARC21
For French installation of Koha using MARC21, the same issues as UNIMARC
affects handling of by translation scripts.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 8 Nov 2010 02:31:49 +0000 (15:31 +1300)]
Merge remote branch 'kc/new/bug_5214' into kcmaster
Owen Leonard [Thu, 28 Oct 2010 14:24:59 +0000 (10:24 -0400)]
Fix for Bug 5214 - undefined itype images cause broken image icon in request.pl
Also fixes the same bug on the Itemtypes administration page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 8 Nov 2010 02:26:37 +0000 (15:26 +1300)]
Merge remote branch 'kc/new/bug_5236' into kcmaster
Galen Charlton [Thu, 28 Oct 2010 13:23:12 +0000 (09:23 -0400)]
bug 5236: remove hidemytags from CSS as well
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Thu, 28 Oct 2010 13:05:21 +0000 (09:05 -0400)]
bug 5219: tidy cleanup_database.pl
Includes a bit of cleanup of the enhancement patch
for bug 5074 - adding comments about old and new
behavior isn't necessary for such small changes.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 7 Nov 2010 20:42:52 +0000 (09:42 +1300)]
Merge remote branch 'kc/new/bug_5370' into kcmaster
Katrin Fischer [Sun, 7 Nov 2010 10:59:00 +0000 (11:59 +0100)]
Bug 5370: Fix all the references to koha.org
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Sun, 7 Nov 2010 07:42:49 +0000 (08:42 +0100)]
Bug 5370: Fix all references to koha.org
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 7 Nov 2010 20:31:28 +0000 (09:31 +1300)]
Merge branch '5370_koha.org' of git://github.com/kfischer/Koha into new/bug_5370
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédéric Demians [Sun, 7 Nov 2010 13:33:36 +0000 (14:33 +0100)]
Bug 5372 (v2) Existing value can be replace by default value
The way an existing value was tested was wrong. 0 is a valid value but a
false value for Perl.
=> replace privious proposal.
[3.2] Should also apply.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Sun, 7 Nov 2010 06:10:06 +0000 (07:10 +0100)]
Bug 5370: Fix references to koha.org and other old websites
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Sun, 7 Nov 2010 06:10:06 +0000 (07:10 +0100)]
Bug 5370: Fix references to koha.org and other old websites
Chris Nighswonger [Sat, 6 Nov 2010 06:56:01 +0000 (01:56 -0500)]
Adding 3.2 Release Maintainer to Release Team List
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédéric Demians [Fri, 5 Nov 2010 11:23:08 +0000 (12:23 +0100)]
Bug 5368 Browse Shelf link appears when no itemcallnumber
Suppress Browse Shelf link on OPAC detail page when there is no item
call number.
[3.2] Should also apply on 3.2
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nahuel ANGELINETTI [Fri, 5 Nov 2010 13:13:21 +0000 (09:13 -0400)]
(MT 2985) simplify CanBookBeReserved
The function was too complex for so simple stuff, not we check if one of all items of the record can be issued.
[Note by Galen Charlton: not only does this patch simplify the routine,
it also makes it behave correctly.]
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 4 Nov 2010 19:02:34 +0000 (08:02 +1300)]
Merge remote branch 'kc/new/bug_5227' into kcmaster
Chris Nighswonger [Thu, 4 Nov 2010 18:14:10 +0000 (14:14 -0400)]
Fixing up a regexp to stop a trivial warn
Chris Cormack [Thu, 4 Nov 2010 07:14:28 +0000 (20:14 +1300)]
Merge remote branch 'kc/new/signoffs' into kcmaster
Conflicts:
installer/data/mysql/updatedatabase.pl
Updated updatedatabase.pl to handle new version number
Chris Cormack [Wed, 3 Nov 2010 20:31:03 +0000 (16:31 -0400)]
Bug 5363 - Removing unused module (C4::Cache::FastMemcached)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 3 Nov 2010 17:49:00 +0000 (13:49 -0400)]
bug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x
Note that OPACXSLTResultsDisplay and OPACXSLTDetailsDisplay
are boolean parameters in 3.2.x, not string parameters.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 3 Nov 2010 17:28:24 +0000 (06:28 +1300)]
Updating version number and fixing the xxx in updatedatabase ... my bad
Chris Cormack [Wed, 3 Nov 2010 08:21:02 +0000 (21:21 +1300)]
Merge remote branch 'kc/new/bug2567' into kcmaster
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 3 Nov 2010 03:52:21 +0000 (16:52 +1300)]
Merge remote branch 'kc/new/bug_5308' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 01:58:40 +0000 (14:58 +1300)]
Merge remote branch 'kc/new/merge_help' into kcmaster
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 3 Nov 2010 01:48:37 +0000 (14:48 +1300)]
Merge remote branch 'kc/new/bug_4991' into kcmaster
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Tue, 2 Nov 2010 17:54:50 +0000 (06:54 +1300)]
Merge remote branch 'kc/new/bug_5301' into kcmaster
dev2 [Fri, 29 Oct 2010 11:53:34 +0000 (07:53 -0400)]
Bug 5192 Enhancement to add new index for 658 curriculum field
Creates new curriculum index for 658 subfields a,b,c and search option in Advanced search (under More Options). Also modifies the installer files to make 658abc display (they were hidden in the frameworks) and to create the new indexes.
The 658 already displays as part of the staff/OPAC subject display line.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Thu, 28 Oct 2010 12:09:47 +0000 (08:09 -0400)]
bug 5243: avoid crash when saving authority records on certain setups
This does not seem to occur on all platforms - C4::Search
exports SimpleSearch() by default - but adding the 'C4::Search::'
qualifier certainly doesn't hurt things.
Patch by Fridolyn Somers <fridolyn.somers@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Tue, 2 Nov 2010 02:09:10 +0000 (22:09 -0400)]
bug 5149: follow-up - remove extraneous character in link
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nicole Engard [Tue, 2 Nov 2010 02:09:09 +0000 (22:09 -0400)]
bug 5149 fix broken link to noItemTypeImages preference
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nicole Engard [Sat, 30 Oct 2010 20:29:24 +0000 (16:29 -0400)]
bug 5110 move NewItemsDefaultLocation to cataloging tab
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 30 Oct 2010 20:25:19 +0000 (16:25 -0400)]
Fix for Bug 4963, sys prefs need date hints and/or picker
This patch adds the standard date format hint used elsewhere
in the interface.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
ByWater Solutions [Sat, 30 Oct 2010 13:50:29 +0000 (09:50 -0400)]
Bug 4254 - adding new patron advanced notice doesn't save
This was due to poorly constructed SQL which returned duplicate values for
certain fields. This patch corrects that SQL.
NOTE: There is also a formatting problem with the message prefs display table
when it is displayed in moremember.pl. This is due to there being no logic to
tell the table in that context to display checkboxes as appropriate. This patch
does not fix that. Bug 5328 has been opened for this problem.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 30 Oct 2010 05:52:50 +0000 (01:52 -0400)]
Fix for Bug 5082 - Not translatable name of default framework 'Default' in MARCdetail.tmpl
This patch also fixes an unreported bug where switching from any
other framework to 'Default' would bring up no MARC data.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 30 Oct 2010 05:52:49 +0000 (01:52 -0400)]
Fix for Bug 4980 - Acq: pull down 'Restrict access to:' for funds not translatable
Applied Owen's patch to current head, updated de-DE translation. The pull down values are now translated.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 30 Oct 2010 05:52:48 +0000 (01:52 -0400)]
Fix for Bug 5142, Untranslatable strings in tag review template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 30 Oct 2010 05:52:47 +0000 (01:52 -0400)]
Fix for Bug 5056, Untranslatable strings in members.js
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 30 Oct 2010 05:36:57 +0000 (01:36 -0400)]
Fix for Bug 5136, Replace SQL with call to GetAuthorisedValues
An embedded query in circulation.pl for BOR_NOTES authorized
values can be replaced with a call to GetAuthorisedValues
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 30 Oct 2010 05:33:42 +0000 (01:33 -0400)]
Fix for Bug 5135 - Authorized value input maxlength should match table column
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Sat, 30 Oct 2010 04:40:15 +0000 (00:40 -0400)]
bug 4991: follow-up tweaks
* make some strings translatable
* display library name instead of code in add/edit
holiday panel
* minor textual fixes to hints
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Mon, 12 Jul 2010 20:41:28 +0000 (16:41 -0400)]
Fix for Bug 4991, Overhaul of Calendar interface
- Put hints, key, and existing holidays into right column
- Style entry form for added clarity and consistency with other
forms in Koha
- Change the way dynamically displayed hints are shown to better
match existing static hints in Koha's interface
- Add branch name (instead of branch code) for clarity
- Add the ability to add and edit holiday titles (previously
only description could be edited).
- Add links to the list of existing single-day holidays and
exceptions which opens the calendar to that month/year
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Sat, 30 Oct 2010 04:48:19 +0000 (00:48 -0400)]
bug 5171 change 'edit items' to read 'edit item' when next to 1 item
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nicole Engard [Sat, 30 Oct 2010 04:48:18 +0000 (00:48 -0400)]
bug 5168 change link text from holdings to items
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared CAMINS-ESAKOV [Sat, 30 Oct 2010 03:49:15 +0000 (23:49 -0400)]
Fix bug 3811; Index language as word
An incorrect definition in record.abs was resulting in searches on languages returning incorrect results. By changing the indexing mode from numeric to word, this patch fixes that problem.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Sat, 30 Oct 2010 03:49:14 +0000 (23:49 -0400)]
bug 5311: correction to database update
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared Camins-Esakov [Sat, 30 Oct 2010 03:49:13 +0000 (23:49 -0400)]
Update language mappings to fix Bug 5311
This patch updates the language_rfc4646_to_iso639 mapping table with the
correct mappings for several languages that were not mapped correctly to
the codes used in MARC, including Finnish (which was not mapped at all),
and Armenian (which was mapped to an obsolete code). This patch also
changes English and French to use the proper three-letter codes, which
will eliminate false positives when, for example, limiting by French
brings up results in Afrikaans.
This patch adds the changes to the updatedatabase.pl script, and removes
the incorrectly specified DBversion in the previous patch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>