]> git.koha-community.org Git - koha.git/log
koha.git
16 years agobug 2386: adding newline between items in overdue notices
Andrew Moore [Wed, 23 Jul 2008 18:19:57 +0000 (13:19 -0500)]
bug 2386: adding newline between items in overdue notices

The lines for each item in the overdue notices were not separated by newlines. This cause them to
all be smashed together. I'm putting a newline between them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoUTF-8 to ASCII MAPPINGS -- WARNING: REINDEX REQUIRED
Joshua Ferraro [Wed, 23 Jul 2008 14:49:57 +0000 (09:49 -0500)]
UTF-8 to ASCII MAPPINGS -- WARNING: REINDEX REQUIRED

You've been warned :-). This patch contains a more
complete mapping of UTF-8 to ASCII. The mappings are
based on those compiled by Richard Mahoney on the
Zebra list: http://lists.indexdata.dk/pipermail/zebralist/2007-August/001707.html

Note to documentation team: we need an area in the
documentation that discusses how Koha handles searches
and indexing for words that contain diacritics, such
as E-ACUTE (vs E without an acute). If you can paste
this list of mappings from this patch directly into
the docs and it preserves the encoding that would be
great.

NOTE: I don't think this patch addresses issues of
combining vs non-combining forms, and may require
a refactor to address that.

Josh

16 years agoCorrecting C4::VirtualShelves::ShelfPossibleAction to handle the case where the staff...
Chris Nighswonger [Wed, 23 Jul 2008 04:42:19 +0000 (23:42 -0500)]
Correcting C4::VirtualShelves::ShelfPossibleAction to handle the case where the staff user is the superlibrarian ($user == 0)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrecting bad session var that caused Lists link not to be displayed in anonymous...
Chris Nighswonger [Wed, 23 Jul 2008 04:29:25 +0000 (23:29 -0500)]
Correcting bad session var that caused Lists link not to be displayed in anonymous sessions

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoDB UPDATE : Patron category code was defined incorrectly in overduerules (notice...
Ryan Higgins [Wed, 23 Jul 2008 01:52:16 +0000 (20:52 -0500)]
DB UPDATE : Patron category code was defined incorrectly in overduerules (notice/status triggers) and deletedborrowers.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2374 Corrects autoBarcode behavior in additem.pl
Chris Nighswonger [Tue, 22 Jul 2008 18:43:34 +0000 (13:43 -0500)]
kohabug 2374 Corrects autoBarcode behavior in additem.pl

There should be a documenation change at least for 3.0 to the effect that on systems
not running JavaScript, 'incremental' is the only option available for autoBarcode
although other options appear. A fix for this will hopefully appear in 3.2.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2150 Correcting (somewhat) the inconsistent use of autoBarcode syspref
Chris Nighswonger [Tue, 22 Jul 2008 18:43:33 +0000 (13:43 -0500)]
kohabug 2150 Correcting (somewhat) the inconsistent use of autoBarcode syspref

This patch corrects somewhat the inconsistent use of the autoBarcode syspref in serials-edit.pl
It does not impliment all the possibilities currently available in the autoBarcode syspref as
there is currently no support for the js plug-in/drop-in feature in serials-edit.pl. So in this
sense, the autoBarcode syspref is still used inconsistantly here. The fix for this is recommended
for rel_3_2

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding lastmodified.virtualshelves; Bumping version to 100
Chris Nighswonger [Tue, 22 Jul 2008 18:43:31 +0000 (13:43 -0500)]
Adding lastmodified.virtualshelves; Bumping version to 100

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2159 Improving "Lists" button list refreshes after adding/changing lists...
Chris Nighswonger [Thu, 26 Jun 2008 04:18:07 +0000 (23:18 -0500)]
kohabug 2159 Improving "Lists" button list refreshes after adding/changing lists/shelves

Adding code to refresh "Lists" button lists display in OPAC masthead.inc

Adding javascript to force refresh of parent window to update "Lists" button menu

Adding query limits and ability to specify row count and offset in queries related to Virtualshelves.
Also added the ability to return total record counts for specified virtualshelves.

Adding C4::VirtualShelves::GetRecentShelves which returns a list of the most recently modified shelves for
a given set of parameters. This allows the user to be offered active private and open lists to add books
to in drop down menus while also allowing drop down menus to be limited to a reasonable length.
This also limits the shelves stored in the user's session to a fixed number. A further enhancement might
be to add a syspref to enable a staff member to define the limit. Currently it is hardcoded at 10 per
list type (private/public-open).

Adding pagination to list/shelf related screens

Moving refresh shelves code into C4::VirtualShelves::RefreshShelvesSummary and tidying up a bit

Correcting several inconsistancies in the shelves templates as well as handling shelf management on
the intranet side correctly.

Correcting "Add To:" drop-down list to show only lists the patron has permission to add to

Correcting a few C4::VirtualShelves::GetShelvesSummary API calls

Modifications for template consistancy

Breaking up a 1367 char line of javascript in opac-results.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAllow anyone with superlibrarian permission to edit/delete public patron lists
Chris Nighswonger [Tue, 22 Jul 2008 18:43:30 +0000 (13:43 -0500)]
Allow anyone with superlibrarian permission to edit/delete public patron lists

Edit functions here are limited to renaming and changing the type. No one can view
a list except the list owner unless it is public.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2279: TagsModeration effectiveness restored.
Joe Atzberger [Tue, 22 Jul 2008 01:28:33 +0000 (20:28 -0500)]
Bug 2279: TagsModeration effectiveness restored.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRefine "Patrons statistics" report, fix highlight, remove CGI::scrolling_lists.
Joe Atzberger [Mon, 21 Jul 2008 23:57:45 +0000 (18:57 -0500)]
Refine "Patrons statistics" report, fix highlight, remove CGI::scrolling_lists.

At client request, I added code for a rowtitle_display and coltitle_display.  This
allows the script to substitute human-readable lables into the table instead of just
the literal hashkeys.  For this client with dozens of numerical patron categorycodes
having a row titled "29" was not very useful.

I cleaned up the templates and a lot of the report code.  It is of the same style as
the other copy/paste reports and still need further cleanup.  Added sql and debug
feedback (default styled to hidden), as I have for other reports.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for Bug 2373 ("Tags missing from the left menu"). Also doing some cleanup and...
Owen Leonard [Mon, 21 Jul 2008 16:23:12 +0000 (11:23 -0500)]
Fix for Bug 2373 ("Tags missing from the left menu"). Also doing some cleanup and reformatting on review.tmpl. Fixing some capitalization--I hope that's not a translation problem.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding new patron form for non-javascript users (Fixes Bug 2344, No "New Member"...
Owen Leonard [Mon, 21 Jul 2008 14:28:20 +0000 (09:28 -0500)]
Adding new patron form for non-javascript users (Fixes Bug 2344, No "New Member" button w/o js).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemoving duplicate column (Bug 2364, "Library column repeated")
Owen Leonard [Mon, 21 Jul 2008 13:15:28 +0000 (08:15 -0500)]
Removing duplicate column (Bug 2364, "Library column repeated")

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrecting markup in intranet-main.tmpl to display "Lists" properly
Chris Nighswonger [Mon, 21 Jul 2008 02:05:40 +0000 (21:05 -0500)]
Correcting markup in intranet-main.tmpl to display "Lists" properly

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdds Arabic Staff Client translation
Joshua Ferraro [Tue, 22 Jul 2008 20:38:03 +0000 (15:38 -0500)]
Adds Arabic Staff Client translation

16 years agoUpdates to the subtype limits for Audience to match the MARC21
Joshua Ferraro [Tue, 22 Jul 2008 18:44:45 +0000 (13:44 -0500)]
Updates to the subtype limits for Audience to match the MARC21
standard:

a - Preschool
b - Primary
c - Pre-adolescent
d - Adolescent
e - Adult
f - Specialized
g - General
j - Juvenile

For documentation team: please update the screenshot for
this drop-down as the options have changed.

No re-indexing should be necessary.

16 years agoFix a bug where the 008 field got replaced if you
Joshua Ferraro [Tue, 22 Jul 2008 00:38:52 +0000 (19:38 -0500)]
Fix a bug where the 008 field got replaced if you
inadvertantly clicked in the field and it wasn't empty.
This patch prevents the field from being replaced unless
it's empty.

16 years agoAdds a stylesheet for Zebra to do an on-the-fly conversion of the
Joshua Ferraro [Mon, 21 Jul 2008 23:09:27 +0000 (18:09 -0500)]
Adds a stylesheet for Zebra to do an on-the-fly conversion of the
Koha 952 item fields to the MARC21 standard 852 location fields:

Please add the following to the documentation in a section explaining
the setup of a SRU/Z39.50 server. You can also pull info from:

http://wiki.koha.org/doku.php?id=en:development:z3950sru

Modifying Output of Your Records On-the-fly

Koha supports modifying the output of your MARC records for public-facing
Z39.50 and SRU servers. You can set up custom mappings to convert fields such
as 952 (Koha items) to 852 (MARC21 location fields). For example here would
be a popular mapping:
Name: Koha Field Mapping in MARC21
---------------------------
Location:  952 $b =>  852 $b
Barcode:  952 $p =>  852 $p
Price:  952 $v =>  852 $r
Item type:  952 $y =>  852 $w
Notes: 952 $z =>  852 $z

This would make the output from the SRU server suitable for a
resource sharing network that used the above convention for location
information. To add this configuration to your Zebra, add the following
block of code in the koha-conf.xml in the <retrievalinfo> area:

<retrieval syntax="xml" name="marc21location">
         <backend syntax="usmarc" name="F">
           <marc inputformat="marc" outputformat="marcxml"
                 inputcharset="utf-8"/>
           <xslt stylesheet="/path/to/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim9522852.xsl"/>
         </backend>
 </retrieval>

The retrieval set name (in this case, marc21location) is arbitrary and
should be set as required by your resource sharing network, so long as it won't
conflict with internal usage within Koha itself. It's the retrieval set name
that is used to trigger the server to respond and parse the record through the
stylesheet and apply the mappings.

In SRU, this is set as follows:

http://example.com:210/biblios?version=1.1&operation=searchRetrieve&query=it&startRecord=1&maximumRecords=20&recordSchema=marc21location

In Z39.50 it's the elementset name construct.

16 years agoFinal fix for 2335: Printers has never worked, so it's removed for 3.0
Joshua Ferraro [Sun, 20 Jul 2008 15:51:03 +0000 (10:51 -0500)]
Final fix for 2335: Printers has never worked, so it's removed for 3.0
Someone who has the time to generalize it can add it back

16 years agoRemoves the Libraries facet if singleBranchMode is ON
Joshua Ferraro [Fri, 18 Jul 2008 22:54:11 +0000 (17:54 -0500)]
Removes the Libraries facet if singleBranchMode is ON

16 years agoHide location selection when singleBranchMode is ON
Joshua Ferraro [Fri, 18 Jul 2008 22:46:58 +0000 (17:46 -0500)]
Hide location selection when singleBranchMode is ON

16 years agoThis patch resolves a few MARC21 Framework issues for
Joshua Ferraro [Fri, 18 Jul 2008 22:39:08 +0000 (17:39 -0500)]
This patch resolves a few MARC21 Framework issues for
a default installation:

1. Re-names several of the item fields to make more sense to catalogers and patrons
2. Remove links Non-public note from items.paidfor
3. Changes Non-public note to be hidden in the OPAC view

Fixes issues with the 'hidden' field in the framework, specifically:

1. the editor obeys the rules of possible values for hidden (>4, or <-4)
2. the OPAC MARC display obeys the rules of positive values meaning 'hidden in OPAC'
3. the staff MARC display now obeys the rules specified in the hidden values description

16 years agoFix for 2372: Breadcrumbs on Tags Wrong
Joshua Ferraro [Fri, 18 Jul 2008 18:47:04 +0000 (13:47 -0500)]
Fix for 2372: Breadcrumbs on Tags Wrong

16 years agoRefine lateorders - error feedback, filter independence
Joe Atzberger [Fri, 18 Jul 2008 18:12:26 +0000 (13:12 -0500)]
Refine lateorders - error feedback, filter independence

Added error catching for bad user input on number of days.  I.E., if you
try to filter by "bAd", you now get an error message prompting for valid
digits.  Also I updated highlighting to use loop_context_vars.

Fixed filtering to work on either days, vendor or both.  Previously, if
you selected a number of days, you had to select a vendor or else got
empty results.  DOCUMENTATION NOTE: this supplies the expected behavior,
so specifying vendor is no longer required.

Changed filters form to GET method.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdd no-replace option to stage_biblios_file.pl, allowing incoming bibs to not overwri...
Ryan Higgins [Fri, 18 Jul 2008 15:46:55 +0000 (10:46 -0500)]
Add no-replace option to stage_biblios_file.pl, allowing incoming bibs to not overwrite existing bibs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix typo, which disabled receipt of non-periodic or unknown periodicity serials due...
Ryan Higgins [Fri, 18 Jul 2008 06:23:52 +0000 (01:23 -0500)]
Fix typo, which disabled receipt of non-periodic or unknown periodicity serials due to miscalculation of subscription end.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2213 : First issue of serial was set to subscription start date instead of first...
Ryan Higgins [Thu, 17 Jul 2008 22:18:51 +0000 (17:18 -0500)]
Bug 2213 : First issue of serial was set to subscription start date instead of first issue date.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrect misspelling of 'recieve'.
Ryan Higgins [Thu, 17 Jul 2008 22:18:39 +0000 (17:18 -0500)]
Correct misspelling of 'recieve'.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoChange language on serials toolbar from 'edit record' to 'edit subscription'.
Ryan Higgins [Thu, 17 Jul 2008 22:18:12 +0000 (17:18 -0500)]
Change language on serials toolbar from 'edit record' to 'edit subscription'.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 2371: Change fine block message behavior...
Jesse Weaver [Fri, 18 Jul 2008 17:54:03 +0000 (12:54 -0500)]
fix for bug 2371: Change fine block message behavior...

This adds a variable to the checkout form, debt_confirmed, that is 1 when the de
bt block message has been canceled for this session.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 1892: When checking in item on hold...
Jesse Weaver [Fri, 18 Jul 2008 17:58:01 +0000 (12:58 -0500)]
fix for bug 1892: When checking in item on hold...

Makes the print slip and confirm button show up on an in-library hold as well as a transfer. It also adds an ignore button that hides the hold dialog.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 2282: Biblio framework subfields...
Jesse Weaver [Thu, 17 Jul 2008 18:39:22 +0000 (13:39 -0500)]
fix for bug 2282: Biblio framework subfields...

This fixes the tabs plugin's view of the % subfield by adding another template var called urisubfieldcode that is "pct" when the subfieldcode is "%".

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for disappearing dropbox mode checkbox on returns screen
Jesse Weaver [Thu, 17 Jul 2008 17:43:56 +0000 (12:43 -0500)]
fix for disappearing dropbox mode checkbox on returns screen

This makes the 'dropbox mode' checkbox appear unconditionally.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 2359: Returning an item from moremember.pl...
Jesse Weaver [Thu, 17 Jul 2008 17:43:55 +0000 (12:43 -0500)]
fix for bug 2359: Returning an item from moremember.pl...

Adds a 'forgive fines' checkbox to moremember.pl that defaults to off, and removes the hardcoded $exemptfine = 1 argument to AddReturn in reserves/renewscript.pl. Also, cleans up a little inline CSS.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoUpdating the name of the script for build_browser_and_cloud.pl
Joshua Ferraro [Thu, 17 Jul 2008 13:29:33 +0000 (08:29 -0500)]
Updating the name of the script for build_browser_and_cloud.pl

16 years agoMassive updates to help file. Translators will have a chance to translate this stuff...
NCE [Wed, 16 Jul 2008 23:48:06 +0000 (19:48 -0400)]
Massive updates to help file. Translators will have a chance to translate this stuff in coming versions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdditional help files updated
NCE [Tue, 15 Jul 2008 12:33:26 +0000 (08:33 -0400)]
Additional help files updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoiMore updates to translations
NCE [Mon, 14 Jul 2008 16:45:43 +0000 (12:45 -0400)]
iMore updates to translations

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoar-Arab po files--only OPAC is translated for now.
Frederic Demians [Mon, 14 Jul 2008 19:00:32 +0000 (21:00 +0200)]
ar-Arab po files--only OPAC is translated for now.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 2221: Problems with Guarantor Fields...
Jesse Weaver [Wed, 16 Jul 2008 20:06:03 +0000 (15:06 -0500)]
fix for bug 2221: Problems with Guarantor Fields...

This patch corrects this problem, by, when a patron record is linked as a guarantor, showing that and not allowing the name to be edited. It still allows manual entry of a guarantor. It also untabifies a few places in the affected files and fixes some inconsistent names.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUGFIX : wrong link
Paul POULAIN [Wed, 16 Jul 2008 16:38:04 +0000 (18:38 +0200)]
BUGFIX : wrong link

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofrench translation updated
Paul POULAIN [Wed, 16 Jul 2008 16:38:03 +0000 (18:38 +0200)]
french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixed bug #2357
Frederic Demians [Wed, 16 Jul 2008 16:11:29 +0000 (18:11 +0200)]
Fixed bug #2357

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2453 - Obsoleted report removed (use issues_stats instead)
Joe Atzberger [Tue, 15 Jul 2008 17:52:52 +0000 (12:52 -0500)]
Bug 2453 - Obsoleted report removed (use issues_stats instead)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 1551: Renewing doesn't move item...
Jesse Weaver [Tue, 15 Jul 2008 17:06:42 +0000 (12:06 -0500)]
fix for bug 1551: Renewing doesn't move item...

This makes C4::Circulation::AddRenewal update lastreneweddate, then has circulation.pl check today's date against issuedate or lastreneweddate. It also cl
eans up a little parenthesis spacing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 2348: Cannot change patron category
Jesse Weaver [Tue, 15 Jul 2008 16:10:39 +0000 (11:10 -0500)]
fix for bug 2348: Cannot change patron category

This makes the code that generates the category code list loop through all six category types.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2274: adding libmime-lite-perl (MIME::Lite) to list of required debian packages
Andrew Moore [Tue, 15 Jul 2008 12:54:26 +0000 (07:54 -0500)]
bug 2274: adding libmime-lite-perl (MIME::Lite) to list of required debian packages

MIME::Lite is now a required perl module. The libmime-lite-perl debian package provides it.
Thanks to Zeno Tajoli for pointing out the omission.
http://markmail.org/message/np3m2zkafr2togez

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2351 : Receive acqui order was not incrementing loop counter when saving multiple...
Ryan Higgins [Tue, 15 Jul 2008 09:03:23 +0000 (04:03 -0500)]
Bug 2351 : Receive acqui order was not incrementing loop counter when saving multiple items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix "Add Tag" button in MARC framework editor
Jesse Weaver [Mon, 14 Jul 2008 20:40:37 +0000 (15:40 -0500)]
fix "Add Tag" button in MARC framework editor

This is part of bug 2282. This patch also improves the "Delete Tag" button so it brings you back to where you were.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix number two for 2181: Late Items in Red
Jesse Weaver [Mon, 14 Jul 2008 17:15:13 +0000 (12:15 -0500)]
fix number two for 2181: Late Items in Red

This new patch uses faster Perl string comparison when comparing dates for overdue checking.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agonew script to fix date code in accountlines
Jesse Weaver [Mon, 14 Jul 2008 17:15:14 +0000 (12:15 -0500)]
new script to fix date code in accountlines

misc/maintenance/fix_accountlines_date.pl runs through the accountlines table and converts every date in the 'description' column from us or metric format (specified on the command line) to the format in the 'dateformat' syspref.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for 2177: Barcode on checkout slip
Jesse Weaver [Mon, 14 Jul 2008 17:15:15 +0000 (12:15 -0500)]
fix for 2177: Barcode on checkout slip

This patch adds barcodes to the Checkouts and Overdues section of the receipt. It also removes the Overdues section if it is empty.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoUpdated INSTALL.opensuse to install yaz
Ricardo Dias Marques [Tue, 15 Jul 2008 01:55:29 +0000 (02:55 +0100)]
Updated INSTALL.opensuse to install yaz

Changelog:
- Added step to install the yaz package. Thanks to Bob Ewart for catching this.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAllowing people to search on all itemtypes when adding a serial subscription, workaro...
Chris Cormack [Tue, 15 Jul 2008 00:44:44 +0000 (12:44 +1200)]
Allowing people to search on all itemtypes when adding a serial subscription, workaround for the fact you cant limit by itemtype

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix to the Carp handling when we have a fatal cant connect to the database error
Chris Cormack [Tue, 15 Jul 2008 00:44:43 +0000 (12:44 +1200)]
Fix to the Carp handling when we have a fatal cant connect to the database error

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for bug 2191: Subfield $n (Suppress in OPAC) has no effect on OPAC
Joshua Ferraro [Mon, 14 Jul 2008 19:51:07 +0000 (14:51 -0500)]
Fix for bug 2191: Subfield $n (Suppress in OPAC) has no effect on OPAC

Adding missing OpacSuppression syspref

16 years agobug 2347 [2/2]: database chagnes (adds to version 098)
Andrew Moore [Mon, 14 Jul 2008 17:20:02 +0000 (12:20 -0500)]
bug 2347 [2/2]: database chagnes (adds to version 098)

I'm removing RSS from the message_transports table now. I forgot that before.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2347 [1/2]: removing RSS from optional and mandatory sql scripts
Andrew Moore [Mon, 14 Jul 2008 17:20:01 +0000 (12:20 -0500)]
bug 2347 [1/2]: removing RSS from optional and mandatory sql scripts

The RSS message_transport_type was recently removed (until we get it implemented). It
is now being removed from the other tables that reference it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBarcodes test - make DB-dependent feedback a diag (not a test).
Joe Atzberger [Mon, 14 Jul 2008 17:45:34 +0000 (12:45 -0500)]
Barcodes test - make DB-dependent feedback a diag (not a test).

I also added a SKIP block in case of constructor failure and improved
the layout of existing diag lines.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for bug: 2323: Conference name search fails in staff interface.
Joshua Ferraro [Mon, 14 Jul 2008 18:05:04 +0000 (13:05 -0500)]
Fix for bug: 2323: Conference name  search fails in staff interface.
wrdl missing from definition on adv search page in staff client

16 years agoFix to 2277: patron cardnumber is not a required field
Joshua Ferraro [Mon, 14 Jul 2008 17:57:20 +0000 (12:57 -0500)]
Fix to 2277: patron cardnumber is not a required field

Note to sysadmins: you'll need to add 'cardnumber' to the
syspref manually.

16 years agoFix for 1863: Result list for 'scan' index searches incorrect after first page
Joshua Ferraro [Mon, 14 Jul 2008 16:33:13 +0000 (11:33 -0500)]
Fix for 1863: Result list for 'scan' index searches incorrect after first page

16 years agoFix for bug 2116: Disable_Dictionary Syspref depreciated
Joshua Ferraro [Mon, 14 Jul 2008 16:05:43 +0000 (11:05 -0500)]
Fix for bug 2116: Disable_Dictionary  Syspref depreciated

It has been replaced by the syspref OpacAuthorities

16 years agoFix for bug 2115: OpacMaintenance wasn't working
Joshua Ferraro [Mon, 14 Jul 2008 16:01:44 +0000 (11:01 -0500)]
Fix for bug 2115: OpacMaintenance wasn't working

16 years agoFix for 2184
Joshua Ferraro [Mon, 14 Jul 2008 13:39:14 +0000 (08:39 -0500)]
Fix for 2184

16 years agoUpdates to online help
NCE [Mon, 14 Jul 2008 12:50:59 +0000 (08:50 -0400)]
Updates to online help

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFinal fix for 2008: Daily reconciliation report broken
Joshua Ferraro [Sat, 12 Jul 2008 15:04:27 +0000 (10:04 -0500)]
Final fix for 2008: Daily reconciliation report broken

Stuff that hasn't ever worked in Koha gets commented out in 3.0 ;-)

16 years agoPartial fix for 2084: opac-topissues.pl is both EXPERIMENTAL and
Joshua Ferraro [Sat, 12 Jul 2008 14:52:17 +0000 (09:52 -0500)]
Partial fix for 2084: opac-topissues.pl is both EXPERIMENTAL and
very proc hungry and we needed to warn systems admins and turn it
OFF by default.

16 years agoFixing bug with the way authority ID query was being generated
Joshua Ferraro [Sat, 12 Jul 2008 14:33:17 +0000 (09:33 -0500)]
Fixing bug with the way authority ID query was being generated
in XSL stylesheet

16 years agoFix for bug2234: noOPACHolds syspref unused, superceded by RequestOnOpac
Joshua Ferraro [Sat, 12 Jul 2008 14:12:41 +0000 (09:12 -0500)]
Fix for bug2234: noOPACHolds syspref unused, superceded by RequestOnOpac
Note to systems maintainers: please delete from your systems manually.

16 years agoFix for bug 2342: Searching on more than 1 itemtype breaks
Joshua Ferraro [Sat, 12 Jul 2008 14:09:14 +0000 (09:09 -0500)]
Fix for bug 2342: Searching on more than 1 itemtype breaks

The problem was that the 'mc-' was removed from the checkboxes a while back and
that's what triggers the automatic application of OR boolean searching. I've
added it back to the templates and modified the ccl.properties file to include
mapping for itype,itemtype and ccode

16 years agoExtra comma caused js error in IE6; _() function allows translation script to pick...
Owen Leonard [Sat, 12 Jul 2008 01:04:10 +0000 (20:04 -0500)]
Extra comma caused js error in IE6; _() function allows translation script to pick up strings in Javascript.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoHide User Tags link when TagsEnabled preference is turned off. Change to Auth.pm...
Owen Leonard [Sat, 12 Jul 2008 00:50:58 +0000 (19:50 -0500)]
Hide User Tags link when TagsEnabled preference is turned off. Change to Auth.pm allows TagsEnabled preference to work on login screens.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoReport cleanup - fix highlight, add debugging feedback
Joe Atzberger [Fri, 11 Jul 2008 23:17:04 +0000 (18:17 -0500)]
Report cleanup - fix highlight, add debugging feedback

The debugging feedback (default style: hidden) is necessary to
investigate client reports where even after "backfill_statistics"
this report still fails to return results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFurther fixes to Labels.pm including escaping '(' and ')' for the PDF distiller
Chris Nighswonger [Fri, 11 Jul 2008 11:40:19 +0000 (07:40 -0400)]
Further fixes to Labels.pm including escaping '(' and ')' for the PDF distiller

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdditional help files
Nicole Engard [Fri, 11 Jul 2008 20:47:01 +0000 (16:47 -0400)]
Additional help files

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFormatting additem form with nicer layout.
Owen Leonard [Fri, 11 Jul 2008 15:42:51 +0000 (10:42 -0500)]
Formatting additem form with nicer layout.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRevert "fix for 2181: Late Items in Red"
Joshua Ferraro [Fri, 11 Jul 2008 02:30:03 +0000 (21:30 -0500)]
Revert "fix for 2181: Late Items in Red"

This used Date::Manip which we went to great lengths to remove about a year ago.

This reverts commit 36b2897430b27a6b8a12f6684d32bc64e026073f.

16 years agoBugfix 2343 : Do not supply default expiry date to patron entry page.
Ryan Higgins [Thu, 10 Jul 2008 22:07:52 +0000 (18:07 -0400)]
Bugfix 2343 : Do not supply default expiry date to patron entry page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 2274: reducing MIME::Lite requirement to 3.0
Andrew Moore [Thu, 10 Jul 2008 20:49:12 +0000 (15:49 -0500)]
Bug 2274: reducing MIME::Lite requirement to 3.0

There has been a report of difficulties installing MIME::Lite 3.01. Only 3.0 is really necessary, so I'm relaxing the requirements.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFurther update to allow notforloan < 0 items to be placed on hold. This is a workarou...
Ryan Higgins [Thu, 10 Jul 2008 20:38:28 +0000 (16:38 -0400)]
Further update to allow notforloan < 0 items to be placed on hold. This is a workaround for the lack of a notforhold flag.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTemplate error prevented chosen branch from being preselected after form submission.
Owen Leonard [Thu, 10 Jul 2008 20:24:41 +0000 (15:24 -0500)]
Template error prevented chosen branch from being preselected after form submission.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAllow holds to be placed on items with notforloan set as a negative value. See http...
Ryan Higgins [Thu, 10 Jul 2008 20:20:39 +0000 (16:20 -0400)]
Allow holds to be placed on items with notforloan set as a negative value. See http://wiki.koha.org/doku.php?id=en:development:kohastatuses

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding javascript to deselect appropriate input fields when 'next available copy...
Owen Leonard [Thu, 10 Jul 2008 18:29:43 +0000 (13:29 -0500)]
Adding javascript to deselect appropriate input fields when 'next available copy' is checked or unchecked. Changing checkboxes to radio buttons to prevent multiple selections. Note: with javascript off, an item-level hold will be placed for the selected item even if the 'next available copy' box is checked.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for 2181: Late Items in Red
Jesse Weaver [Thu, 10 Jul 2008 18:21:28 +0000 (13:21 -0500)]
fix for 2181: Late Items in Red

Modified overdue check in circ/circulation.pl to use Date::Manip's Date_Cmp. This would likely be useful other places in the file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoNomenclature update: s/Reserved on/Hold placed on/ and also updated translations
Joshua Ferraro [Thu, 10 Jul 2008 18:31:10 +0000 (13:31 -0500)]
Nomenclature update: s/Reserved on/Hold placed on/ and also updated translations

16 years agoFallout from removing Date.pm, two places still used it
Joshua Ferraro [Thu, 10 Jul 2008 17:06:37 +0000 (12:06 -0500)]
Fallout from removing Date.pm, two places still used it

16 years agobug 2329: removing unused RSS transport type - DB version 098.
Andrew Moore [Thu, 10 Jul 2008 16:34:38 +0000 (11:34 -0500)]
bug 2329: removing unused RSS transport type - DB version 098.

I didn't implement a way for patrons to get their advance notices and other
messages through RSS, so I'm removing it from the list of available transport types.
This will cause the "RSS" column in the patron messasging pages to be
unavailable. When we implement RSS, we can add it back in and the checkboxes will return.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrecting text wrapping on labels
Chris Nighswonger [Thu, 10 Jul 2008 09:16:59 +0000 (05:16 -0400)]
Correcting text wrapping on labels

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2284: ModMember can erase the dateofbirth field
Andrew Moore [Thu, 10 Jul 2008 14:32:56 +0000 (09:32 -0500)]
bug 2284: ModMember can erase the dateofbirth field

patch to C4::Members::ModMember to prevent it from deleting the dateofbirth field when none is supplied.

I also added a KohaTest::random_date method to help generate randomish dates for the test suite.
Added some tests for Member::ModMember. This is an easy method to test, and this bug shows that it
could use some closer examiniation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1980 [3/3]: remove bug workaround from pagination links
Andrew Moore [Thu, 10 Jul 2008 14:12:38 +0000 (09:12 -0500)]
bug 1980 [3/3]: remove bug workaround from pagination links

yesterday, the C4::Output::pagination_bar had a bug in it that I was crudely working around.
atz fixed that bug this morning. This patch removes the workaround. Thanks, atz!

I'm sending along atz's patch again with my signoff. It needs to be applied before this, as does the
other 1980 patch. I have sent that along (again), too, with a modified subject line. That makes a total of 3 patches for 1980.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2329 [1/1]: remove RSS from list of transport options for patron messaging
Andrew Moore [Thu, 10 Jul 2008 13:45:27 +0000 (08:45 -0500)]
bug 2329 [1/1]: remove RSS from list of transport options for patron messaging

I didn't implement a way for patrons to get their advance notices and other messages
through RSS, so I'm removing it from the list of available transport types.
This will cause the "RSS" column in the patron messasging pages to be unavailable.
When we implement RSS, we can add it back in and the checkboxes will return.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBugfix pagination_bar to work with only one param/value pair.
Joe Atzberger [Thu, 10 Jul 2008 13:31:16 +0000 (08:31 -0500)]
Bugfix pagination_bar to work with only one param/value pair.

A valid test of this patch is this command:
perl -MC4::Output -e 'print pagination_bar("my/script?query=foobar",5,2,"page"),"\n";'

The output before patch begins:
&nbsp;<a href="my/script?query=foobar?page=1" rel="start">&lt;&lt;</a>
and AFTER patch:
&nbsp;<a href="my/script?query=foobar&amp;page=1" rel="start">&lt;&lt;</a>

The double "?" in QUERY_STRING are now avoided.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2274: correcting call to new interface of overdue_notices.pl
Andrew Moore [Thu, 10 Jul 2008 13:06:48 +0000 (08:06 -0500)]
bug 2274: correcting call to new interface of overdue_notices.pl

I changed the interface to overdue_notices.pl at the last moment and forgot to correct one call to it.
This corrects circ/overdue.pl to call misc/cronjobs/overdue_notices.pl with the correct parameters.

Even better would be to move most of the code from overdue_notices.pl to a method somewhere
that both of these programs could call. It's inappropriate to call a cronjob from one of our CGIs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTotal overhaul of broken "Items with no checkouts" report.
Joe Atzberger [Wed, 9 Jul 2008 23:36:40 +0000 (18:36 -0500)]
Total overhaul of broken "Items with no checkouts" report.

Previous implementation was a crude copy/paste from a larger report.
CSV output was and is not functional (disabled in interface accordingly).
Output now includes and is sorted by itemcallnumber, because the purpose
of this report is to isolate uncirculating items to cull from the shelves.
Output also includes a summary at the top, with links to individual tables
below when broken out by a grouping.  Also included in the feedback but
default styled to display="none" are the actual SQL queries.  This is
incredibly useful for debugging and should probably be done in all reports.

Yet TODO: allow date range for checkouts and instead of
"no checkouts" (=0) allow the query to filter based on =x, >x, <x, etc.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agouseless line that generates zillions of "Useless use of a variable in void context...
Paul POULAIN [Thu, 10 Jul 2008 09:19:34 +0000 (11:19 +0200)]
useless line that generates zillions of "Useless use of a variable in void context" in apache logs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1980: updateing calls to SimpleSearch to limit number of things returned
Andrew Moore [Wed, 9 Jul 2008 20:52:24 +0000 (15:52 -0500)]
bug 1980: updateing calls to SimpleSearch to limit number of things returned

C4::Search::SimpleSearch was alredy patched to let you pass in the number of results you want back.
These instances were not using the new API. This patch makes all calls to SimpleSearch specify a limit.

I improved the documentation of SimpleSearch a bit to include the third returned value.

I believe there's a bug in C4::Output::pagination_bar, in that it doesn't deal well with URLs
with only one pair of parameter=value passed to it. I'm getting around this by passing in a second
pair that does nothing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 2296: removing depreceated C4::Date module
Andrew Moore [Wed, 9 Jul 2008 17:08:14 +0000 (12:08 -0500)]
bug 2296: removing depreceated C4::Date module

The C4::Date module is deprecated. It is also no longer used anywhere in Koha.
This patch removes it and the associated tests.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>