]> git.koha-community.org Git - koha.git/log
koha.git
8 years agoBug 14613: Send cart window is too small in staff and hides 'send' button
Chloe [Mon, 18 Jan 2016 22:31:19 +0000 (22:31 +0000)]
Bug 14613: Send cart window is too small in staff and hides 'send' button

To Test: Add an item to cart click "cart" click "send"
confirm that the send window is larger and the send button is
visible

NOTE: Remember to clear cache to refresh javascripts.
      This is much more visible if you zoom in 10% or more.
      This is larger, but more of a stop gap if you've got a large zoom.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 14538: editing perl doc for CalcFine
Natasha [Mon, 18 Jan 2016 22:59:03 +0000 (22:59 +0000)]
Bug 14538: editing perl doc for CalcFine

To Test:
Read perldoc C4/Overdues.pm
Confirm that it says CalcFine returns four values and that rest of the documentation is correct

NOTE: only a little visual ugliness, but definitely an improvement.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15354: (QA followup) remove tab character
Jesse Weaver [Tue, 5 Jan 2016 20:37:39 +0000 (13:37 -0700)]
Bug 15354: (QA followup) remove tab character

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15354: Sort itemtypes by translated description everywhere on circ rules admin...
Jonathan Druart [Mon, 4 Jan 2016 10:02:06 +0000 (10:02 +0000)]
Bug 15354: Sort itemtypes by translated description everywhere on circ rules admin page

It's better to cmp on lc.

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Passes QA tools. Fixes sorting of dropdown for translated itemtype
descriptions.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15354: Fix translated itemtype descriptions in circ rules
Jonathan Druart [Mon, 14 Dec 2015 10:14:16 +0000 (10:14 +0000)]
Bug 15354: Fix translated itemtype descriptions in circ rules

In bug 14100, the admin/smart-rules.pl needed much more love.
Indeed, the translated_description string should be used everywhere and
replaced the previous 'humanitemtype'.

Test plan:
1/ Translate some item types.
2/ Define some holds policy using these item types.
3/ Update the template strings
4/ Confirm that the "holds policy by item type" are displayed (for the
default and specific library) and sorted by translated item type descriptions.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Passes QA tools.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15568: Fix display default circ rules
Jonathan Druart [Wed, 13 Jan 2016 16:13:36 +0000 (16:13 +0000)]
Bug 15568: Fix display default circ rules

To reproduce:
Go on the admin circ rules page (admin/smart-rules.pl), switch the
dropdown list from specific to "all libraries".
The rules are not displayed anymore.

Test plan:
Apply this patch and confirm that the rules are now displayed correctly.
Make sure the enh introduced by bug 11625 is not broken.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates
Jonathan Druart [Wed, 13 Jan 2016 17:51:01 +0000 (17:51 +0000)]
Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates

Test plan:
use circ/renew.pl to renew an issue.
Without this patch, you will get an error.

Note: The error exists for 1 year now and nobody complained?? Does
someone still use this script?

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15572: Add tests for TransformHtmlToMarc
Jonathan Druart [Tue, 12 Jan 2016 15:23:33 +0000 (15:23 +0000)]
Bug 15572: Add tests for TransformHtmlToMarc

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15572: Follow-up to fix error on authority creation
Frédéric Demians [Tue, 12 Jan 2016 10:53:11 +0000 (11:53 +0100)]
Bug 15572: Follow-up to fix error on authority creation

Bug 6657 modified the way C4::Biblio::TransformHtmlToMarc operates in order to
solve an issue occuring during biblio record cataloguing. But this function is
also used by authorities cataloguing, and the code in this case is irrelevante.
This followup allows to distinguish for which kind of record
TransformHtmlToMarc is called: biblio/authority.

A bug appears in authority creation without this patch in some circunstances:
when authid is linked to 001 field.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Tested with a new authority record

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15572: TransformHtmlToMarc - rewrite the loop
Julian Maurice [Tue, 12 Jan 2016 15:49:15 +0000 (16:49 +0100)]
Bug 15572: TransformHtmlToMarc - rewrite the loop

This rewrites the while loop into a for loop, so $i still gets
incremented when we call next

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Make sense. Add readability. Infinite loop no more possible.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoBug 15586 - References to Koha::Branches remain in unit tests
Kyle M Hall [Sat, 16 Jan 2016 01:28:45 +0000 (01:28 +0000)]
Bug 15586 - References to Koha::Branches remain in unit tests

The unit tests BiblioObject.t and Hold.t still have references to
Koha::Branches that need to be changed to Koha::Libraries. These tests
currently fail because of this.

Test Plan:
1) prove t/db_dependent/BiblioObject.t should fail
2) prove t/db_dependent/Hold.t should fail
3) Apply this patch
1) prove t/db_dependent/BiblioObject.t should pass
2) prove t/db_dependent/Hold.t should pass

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15295: (follow-up) Koha::Libraries - Remove GetBranchesCount
Jonathan Druart [Fri, 15 Jan 2016 09:35:26 +0000 (09:35 +0000)]
Bug 15295: (follow-up) Koha::Libraries - Remove GetBranchesCount

Fix conflict with bug 11625

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15394 - Tidy up error messages in OPAC lists
Liz Rea [Thu, 17 Dec 2015 22:01:47 +0000 (11:01 +1300)]
Bug 15394 - Tidy up error messages in OPAC lists

To test:

Create a list in the OPAC, observe the message
Create another list in the OPAC with the same name, observe the message
Delete a list, observe the message

Check the patch itself, look for typos.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15469: Same fix for the "entire record" tab
Jonathan Druart [Thu, 7 Jan 2016 08:29:40 +0000 (08:29 +0000)]
Bug 15469: Same fix for the "entire record" tab

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15469: Fix authority header search
Jonathan Druart [Tue, 5 Jan 2016 10:49:31 +0000 (10:49 +0000)]
Bug 15469: Fix authority header search

Introduced by bug 15381.

The logs contain plenty of "detail.pl: No method value!" and the
dropwdown list is not correctly populated (no value for options)

Test plan:
Go to the authority module and have a look at the auth type codes
dropdown list.
Without this patch, the values of the options are empty.
With this patch, the values are correctly filled.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  I confirm this patch silence noise in log file.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15295! Koha::Libraries - Remove ModBranchCategoryInfo
Jonathan Druart [Thu, 3 Dec 2015 15:02:35 +0000 (15:02 +0000)]
Bug 15295! Koha::Libraries - Remove ModBranchCategoryInfo

This has been replaced with Koha::Library->update_categories and
Koha::Library->add_to_categories

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
http://bugs.koha-community.org/show_bug.cgi?id=15294

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15295: Koha::Libraries - Remove GetBranchesCount
Jonathan Druart [Thu, 3 Dec 2015 14:47:50 +0000 (14:47 +0000)]
Bug 15295: Koha::Libraries - Remove GetBranchesCount

This is replaced with Koha::Libraries->search->count.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
http://bugs.koha-community.org/show_bug.cgi?id=15294

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15295: Koha::Libraries - Remove GetCategoryTypes
Jonathan Druart [Thu, 3 Dec 2015 14:42:11 +0000 (14:42 +0000)]
Bug 15295: Koha::Libraries - Remove GetCategoryTypes

'searchdomain' and 'properties' were hardcoded in this subroutine.
Now there are in the admin script. Not a big deal, we could improve that
later if someone wants to add a third values.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
http://bugs.koha-community.org/show_bug.cgi?id=15294

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15295: Koha::Libraries - Remove GetBranchCategories
Jonathan Druart [Thu, 3 Dec 2015 14:35:05 +0000 (14:35 +0000)]
Bug 15295: Koha::Libraries - Remove GetBranchCategories

Test plan
1/ enable OpacAddMastheadLibraryPulldown
2/ Defined a group of libraries as searchdomain
and tick 'show in pull down'
3/ At the OPAC, go on the advanced search form, limit by the group of
libraries you have just created.
4/ The group should be selected by default in the dropdown list

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
http://bugs.koha-community.org/show_bug.cgi?id=15294

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15295: Koha::Libraries - Remove GetBranchCategory
Jonathan Druart [Thu, 3 Dec 2015 14:12:22 +0000 (14:12 +0000)]
Bug 15295: Koha::Libraries - Remove GetBranchCategory

This has been replaced with Koha::Libraries->find

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
http://bugs.koha-community.org/show_bug.cgi?id=15294

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15295: Koha::Libraries - Remove CheckBranchCategorycode
Jonathan Druart [Thu, 3 Dec 2015 14:09:36 +0000 (14:09 +0000)]
Bug 15295: Koha::Libraries - Remove CheckBranchCategorycode

This verification is now done in admin/branches.pl, no need for a
special subroutine/method, it's 1 line only called once.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
http://bugs.koha-community.org/show_bug.cgi?id=15294

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15295: Koha::Libraries - Remove CheckCategoryUnique
Jonathan Druart [Thu, 3 Dec 2015 14:06:13 +0000 (14:06 +0000)]
Bug 15295: Koha::Libraries - Remove CheckCategoryUnique

This subroutine is not used anymore and was not really useful.
The branchcategories table has a primary key defined on categorycode.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
http://bugs.koha-community.org/show_bug.cgi?id=15294

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15295: Koha::Libraries - Remove DelBranch and DelBranchCategory
Jonathan Druart [Thu, 3 Dec 2015 14:04:06 +0000 (14:04 +0000)]
Bug 15295: Koha::Libraries - Remove DelBranch and DelBranchCategory

These 2 subroutines are not used anymore, there were only used from the
admin script rewrote on bug 15294.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15294: Koha::Libraries - Rewrite the admin scripts
Jonathan Druart [Thu, 3 Dec 2015 15:19:13 +0000 (15:19 +0000)]
Bug 15294: Koha::Libraries - Rewrite the admin scripts

This patch rewrites the admin/branches.pl script to use the new modules
instead of C4::Branches.

Test plan:
1/ Create libraries using all the fields available
2/ Create groups of libraries
3/ Assign 1+ libraries to some groups
4/ Delete libraries and groups of libraries
You should not able to delete a library if items or patrons use it.
You should not able to delete a group of libraries if there are still
libraries using it.
5/ Update libraries and groups of libraries

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15294: Koha::Libraries - Move existing Koha::Branch[es]
Jonathan Druart [Wed, 2 Dec 2015 16:53:33 +0000 (16:53 +0000)]
Bug 15294: Koha::Libraries - Move existing Koha::Branch[es]

There was already 2 Koha::Branch[es] using Koha::Object[s] before.
For this new rewrite, it seems preferable to start with good basis and
name the new modules Koha::Library and Koha::Libraries.

Tested both patches together, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions
Jonathan Druart [Tue, 5 Jan 2016 14:25:35 +0000 (14:25 +0000)]
Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions

Prior to this patch, the itemtypes were displayed ordered by the code
(itemtypes.itemtype DB column).
This patch will make them displayed by the description displayed (the
translated description).

Test plan:
0/ Do not apply this patch set
1/ Confirm that the itemtypes are displayed ordered by code (when adding
an item, cataloguing/additem.pl)
2/ Confirm that t/db_dependent/Koha.t does not pass
3/ Apply the test patch
4/ Confirm that t/db_dependent/Koha.t pass
5/ Confirm that the itemtypes are not displayed by description (on
additem.pl)

See comment #3
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc
Jonathan Druart [Tue, 5 Jan 2016 14:23:24 +0000 (14:23 +0000)]
Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc

See comment #3
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15477: (follow-up) Bug 14100: Better errors handling
Jonathan Druart [Wed, 6 Jan 2016 11:17:00 +0000 (11:17 +0000)]
Bug 15477: (follow-up) Bug 14100: Better errors handling

On bug 14100, the patch "Better errors handling" introduced an ...
error.
The user always get "An error occurred when updating this translation"
although it has been updated in DB.

Test plan:
Edit translations for an item type: you should not get an error when
everything went fine.

Tested on top of 15487, error message does no longer appear.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15487: Fix encoding issue on localization
Jonathan Druart [Wed, 6 Jan 2016 16:59:22 +0000 (16:59 +0000)]
Bug 15487: Fix encoding issue on localization

It has been introduced
  commit ed0ff59152a41f6690b480d0b13b607250678418
    Bug 11559: Supporting changes for Rancor

Pushed at the same time as bug 14100.

Test plan:
Add/update translations for item types, confirm there is no encoding
issues.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered
Nick Clemens [Thu, 7 Jan 2016 00:27:38 +0000 (00:27 +0000)]
Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered

To test:
1 - Delete an item using the Action menu
2 - There is a js error and no warning box
3 - Apply patch
4 - Delete an item using the action menu
5 - You should get a confirmation box as expected

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15473: Make Koha::Objects->find accepts 0 and '' as a key
Jonathan Druart [Tue, 5 Jan 2016 15:08:23 +0000 (15:08 +0000)]
Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key

This bug has been found after bug 15381 was pushed:
If you go on authorities/authorities.pl, you expect a form to create a
 authorities with a "Default" authority type.
Now, it explodes:
    Can't call method "authtypetext" on an undefined value at
    /home/koha/src/authorities/authorities.pl line 665.

Koha::Objects->find does not want to search if the key does not exist
(undef, '', 0). But actually it should only be a coward if it is not defined.

Moreover this is the default behavior of the DBIx::Class find method.

Test plan:
  prove t/db_dependent/Koha/Objects.t
should return green
and
  GET /cgi-bin/koha/authorities/authorities.pl
should not make everything explode.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Find this after signing 15470 :)
Test pass, new auth (Default) created, no errors.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15501 - Planned Irregularities are deleted when modifying subscription
Lyon3 Team [Thu, 7 Jan 2016 09:48:42 +0000 (10:48 +0100)]
Bug 15501 - Planned Irregularities are deleted when modifying subscription

Add a warning to avoid saving a subscription whitout testing prediction pattern
when there are planned no published issues

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Ran through test plan, looks all good.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15367: Do not display repeatable patron attributes in the batch patron modification
Jonathan Druart [Mon, 21 Dec 2015 12:24:46 +0000 (12:24 +0000)]
Bug 15367: Do not display repeatable patron attributes in the batch patron modification

The repeatable patron attributes are not correctly managed and can cause
data lost. To avoid that, the easier way is not to display them in the
batch patron modification tool.
This should be implemented, as a new enhancement.

Test plan:
Create some patron attributes, some should be repeatable.
Use the batch patron modification tool to modify patrons.
With this patch, the patron attributes marked as repeatable won't be
display anymore.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works as described, no koha-qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years ago Bug 15412: Enable dropdowns date selector when suspending holds
Jonathan Druart [Tue, 5 Jan 2016 15:54:59 +0000 (15:54 +0000)]
 Bug 15412: Enable dropdowns date selector when suspending holds

It seems to be the way to fix that
https://stackoverflow.com/questions/13649459/twitter-bootstrap-multiple-modal-error

Test plan:
1 - Place a hold through the opac
2 - View your account->Holds
3 - Click suspend hold
4 - You should be able to select a date using the arrows and dropdowns

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15466: Do not assume $values_in is a hashref
Jonathan Druart [Tue, 5 Jan 2016 09:39:32 +0000 (09:39 +0000)]
 Bug 15466: Do not assume $values_in is a hashref

It could be undefined.
Test plan:
prove t/db_dependent/Suggestions.t
should return green.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15467: If authtypecode is not defined, do not explode
Jonathan Druart [Tue, 5 Jan 2016 10:23:16 +0000 (10:23 +0000)]
 Bug 15467: If authtypecode is not defined, do not explode

The test t/db_dependent/AuthoritiesMarc.t fails because one test expect
the BuildSummary subroutine to not crash if the authtypecode passed in
parameter does not exist in the DB.

Test plan:
prove t/db_dependent/AuthoritiesMarc.t
should return green.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Test fails before patch, and doesn't anymore after.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15511: Fix tabbed display on OPAC patron account summary page
Katrin Fischer [Wed, 6 Jan 2016 22:05:35 +0000 (23:05 +0100)]
 Bug 15511: Fix tabbed display on OPAC patron account summary page

Some variables were not correctly renamed in a previous patch,
resulting in the fines tab of the OPAC patron summary page
not showing correctly.

To test:
- Go to the OPAC patron account
- Check the display of the Checkouts, Fines and Holds tabs on
  the summary page
- Verify that with the patch, the display is corrected

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15453: Assign the correct shelfid to the download list links
Jonathan Druart [Thu, 31 Dec 2015 11:11:51 +0000 (11:11 +0000)]
 Bug 15453: Assign the correct shelfid to the download list links

Introduced by bug 14544, the shelfnumber is not correctly passed to the
template.
The shelf variable is passed to the template, to access the shelfnumber,
we need to get shelf.shelfnumber.

Test plan:
At the intranet, try to download a list.
Without this patch it won't work.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15478 - Update the remaining schema files that do not match the db schema
Kyle M Hall [Wed, 6 Jan 2016 12:06:34 +0000 (12:06 +0000)]
 Bug 15478 - Update the remaining schema files that do not match the db schema

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15478 - Checksum mismatch when regenerating schema
Kyle M Hall [Wed, 6 Jan 2016 12:04:56 +0000 (12:04 +0000)]
 Bug 15478 - Checksum mismatch when regenerating schema

When regenerating the db schema on master, the script will error out
with a checksum mismatch on Borrower.pm, and also DeletedBorrower.pm

Test Plan:
1) Check out master
2) Run ./misc/devel/update_dbix_class_files.pl
3) Note the error
4) Apply this patch
5) Re-reun ./misc/devel/update_dbix_class_files.pl
6) Note there is no error

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15493: Use the correct CSV profile when exporting records from the export tool
Jonathan Druart [Wed, 6 Jan 2016 16:17:10 +0000 (16:17 +0000)]
 Bug 15493: Use the correct CSV profile when exporting records from the export tool

The CSV profile used is not the one the user has chosen, but the one
defined in the pref ExportWithCsvProfile.

It's caused by a wrong variable name csv_profile vs csv_profile_id

Test plan:
Define 1+ csv profiles
Set ExportWithCsvProfile with 1 of these profile
Use the export tool to export some records using a csv profile.
Without this patch, the csv profile used, will always be the one defined
in ExportWithCsvProfile.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as descrived

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years ago Bug 15462 - Unable to renew books via circ/renew.pl
Marc Véron [Tue, 5 Jan 2016 08:14:30 +0000 (09:14 +0100)]
 Bug 15462 - Unable to renew books via circ/renew.pl

To verify: Got to circ/circulation.pl and try to renew an item.
Result: Can't call method "single" without a package or
        object reference at /usr/share/kohaclone/circ/renew.pl
        line 57

To test:
- Apply patch
- Try to renew items that are or are not checked out. Error
  no longer occurs.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
8 years agoBug 7143: Adding releases and fixing some missing tabs
Chris Cormack [Sun, 3 Jan 2016 20:34:09 +0000 (09:34 +1300)]
Bug 7143: Adding releases and fixing some missing tabs

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
8 years agoRevert "Bug 15478 - Checksum mismatch when regenerating schema"
Kyle M Hall [Wed, 6 Jan 2016 14:56:18 +0000 (14:56 +0000)]
Revert "Bug 15478 - Checksum mismatch when regenerating schema"

This reverts commit f56a37a6ab444a9544f3864c561c6759639efccd.

8 years agoRevert "Bug 15478 - Update the remaining schema files that do not match the db schema"
Kyle M Hall [Wed, 6 Jan 2016 14:56:06 +0000 (14:56 +0000)]
Revert "Bug 15478 - Update the remaining schema files that do not match the db schema"

This reverts commit 4f6b4a3a57044af2f847a4e7a40d9f7987d3f337.

8 years agoBug 12375 - Add new serial fields to kohastructure
Kyle M Hall [Wed, 6 Jan 2016 12:17:22 +0000 (12:17 +0000)]
Bug 12375 - Add new serial fields to kohastructure

8 years agoBug 15478 - Update the remaining schema files that do not match the db schema
Kyle M Hall [Wed, 6 Jan 2016 12:06:34 +0000 (12:06 +0000)]
Bug 15478 - Update the remaining schema files that do not match the db schema

8 years agoBug 15478 - Checksum mismatch when regenerating schema
Kyle M Hall [Wed, 6 Jan 2016 12:04:56 +0000 (12:04 +0000)]
Bug 15478 - Checksum mismatch when regenerating schema

When regenerating the db schema on master, the script will error out
with a checksum mismatch on Borrower.pm, and also DeletedBorrower.pm

Test Plan:
1) Check out master
2) Run ./misc/devel/update_dbix_class_files.pl
3) Note the error
4) Apply this patch
5) Re-reun ./misc/devel/update_dbix_class_files.pl
6) Note there is no error

8 years agoBug 15344: Remove one occurrence in circ/circulation.pl
Jonathan Druart [Thu, 31 Dec 2015 11:43:54 +0000 (11:43 +0000)]
Bug 15344: Remove one occurrence in circ/circulation.pl

In C4::Circulation::CanBookBeIssued, $borrower->{flags} is called and
should be populated by GetMemberDetails

It fixes the following error on checking out:
Can't use string ("1900156") as a HASH ref while "strict refs" in use at
/home/koha/src/C4/Circulation.pm line 813.

Note: Error occurs with patrons with staff permissions, not with 'normal' patrons.
Error is fixed with this patch.
Signed-off-by: Marc Véron <veron@veron.ch>
8 years agoBug 15443 - DBrev 3.23.00.015
Kyle M Hall [Mon, 4 Jan 2016 12:53:08 +0000 (12:53 +0000)]
Bug 15443 - DBrev 3.23.00.015

8 years agoBug 15443 - Re-code RESERVESLIP as HOLD_SLIP
Kyle M Hall [Wed, 30 Dec 2015 15:03:23 +0000 (15:03 +0000)]
Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP

It's a bit confusing to have RESERVESLIP named "Hold Slip", we should
finish the job and recode the slip.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Try printing a hold slip, you should note no difference
   from pre-patch behavior

Followed test plan. The slip is triggered if you want to check out
an item that is reserved / on hold for another patron. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
8 years agoBug 13774 Add the unique anchors of news as links in the RSS for news in Opac
Viktor Sarge [Mon, 2 Mar 2015 13:27:01 +0000 (13:27 +0000)]
Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac

This patch adds the unique anchors of bugs from bug13729 into the rss stream of the news in opac from bug7843.
Since 7843 is already passed QA and I'm new to Git and mess things up I chose to post this update in a separate patch even if it's a tiny change.

The addition of a unique guid tag both help users and keeps validators happy.

Test plan:
* Make sure you are on master in order to get the anchors from bug 13729 (or you could apply it manually).
* Apply bug 7843
* Apply this patch.
* Make shure you have enough news to make the Opac main page scroll.
* Find the RSS link at the bottom om opac main and klick it.
* Verify that the link displayed for each newsitem takes you to the right anchor.

Followed test plan, works as expected. Signed-off-by: Marc Véron
<veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14034: Fix logout on refresh for shibboleth
Martin Renvoize [Fri, 18 Sep 2015 08:10:27 +0000 (08:10 +0000)]
Bug 14034: Fix logout on refresh for shibboleth

This is similar to bug 12877

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
While this is missing a detailed test plan, what I did to test was

1/ Login to koha .. it works
2/ Apply patch
3/ Login to koha .. it still works, no regressions. I can't test the
shibboleth part but it doesnt break anything else so I'm happy to sign
off

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
We had to implement this fix for one of our customers using Shibboleth.
Can verify that it fixes the issue (which, incidentally, breaks
stage-marc-import since that depends on a constant sessionID).

Passing QA (verified with QA tools). Thanks, Martin!

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoremoving the actomic update
Brendan Gallagher [Thu, 31 Dec 2015 20:39:01 +0000 (20:39 +0000)]
removing the actomic update

8 years agoBumping the DBrev to .014 (fixed earlier DBrev too)
Brendan Gallagher [Thu, 31 Dec 2015 20:36:30 +0000 (20:36 +0000)]
Bumping the DBrev to .014 (fixed earlier DBrev too)

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues
Charles Farmer [Tue, 1 Dec 2015 13:55:50 +0000 (08:55 -0500)]
Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues

There is already a syspref called "OverdueNoticeBcc" for sending Bcc
copies of mails sent for overdues and other notices. This patch add a
new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues
alerts.

Changed the wording of the system preference to:

[Send|Don't send] blind copy (BCC) to logged in user when sending
serial or acquisitions claims notices.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14131: Reduce the greybox height to 400px
Jonathan Druart [Fri, 23 Oct 2015 08:21:21 +0000 (09:21 +0100)]
Bug 14131: Reduce the greybox height to 400px

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14131 - Adding print patron cards to patron lists home page
Liz [Thu, 15 Oct 2015 04:11:39 +0000 (04:11 +0000)]
Bug 14131 - Adding print patron cards to patron lists home page

To test:

Go to /cgi-bin/koha/patron-lists/lists.pl
Make a patron list
Click "Print patron cards"
Success: you get a pdf of cards to print.
Failure: you can't get a pdf of cards to print.

Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14131 - Patroncard: Add possibility to print from patron lists
Marc Véron [Sun, 3 May 2015 21:26:11 +0000 (23:26 +0200)]
Bug 14131 - Patroncard: Add possibility to print from patron lists

This patch adds the possibility to print patron cards from patron lists.

To test:

- Go to Home > Tools > Patron card creator
- Prepare a patron card and create some cards using the batch functionality
- Apply patch
- Prepare a patron list e.g. from patron search
- Go to Home > Tools > Patron card creator > Manage batches
- Below the list of batches you have a dropdown to select a patron list
- Select your list and hit "Export from patron list"
- Select template and layout as you would do with batches
- Hit "Export"
- Download PDF

Modified patch to work with Bug 14676 changes. Functionality unchanged.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Liz <wizzyrea@gmail.com>
(Amended to make it apply on current master)

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoAdding Koha.pm update
Brendan Gallagher [Thu, 31 Dec 2015 19:47:06 +0000 (19:47 +0000)]
Adding Koha.pm update

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoRemoving the amoticupdate file
Brendan Gallagher [Thu, 31 Dec 2015 19:45:35 +0000 (19:45 +0000)]
Removing the amoticupdate file

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoUpdating the DBrev.
Brendan Gallagher [Thu, 31 Dec 2015 19:44:50 +0000 (19:44 +0000)]
Updating the DBrev.

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14945: Add 2 more tests for StoreLastBorrower
Jonathan Druart [Wed, 9 Dec 2015 10:24:15 +0000 (10:24 +0000)]
Bug 14945: Add 2 more tests for StoreLastBorrower

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14945 - Add the ability to store the last patron to return an item
Kyle M Hall [Mon, 5 Nov 2012 19:35:23 +0000 (14:35 -0500)]
Bug 14945 - Add the ability to store the last patron to return an item

Currently if the AnonymousPatron system preference is in use, all patron
data is anonymized. Some libraries would like to be able to see the last
patron who returned out an item ( in case of damage ) but still keep all
other patrons anonymized.

* Add the table items_last_borrower ( id, itemnumber, borrowernumber )
* Add new system preference StoreLastBorrower
* If StoreLastBorrower is enabled, upon checkin have Koha insert into
  this table the patron who last returned this item. Replace existing
  row based on itemnumber if exists.
* If table has a row for a given item, link to the patron from the item
  details page.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Enable StoreLastBorrower
4) Issue an item to a patron and return said item
5) Issue the same item to a second patron, do not return it.
6) View moredetail.pl for the given bib, find the given item. There
   should be a new field in the history list 'Last returned by' with a link
   to the last patron to return the item.

Optionally, you can also verify this works even if patron issuing
history has been set to anonymize issues upon return.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jen DeMuth <JDeMuth@roseville.ca.us>
Signed-off-by: Tom Misilo <misilot@fit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it
Joonas Kylmälä [Wed, 4 Nov 2015 15:15:04 +0000 (15:15 +0000)]
Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it

Test plan:
1. Make sure that in koha/admin/smart-rules.pl you can still create
   new rules and that the new rules have all their values remained
   after saving the rule (so put to every field something).
2. Make sure you can edit that rule
3. Make sure you can delete that rule

Sponsored-by: Vaara-kirjastot
Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: Add tests for Koha::BiblioFramework[s]
Jonathan Druart [Mon, 26 Oct 2015 08:56:49 +0000 (08:56 +0000)]
Bug 14889: Add tests for Koha::BiblioFramework[s]

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: Fix error msg on duplicate
Jonathan Druart [Mon, 26 Oct 2015 08:55:43 +0000 (08:55 +0000)]
Bug 14889: Fix error msg on duplicate

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: QA Follow-up
Katrin Fischer [Sun, 25 Oct 2015 09:33:50 +0000 (10:33 +0100)]
Bug 14889: QA Follow-up

- Removes unused package from BiblioFramework.pm
- Makes framework table sortable
- Some small changes in wording of error messages

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: Use Koha::BiblioFramework[s] in admin/biblio_framework.pl
Jonathan Druart [Thu, 24 Sep 2015 15:08:54 +0000 (16:08 +0100)]
Bug 14889: Use Koha::BiblioFramework[s] in admin/biblio_framework.pl

Test plan:
Add/edit/remove biblio frameworks from the administration module
(admin/biblio_framework.pl).
You should get message feedback after each action.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No problems found. Tested add/edit/delete
No koha-qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 14889: Add Koha::BiblioFramework[s] classes
Jonathan Druart [Thu, 24 Sep 2015 15:08:49 +0000 (16:08 +0100)]
Bug 14889: Add Koha::BiblioFramework[s] classes

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15381: Fix error in SearchAuthorities when no authtypecode
Frédéric Demians [Sun, 20 Dec 2015 16:17:08 +0000 (17:17 +0100)]
Bug 15381: Fix error in SearchAuthorities when no authtypecode

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15381: Remove GetAuthType and GetAuthTypeCode
Jonathan Druart [Tue, 15 Dec 2015 13:43:47 +0000 (13:43 +0000)]
Bug 15381: Remove GetAuthType and GetAuthTypeCode

Test this patch with the previous one.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15381: Remove getauthtypes and getauthtype
Jonathan Druart [Tue, 15 Dec 2015 13:19:53 +0000 (13:19 +0000)]
Bug 15381: Remove getauthtypes and getauthtype

These 2 subroutines are now not necessary anymore, we can use
Koha::Authority::Types to retrieve the authority types.

This patch won't be easy to test. Indeed, a lot of file are updated.
To test it I would suggest to focus on the merge authority

You should also confirm that the authtypecode and the authtypetext
values are correctly displayed when navigating in the authority module.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15381: Use Koha::Authority::Types in some other places
Jonathan Druart [Tue, 15 Dec 2015 11:59:02 +0000 (11:59 +0000)]
Bug 15381: Use Koha::Authority::Types in some other places

There are 3 place where the auth_types table were requested directly
from the script or a subroutine.  These 3 occurrences are easy to
replace with the new module.

Test plan:
1/ Search for authorities and use the "did you mean" feature for
authorities.
Focus on the authtypecode
2/ Edit authority and biblio frameworks.
The "Thesaurus" dropdown list should be correctly populated (UNIMARC
only).

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15380: Use Koha::Authority::Type[s] in admin script
Jonathan Druart [Tue, 15 Dec 2015 11:41:51 +0000 (11:41 +0000)]
Bug 15380: Use Koha::Authority::Type[s] in admin script

This path rewrites the admin/authtypes.pl script to use the new modules
instead of executing the SQL queries from the script.

Test plan:
1/ Create 1+ authority types
2/ Update one
3/ Delete it
4/ Create an authority record using this authority type.
5/ Try to delete the authority type
Here there is a change in the behavior.
Prior to this patch, the user was able to delete the authority type, now
it's not.
I think it was a bug, feel free to give your opinion if you disagree on
this change.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s]
Jonathan Druart [Tue, 15 Dec 2015 11:41:24 +0000 (11:41 +0000)]
Bug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s]

Based on Koha::Objects.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority
Jonathan Druart [Tue, 15 Dec 2015 10:21:02 +0000 (10:21 +0000)]
Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority

The existing Koha::Authority does not use Koha::Objects and does not
exclusively deal with DB objects.
It makes much sense to move it to let the space free for a
Koha::Authority and Koha::Authorities modules based on Koha::Object.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBumping the DBrev up
Brendan Gallagher [Thu, 31 Dec 2015 18:38:40 +0000 (18:38 +0000)]
Bumping the DBrev up

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 13022 [QA Followup] - Highlight the results with inaccurate status, add explanati...
Kyle M Hall [Fri, 17 Apr 2015 14:41:13 +0000 (10:41 -0400)]
Bug 13022 [QA Followup] - Highlight the results with inaccurate status, add explanation when mouse hovers over.

Bug 13022 [QA Followup] - Revert changes in whitespace back to original for items count lines

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 13022 [QA Followup] - Allow the pref to be unset for unlimited item status checks
Kyle M Hall [Fri, 17 Apr 2015 13:51:03 +0000 (09:51 -0400)]
Bug 13022 [QA Followup] - Allow the pref to be unset for unlimited item status checks

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate...
Kyle M Hall [Thu, 2 Oct 2014 13:19:21 +0000 (09:19 -0400)]
Bug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate statuses

If a record has more than 20 items, all the items over 20 will show as
available on the search results even if they are not!

This is a hard coded limit in the Search module. This number should be
configurable.

Test Plan:
1) Create a record with more than 20 items
2) Set all the items to waiting holds or in transit
3) Search for results that will include that item
4) Note some say they are available even though they are not
5) Apply this patch
6) Run updatedatabase.pl
7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck
   to a number larger than the number of items on your record
8) Re-run the search
9) Note that the hold and transit statuses for the items are now correct

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
8 years agoBug 10154: QA follow-up - Spelling and terminology
Katrin Fischer [Mon, 30 Nov 2015 23:47:54 +0000 (00:47 +0100)]
Bug 10154: QA follow-up - Spelling and terminology

- Changing capitalization: Any Patron category > Any patron category
- Changing Collection code > Collection

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 10154 Add Call number in the filter of most circulated items
Eivin Giske Skaaren [Wed, 28 Oct 2015 00:28:28 +0000 (00:28 +0000)]
Bug 10154 Add Call number in the filter of most circulated items

This patch adds call number, collection code and shelving location to
the filter.

To test:

It is of course a prerequisite to have items in the DB with the correct
MARC fields and that they have been checked out etc. to get a valid
result when testing.

1. Apply patch to koha synced to master.
2. Go to /cgi-bin/koha/reports/cat_issues_top.pl
3. Select filters, the new ones are Call number, Collection code and
   Shelving location
4. Hit submit.

Expected result:
The filters chosen will be printed under "Filtered on".
A table with the result is shown.

For manual verification here is some SQL to run:

SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues`
                  LEFT JOIN items USING(itemnumber)
                  LEFT JOIN biblio USING(biblionumber)
                  LEFT JOIN biblioitems USING(biblionumber)
                  LEFT JOIN borrowers USING(borrowernumber)
                  WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC;

Put in your valid values in the WHERE clause for the values in the
single quotes ''.

Sponsored-by: Halland county library
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  It works as described. Valid results, tested in various combinations.
  Follows the coding (awful) style of the original script, without
  introducing any regression. It would have been great to have
  callnumber interval, but anyway...

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 12923 Improve error logging for advance_notices.pl
Olli-Antti Kivilahti [Mon, 15 Sep 2014 08:42:34 +0000 (11:42 +0300)]
Bug 12923 Improve error logging for advance_notices.pl

Show borrowernumber when no letter of type is found and force utf8
output when running advance_notices.pl with -n flag, diacritics run awol
in the console output!

Also when debugging which borrower requests undefined letter templates,
it is very handy to log the borrowernumber so we catch and fix bad
borrower message transport settings.

TEST PREPARATION:

0. Edit the ODUEDGST letter, find an undefined letter for any trasport
   type.

::TESTS ARE (ALMOST) THE SAME AS IN bugg 12922::
TEST PLAN:

1. Find a borrower and from the messaging preferences set the "Advance
   notice" transport type to the undefined digest. Set the "Days in
   Advance" to 1.
2. Check-out something for that borrower and set the due date for
   tomorrow.
3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal.
4. BEFORE THIS PATCH: You get an error "no letter of type 'PREDUEDGST'
   found. Please see sample_notices.sql at ./advance_notices.pl line
   366."
4. AFTER THIS PATCH: You get an error "no letter of type 'PREDUEDGST'
   found for borrowernumber 1104659. Please see sample_notices.sql at
   ./advance_notices.pl line 368."
   Makes life more worth living for!
   Also diacritics printed on screen are displayed properly.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  I confirm the diacritics issue and solution. borrowernumber is
  displayed with warning when the 'no letter...' message is displayed.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592 - DBrev 3.23.00.011
Kyle M Hall [Thu, 31 Dec 2015 16:01:26 +0000 (16:01 +0000)]
Bug 13592 - DBrev 3.23.00.011

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592 [QA Followup] - Make the system preference description self documenting
Kyle M Hall [Fri, 18 Dec 2015 18:50:32 +0000 (18:50 +0000)]
Bug 13592 [QA Followup] - Make the system preference description self documenting

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 13592: Add an option to charge for any hold placed
Jonathan Druart [Wed, 11 Nov 2015 15:12:45 +0000 (15:12 +0000)]
Bug 13592: Add an option to charge for any hold placed

Currently the fee is applied on if all items for the record are issued
and at least one hold already exists on the record.
This patch does not give a complete answer to the problem (see
discussion on bug 13592 for the other user's expectations).
It only adds the ability to charge for any hold placed regardless of the
conditions.

Test plan:
1) Execute the updatedb entry to insert the new pref
2) Confirm that the behavior is the same as before applying this patch
3) Change the HoldFeeMode pref to 'always'
4) Note that the fee is applied for any hold placed

Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15225: [QA Follow-up] Improve changes to gethtml5media
Marcel de Rooy [Wed, 16 Dec 2015 14:54:49 +0000 (15:54 +0100)]
Bug 15225: [QA Follow-up] Improve changes to gethtml5media

[1] Improve readability, add some checks.
[2] Add the public flag for OPAC use. (If a file has not been marked as
    public, we should not return it in OPAC.)

Test plan:
See original commit. No changes in behavior.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15225: Make HTML5Media work with file upload feature.
Mirko Tietgen [Mon, 16 Nov 2015 17:10:27 +0000 (18:10 +0100)]
Bug 15225: Make HTML5Media work with file upload feature.

Koha::Upload allows files to be attached to bibliographic records.
HTML5Media streaming in Koha does not work with these files.

Test plan:
- apply patch
- make sure OPACBaseURL is set correctly
- enable HTML5MediaEnabled in OPAC and staff client
- connect upload.pl to 856$u in your framework
- upload a file with an extension set in HTML5MediaExtensions,
  make sure to set the codec correctly if you use WEBM (subfield c,
  eg. 'vp8, vorbis')
- save record, view in staff client and browser, check if 'Play
  media' option is available and works

Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15321: No need to add the change trigger conditionally
Jonathan Druart [Wed, 9 Dec 2015 09:04:35 +0000 (09:04 +0000)]
Bug 15321: No need to add the change trigger conditionally

It will be applied if the button exists.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 15321 - Add delete report link to Show, Edit and Run screens
Magnus Enger [Tue, 8 Dec 2015 19:45:39 +0000 (20:45 +0100)]
Bug 15321 - Add delete report link to Show, Edit and Run screens

Currently, if you are editing or viewing the results of running a
report and you decide you want to delete it, you have to go back
to the list of saved reports to do so. This patch adds a "Delete"
link in some convenient places.

To test:
- Apply the patch
- Make sure you have at least one saved report
- Make sure you have the create_reports permission
- Go to the Show, Edit and Run screens and verify the Delete link
  is present and functional, including the JavaScript confirmation
  dialogue
- Change to a user without the create_reports permission and check
  that the Delete link is not displayed on the Show, Edit and Run
  screens
- Sign ye off merrily!

Version 2: This version makes sure the JavaScript confirmation is
shown before an actual delete is carried out.

Signed-off-by: Heather Braum <hbraum@nekls.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - DBrev 3.23.00.010
Kyle M Hall [Thu, 31 Dec 2015 15:35:31 +0000 (15:35 +0000)]
Bug 9129 - DBrev 3.23.00.010

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 [QA Followup] - Make unit test file conform to PBP
Kyle M Hall [Thu, 31 Dec 2015 15:31:19 +0000 (15:31 +0000)]
Bug 9129 [QA Followup] - Make unit test file conform to PBP

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - Add the ability to set the maximum fine for an item to its replacement...
Kyle M Hall [Thu, 22 Oct 2015 10:40:12 +0000 (06:40 -0400)]
Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price

This patch adds the ability to set the maximum fine for a given item to
its replacement price ( assuming the replacement price is set ). If
overduefinescap is also set, the fine will be the lesser of the two, if
both apply to the given overdue checkout.

To enable this new limit, create or edit your circulation rules and
check the checkbox for "Cap fines at replacement price"

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Pick an item, and set it's replacement price to 3.99
4) Edit the circulation rule that would apply to this item
   and the patron you will check it out to.
5) Check out the item to the patron, and backdate the due date
   such that the fine generated would be more than 3.99
6) Enable CalculateFinesOnReturn
7) Return the item, and view the fine generated, it should be 3.99

Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - Update schema
Kyle M Hall [Thu, 31 Dec 2015 15:29:13 +0000 (15:29 +0000)]
Bug 9129 - Update schema

Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 9129 - Update database
Kyle M Hall [Thu, 22 Oct 2015 10:38:57 +0000 (06:38 -0400)]
Bug 9129 - Update database

Signed-off-by: Cindy Murdock Ames <cmurdock@ccfls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14939: Remove the Capture::Tiny dependency
Jonathan Druart [Thu, 10 Dec 2015 12:56:44 +0000 (12:56 +0000)]
Bug 14939: Remove the Capture::Tiny dependency

It's possible to redirect the std output to a variable, it will avoid to
add this new dependency.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  OK. + code factorisation with a function call.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14939: Modularize OAI Server existing classes
Frédéric Demians [Fri, 2 Oct 2015 07:18:18 +0000 (09:18 +0200)]
Bug 14939: Modularize OAI Server existing classes

Koha OAI server has been done in one unique .pl file because there
wasn't any object model or rules in the Koha project when it has been
coded. This patch modularized existing classes, putting each class in a
separate file in Koha::OAI::Server namespace. UT begining.

Add new dependency: Capture::Tiny

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
OAI server moduralized succefully. Works for Debian Jessie and
Wheezy. Test pass successfully

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 12342: Patron registration datepicker dropdown shows only 10 years
Martin Persson [Tue, 12 May 2015 11:33:14 +0000 (13:33 +0200)]
Bug 12342: Patron registration datepicker dropdown shows only 10 years

This patch changes the options to the date picker, allowing easy
selection of dates up to 120 years from the current date.

To test:
- Click on 'Patrons' from the main menu, select 'New patron'
- Set input focus to the 'Date of birth' input field,
  the date selection widget should show up.
- The year selection drop-down will only show current year minus 10.
- Apply the patch
- Go back to the same screen, set input focus to the 'Date of birth' field.
- The year selection drop-down should show current year minus 120.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 14397: Fix tiny typo in database documentation
Katrin Fischer [Sun, 22 Nov 2015 02:01:18 +0000 (03:01 +0100)]
Bug 14397: Fix tiny typo in database documentation

Fixes Foriegn to Foreign.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>