Nahuel Angelinetti [Thu, 27 Nov 2008 16:39:12 +0000 (17:39 +0100)]
No more used since a while.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Mon, 1 Dec 2008 09:06:01 +0000 (10:06 +0100)]
Delete all calls to thesaurus_popup.pl, and no more used plugins.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Sat, 22 Nov 2008 06:21:21 +0000 (07:21 +0100)]
Updating default UNIMARC framework
The previous one was out of date and contained some errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 21 Nov 2008 00:49:23 +0000 (18:49 -0600)]
bug 2801 followup
Quell unitialized value warnings emited when
'use warnings' was added.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 18 Nov 2008 20:50:00 +0000 (14:50 -0600)]
Bug 2801 followup... [SQUASHABLE]
Apparently my git skills are lacking, since I intended this one-liner
to be amended into the patch I resent.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 18 Nov 2008 16:33:54 +0000 (10:33 -0600)]
Bug 2801 and other cleanup.
In addition to documented bug:
~ SearchString took an unused argument,
~ refactored repeated code into column_picks(),
~ fixed display during delete_confirm, including "name",
~ removed unused C4::Dates dependency.
Resend: typo fixed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:21 +0000 (14:58 +0100)]
Bug Fix : 2686
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 21 Nov 2008 00:12:42 +0000 (18:12 -0600)]
bug 2531 followup
* & -> & in URL for XHTML validation
* (unrelated to prior patch) remove broken link to
button-bg.png for confirm button
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Allen Reinmeyer [Mon, 17 Nov 2008 21:10:27 +0000 (15:10 -0600)]
Bug #2531 Cannot delete private shelf
Added logic to create a list of private lists to check on deletion. Multiple pages have the ability to delete lists, both private and public. Default option of retrieving a user's lists is retrieving the public ones. Now private lists of the owner are retrieved as well and checked upon deletion request. This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list. Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.
UPDATE: added logic for conditional creation of shelves. Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting. The confirm message showed, but the display was of public shelves, not private.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Wed, 19 Nov 2008 15:56:12 +0000 (09:56 -0600)]
bug 2787 : Fix Global Due date
This patch also lightly refactors the conditional structure wrapping the
call to AddItem, renaming a couple variables to remove double-negatives and
abstruse logic. If SpecifyDueDate is ON, then the input box is used to pass
GlobalDueDate, allowing modification by circ staff, resulting in a default
'sticky' due date of the global due date in that mode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Wed, 19 Nov 2008 13:58:31 +0000 (14:58 +0100)]
fix for bug 2447: yuipath variable not getting passed to help pages
This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric DEMIANS [Wed, 19 Nov 2008 13:58:30 +0000 (14:58 +0100)]
Get back boolean button on OPAC Advanced Search page
With this patch, on OPAC Advanced Search page, when More Options is
selected, a boolean combo box appears in front of fields combo box.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:25 +0000 (14:58 +0100)]
Bug 2790 no UNIMARC search on avail items [1/2]
Changing record.abs file to add the management of acquisition date,
modification date and lost
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Wed, 19 Nov 2008 15:55:38 +0000 (09:55 -0600)]
Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
See bugzilla for details.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 18 Nov 2008 22:50:25 +0000 (16:50 -0600)]
bug 2802 followup: remove another reference to "branches"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 18 Nov 2008 15:18:15 +0000 (16:18 +0100)]
bug fix : 2805
deleting die on lack of user/password in config file.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 18 Nov 2008 16:01:27 +0000 (10:01 -0600)]
Language corrections: branch -> library. Changing "Libraries, branches, and groups" to "Libraries and groups." Fixes Bug 2802.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 18 Nov 2008 21:40:18 +0000 (15:40 -0600)]
bug 2654: require circulate permission to upload offline circ files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 18 Nov 2008 21:40:17 +0000 (15:40 -0600)]
bug 2606: reduce size of offline circ patron database
Reduce the size of the SQLite database produced by
create_koc_db.pl by emiting only the columns
actually used by Kyle Hall's offline circ client.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 18 Nov 2008 22:17:16 +0000 (15:17 -0700)]
add isbn to cataloging search results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Mon, 17 Nov 2008 16:18:18 +0000 (17:18 +0100)]
Do not show the language chooser
This patch change the footer of authority search results popup to use the popup footer, so do not show the language chooser.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 17 Nov 2008 16:18:38 +0000 (10:18 -0600)]
moved Test_CSV_Various.t to xt/author
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 7 Nov 2008 21:49:59 +0000 (15:49 -0600)]
Results of CSV module analysis, testing various CSV modules and configs.
The upshot is that despite appearances, whe should NEVER use Text::CSV::Unicode
or any CSV module in non-binary mode. Text::CSV works in binary mode
by using Text::CSV_XS, so the behavior is the same for both (in binary).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Marc Chantreux [Mon, 10 Nov 2008 16:40:13 +0000 (17:40 +0100)]
use DESTDIR now
takes carre of changes in Makefile.PL about debian install
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frederic Demians [Sun, 16 Nov 2008 08:50:54 +0000 (09:50 +0100)]
Fixes bug #2788 - CoinS support
1 In URL rft.tpages is replaced with rft.page. That's what
Zotero expects.
2 TMPL_VAR NAME="size" is replaced with "pages" for 1.
3 TMPL_VAR NAME="publisher" is replaced with "publishercode"
the correct value for rft.pub
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frederic Demians [Mon, 17 Nov 2008 08:34:50 +0000 (09:34 +0100)]
Bug #2794: Browse Shelf doesn't work with ISBN containing '-'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 17 Nov 2008 15:21:33 +0000 (09:21 -0600)]
bug 1891 followup - remove dangling /TMPL_IF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 11 Nov 2008 20:47:51 +0000 (14:47 -0600)]
adding "DROP TABLE" commands to several table definitions in kohastructure.sql
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Wed, 12 Nov 2008 03:05:03 +0000 (22:05 -0500)]
bug 1891 : bib-level itemtype was required in order to place a hold.
This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values. Code previously required a value
in biblioitems.itemtype in order to place hold.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 13 Nov 2008 00:19:20 +0000 (18:19 -0600)]
bug 2779: fix template syntax error in OPAC home page
Fixes cause of following message in Apache log:
[Wed Nov 12 14:33:36 2008] [error] [client xxxxx] HTML::Template::Pro:in
TMPL_IF at pos 2860:end tag:found e instead of > at pos 2886
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 11 Nov 2008 22:02:34 +0000 (16:02 -0600)]
fix POD error
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 11 Nov 2008 20:34:13 +0000 (14:34 -0600)]
Bug 2775: adding method to clean syspref cache in C4::Context
C4::Installer provides a way to update the kohaversion syspref. Now that
C4::Context caches syspref values, any updated value through C4::Installer
is not being seen.
This patch adds a method to C4::Context to allow you to clean that
cache. Then, it calls that method when the kohaversion syspref is changed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Fri, 7 Nov 2008 22:33:23 +0000 (11:33 +1300)]
Updated Italian translation files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 28 Oct 2008 00:31:25 +0000 (19:31 -0500)]
Removing some unused stuff from print stylesheet, hiding Koha logo from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Thu, 30 Oct 2008 09:35:59 +0000 (10:35 +0100)]
Fix overdue list if you do not specify a branchcode.
Before, if you do not provide a "branchcode" you have an empty csv export.
Now, if you have an empty branchcode you have all overdues listed in csv.
(I made a typo error in code)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Fri, 31 Oct 2008 14:54:47 +0000 (15:54 +0100)]
Do not allow an user to have an empty date
If the user set an empty date as the expiration date during a patron modification, we recalculate the expiration date with sysprefs and the registration date.
Before, when you set an empty date, 0000-00-00 is put in the database (too bad).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frederic Demians [Sat, 25 Oct 2008 08:38:37 +0000 (10:38 +0200)]
Improve C4::Charset::MarcToUTF8Record performance
A script like bulkmarkimport.pl spends most of the time
in C4::Charset::MarcToUTF8Record function, and
specifically in C4::Charset::char_decode5426
just initializing a hash. This patch moves this
hash outside function to avoid its initializing
each time the functon is called.
A test on a specific conversion script shows me
that performances were improved from 23s to 8s.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Mon, 27 Oct 2008 09:37:46 +0000 (10:37 +0100)]
A typo error was in the tmpl does not allow the user to sort by acquisition date.
The patch fix this, after changing a bad "if".
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Clay Fouts [Thu, 30 Oct 2008 02:22:15 +0000 (19:22 -0700)]
Database connectivity cleanups
This patch employs process-local caching of systempreferences and
eliminates the "select 1" execution every time dbh() is called.
DBI::ping() is used instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
John Beppu [Wed, 5 Nov 2008 16:51:32 +0000 (10:51 -0600)]
bug 2563: could not input into marc 008, fields 7-10 and 11-14
You actually *could* input data into those fields, but it wasn't
immediately obvious, because the field size was "4" and the
value was " ". You couldn't type anything in until you
backspaced over the spaces that were there by default.
UPDATE 2008-11-05: Make absolutely sure that those values
are 4 chars long (via JavaScript)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 3 Nov 2008 20:07:44 +0000 (14:07 -0600)]
Correcting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Wed, 5 Nov 2008 15:43:11 +0000 (16:43 +0100)]
Add a dependance to CGI::Session::serialize::yaml 4.20
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Allen Reinmeyer [Wed, 5 Nov 2008 20:14:40 +0000 (14:14 -0600)]
Bug #2760 wrong permissions for guided reports
Guided reports and dictionary access was dependant on the editcatalogue permission instead of the report permission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Allen Reinmeyer [Thu, 6 Nov 2008 20:43:26 +0000 (14:43 -0600)]
UPDATE:Bug #2756 opacbookbag preference turns off add items to list
There was a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list. Javascript wasn't including basket.js on virtualshelves option. Also, 'Save to Lists' was calling addtoshelf instead of addtolist. Functionality is now the same for virtualshelves regardless of opacbookbag status.
UPDATED: Removed EXPR in TMPL_IF conditions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Thu, 6 Nov 2008 08:41:48 +0000 (09:41 +0100)]
Some tab cleaning
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Thu, 6 Nov 2008 08:34:06 +0000 (09:34 +0100)]
fix the private shelf deletion in opac
this patch add an "hidden" field in the template, that permit in C4::VirtualShelves::Pages to get the right(privates) shelves with
GetShelves in$
of always public shelves.
So when a private shelf is wanted to be deleted, the script watch only in public shelves if the shelf exists, and doesn't work.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 6 Nov 2008 19:04:11 +0000 (13:04 -0600)]
Adding javascript to let user click table cell to check containing checkbox.
This is a usability improvement as it widens the target of the click. The script for moremember.pl includes code necessary to uncheck its sibling as per uncheck_sibling(). If this patch is approved I will look for other instances so that <td> interactions will be consistent.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Thu, 6 Nov 2008 10:58:38 +0000 (11:58 +0100)]
make some line REAL comments, else the installer is buggous
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 30 Oct 2008 05:10:57 +0000 (00:10 -0500)]
Squash warnings by checking if $type is defined before comparing it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 27 Oct 2008 19:41:01 +0000 (14:41 -0500)]
This file was missing from previous commit. bakertaylorimages.js manages the display of 'missing cover' text when Baker & Taylor images are used.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 27 Oct 2008 16:55:13 +0000 (11:55 -0500)]
Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
John Beppu [Fri, 24 Oct 2008 14:45:24 +0000 (09:45 -0500)]
bug 2707 - overdue rules not being deleted
* I added some code to detect the rows which were blank,
and I deleted them upon saving the form.
* Updated to get the categories from the database
instead of hardcoding them.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 30 Oct 2008 05:14:25 +0000 (00:14 -0500)]
Circ cleanup.
Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort. The rest is whitespace cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Tue, 4 Nov 2008 20:34:53 +0000 (14:34 -0600)]
Allow SIP checkout to pre-empt unfilled holds.
This affects transactions on items that may be covered by
a title or item-level hold, but have not yet been retrieved
from the stacks (i.e. "confirmed") by the librarian. This does
not affect waiting holds (found="W"), so they will still block
transaction unless they belong to the operating patron.
Also I cleanup any hold the patron has on a biblio/item when
they are allowed to checkout the item.
Here we are filling the hold because the checkout is allowed, regardless
of of the queue position. This is different from AddIssue's CancelReserve, that
only fills the hold if it is next in line, but in the future AddIssue should
adopt a similar logic.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Tue, 4 Nov 2008 20:34:52 +0000 (14:34 -0600)]
followup - make barcode_to_borrowernumber an internal function
Set this function apart with _ since it is not OO like the rest.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Clay Fouts [Tue, 28 Oct 2008 00:04:25 +0000 (17:04 -0700)]
bug 2729: redundant call to C4::Biblio::get_biblio_authorised_values
Removes redundant and expensive call to C4:Biblio:get_biblio_authorised_values
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 28 Oct 2008 00:31:34 +0000 (19:31 -0500)]
Standardizing opac/circulation note terminology; Adding hint to opac/circulation note entry
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 28 Oct 2008 00:40:03 +0000 (19:40 -0500)]
Terminology and spelling corrections. Fixes Bug 2724.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 29 Oct 2008 14:16:41 +0000 (09:16 -0500)]
Spelling correction: catalogue -> catalog. Fixes Bug 2730.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 14 Oct 2008 20:36:42 +0000 (14:36 -0600)]
Add fine amount to display on circ pages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Oct 2008 21:07:19 +0000 (16:07 -0500)]
bug 2682: followup - only do lc() on $op once
Per suggestion by Joe Atzberger.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 15:36:32 +0000 (10:36 -0500)]
Fix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on value of submit buttons didn't take into account capitalization.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 19 Sep 2008 21:24:22 +0000 (16:24 -0500)]
Unravelling links in masthead. Regularize logic and improve readability.
Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself. This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc. I would argue even this is undesirable. At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery. IMHO, masthead itself should not be engage in such trifling
interface polishes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Allen Reinmeyer [Thu, 23 Oct 2008 19:16:18 +0000 (14:16 -0500)]
Bug #2709 Cannot add from Search to New list
While a new list was created, no subsequent call to add the biblio number was made,
thus a new empty list would be created every time.
Under the existing list add, the same code to add items would also apply to a new list,
so I refactored out the logic to add items and made a new subroutine.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Oct 2008 17:34:05 +0000 (12:34 -0500)]
followup to Calendar overhaul
correct an errant "SELECT FROM" that slipped in
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 19 Sep 2008 00:02:47 +0000 (19:02 -0500)]
Begin Calendar overhaul, turn on warnings.
Reuse SQL with placeholders where possible.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Oct 2008 17:05:56 +0000 (12:05 -0500)]
bug 2543: follow-up patch
Add 'use C4::Reports' lines that original patch
omitted.
Note that original patch prevented these two reports
from even compiling. Not good.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Wed, 10 Sep 2008 00:31:31 +0000 (19:31 -0500)]
fix for bug 2543: report output by tabulation a bit too literal
This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 23 Oct 2008 16:01:03 +0000 (11:01 -0500)]
Patch security hole in vestigial report.
IMHO, this report should be removed in entirity because of its faulty
construction and total inability to distinguish between register "tills".
That is, it appears to be a valid accounting measure but isn't.
In any case, it let's not let just anybody run it!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:31 +0000 (18:11 -0500)]
followup 5 to renewal limit override
With removal of content_hidden CSS class from
the circ templates, undoing change to staff-global.css
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:30 +0000 (18:11 -0500)]
followup 4 to renewal limit override
* use style="display: none" instead of content_hidden
* fix JavaScript so that actions that check/uncheck
items for a renew or return do not affect
the override renewal limit checkbox
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:29 +0000 (18:11 -0500)]
followup 3 to to renewal limit override
style="display: none" suffices to have a span
be hidden initially; content_hidden is not necessary.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:28 +0000 (18:11 -0500)]
followup 2 to to renewal limit override
Remove duplicate entry for SMSSendDriver syspref
added by original patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:27 +0000 (18:11 -0500)]
followup 1 to to renewal limit override
Update POD for CanBookBeRenewed().
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 22 Oct 2008 23:11:26 +0000 (18:11 -0500)]
Allow renewal limits to be overridden
Originally by Jesse Weaver <jesse.weaver@liblime.com>
This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 16 Oct 2008 15:45:29 +0000 (10:45 -0500)]
Steamlining javascript for cloning additem block and tweaking style.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 17 Oct 2008 14:19:12 +0000 (09:19 -0500)]
Adding some body IDs to OPAC pages to enable finer per-page control via CSS.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 20 Oct 2008 15:42:59 +0000 (10:42 -0500)]
Changing checkboxes to radio buttons (as it is in the OPAC), since you can't place a hold on more than one specific item. Also includes some markup cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 17 Oct 2008 14:19:24 +0000 (09:19 -0500)]
Show card number (non-editable) on opac-userupdate.pl. Also correctly formatting expiration date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
John Beppu [Wed, 22 Oct 2008 20:34:06 +0000 (15:34 -0500)]
1571
made the description show up by running the query w/ the required number of params
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Allen Reinmeyer [Wed, 22 Oct 2008 17:20:49 +0000 (12:20 -0500)]
Bug #2030 z3950 search function does not filter
Entering a term in the z3950 search box does not filter the results.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 20:22:46 +0000 (15:22 -0500)]
bug 2692: remove escape="url" from opac-facets.inc
Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.
For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 14:04:54 +0000 (09:04 -0500)]
OPAC-side ISBN display fix (Bug 2592)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 14 Oct 2008 18:50:47 +0000 (13:50 -0500)]
Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 15:18:14 +0000 (10:18 -0500)]
Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Fri, 17 Oct 2008 03:25:27 +0000 (22:25 -0500)]
Bug 2660: Add command-line options to overdue notice script.
This commit adds two options to the overdue_notices.pl script.
The notices are now generated in one of two modes: default or triggered.
In default mode, every time the script runs, a notice is generated if an item
is overdue within a notice date range. This mode is suitable for a weekly cron
(or manual run), but the notice triggers should be syncronized with the cron script such that
the script is run once per notice date range. Otherwise, duplicate messages will
be generated ( or no notice generated if a notice date range passes without the script being run).
Triggered mode is suitable for a nightly cron job: a notice is generated only on those
days that an overdue item enters a notice date range. This mode is susceptible to message
loss when the cron script fails to run, or when notice triggers are edited.
A second flag is added: --list-all, which causes items.content to list all currently overdue items.
Without this flag, only items that are overdue within the given notice's date range are listed on
that notice.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Fri, 17 Oct 2008 07:38:13 +0000 (09:38 +0200)]
Report to user the connections errors to z39.50 server, like timeout(10007), and refused(10000).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 16 Oct 2008 20:45:41 +0000 (15:45 -0500)]
followup - use & in place of &
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 19 Sep 2008 00:02:45 +0000 (19:02 -0500)]
Bug 2627: Allow Unicode data in import_borrowers, expand feedback on errors.
Date fields are now checked against syspref and iso regexps before attempting
to convert or insert them. The problem characters were non-ASCII diacriticals.
Note: this may rely on improvements in the current 0.54 version of Text::CSV and
Text::CSV_XS, rather than the Koha minimum of 0.01 and 0.32, respectively.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Thu, 16 Oct 2008 19:59:44 +0000 (13:59 -0600)]
fix calls to get_template_and_user in label-item-search.pl
remove extra flagsrequired line.
move call in first branch to the top.
This will be important is IndepenantBranches code is later added to,
for example, C4::Items::get_itemnumbers_of()
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 7 Oct 2008 18:51:07 +0000 (13:51 -0500)]
Some minor markup corrections to opac authorities pages. Some fixes to address Bug 2620.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 7 Oct 2008 17:30:27 +0000 (11:30 -0600)]
bug in 'Add/Change link to item details...' I missed Previous checkouts area
This turns the barcode into a link to moredetail.pl in the Previous
checkouts area of the circulation page, so it matches the Todays
checkouts area.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Thu, 9 Oct 2008 21:15:56 +0000 (16:15 -0500)]
Bug 2622 & 2623 : tools permissions for edit notice triggers and picture upload overly restrictive
removing requirements for parameters & management respectively for these two tools.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 7 Oct 2008 21:58:07 +0000 (15:58 -0600)]
Adding a few columns to members/readingrec.pl
Add barcode and issues.renewals to members/readingrec.pl
Had to change the query in C4/Members, items.renewals was squashing
issues.renewals.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 7 Oct 2008 22:04:14 +0000 (16:04 -0600)]
In members/readingrec.pl use itemcallnumber is classification isn't set
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 6 Oct 2008 01:40:24 +0000 (20:40 -0500)]
bug 2659: fix crash in OAI-PMH interface
When retrieving a record via the OAI-PMH interface, if one of the fields used
to prepare the DC metadata is not defined in the MARC framework (e.g.,
biblioitems.publicationyear in the default MARC21 framework), an OAI GetRecord
can fail with the following error:
> Can't call method "as_string" on an undefined value at
> /usr/share/koha/opac/cgi-bin/opac/oai.pl line 59.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 1 Oct 2008 20:14:56 +0000 (14:14 -0600)]
bugfix: Sort previous borrowers descending in Items.pm for moredetail.pl
The list of previous borrowers on moredetail.pl shows the three oldest
rather than the three most recent as I expected. This changes the sql
to order descending so we get the three most recent.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 16 Oct 2008 19:27:16 +0000 (14:27 -0500)]
bugfix: reenable listing suggestions by anyone
Change in parameter name in template not reflected
in script.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 2 Sep 2008 22:03:15 +0000 (00:03 +0200)]
Displaying branchnames rather than branchcodes
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 9 Sep 2008 20:33:32 +0000 (14:33 -0600)]
Don't pull all of biblioitems in GetItemsInfo
Pulling marc and marcxml for some 1200 copies takes a lot of RAM. Lets
not do that.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>