]> git.koha-community.org Git - koha.git/commit
Bug 29561: Remove blank facets
authorNick Clemens <nick@bywatersolutions.com>
Tue, 23 Nov 2021 14:42:54 +0000 (14:42 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 5 Dec 2022 18:18:25 +0000 (18:18 +0000)
commit3fb3a8c7d684d098b146be1067587563e159f93b
tree2d48973727c65790686173c532b79b3183458998
parent5b6b095f1f32cf41aef3e12a2e6374c8f29dbe33
Bug 29561: Remove blank facets

This patch strips the blank facets from the ES aggregations, this seems
to only affect language fields currently, but could affect any facetable field
that can contain blank values

To test:
1 - Have Koha running Elasticsearch with standard test data,
    or add some records with blank values in the 008/35-37
2 - Search for 'a'
3 - Look at the language facets, they should appear normal
4 - Browse to:
    http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=&q=a&sort_by=relevance_dsc&count=20&limit=ln:
5 - Note there is now an 'x' under the Languages facet - to remove a limit you cannot see
6 - Apply patch
7 - Reload
8 - Note the x is not there
9 - Inspect HTML, confirm no blank link under language facets

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit eeb12f8a521ccc470d2363fb6529a8c3e0cf78d5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/SearchEngine/Elasticsearch/Search.pm