]> git.koha-community.org Git - koha.git/commit
Bug 6877 - use is executed and errors at compile time
authorColin Campbell <colin.campbell@ptfs-europe.com>
Sat, 17 Sep 2011 11:45:09 +0000 (12:45 +0100)
committerPaul Poulain <paul.poulain@biblibre.com>
Fri, 25 Nov 2011 13:17:58 +0000 (14:17 +0100)
commit4f49dc5ad05289820916c6fd879e70f3adeee253
treea9c4a0391e32a83bd8a2cc5cf9a0a8d956b626ec
parent1f6ae97375038d222d9cfb2ced42188250bee460
Bug 6877 - use is executed and errors at compile time

Although use is being called in an eval it will still be executed
at compile time so that an error can cause the script to abort before
the eval is executed. The eval expression syntax is not checked
so eval block should be preferred.
Use require/import which execute at runtime which is the intention
here.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
checked that, with Libravatar OK things are still OK
opac/opac-detail.pl
opac/opac-showreviews.pl