Bug 27580: Handle NULL values correctly in Koha::Items->filter_by_visible_in_opac
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 29 Jan 2021 19:43:06 +0000 (16:43 -0300)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 8 Feb 2021 20:29:56 +0000 (20:29 +0000)
commit53811a1700f9e7083e24ab65f5b7291a2fa090be
treeb95dc010a35e60de6b0a5a4abb619f84406c1cc4
parent27bc87fed72a7e5499445a35278b76526f1a4a28
Bug 27580: Handle NULL values correctly in Koha::Items->filter_by_visible_in_opac

This patch fixes the internally used query so it doesn't consider NULL
values as IN the set.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> FAIL: Tests fail :-/
3. Apply this patch
4. Repeat 2
=> SUCCESS: tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b60ff6452ef2212a02f16ddc5c46edeb3d83a5e3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 606f47b2e91dcc51b1348356d672e95f8943ab8a)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Koha/Items.pm