]> git.koha-community.org Git - koha.git/commit
Bug 20145: Do not insert 0000-00-00 in patron tests (and more)
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 14 Feb 2018 18:15:39 +0000 (15:15 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 23 Mar 2018 10:16:24 +0000 (10:16 +0000)
commit9f075a4fdb2649493820ffed20a352add02c05ea
tree486fd8accf17baa335949f50d520d5c3801df815
parent71c81423dd10447e7179e28a5423eb95e15fb416
Bug 20145: Do not insert 0000-00-00 in patron tests (and more)

We should call Koha::Patron->is_expired in CanBookBeIssued instead of
doing the same calculation.

Tests have been adapted to pass with new SQL modes.

We should not need to update the values in DB, we already have
  Bug 14717: Prevent 0000-00-00 dates in patron data (3.21.00.023)

Test plan:
  prove t/db_dependent/Circulation/dateexpiry.t
  prove t/db_dependent/Koha/Patrons.t
must return green

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Conflicts:
C4/Circulation.pm
t/db_dependent/Koha/Patrons.t

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Circulation.pm
C4/Utils/DataTables/Members.pm
Koha/Patron.pm
t/db_dependent/Circulation/dateexpiry.t
t/db_dependent/Koha/Patrons.t