Bug 27548: "use of uninitialized value" warning on branchoverdues.pl
authorPetro Vashchuk <stalkernoid@gmail.com>
Mon, 25 Jan 2021 15:35:18 +0000 (17:35 +0200)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Tue, 9 Feb 2021 21:22:43 +0000 (21:22 +0000)
commitd766debe2c80bf991145e413308ef1a8b298286e
tree5311ec713b1f989d9a62ce1c44e1500d668df2a6
parenta41a188e7edf48cc077a254cfb82299ad6bb5b5a
Bug 27548: "use of uninitialized value" warning on branchoverdues.pl

On the beginning we have empty "location" parameter for this form,
but that not taken into account in comparison and undef warning emitted:
"Use of uninitialized value $location in string eq at
/usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72" in branchoverdues.pl

Fixed by adding pre-check for $location.

To reproduce:
    1) Head over to "Circulation ->Overdues with fines" page. Check
       intranet-error.log where there will be many warnings
       "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72".
    2) Apply the patch, refresh the "Overdues with fines" page.
    3) Ensure that the new "use of uninitialized value" warnings didn't appear in the console.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit c3d22687568640930bad9ffbb426033423e7efe9)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 44d1675aaf1e602e12ccd669dad50a299654f89d)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
circ/branchoverdues.pl