Bug 35588: Scope authorised value desc lookup according to field/subfield
authorDavid Cook <dcook@prosentient.com.au>
Mon, 18 Dec 2023 00:35:53 +0000 (00:35 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Thu, 28 Dec 2023 11:16:11 +0000 (12:16 +0100)
commitf53ebe874e74258e1465bc4ead3fdcd95008ca98
tree28a49b3d9d7d85095f8ff2cb80407b843e1e4957
parentca754a2c5e8508ee8a3399fcbc8954aa23eda19b
Bug 35588: Scope authorised value desc lookup according to field/subfield

This patch ensures that the authorised value descriptions looked up
are for the correct field/subfield designated in the CSV profile.

Test plan:
0. Do not apply the patch yet!
1. Go to http://localhost:8081/cgi-bin/koha/tools/csv-profiles.pl
2. Add a CSV profile with the default values and using the following
for the "Profile MARC fields":
000|001|003|005|006|007|008|010|015|016|020|022|040|050|082|100|110|
111|130|240|243|245|246|247|250|260|300|336|337|338|440|490|500|501|
505|520|530|600|610|611|630|648|650|651|690|700|710|711|856|887|942|995

3. Create a new List
4. Add all the database's bibs to that list using SQL like the following (where the shelfnumber equals the number for your list):
insert into virtualshelfcontents (shelfnumber,biblionumber,borrowernumber) select 1,biblionumber,51 from biblio;

5. Go to that list in the staff interface
6. Download that list using your CSV profile

7. Apply the patch
8. koha-plack --reload kohadev

9. Download that list using your CSV profile
10. Note that the output is a little slower, but still quick enough.
11. Note that the output is a bit different. For records like "Gairm",
the output will end in "1" instead of "Yes". This is correct, because
this subfield isn't an authorised value!!!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
C4/Record.pm
t/db_dependent/AuthorisedValues.t