From 19b543a51b59c7a13e5a901c2c31413eee2f2692 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 2 Apr 2024 12:39:02 -0300 Subject: [PATCH] Bug 36493: Make cashups test more robust This patch makes the test independent from existing cash registers in the system. To test: 1. Enable UseCashRegisters on a fresh KTD 2. Add a cash register 3. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/cashups.t => FAIL: Tests fail! 4. Apply this patch 5. Repeat 3 => SUCCESS: Tests pass! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer (cherry picked from commit 4436a7d41a74bf002fdd80ec97f0be38d40eee22) Signed-off-by: Fridolin Somers --- t/db_dependent/api/v1/cashups.t | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/api/v1/cashups.t b/t/db_dependent/api/v1/cashups.t index 4dcb4ae6a6..ab7646d0f9 100755 --- a/t/db_dependent/api/v1/cashups.t +++ b/t/db_dependent/api/v1/cashups.t @@ -63,7 +63,11 @@ subtest 'list() tests' => sub { ## Authorized user tests # No cash register, so 404 should be returned - $t->get_ok("//$userid:$password@/api/v1/cash_registers/1/cashups") + my $cash_register_to_delete = $builder->build_object( { class => 'Koha::Cash::Registers' } ); + my $non_existent_cr_id = $cash_register_to_delete->id; + $cash_register_to_delete->delete; + + $t->get_ok("//$userid:$password@/api/v1/cash_registers/$non_existent_cr_id/cashups") ->status_is(404)->json_is( '/error' => 'Register not found' ); my $register = $builder->build_object( -- 2.39.5